iliekcomputers: what's the format to initiate github link to the pullreguest thing?
2020-03-27 08746, 2020
CatQuest
hmm
2020-03-27 08754, 2020
CatQuest
yes one of those would have the pass, surly
2020-03-27 08754, 2020
shivam-kapila
alastairp: the timescale_lb user to connect to timescale has password timescale_lb
2020-03-27 08759, 2020
alastairp
if possible, for local development, it'd be nice to make that not required? I think ruaok had issues with that?
2020-03-27 08712, 2020
CatQuest
surely.. thoguh in the case of leftmost who knows :P
2020-03-27 08719, 2020
alastairp
shivam-kapila: right. in postgres we don't have a password, which makes it easy to connect with a single command
2020-03-27 08705, 2020
alastairp
my recommendation would be to configure timescale to do the same, but I remember that ruaok was fighting with authentication a few weeks back, I'm not sure if that's related
2020-03-27 08705, 2020
shivam-kapila
Afaik we need to enter password explicitly. Rest all can be cmd arguments
2020-03-27 08742, 2020
shivam-kapila
alastairp: I also recall that ruaok told the need of password. But I don't remember the reason. I will see if I can find that in logs
2020-03-27 08750, 2020
flamingspinach joined the channel
2020-03-27 08700, 2020
shivam-kapila
In timescale container even postgres user has password postgres
2020-03-27 08703, 2020
Sophist-UK joined the channel
2020-03-27 08702, 2020
Sophist_UK has quit
2020-03-27 08751, 2020
Sophist_UK joined the channel
2020-03-27 08726, 2020
Sophist-UK has quit
2020-03-27 08716, 2020
ruaok
yes, and I would like to continue using pre-built docker images, so lets keep the password.
2020-03-27 08733, 2020
IamDheerajS has quit
2020-03-27 08707, 2020
IamDheerajS joined the channel
2020-03-27 08735, 2020
alastairp
ruaok: btw, 42 branches in listenbrainz remote... might be time for a spring clean :)
2020-03-27 08712, 2020
ruaok
oh yes. great idea -- thanks for volunteering to get on that! Much love! <3
2020-03-27 08754, 2020
alastairp
done đź‘Ť
2020-03-27 08749, 2020
alastairp
there are a handful of branches for PRs that weren't merged, and were closed for some reason
this was a branch to merge into master, the PR was merged, but the branch still says that it's ahead of master
2020-03-27 08700, 2020
alastairp
I'm not sure if this is because of the production/master split that LB has, or if it's something else
2020-03-27 08704, 2020
ruaok
iliekcomputers: ^^
2020-03-27 08739, 2020
alastairp
yeah. I did the easy ones, but someone with more understanding about the codebase/branches should do the rest
2020-03-27 08744, 2020
alastairp
thanks for volunteering, iliekcomputers
2020-03-27 08733, 2020
ruaok
reosarevok: the JSON web service is *still* in beta. I though we resolved to take it out of beta... how long have we had it in that state? has it been a decade yet?
2020-03-27 08752, 2020
iliekcomputers
>param/perm-errors-aaargghhhhhhhhh (Updated 7 months ago by paramsingh)
2020-03-27 08754, 2020
iliekcomputers
oof
2020-03-27 08701, 2020
alastairp
iliekcomputers: that was a long night, I bet
2020-03-27 08707, 2020
ruaok
reosarevok: 8 years. not quite a decade. :p
2020-03-27 08702, 2020
c1e0_ joined the channel
2020-03-27 08735, 2020
c1e0 has quit
2020-03-27 08703, 2020
MusicbrainzB0T joined the channel
2020-03-27 08732, 2020
MusicbrainzB0T1 has quit
2020-03-27 08750, 2020
c1e0_ has quit
2020-03-27 08727, 2020
c1e0_ joined the channel
2020-03-27 08707, 2020
ishaanshah[m]
> i'm gonna take a last look at your proposal today. haven't looked at it yet, so you might have done this already, but let's mention that we'll try to introduce typescript into the stack before or during community bonding.
2020-03-27 08744, 2020
ishaanshah[m]
iliekcomputers: Hi, other than the typescript thing should I update anything else?
2020-03-27 08722, 2020
ishaanshah[m]
ruaok: Hi, did you get a chance to review the updated propsal?
2020-03-27 08732, 2020
ruaok
no. not yet.
2020-03-27 08734, 2020
iliekcomputers
make sure you have this version in the gsoc site as a backup in case there's problems like internet problems etc later
I don't think the other tabs should be optional. I think we should encourage users to fill up as much of the data as possible. Edits you suggest with just the first tab seem insufficient.
2020-03-27 08714, 2020
c1e0_ has quit
2020-03-27 08743, 2020
Cyna
Isn't that the bare minimum that is required for a book ?
2020-03-27 08702, 2020
shivam-kapila
iliekcomputers: Draft proposals dont count. So doesnt make much difference. But its better to be safe
2020-03-27 08708, 2020
Cyna
Which the new editors can simply fill and get through
2020-03-27 08748, 2020
Mr_Monkey
Well, how would that translate in terms of the entities that will be created in the database?
2020-03-27 08719, 2020
Cyna
Wouldn't that be an edition
2020-03-27 08728, 2020
c1e0_ joined the channel
2020-03-27 08740, 2020
Cyna
And any work with the edition are of work entities
2020-03-27 08758, 2020
Cyna
I dont have much idea of putting an edition group in the form 🤔
2020-03-27 08735, 2020
Cyna
Any author name filled in, becomes an author entity with just a name if the user doesnt find the author in the search. incase he just creates an edition
2020-03-27 08738, 2020
Cyna
and filling in authors tab makes it more clearer... So author and publisher tab could be dynamic.. i.e. if the author is present, dont show. else show it. same for publisher
2020-03-27 08702, 2020
Mr_Monkey
I don't think that's the best way to go about it with entity stubs like that.
2020-03-27 08702, 2020
Mr_Monkey
I think if you're going to have something like your first tab, the author field should be a search field with an option to create a new entity. When you click on create new, maybe that adds a tab in the workflow as you currently have, maybe you present a modal, maybe something else, I'll let you think it through.
2020-03-27 08710, 2020
Mr_Monkey
and same for publisher.
2020-03-27 08731, 2020
Cyna
Yea just mentioned that in the last comment
2020-03-27 08704, 2020
Cyna
All the entites that may be present will be search fields. I'll create search icon next to them
2020-03-27 08704, 2020
Mr_Monkey
If you then have a tab about the contents of the book (the work entities) and about the physical object (edition and edition-group) you're starting to have the whole picture
2020-03-27 08743, 2020
shivam-kapila
iliekcomputers: Will my GSoC project be based on typescript too??
2020-03-27 08748, 2020
Mr_Monkey
If on the first tab you selected an author and a publisher then you have two tabs less…
2020-03-27 08735, 2020
Cyna
Yea.. so Im now left with two tabs. basic information and addition details
2020-03-27 08742, 2020
Cyna
damn..
2020-03-27 08717, 2020
Mr_Monkey
Maybe the contents of the book should have the same treatment and be on the first tab? And if you tick a box "contains multiple Works" it creates a tab, something like that maybe?
2020-03-27 08700, 2020
ishaanshah[m]
> I was observing your proposal and liked it. But had a basic thought in mind. Will the users be willing to see so many graphs? Some things look good graphically but some things like top artists albums etc would look better in terms of UI than graphs. But this is just a personal opinion.
2020-03-27 08719, 2020
Cyna
It makes sense too. but what if there are no multiple works ?. Create a single work with book name ?
2020-03-27 08749, 2020
Mr_Monkey
Then you have a tab about the content of the book just the same :D I see your point
2020-03-27 08712, 2020
ishaanshah[m]
shivam-kapila: Hi, I have included the possible graphs and stats which can be shown, however the UI is not final yet
2020-03-27 08757, 2020
ishaanshah[m]
Do you have any specific graphs which could improved or shown in a better way
2020-03-27 08758, 2020
ishaanshah[m]
?
2020-03-27 08716, 2020
Cyna
Plus the consideration of having a separate tab is that it would be a waste of lots of space as the whole page would only have work entity creation form.. which will actually be embedded in modal view
2020-03-27 08719, 2020
Mr_Monkey
If you select an existing Work on the first tab, then you don't have a tab about the content of the book. If there's no existing Work and for more complex cases (multiple works), you have a tab about the content of the book.
Right, I could shift the work property into the main page which would make things a bit easier and then show a new tab only if user wants to create work.. similar to publisher and author
2020-03-27 08714, 2020
Mr_Monkey
I think that's more homogenous
2020-03-27 08750, 2020
Cyna
We still will only have two tabs in the basic version... additional properties and basic information
2020-03-27 08721, 2020
Mr_Monkey
The first tab becomes a way to select existing entities or adding tabs to the workflow.
2020-03-27 08724, 2020
Cyna
3 more in complex workflow.. author details , publisher details and Works
ishaanshah[m]: Heya. Thanks for the info. I liked all the stats you have listed. Mood part seems quite interesting. It was just in my mind that stuffing the stats portion with just graphs might make users unlikely to observe them in detail.
2020-03-27 08716, 2020
shivam-kapila
Actually during my previous intern I was working on an AQI prediction model. My mentor conducted a lil survey and collected user opinions. More than half were unwilling to see too many charts and wanted some simple demonstrations. My opinions was just based on that. Wanted to let it know as help. :)
2020-03-27 08716, 2020
shivam-kapila
For the design part I will look into it and share any design that might come in your mind.
2020-03-27 08708, 2020
ishaanshah[m]
> For the design part I will look into it and share any design that might come in your mind.
2020-03-27 08731, 2020
ishaanshah[m]
Thanks, I especially to improve the Mood Analysis part
2020-03-27 08714, 2020
ishaanshah[m]
want*
2020-03-27 08714, 2020
Mr_Monkey
Cyna: There should also be a way somewhere to add other related entities in the same workflow. You should have a way to add another Author, for example a translator, in the same way that you can add multiple Works.
2020-03-27 08733, 2020
Mr_Monkey
The more similar these processes are, the clearer it'll be for the user.
2020-03-27 08745, 2020
shivam-kapila
ishaanshah[m]: Sure. I will need some details about it though.
2020-03-27 08726, 2020
Cyna
I'm currently considering that translated version would be distinguished by editions
2020-03-27 08732, 2020
iliekcomputers
shivam-kapila: re typescript, yes
2020-03-27 08737, 2020
iliekcomputers
Ideally
2020-03-27 08727, 2020
shivam-kapila
iliekcomputers: Thanks. I will quote it in my proposal.
2020-03-27 08732, 2020
Zastai
where/how should issues with the ListenBrainz API docs be reported? how/when is the content on readthedocs regenerated from the server code?
OK, found a ticket and added a comment (it includes a PR from last June that addresses most of my issues, but it is not reflected on readthedocs)
2020-03-27 08756, 2020
alastairp
it feels like a sunday which is also a public holiday at 8 in the morning when everyone is still sleeping outside. not like Friday 6pm :(
2020-03-27 08733, 2020
Zastai
And the fact that the docs are extracted from server code means there is no full overview in GitHub either, which is unfortunate
2020-03-27 08749, 2020
ruaok
shivam-kapila: overall you proposal is nearly complete. I left some comments -- ping me once you've incorporated those changes and then I will review the schedule.
2020-03-27 08731, 2020
shivam-kapila
ruaok: Thanks for the review. I will make the necessary changes
2020-03-27 08705, 2020
reosarevok
ruaok: I honestly don't remember what we decided. bitmap: do you?
2020-03-27 08733, 2020
ruaok
fix some bugs, then call it out of beta.
2020-03-27 08738, 2020
ruaok
check bug list?
2020-03-27 08718, 2020
ruaok
ishaanshah[m]: why did you already submit your final proposal? now you cant change if it we give you feedback.
2020-03-27 08735, 2020
ishaanshah[m]
The gsoc website allows to reupload the document before 31st
2020-03-27 08752, 2020
ishaanshah[m]
I just submitted in case the internet goes down
2020-03-27 08749, 2020
ruaok
ah, yes, life in india. ;)
2020-03-27 08701, 2020
ruaok
I didn't realize you can update final ones...
2020-03-27 08730, 2020
rohitdandamudi has quit
2020-03-27 08705, 2020
ishaanshah[m]
Did you recieve the pdf or just the link to the draft?
Oh, I uploaded the pdf too, I guess you will recieve it after the deadline
2020-03-27 08721, 2020
ruaok
how close is the link I posted to the PDF?
2020-03-27 08745, 2020
ishaanshah[m]
Completely same
2020-03-27 08758, 2020
ruaok
great
2020-03-27 08710, 2020
rohitdandamudi joined the channel
2020-03-27 08751, 2020
ruaok
ishaanshah[m]: I love the graphs for the sitewide statistics.
2020-03-27 08704, 2020
ruaok
who was it that told you to make them orange??
2020-03-27 08712, 2020
ishaanshah[m]
Thanks
2020-03-27 08745, 2020
ishaanshah[m]
No one, I just did it to match with the overall LB theme
2020-03-27 08746, 2020
ruaok
more seriously, I doubt the data changes sufficiently for those graphs to be visually appealing. I would expect the change to be slower. might work for weeks.
2020-03-27 08755, 2020
ruaok
but for days, it would be nearly flat lines, I would guess
2020-03-27 08743, 2020
ishaanshah[m]
Hmm, makes sense coz a trending artist doesn't change suddenly
2020-03-27 08757, 2020
ruaok
yeah.
2020-03-27 08719, 2020
ruaok
but, changing graph types isn't super difficult, right?
2020-03-27 08744, 2020
ruaok
in which case we might just want to say leave room in the schedule for tinkering with graph types
2020-03-27 08756, 2020
ishaanshah[m]
> but, changing graph types isn't super difficult, right?
