let's try to keep master and production as close as possible from now on.
ruaok
yes, please.
thank you iliekcomputers !
!m
!m iliekcomputers
BrainzBot
You're doing good work, iliekcomputers!
ruaok
sigh. :)
alastairp
related to that, is there public docs about the branching method used? :)
ruaok
not yet, but I'm glad you'll be writing them up for us. :)
alastairp
you're welcome
someone needs to tell me what that is first
and then, I'll just copy that
ruaok
we don't plan to merge PRs until right before release, essentially.
alastairp
get all PRs ready to merge. then on release, merge to master, merge master to production, deploy production?
ruaok
yep. right iliekcomputers ?
alastairp
which means that it's either a good idea to release often, or make sure PRs are small, or both?
iliekcomputers
critical part of this would be to have regular releases (possibly weekly)
alastairp
especially when 2 PRs may be overlappin
iliekcomputers
otherwise it'll just be a bunch of prs based on each other
alastairp
if the idea is to release regularly, maybe merging to master isn't a bad idea - at least it means there'll be a centralised branch which has _all_ changes on it at once, for testing etc
something to deploy to beta, etc
(just throwing ideas out)
iliekcomputers
alastairp: yeah, i think that makes more sense
alastairp
but agreed that it depends strongly on keeping discipline for regular releases
shivam-kapila
iliekcomputers: Thanks for that :D.
alastairp
shivam-kapila: you pinged last night?
shivam-kapila
New release. Yay! π
alastairp: Hi. Yes. Actually regarding that PSQL login. I found a fix. Can you have a look at it? I will share it as a pastebin and then push the commit
alastairp
shivam-kapila: use the PR, that's what we have it for
it's much easier to keep the discussion all in one place
shivam-kapila: yes, but for now just the timescale branch should be sufficient.
shivam-kapila
alastairp: The PR is updated. Its waiting for you. :)
ruaok
iliekcomputers: uhm.
shivam-kapila
ruaok: Modified to timescale branch :)
ruaok
th
thx
alastairp
shivam-kapila: it's easy. first I ignore it completely, and wait until it's been approved and merged. and then I review it, asking for a number of changes, and so the author has to do more work
ruaok
iliekcomputers: I dont think we've moved that yet. we moved the android package.
alastairp
apparently it's become a running joke now
iliekcomputers
:D
ruaok
s/become/been/
iliekcomputers
ruaok: we can merge the pr then, right?
shivam-kapila
alastairp: Well perhaps GitHub will like to honour you for your approach :p
ruaok: Just out curiousity when will you review the proposals for a final push?
ruaok
when I feel well enough to do so.
please stop pestering me, ok?
CatQuest
oohh. is the new lb update on prod or beta?
ruaok
prod
iliekcomputers
CatQuest: prod
CatQuest
:OO
CatQuest goes to test right away
iliekcomputers
the last.fm importer definitely needs some tester love
shivam-kapila
ruaok: Oh sorry for that. Take care of your health.
CatQuest
ok first thing: it now shows in the middle of the page and not the bottom \o/
it's responisive to resising the window, good good
aand the import worked!
!m well done ListenBrainz devs! π
BrainzBot
You're doing good work, well done ListenBrainz devs! π!
CatQuest
oh. guess what i'm 33106 listens off 1,5M! so then I thought about stuff and here's an idea: how about a timeline for listens? it could easily be calculated with play count-numbers. so it could be like "months" and a graph how many accumulated listens. or you could do "year" view also
iliekcomputers
what do you mean by timeline?
CatQuest
so then like, I could see when likly I'll have listened to 33k tracks
oh i meant a grap with x time and y listens
sorry, english
iliekcomputers
that does sound cool
CatQuest
:D
iliekcomputers
although i guess it would be relatively linear for most people
i think ishaanshah[m] has something similar-ish in his proposal
CatQuest
possibly linear yes. but the "angle" of that linear is interesting to me. tbh
ruaok: Hi, this might be a silly question but can we get musicbrainz database on lb
iliekcomputers
we can get read access, yes
ishaanshah[m]
Oh direct read access, not through api
iliekcomputers
it's hard to develop for because you have to set up an entire MB environment locally
what's your use case here?
ishaanshah[m]
In my proposal I have stats which require data to be obtained from MB
CatQuest
oh jeez. it i devide the number of listens minus my listens on the number of users minus me it's 37 730 listens
ishaanshah[m]
Artist Origin and Top Genres specifically
CatQuest
here's another stat idea: amount listens leaderboard πΉ
ishaanshah[m]
> here's another stat idea: amount listens leaderboard
That's actually really cool
iliekcomputers
ishaanshah[m]: i'd prefer to do it via the API.
i don't want to add musicbrainz as a dependency unless absolutely necessary.
ishaanshah[m]
iliekcomputers: about that, I was writing the code for the trackMBID issue that I described before
However api requests slow down the process significantly
Not to mention rate limiting
iliekcomputers
hmmm
ishaanshah[m]
As we have get such kind of data for all users, I thought direct access would be better
iliekcomputers
we can't really add an exception for the rate limiting because the importer works on the client.
CatQuest
>trackMBID
is that a fix to the problem with lastfm imported listens using a bugged recording mbid? (it uses a track mbid but website assumes recording mbid, so every single link is error)