#metabrainz

Freso: oh! Well, I bet that someone could write some tests ;p

reosarevok: yeah, lots of unsupported things at the moment :(, it's on the plan

[listenbrainz-server] ishaanshah opened pull request #773 (master…artist_mbid): Add Artist MBID and Release MBID fields for lastFM imports https://github.com/metabrainz/listenbrainz-serv...

Mr_Monkey, alastairp: I'm in the latest flight to BCN to make a full audit of your crafted beers! https://www.flickr.com/photos/slimdandy/1679350...

that picture looks a little fishy

Re this https://github.com/metabrainz/listenbrainz-serv..., there was a reason why we didn't import artist and release mbids from last.fm, right alastairp ruaok?

I remember some discussion about data quality

yeah, they were basically all wrong

alastairp: for the data that I imported, all of them turned out to be correct

Maybe they fixed their db?

reosarevok, bitmap: since the blog post has not been published on yesterday, the blog url in the git tag message is outdated already, thus I will fix it and rename git tag to -31 at the same time.

ishaanshah[m]: maybe the items that you imported were OK, however we believe that there are still lots of wrong ones. we often have people asking how to match mbids to musibrainz from lastfm, and many of their problems come from bad ids

maybe we could import them, but indicate that the ids are from lastfm, so that we know to not trust the mcompletely

Oh, maybe true because linked my lastfm account to spotify

So they may be getting clean.metadata to make a match

reosarevok: updated git tag, blog post, and jira release

<3

you should remove previous git tag:

git tag -d v-2020-03-30 # removes it from your working copy

git push origin :v-2020-03-30 -f # removes it from your clone at github (since you pushed tag to it at first)

You removed it from the metabrainz repo?

reosarevok: yes

mooooin!

morning

ishaanshah[m]: let's import them into different fields, for example `artist_mbid_from_lastfm`

that way we have the data and we can think about what to do with it later

Maybe we can add another import type as lastfm_import

So that fixing the recording_mbid will also become simple

What do you think about it?

i'd add a source field to the additional_info instead

Oh ya that will be easier, I'll do that

but i'm still not convinced on keeping potentially incorrect artist mbids in the main field

we use the main field for links and incorrect links will end up on the user visible pages

Maybe for now I will keep them in different fields

sgtm

I actually wanted the mbids because more metadata made getting data from mb easier

But I did not know that the data was incorrect

no worries, we still thought of improvements to make.

anyways, it might be a good idea to just tell us once before starting on a task once

Ya, should have told you about this, sorry about that

A suggestion. After we fetch listens from last.fm whh not put the users listens into a queue to fetch the required data from MB? I will also need MB_IDs to fetch cover arts

it's not a trivial problem to get mbids from the listen data (which sometimes might be just artist name and track name). MessyBrainz tries to solve this (https://messybrainz.org)

artist_mbid_from_lastfm !

> <alastairp> that picture looks a little fishy

That's because it was shot with a mackerel lens.

lastfm_artist_mbid might be better, iliekcomputers ;)

sounds good to me

mmm, but those need quite a bit of fine-tunaing, no?

naming things is hard :D

Wasn't there a thing about slapping people with trouts on IRC, back in the day?

yep, some clients even had it built in as a command

/slap works

I remember having that

wtf is an ilish

ilisha

Hmm, thanks.

lol

I got schooled. (<- get it?)

Slapping around on April fools day... 🤣

I seriously lack fish vocabulary in all the languages I speak.

outsidecontext: it seems 2.3.2dev1 based on previous Qt version solves Network issue for users that reported it, so I guess we can conclude that's a Qt 5.14 issue. So now, not sure what we should do, as downgrading isn't really an option and 5.15 is still in beta (it might be interesting to build Picard against it though, and ask same users to test)

reosarevok: I think part of what, in turn, stalled the test writing was that alastairp wanted to revamp how testing is done (automate stuff more).

Oh no

oh yeah, but I decided to just merge a bunch of stuff and get a new release out, and deal with tests later

maybe that's a good thing to do

Freso: in fact, I think we might both have been waiting for each other there - I think you said that you wanted to address my changes, but perhaps you were waiting for me to set up the test infrastructure before continuing?

I actually think I might have even said I had an idea about doing the infrastructure since I had been having similar thoughts re: whipper’s test suite.

Which also has yet to manifest. :)

yeah, we very briefly discussed it, but I don't think we decided to go ahead

I rearranged some issues in milestones, and I think I pushed the test infra back a bit

I got a release out a few weeks ago, but I want to merge the open PRs and make another one, then we can focus on improvements

Freso: if you specifically address my 2 points on that PR, we can merge it

alastairp: Is that https://github.com/alastair/python-musicbrainzn... ?

Or https://github.com/alastair/python-musicbrainzn... ?

yes, and the updated docstring

[musicbrainz-server] reosarevok opened pull request #1444 (master…MBS-10721): MBS-10721: Improve track info in ArtistCreditBubble https://github.com/metabrainz/musicbrainz-serve...

MBS-10721: Editing AC for track without a title entered shows [removed] https://tickets.metabrainz.org/browse/MBS-10721

I think the comments of https://github.com/alastair/python-musicbrainzn... is sort of outside the scope of the PR. Those were issues present before the PR and the PR doesn’t really alter the state of that issue either. I can try and work on a separate PR for that, but I don’t think it should be part of this one. (In the spirit of keeping PRs somewhat on a single topic.)

But docstring and AUTH_REQUIRED_INCLUDES, sure.

mmm, you're right, however I wanted to be in a situation where we leave code better than we find it

I know it's not directly related to this feature, but it's touching the same code workflow

I’ll try and give it a look later.

🙏

14mm, 167.8

meh. wrong window. :)

Hi! How would I best go about helping on a specific improvement request? https://tickets.metabrainz.org/browse/MBS-5380

MBS-5380: Contextualize further strings

Fork the project on Github, then do a pull request there?

v6lur: yes

Thanks :)

iliekcomputers I updated the PR, please have a look when free