Did you import the listens after the artist mbid pr that I made
shivam-kapila
I imported just now
ishaanshah[m]
For the first time?
shivam-kapila
And my lb profile had listens before that PR too
ishaanshah[m]: Naah. I import daily
If the issue reported by Zastai is true. My profile should have at least 800 to 1000 dupes
ishaanshah[m]: Did you give it a try?
ishaanshah[m]
Hmm, I am not sure then, I was getting duplicated listens for listens which were imported pre artist_mbid pr
So I deleted all the listens, imported again
Then even after reseting and importing again I was not getting duplicated listens
shivam-kapila
Seems like we need something like "Delete my Last.fm listens"
ishaanshah[m]
Yep
That would be useful
Zastai
might be tricky since older imports don't have listening_from to help identify them
I'd settle for "delete any listen not from spotify" tbh
because those aren't recoverable AFAIK
just for reference, this query returns two pairs of my dupes. wonder why the messy id would change if the main identifiers are the same (unless the artist mbid is now factored into the msid)
[listenbrainz-server] paramsingh opened pull request #790 (master…param/frontend-test-sh-improvements-1): Add ability to update snapshots to frontend-test.sh https://github.com/metabrainz/listenbrainz-serv...
yvanzo
!m _lucifer
BrainzBot
You're doing good work, _lucifer!
Freso
I stopped scrobbling to Last.FM a while ago, so I’d be losing a lot of unique listens if I dropped my Last.FM history on LB, but I am also interested in re-importing to get the changed/improved tags. It would be nice if there could be a tool to compare potential duplicate listens and you could decide to merge or delete them. (For people with a long history, it might take a while to get through them all manually, but I would
personally prefer being able to go through them that way.)
_lucifer: Seems like I’ll finally get to install it on my phone then. :)
iliekcomputers: I left a review on your spotify PR
jbs1 joined the channel
jbs1 has quit
Gazooo has quit
Gazooo joined the channel
CatQuest
same as freso. I would definitely want to go through my history and "fix" or "check" things
dseomn1 has quit
dseomn joined the channel
dseomn1 joined the channel
dseomn has quit
ishaanshah[m]
iliekcomputers: ping
iliekcomputers
Pong
ishaanshah[m]
I just read your comment on my PR, I agree with keeping the props and states in the same file
iliekcomputers
Great!
ishaanshah[m]
Can you just move the spotfiy direction type to types.d.ts
Because that is needed in RecentListens too
iliekcomputers
Yeah, I was gonna do that, sounds good.
SkweezyJibbz joined the channel
I'm probably not gonna work on it today, however
SkweezyJibbz
Hi all. I'm encountering some issues with MBP 2.3.1
ishaanshah[m]
Yep, no problem, I am nearly done with porting RecentListens, I will complete it by tomorrow
iliekcomputers
Great, sounds good. I also am having some problems with getting Spotify permissions to work in my local environment
SkweezyJibbz
Adding music that's already been tagged by MBP seems VERY slow and more than that, music that was tagged correctly by MBP now show up as [non-album tracks] with certain tag metadata being really weird.
iliekcomputers
Looks like we'll have to test it on beta
The migration is not very risky because we're just adding types most of the time.
ishaanshah[m]
Sound good
A snaphshot test for RecentListens should be fine for now right
iliekcomputers
Yeah, just make sure to put in a list of listens
:D
(ideally with mbids and Spotify ids)
Just try to get as many cases as possible into the the snapshot
With mbid, without mbid, with Spotify id, without etc etc
ishaanshah[m]
Ok, will do
Freso
SkweezyJibbz: You might want to search the forums for related topics. Picard is known to be slow in certain conditions, which have been iterated multiple times there.
SkweezyJibbz, is it possible that something in a tagging script is mangling the MBID tags? That would only be the case if you have a tagging script enabled. Note that the renaming script won't affect the tags written to the files.
SkweezyJibbz
rdswift: I only have whatever the stock setup is
rdswift
Finally, what type of files? (e.g. MP3, FLAC, etc.)?
(These are the questions the devs are going to ask when trying to figure out what might be causing the problem.)
iliekcomputers
deployed more typescript to beta, the spotify player is now partially typescript
the linter also pointed out some accessibility bugs and now the player has keyboard support as well
SkweezyJibbz
rdswift: only mp3 and m4a
rdswift
That shouldn't be the problem then. As far as I can tell, both are fully supported.
extreme slowness could be a case of lots of files selected, plus it might be rewriting tags (say v2.3 as v2.4); that might also yield "corrupt tags
SkweezyJibbz
Zastai: i'm doing about 1,800. have always used v2.3
Zastai
"corrupt tags" in other software because it expects different tags for a particular property
yeah then the "extreme slowness" is possibly to be expected. picard is not intended for mass tagging like that, more for one release at a time. a huge batch will make it seem unresponsive. it should still be doing its thing though
as for the corrupted tags, I have no idea
I only rip to flac
SkweezyJibbz
Zastai: i thought it was doing it's thing as well, but I left it running for like 10 hours and I think the program just froze up completely.
Zastai
yeah ten hours should have been enough for 1800 files
SkweezyJibbz
So, I can circumvent that issue relatively easily by just selecting only 50 files at a time I guess. But the corrupted tag issues is a whole 'nother thing
Zastai
yeah, batching in groups of 50/100 should work around that part. but not the tags
prabal has quit
SkweezyJibbz has quit
Xellos has quit
CatQuest
what corrpted tags exactly?
thomasross joined the channel
v6lur_ has quit
Zastai
see the discourse post. values being substrings of tag names