ishaanshah[m]: can you document the json that the endpoint returns
2020-05-06 12755, 2020
ishaanshah[m]
I have done that
2020-05-06 12754, 2020
iliekcomputers
For the validate-token endpoint, sorry I wasn't clear
2020-05-06 12746, 2020
ishaanshah[m]
Ok, ya sure
2020-05-06 12720, 2020
ishaanshah[m]
But isnt that endpoint a security threat
2020-05-06 12755, 2020
ishaanshah[m]
I mean i can write script to generate a bunch of random tokens and send it to this endpoint
2020-05-06 12715, 2020
ishaanshah[m]
If I hit a valid one, I get the users username
2020-05-06 12744, 2020
Lotheric_ joined the channel
2020-05-06 12724, 2020
Lotheric has quit
2020-05-06 12731, 2020
iliekcomputers
The probability of you generating a valid token is very low
2020-05-06 12709, 2020
iliekcomputers
Our tokens are uuids and two scripts generating the same uuid is basically impossible. Plus we rate limit the endpoint.
2020-05-06 12716, 2020
iliekcomputers
I don't think there's a threat here.
2020-05-06 12741, 2020
iliekcomputers
Reviewed the stats API endpoint pr.
2020-05-06 12753, 2020
diru1100
Morning 🌞
2020-05-06 12709, 2020
ishaanshah[m]
Thanks, I will have a look in the afternoon
2020-05-06 12742, 2020
Zastai joined the channel
2020-05-06 12752, 2020
prabal
Mr_Monkey: Hi.
2020-05-06 12703, 2020
Mr_Monkey
Hi !
2020-05-06 12709, 2020
prabal
How do we proceed for GSOC project?
2020-05-06 12714, 2020
prabal
I was afk for last week, had some college stuff. Couldn't work on the API pr. I am thinking of completing it first. It should not take more time
2020-05-06 12726, 2020
prabal
What do you think?
2020-05-06 12704, 2020
yvanzo
mo’’in’
2020-05-06 12729, 2020
yvanzo
bitmap: that fixed lock file indeed, thanks.
2020-05-06 12738, 2020
Mr_Monkey
prabal: I think it would be great to put the last nail in that PR's coffin :) And after that, depending on how you feel about it, you could get started on the GSOC project (even though we're technically in the bonding period), or tie some other loose ends (I'm thinking about the revision page for example).
2020-05-06 12729, 2020
Cyna[m]
reosarevok:
2020-05-06 12736, 2020
Cyna[m]
Green light on PR ?
2020-05-06 12701, 2020
Gazooo has quit
2020-05-06 12703, 2020
iliekcomputers
ishaanshah[m]: can you add the scraper PR to the jira board too, it's easier to track stuff being done then.
I was delving a little deeper into the framework concept. trying to keep things super simple
2020-05-06 12701, 2020
Mr_Monkey
After some discussion in private, prabal and I decided it would be best to start the GSOC coding project sooner rather than later, in case exams are moved to the summer, thus taking some time away from the coding period. Writing this here in case it's useful for other participants/mentors
2020-05-06 12701, 2020
alastairp
ruaok: cool. I'm busy until lunch, but will take a look at it this afternoon
shivam-kapila: i think you can stop the task about the artist chart bugs, ishaanshah[m] is working on migrating it to react, we should probably just fix it there, otherwise work will be duplicated.
2020-05-06 12716, 2020
iliekcomputers
if you have something, push it and maybe ishaanshah[m] can merge it with his branch
2020-05-06 12727, 2020
shivam-kapila
I am done with reset stats on delete
2020-05-06 12750, 2020
alastairp
iliekcomputers: I'm wondering what we should call the syswiki document for how to deploy AB/LB
2020-05-06 12753, 2020
iliekcomputers
oh yeah, that sounds like a seperate pr, i was talking about the bug in the artist chart specifically
2020-05-06 12705, 2020
alastairp
PythonBrainzReleaseProcess?
2020-05-06 12717, 2020
alastairp
(the MB one is MusicBrainzServerReleaseProcess)
2020-05-06 12719, 2020
iliekcomputers
sorry for the late notice on it, totally slipped my mind until i saw a jira email
2020-05-06 12740, 2020
shivam-kapila
iliekcomputers: Actually that ticket had two subparts. 1. is done. 2. the artist chart bugs in not yet left
2020-05-06 12743, 2020
iliekcomputers
alastairp: sgtm
2020-05-06 12750, 2020
alastairp
I've started using 'pythonbrainz' when referring to the python/flask-based projects, I wonder if it's a good term or not :)