rdswift: are you taking requests for improvements to OpenPost?
2020-05-12 13334, 2020
Mr_Monkey
OK. Shall I create the LB endpoint and page that we can send requests to?
2020-05-12 13345, 2020
ruaok
I want to post one block of JSON to the target page.
2020-05-12 13349, 2020
ruaok
yes, please.
2020-05-12 13343, 2020
Mr_Monkey
OK. So I'll set up the endpoint and page we need, and work on improving the player. š
2020-05-12 13300, 2020
ruaok
fabu.
2020-05-12 13322, 2020
Mr_Monkey
The code we had was a GET endpoint with list of recordings and playlist name/description in args. We'll eventually want a POST endpoint instead, but shall I set that up for now?
2020-05-12 13332, 2020
Mr_Monkey
As a GET, I mean
2020-05-12 13321, 2020
Mr_Monkey
That's where OpenPost was coming in, but I forget if you got it to work back then
2020-05-12 13325, 2020
ruaok
we want POST, so i can post JSON as the body of the request.
2020-05-12 13339, 2020
Mr_Monkey
OK
2020-05-12 13348, 2020
ruaok
I did't back then and we got distracted before we could try rdswift's work.
2020-05-12 13308, 2020
ruaok
but he's proven it works and it just need a minor tweak.
2020-05-12 13316, 2020
Mr_Monkey
Great
2020-05-12 13332, 2020
_lucifer
gr0uch0mars: yeah sure no issues but my internet is a bit slow so i would prefer chat. a videocall is a bit difficult but possible if need be.
2020-05-12 13328, 2020
Mr_Monkey
Hey that's an esay way we can save playlists, by the way. OpenPost outputs an html file, and if we date them or give them a naming scheme you'll have your playlist file.
2020-05-12 13348, 2020
Mr_Monkey
(`--keep-file` flag)
2020-05-12 13334, 2020
ruaok
yeah, I wonder about the utility of a local files clattering about.
2020-05-12 13359, 2020
gr0uch0mars
_lucifer: I'm OK with the chat. Do you know if there's a way to make a room here in IRC for us three?
2020-05-12 13320, 2020
ruaok
gr0uch0mars: just `/join #room-name` and if the room doesn't exist, it will be created for you.
2020-05-12 13339, 2020
ruaok
but why not actually hold the meeting here, if things are not too noisy here already?
2020-05-12 13303, 2020
gr0uch0mars
ruaok: thanks for the command. Now it's not too noisy, but I don't know if when we are connected at the same time, it'll be the sameā¦
2020-05-12 13323, 2020
ruaok
if too noisy then, make a room.
2020-05-12 13332, 2020
gr0uch0mars
šš»
2020-05-12 13339, 2020
ruaok
but then again, reosarevok might still get angry for you for having too much on-topic conversation here.
2020-05-12 13351, 2020
ruaok
šāāļø
2020-05-12 13305, 2020
reosarevok
ruaok: what can I say, I get crankier with every year :D
2020-05-12 13310, 2020
reosarevok
(here is fine)
2020-05-12 13325, 2020
ruaok
you're just 20 years ahead of the curve, really.
2020-05-12 13356, 2020
reosarevok
What can I say, I was born ready
2020-05-12 13300, 2020
iliekcomputers
where are these api endpoints hosted? they're not in master
2020-05-12 13301, 2020
reosarevok
(for old age)
2020-05-12 13323, 2020
ruaok
which ones, iliekcomputers ?
2020-05-12 13327, 2020
iliekcomputers
the playlist ones
2020-05-12 13339, 2020
iliekcomputers
is it in a different branch?
2020-05-12 13300, 2020
ruaok
try looking at the standalone-player branch.
2020-05-12 13307, 2020
ruaok
Mr_Monkey posted links to it ealier.
2020-05-12 13325, 2020
iliekcomputers
got it. sorry.
2020-05-12 13355, 2020
ruaok
np, that wasn't meant as a "read the backscroll!" comment. :)
2020-05-12 13329, 2020
iliekcomputers
one suggestion (i realize it might not be realistic): we should try to keep as much of this stuff in master as possible. that way we all get benefits of improvements like the typescript stuff and automated tests that we set up since the work on this branch, and it's easier to merge and release.
2020-05-12 13309, 2020
iliekcomputers
there's stuff like an extra permission removal for spotify in the branch that we basically duplicated.
2020-05-12 13313, 2020
ruaok
what do we do with half-baked code like this? it was nowhere near mergable.
2020-05-12 13335, 2020
iliekcomputers
ruaok: having such a large branch of half baked code is the thing that i want to avoid. this branch also probably had a bunch of subtasks / small prs on the branch etc. i'd prefer if those target master as much as possible, so that these branches don't accumulate.
2020-05-12 13309, 2020
ruaok
ok, where do we keep code that we're "just playing around" with?
2020-05-12 13310, 2020
iliekcomputers
i realize it's not always possible (hackathons etc), but for the general use case where we're working weeks and months on things, master should be the way to go
2020-05-12 13307, 2020
iliekcomputers
keep it in a branch, sure. i'm not saying we don't do any other branches. just saying that it'd be nice if we all tried to merge as much of that into master as soon as possible.
2020-05-12 13344, 2020
iliekcomputers
so that instead of huge PRs, we have smaller ones.
2020-05-12 13327, 2020
_lucifer
gr0uch0mars: i am available right now, we can start right now if its fine with you
2020-05-12 13332, 2020
iliekcomputers
anyways, just an opinion. i realize it won't make sense a lot of the time.
2020-05-12 13300, 2020
_lucifer
i am fine with both having it here or in other room
That means the type should be set to group by the merge (since it's empty) but a group can't have gender, so it crashes
2020-05-12 13343, 2020
reosarevok
Should we fail the edit in this case, should we drop the type?
2020-05-12 13350, 2020
reosarevok
(and still merge them)
2020-05-12 13356, 2020
reosarevok
Or what would seem sensible
2020-05-12 13334, 2020
jmp_music
alastairp: Just got your email. The download process has already begun. :)
2020-05-12 13341, 2020
yvanzo
reosarevok: If you ask me about this specific edit, the target artist should be a group, not an undefined male.
2020-05-12 13344, 2020
alastairp
great š
2020-05-12 13304, 2020
reosarevok
yvanzo: no, I ask about the general case where group is merged into something with gender
2020-05-12 13323, 2020
reosarevok
If you think it should be completely case-per-case, then the better might be to fail the edit?
2020-05-12 13325, 2020
yvanzo
reosarevok: I would say that entries with dubious data make dubious targets, so we should probably fail such edit with a ModBotās message.
2020-05-12 13331, 2020
reosarevok
Ok
2020-05-12 13347, 2020
jmp_music
alastairp: thanks for uploading the audio files too. I would to experiment in further features extraction in case it is possible
2020-05-12 13300, 2020
jmp_music
*I would like
2020-05-12 13340, 2020
alastairp
yeah, as a general classification task this would be interesting. Remember of course that in AcousticBrainz we only have the feature files that I gave you
2020-05-12 13319, 2020
v6lur joined the channel
2020-05-12 13329, 2020
iliekcomputers
I pay 80 inr per month for Spotify still š¤£
2020-05-12 13355, 2020
shivam-kapila
59?
2020-05-12 13306, 2020
shivam-kapila
Its 59 for students
2020-05-12 13319, 2020
iliekcomputers
I'm not a student
2020-05-12 13326, 2020
iliekcomputers
Thankfully.
2020-05-12 13310, 2020
Mr_Monkey
prabal: pong
2020-05-12 13325, 2020
prabal
I need to use a library which gives difference in array. Need to find difference in oldCollaborators and newCollaborators in user-collection form
ruaok: Is there a way to make flask output the whole url for files, rather than a relative path?
2020-05-12 13351, 2020
Mr_Monkey
Otherwise, I'm not sure what we want to do with the page returned from the POST request (which will point to js and less files with relative path).
2020-05-12 13340, 2020
Mr_Monkey
There's also the question of auth: considering we want to access the user's spotify account details (if any), do we send an auth token in the POST request?
2020-05-12 13344, 2020
Mr_Monkey
for url_for, I think I found how to generate a absolute url
2020-05-12 13345, 2020
ruaok
rdswift: yes, that is possible, but there is one signficant snag with that -- maximum URL length.
2020-05-12 13330, 2020
ruaok
there is no clear definition of the largest one, so implementation differs. and we're talking about 20k-30k of data being posted, possibly...
2020-05-12 13348, 2020
ruaok
it would likely lead to a bad user experience
2020-05-12 13342, 2020
rdswift
Okay. So if I understand, you want to be able to pass a file (or stream) as the argument to openpost?
2020-05-12 13314, 2020
ruaok
no, i would prefer to be able to do something like this:
Mr_Monkey: can you backup a sec and give me more context?
2020-05-12 13343, 2020
ruaok
I'm confused as to what you're asking and sense some confusion
2020-05-12 13302, 2020
CatQuest
.. I mean.. wow the first vote was cast 2018-12-15 15:22 CET actually
2020-05-12 13304, 2020
CatQuest
so while I agree that "code some thing that fixes it so this no longer happens (edits open for YEARS) it's still ridicolous that it's been open for years and noone's managed to make more noize so we figured otu what it was so we could fix it :D
2020-05-12 13348, 2020
Mr_Monkey
Sure. The POST request you mant to make is supposed to return an html page, correct? That page will currently point to resources on the server with a relative path (eg `/static/js/player.js`). If you try to open that page, it won't work as the relative path is not pointing to the server anymore.
2020-05-12 13307, 2020
Mr_Monkey
Transforming paths to resources into absolute paths would solve that issue
2020-05-12 13347, 2020
ruaok
ah, I see.
2020-05-12 13311, 2020
Mr_Monkey
Unless I misunderstood something, the POST method presents a few challenges
2020-05-12 13314, 2020
ruaok
so, the workflow for this is: 1) python script does magic, creates playlist. 2) writes playlist to openpost, which creates a tiny html page. 3) tiny html page gets opened in the browser, which immediately POSTs and loads the LB play page.
2020-05-12 13338, 2020
rdswift
ruaok, just to clarify... Using your example, the form content would be sonething like: <input type="hidden" name="thisbejenson" value="1">
2020-05-12 13346, 2020
ruaok
which means that you are making a stinking normal player page that can be invoked via POST. otherwise there is nothing special about this page, nothing special needs to be done with paths.
reosarevok: I think we discussed MBS-10187 at some point and decided that allowing the edit to pass but leaving a ModBot note about the type/gender being dropped was ok. at least I have a branch that does that
