#metabrainz

/

      • BrainzGit
        [listenbrainz-server] mayhem opened pull request #860 (master…postgres-12): Start working on pg 12 support. https://github.com/metabrainz/listenbrainz-server…
      • 2020-05-17 13840, 2020

      • bitmap
        zas: I'd like to move the postgres instance on williams to paco, rn williams is a bit too overloaded with json dumps, search index dumps, barman backups, jenkins builds, and slow disks
      • 2020-05-17 13858, 2020

      • supersandro2000 has quit
      • 2020-05-17 13801, 2020

      • supersandro20006 joined the channel
      • 2020-05-17 13816, 2020

      • bitmap
        can barely run a 200GB rsync locally without waiting 3 hours :/
      • 2020-05-17 13854, 2020

      • bitmap
        lmk if there's a better spot but looks like paco has enough space and is relatively underused
      • 2020-05-17 13820, 2020

      • leonardo has quit
      • 2020-05-17 13829, 2020

      • somasis has left the channel
      • 2020-05-17 13852, 2020

      • Chinmay3199 joined the channel
      • 2020-05-17 13812, 2020

      • Nyanko-sensei has quit
      • 2020-05-17 13851, 2020

      • Nyanko-sensei joined the channel
      • 2020-05-17 13800, 2020

      • Nyanko-sensei has quit
      • 2020-05-17 13816, 2020

      • Nyanko-sensei joined the channel
      • 2020-05-17 13814, 2020

      • Nyanko-sensei has quit
      • 2020-05-17 13846, 2020

      • Nyanko-sensei joined the channel
      • 2020-05-17 13810, 2020

      • Nyanko-sensei has quit
      • 2020-05-17 13824, 2020

      • Nyanko-sensei joined the channel
      • 2020-05-17 13842, 2020

      • m00n has quit
      • 2020-05-17 13854, 2020

      • m00n joined the channel
      • 2020-05-17 13834, 2020

      • sumedh joined the channel
      • 2020-05-17 13846, 2020

      • m00n has quit
      • 2020-05-17 13820, 2020

      • m00n joined the channel
      • 2020-05-17 13812, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1478 (master…MBS-10785): MBS-10785: Remove FreeDB Gateway from menu https://github.com/metabrainz/musicbrainz-server/…
      • 2020-05-17 13814, 2020

      • BrainzBot
        MBS-10785: Remove link to FreeDB Gateway documentation https://tickets.metabrainz.org/browse/MBS-10785
      • 2020-05-17 13846, 2020

      • sumedh has quit
      • 2020-05-17 13811, 2020

      • sumedh joined the channel
      • 2020-05-17 13837, 2020

      • Chinmay3199 has quit
      • 2020-05-17 13821, 2020

      • v6lur joined the channel
      • 2020-05-17 13816, 2020

      • ruaok
        moooin!
      • 2020-05-17 13855, 2020

      • mzfr joined the channel
      • 2020-05-17 13857, 2020

      • ruaok
        iliekcomputers: you about?
      • 2020-05-17 13826, 2020

      • iliekcomputers
        Morning
      • 2020-05-17 13852, 2020

      • ruaok
        hey. so, pg12 coming tomorrow. I failed to put that on our radar.
      • 2020-05-17 13850, 2020

      • ruaok
        which means that PG 9.5 goes down and then comes back up and migrated as far as CB, LB and MeB are concerned.
      • 2020-05-17 13812, 2020

      • iliekcomputers
        Hmm, I saw the PR.
      • 2020-05-17 13815, 2020

      • ruaok
        I *think* it will be a non-event.
      • 2020-05-17 13839, 2020

      • iliekcomputers
        Does the password thing mean that we'll have to release new versions of LB and CB
      • 2020-05-17 13840, 2020

      • iliekcomputers
        ?
      • 2020-05-17 13851, 2020

      • iliekcomputers
        Or is that for dev only?
      • 2020-05-17 13854, 2020

      • ruaok
        unsure. let me see about passwords in production.
      • 2020-05-17 13836, 2020

      • ruaok
        but I think that thing for us to do is to put passwords on all PG accounts going forward. that should avoid trouble.
      • 2020-05-17 13839, 2020

      • ruaok
        the password is specified in consul_config.py.ctmpl, so it should be fine.
      • 2020-05-17 13808, 2020

      • ruaok
        things even seem to work with the pg9.5 postgresql client inside docker images.
      • 2020-05-17 13835, 2020

      • ruaok
        however, the messybrainz tests are all failing and they are setup differently than the LB tests.
      • 2020-05-17 13805, 2020

      • ruaok
        can you please take a look and see how to set the password for the messybrainz tests?
      • 2020-05-17 13815, 2020

      • iliekcomputers
        Yeah, I can look at that.
      • 2020-05-17 13820, 2020

      • ruaok
        thx.
      • 2020-05-17 13832, 2020

      • ruaok
        once we get LB tucked away we need to look at MeB and CB.
      • 2020-05-17 13857, 2020

      • iliekcomputers
        I think it might be better if you take MeB, I'll take LB and then we'll circle back to CB
      • 2020-05-17 13811, 2020

      • ruaok
        sure, that works.
      • 2020-05-17 13812, 2020

      • iliekcomputers
        LB is mostly done anyways, thanks to your PR.
      • 2020-05-17 13821, 2020

      • ruaok
        on Meb as we speak.
      • 2020-05-17 13832, 2020

      • ruaok
        and CB is likely to be very similar to MeB.
      • 2020-05-17 13832, 2020

      • CatQuest
        Gratulerer med Dagen!
      • 2020-05-17 13821, 2020

      • CatQuest
        🇳🇴
      • 2020-05-17 13802, 2020

      • Gazooo has quit
      • 2020-05-17 13841, 2020

      • Gazooo joined the channel
      • 2020-05-17 13815, 2020

      • ruaok
        all meb tests pass with pg12.3
      • 2020-05-17 13846, 2020

      • ruaok
        iliekcomputers: should I look at how to install postgres-client-12 or have you looked into that already?
      • 2020-05-17 13801, 2020

      • iliekcomputers
        i'm looking at the tests
      • 2020-05-17 13812, 2020

      • iliekcomputers
        go ahead
      • 2020-05-17 13816, 2020

      • ruaok
        ok
      • 2020-05-17 13820, 2020

      • iliekcomputers
        that way i can cargo-cult :D
      • 2020-05-17 13833, 2020

      • ruaok
        obvs
      • 2020-05-17 13802, 2020

      • iliekcomputers
        8 messybrainz tests failing...
      • 2020-05-17 13834, 2020

      • iliekcomputers
        they seem to be actual issues
      • 2020-05-17 13824, 2020

      • iliekcomputers
        i don't think we run any of this code at all in prod
      • 2020-05-17 13852, 2020

      • iliekcomputers
        it's from kartikeya's gsoc project
      • 2020-05-17 13832, 2020

      • ruaok
        oh, that is why absolutely nothing made sense yesterday.
      • 2020-05-17 13808, 2020

      • ruaok
        messybrainz may have one problem we should look at.
      • 2020-05-17 13856, 2020

      • ruaok
        pg12 requires function names to be fully qualified. and when I import the msb data into timescale, which is pg12, there are problems resolving the array_agg function.
      • 2020-05-17 13801, 2020

      • iliekcomputers
        do we use array_agg somewhere in prod
      • 2020-05-17 13813, 2020

      • ruaok
        yes. array_agg is used by artist_sort. And neither calls to array_sort are qualified.
      • 2020-05-17 13826, 2020

      • ruaok
        db/artist.py uses array_sort.
      • 2020-05-17 13839, 2020

      • ruaok
        doesn't look like a huge problem
      • 2020-05-17 13855, 2020

      • iliekcomputers
        oh yeah, artist.py is the 8 failing tests
      • 2020-05-17 13816, 2020

      • ruaok
        but that may all be unused code from katikeyas project, I would guess.
      • 2020-05-17 13832, 2020

      • ruaok
        quite frankly we could back that code out if you prefer.
      • 2020-05-17 13840, 2020

      • ruaok
        the mapping is the way forward for the time being.
      • 2020-05-17 13801, 2020

      • ruaok
        if the other approach gets picked up again, we can cobble together code from it.
      • 2020-05-17 13823, 2020

      • iliekcomputers
        yeah, make sense.
      • 2020-05-17 13832, 2020

      • iliekcomputers
        i'll try to fix the array_agg and see what happens
      • 2020-05-17 13839, 2020

      • iliekcomputers
        if it's a pain, i'll just skip the 8 tests
      • 2020-05-17 13853, 2020

      • iliekcomputers
        all integration tests pass
      • 2020-05-17 13821, 2020

      • iliekcomputers
        actually i'll just skip them
      • 2020-05-17 13803, 2020

      • iliekcomputers
        man, these tests are hard to grok lol
      • 2020-05-17 13830, 2020

      • iliekcomputers
      • 2020-05-17 13845, 2020

      • ruaok
        just nuke them. not point in working so hard to fix stuff that will likely get tossed.
      • 2020-05-17 13803, 2020

      • iliekcomputers
        yep, agreed.
      • 2020-05-17 13825, 2020

      • CatQuest
        :/
      • 2020-05-17 13810, 2020

      • ruaok
        installing the pg12 client might be interesting -- not having any luck so far on the older version of brainzutils we're on.
      • 2020-05-17 13840, 2020

      • ruaok
        why do we even need that module? because psychopg2 needs it? why not install psychopg2-binary?
      • 2020-05-17 13858, 2020

      • iliekcomputers
        what module?
      • 2020-05-17 13841, 2020

      • ruaok
        postgresql-client-12
      • 2020-05-17 13807, 2020

      • iliekcomputers
        it gives us psql in the web container.
      • 2020-05-17 13812, 2020

      • ruaok
        I think we include it as a convenience to ourselves, because meb runs fine without the client.
      • 2020-05-17 13817, 2020

      • iliekcomputers
        yeah
      • 2020-05-17 13820, 2020

      • iliekcomputers
        AB doesn't have it
      • 2020-05-17 13805, 2020

      • ruaok
        Meb dones't need it and I am removing it. should we remove from LB as well?
      • 2020-05-17 13827, 2020

      • iliekcomputers
        i would prefer to have it, makes schema changes convenient, but i'm happy to remove today and open a ticket for adding it back.
      • 2020-05-17 13816, 2020

      • ruaok
        9.5 works fine, really.
      • 2020-05-17 13825, 2020

      • ruaok
        then lets not remove it at all and open a ticket for upgrading it.
      • 2020-05-17 13833, 2020

      • iliekcomputers
        yeah, that sounds good.
      • 2020-05-17 13853, 2020

      • ruaok
        I'll backport that for MeB if I ever get fussed by it.
      • 2020-05-17 13850, 2020

      • iliekcomputers
        👍🏽
      • 2020-05-17 13807, 2020

      • iliekcomputers
        i think the LB build should work with the latest commit I added.
      • 2020-05-17 13835, 2020

      • iliekcomputers
        i'm gonna pretend i didn't see the pep-8 things :)
      • 2020-05-17 13852, 2020

      • ruaok
        what pep-8 things?
      • 2020-05-17 13814, 2020

      • iliekcomputers
        it's complaining about some spacing issues in my unittest.skip statements
      • 2020-05-17 13829, 2020

      • ruaok
        you response should be: "exactly!"
      • 2020-05-17 13838, 2020

      • v6lur has quit
      • 2020-05-17 13845, 2020

      • iliekcomputers
        missed opportunity
      • 2020-05-17 13847, 2020

      • ruaok was suggesting he didn't see anything
      • 2020-05-17 13840, 2020

      • BrainzGit
        [metabrainz.org] mayhem opened pull request #344 (master…postgres-12): Upgrade PG to 12.3 https://github.com/metabrainz/metabrainz.org/pull…
      • 2020-05-17 13848, 2020

      • iliekcomputers
        LB-591
      • 2020-05-17 13849, 2020

      • BrainzBot
        LB-591: Upgrade the postgresql client to 12 from 9.5 https://tickets.metabrainz.org/browse/LB-591
      • 2020-05-17 13842, 2020

      • BrainzGit
        [metabrainz.org] mayhem merged pull request #344 (master…postgres-12): Upgrade PG to 12.3 https://github.com/metabrainz/metabrainz.org/pull…
      • 2020-05-17 13848, 2020

      • iliekcomputers
        LB build passes, i'm happy to merge.
      • 2020-05-17 13858, 2020

      • ruaok
        MeB merged.
      • 2020-05-17 13808, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #860 (master…postgres-12): Upgrade to Postgres 12 https://github.com/metabrainz/listenbrainz-server…
      • 2020-05-17 13814, 2020

      • ruaok
        CB looks very similar to MeB, working on it now.
      • 2020-05-17 13817, 2020

      • ruaok
        woo!
      • 2020-05-17 13805, 2020

      • shivam-kapila
        Regarding LB-591 doesn't it require just upgrading version in Dockerfile or am I missing something
      • 2020-05-17 13806, 2020

      • BrainzBot
        LB-591: Upgrade the postgresql client to 12 from 9.5 https://tickets.metabrainz.org/browse/LB-591
      • 2020-05-17 13837, 2020

      • ruaok
        yes, but it doesn't work
      • 2020-05-17 13814, 2020

      • ruaok
        :q
      • 2020-05-17 13817, 2020

      • ruaok
        gah
      • 2020-05-17 13824, 2020

      • iliekcomputers
        heh
      • 2020-05-17 13853, 2020

      • ishaanshah[m]
        Another vimmer ;)
      • 2020-05-17 13811, 2020

      • ishaanshah[m]
        ruaok: You use vim on a daily basis?
      • 2020-05-17 13827, 2020

      • ruaok
        Yes
      • 2020-05-17 13839, 2020

      • ishaanshah[m]
        Nice, me too
      • 2020-05-17 13847, 2020

      • ruaok
        and have used it daily since...
      • 2020-05-17 13853, 2020

      • ruaok
        1989. lol.
      • 2020-05-17 13820, 2020

      • shivam-kapila
        wow! you guys have loads of patience. lol
      • 2020-05-17 13834, 2020

      • ishaanshah[m]
        I started out two months ago, but will never switch again
      • 2020-05-17 13841, 2020

      • ishaanshah[m]
        Its addictive
      • 2020-05-17 13809, 2020

      • iliekcomputers
        i use vim in my browser too... https://vimium.github.io/
      • 2020-05-17 13822, 2020

      • ishaanshah[m]
        Me too
      • 2020-05-17 13800, 2020

      • ishaanshah[m]
        Don't even have to touch the mouse :D
      • 2020-05-17 13855, 2020

      • iliekcomputers
        LB-592
      • 2020-05-17 13856, 2020

      • BrainzBot
        LB-592: Fix skipped tests in MessyBrainz https://tickets.metabrainz.org/browse/LB-592
      • 2020-05-17 13816, 2020

      • leonardo joined the channel
      • 2020-05-17 13820, 2020

      • iliekcomputers
        i use vim bindings in vscode these days though.
      • 2020-05-17 13828, 2020

      • ishaanshah[m]
        Why, you can get features like lsp in vim too, have you tried CoC
      • 2020-05-17 13849, 2020

      • ishaanshah[m]
        Works like a charm for me
      • 2020-05-17 13806, 2020

      • iliekcomputers
        i installed a new version of ubuntu and didn't have time to set up the vim bells and whistles
      • 2020-05-17 13820, 2020

      • iliekcomputers
        vscode comes with much saner defaults
      • 2020-05-17 13825, 2020

      • shivam-kapila
        20.04?
      • 2020-05-17 13832, 2020

      • ishaanshah[m]
        Hmm, that is true