#metabrainz

[listenbrainz-server] mayhem opened pull request #860 (master…postgres-12): Start working on pg 12 support. https://github.com/metabrainz/listenbrainz-serv...

zas: I'd like to move the postgres instance on williams to paco, rn williams is a bit too overloaded with json dumps, search index dumps, barman backups, jenkins builds, and slow disks

can barely run a 200GB rsync locally without waiting 3 hours :/

lmk if there's a better spot but looks like paco has enough space and is relatively underused

[musicbrainz-server] reosarevok merged pull request #1478 (master…MBS-10785): MBS-10785: Remove FreeDB Gateway from menu https://github.com/metabrainz/musicbrainz-serve...

MBS-10785: Remove link to FreeDB Gateway documentation https://tickets.metabrainz.org/browse/MBS-10785

moooin!

iliekcomputers: you about?

Morning

hey. so, pg12 coming tomorrow. I failed to put that on our radar.

which means that PG 9.5 goes down and then comes back up and migrated as far as CB, LB and MeB are concerned.

Hmm, I saw the PR.

I *think* it will be a non-event.

Does the password thing mean that we'll have to release new versions of LB and CB

?

Or is that for dev only?

unsure. let me see about passwords in production.

but I think that thing for us to do is to put passwords on all PG accounts going forward. that should avoid trouble.

the password is specified in consul_config.py.ctmpl, so it should be fine.

things even seem to work with the pg9.5 postgresql client inside docker images.

however, the messybrainz tests are all failing and they are setup differently than the LB tests.

can you please take a look and see how to set the password for the messybrainz tests?

Yeah, I can look at that.

thx.

once we get LB tucked away we need to look at MeB and CB.

I think it might be better if you take MeB, I'll take LB and then we'll circle back to CB

sure, that works.

LB is mostly done anyways, thanks to your PR.

on Meb as we speak.

and CB is likely to be very similar to MeB.

Gratulerer med Dagen!

🇳🇴

all meb tests pass with pg12.3

iliekcomputers: should I look at how to install postgres-client-12 or have you looked into that already?

i'm looking at the tests

go ahead

ok

that way i can cargo-cult :D

obvs

8 messybrainz tests failing...

they seem to be actual issues

i don't think we run any of this code at all in prod

it's from kartikeya's gsoc project

oh, that is why absolutely nothing made sense yesterday.

messybrainz may have one problem we should look at.

pg12 requires function names to be fully qualified. and when I import the msb data into timescale, which is pg12, there are problems resolving the array_agg function.

do we use array_agg somewhere in prod

yes. array_agg is used by artist_sort. And neither calls to array_sort are qualified.

db/artist.py uses array_sort.

doesn't look like a huge problem

oh yeah, artist.py is the 8 failing tests

but that may all be unused code from katikeyas project, I would guess.

quite frankly we could back that code out if you prefer.

the mapping is the way forward for the time being.

if the other approach gets picked up again, we can cobble together code from it.

yeah, make sense.

i'll try to fix the array_agg and see what happens

if it's a pain, i'll just skip the 8 tests

all integration tests pass

actually i'll just skip them

man, these tests are hard to grok lol

yep, agreed.

:/

installing the pg12 client might be interesting -- not having any luck so far on the older version of brainzutils we're on.

why do we even need that module? because psychopg2 needs it? why not install psychopg2-binary?

what module?

postgresql-client-12

it gives us psql in the web container.

I think we include it as a convenience to ourselves, because meb runs fine without the client.

yeah

AB doesn't have it

Meb dones't need it and I am removing it. should we remove from LB as well?

i would prefer to have it, makes schema changes convenient, but i'm happy to remove today and open a ticket for adding it back.

9.5 works fine, really.

then lets not remove it at all and open a ticket for upgrading it.

yeah, that sounds good.

I'll backport that for MeB if I ever get fussed by it.

👍🏽

i think the LB build should work with the latest commit I added.

i'm gonna pretend i didn't see the pep-8 things :)

what pep-8 things?

it's complaining about some spacing issues in my unittest.skip statements

you response should be: "exactly!"

missed opportunity

[metabrainz.org] mayhem opened pull request #344 (master…postgres-12): Upgrade PG to 12.3 https://github.com/metabrainz/metabrainz.org/pu...

LB-591

LB-591: Upgrade the postgresql client to 12 from 9.5 https://tickets.metabrainz.org/browse/LB-591

[metabrainz.org] mayhem merged pull request #344 (master…postgres-12): Upgrade PG to 12.3 https://github.com/metabrainz/metabrainz.org/pu...

LB build passes, i'm happy to merge.

MeB merged.

[listenbrainz-server] paramsingh merged pull request #860 (master…postgres-12): Upgrade to Postgres 12 https://github.com/metabrainz/listenbrainz-serv...

CB looks very similar to MeB, working on it now.

woo!

Regarding LB-591 doesn't it require just upgrading version in Dockerfile or am I missing something

LB-591: Upgrade the postgresql client to 12 from 9.5 https://tickets.metabrainz.org/browse/LB-591

yes, but it doesn't work

:q

gah

heh

Another vimmer ;)

ruaok: You use vim on a daily basis?

Yes

Nice, me too

and have used it daily since...

1989. lol.

wow! you guys have loads of patience. lol

I started out two months ago, but will never switch again

Its addictive

i use vim in my browser too... https://vimium.github.io/

Me too

Don't even have to touch the mouse :D

LB-592

LB-592: Fix skipped tests in MessyBrainz https://tickets.metabrainz.org/browse/LB-592

i use vim bindings in vscode these days though.

Why, you can get features like lsp in vim too, have you tried CoC

Works like a charm for me

i installed a new version of ubuntu and didn't have time to set up the vim bells and whistles

vscode comes with much saner defaults

20.04?

Hmm, that is true