#metabrainz

/

      • ruaok
        iliekcomputers: got a sec for a sanity check?
      • 2020-05-19 14057, 2020

      • ruaok
        Mr_Monkey: congrats!
      • 2020-05-19 14034, 2020

      • iliekcomputers
        yeah.
      • 2020-05-19 14040, 2020

      • iliekcomputers
        sure, what can I help with?
      • 2020-05-19 14042, 2020

      • ruaok
        iliekcomputers: the function profile in lb/webserver/views/user.py loads a value latest_listen_ts
      • 2020-05-19 14051, 2020

      • ruaok
        I can't see it ever getting consumed.
      • 2020-05-19 14008, 2020

      • ruaok
        late i see it getting passed into react land as latestListenTs
      • 2020-05-19 14022, 2020

      • ruaok
        but livegrep doesn't show any place that that value is used.
      • 2020-05-19 14039, 2020

      • ruaok
        is this vestigal or am I not looking correctly into the react world?
      • 2020-05-19 14044, 2020

      • iliekcomputers
        does not seem like it's used to me.
      • 2020-05-19 14056, 2020

      • _flow_ joined the channel
      • 2020-05-19 14008, 2020

      • ruaok
        k, thanks.
      • 2020-05-19 14017, 2020

      • ruaok
        easy to remove it, since it is very expensive to calculate. lol.
      • 2020-05-19 14016, 2020

      • Mr_Monkey
        ruaok: `latestListenTs` looks used in RecentListens.tsx
      • 2020-05-19 14018, 2020

      • iliekcomputers
      • 2020-05-19 14034, 2020

      • iliekcomputers is so great at communication
      • 2020-05-19 14041, 2020

      • iliekcomputers
        >we need the timestamp of the latest listen for each user.
      • 2020-05-19 14047, 2020

      • iliekcomputers
        WHY, past param, WHY?
      • 2020-05-19 14001, 2020

      • Mr_Monkey
      • 2020-05-19 14002, 2020

      • ruaok
        lolol
      • 2020-05-19 14019, 2020

      • ruaok
      • 2020-05-19 14021, 2020

      • Mr_Monkey
        I *think* it's used for 'pagination'
      • 2020-05-19 14052, 2020

      • ruaok
        wouldn't the string show up someplace else then?
      • 2020-05-19 14006, 2020

      • Mr_Monkey
        Hang on, let me check
      • 2020-05-19 14008, 2020

      • Mr_Monkey
        :p
      • 2020-05-19 14010, 2020

      • iliekcomputers
        i have a feeling that it was used to check whether we should show the playing now or not
      • 2020-05-19 14023, 2020

      • iliekcomputers
        and then we regressed during the typescript migration
      • 2020-05-19 14053, 2020

      • iliekcomputers
        just a guess though, not sure
      • 2020-05-19 14004, 2020

      • ruaok
        may I suggest that not work too hard to find the proper use for it? 😇
      • 2020-05-19 14025, 2020

      • Mr_Monkey
        Yeah, I only have memories of it being used, but that might have gone during TS migration
      • 2020-05-19 14031, 2020

      • Mr_Monkey
        :)
      • 2020-05-19 14055, 2020

      • Mr_Monkey
        Off with its head !
      • 2020-05-19 14001, 2020

      • iliekcomputers
        yeah, i'd say remove it and if a real need pops up, we can try to bring it back
      • 2020-05-19 14006, 2020

      • ruaok
        it IS going during timescale migration. :)
      • 2020-05-19 14013, 2020

      • ruaok
        done, thanks, gents!
      • 2020-05-19 14026, 2020

      • ruaok
        lol support@
      • 2020-05-19 14008, 2020

      • shivam-kapila
        finally that heavy query is gone. Huh
      • 2020-05-19 14019, 2020

      • ruaok
        exactly.
      • 2020-05-19 14028, 2020

      • ruaok has his axe out
      • 2020-05-19 14051, 2020

      • iliekcomputers
        i hope removing it from the API endpoint doesn't break clients.
      • 2020-05-19 14007, 2020

      • ruaok
        you *just* beat me to it.
      • 2020-05-19 14057, 2020

      • Chinmay3199 has quit
      • 2020-05-19 14038, 2020

      • shivam-kapila
        ruaok: iliekcomputers: Any opinions on the modules PR?
      • 2020-05-19 14055, 2020

      • shivam-kapila
        Anything that might be missing in the file?
      • 2020-05-19 14000, 2020

      • iliekcomputers
        tests
      • 2020-05-19 14030, 2020

      • shivam-kapila
        I mean any fxn we might need to add. Otherwise I will move to tests.
      • 2020-05-19 14054, 2020

      • iliekcomputers
        looks good to me.
      • 2020-05-19 14000, 2020

      • BrainzGit
        [listenbrainz-server] release v-2020-05-19.0 has been published by release-drafter[bot]: https://github.com/metabrainz/listenbrainz-server…
      • 2020-05-19 14031, 2020

      • iliekcomputers
      • 2020-05-19 14010, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #865 (master…implement-lovehate-table): Implement the database changes and SQL scripts for the lovehate table https://github.com/metabrainz/listenbrainz-server…
      • 2020-05-19 14001, 2020

      • Mr_Monkey
        🚂 Choo choo ! The GSOC train has left the station !
      • 2020-05-19 14046, 2020

      • shivam-kapila
        Passengers on board :)
      • 2020-05-19 14029, 2020

      • iliekcomputers
      • 2020-05-19 14018, 2020

      • alastairp
        hey, who's working on the love/hate project? shivam-kapila?
      • 2020-05-19 14030, 2020

      • shivam-kapila
        alastairp: yes
      • 2020-05-19 14039, 2020

      • alastairp
        do you have a ticket open for data download? People should be able to download a list of their feedback
      • 2020-05-19 14038, 2020

      • shivam-kapila
        Not a ticket added. But I have already added a function to fetch the love/hate records for a given user or recording
      • 2020-05-19 14053, 2020

      • shivam-kapila
        Does that seem ok to you?
      • 2020-05-19 14002, 2020

      • alastairp
        no,
      • 2020-05-19 14015, 2020

      • alastairp
        we need a specific feature for someone to press a button and download their feedback
      • 2020-05-19 14023, 2020

      • alastairp
        it should be integrated into this page: https://listenbrainz.org/profile/export
      • 2020-05-19 14037, 2020

      • alastairp
        (sorry, it sounds like I'm just dumping more work on you)
      • 2020-05-19 14044, 2020

      • shivam-kapila
        Got it. Export the feedback
      • 2020-05-19 14007, 2020

      • alastairp
        some background: this is a legal requirement of the GDPR law, users should be able to download all of the data that we collect about them.
      • 2020-05-19 14038, 2020

      • alastairp
        we already have it for exporting listens. This functionality should be extended to include any other types of data that users add to the database
      • 2020-05-19 14049, 2020

      • shivam-kapila
        > (sorry, it sounds like I'm just dumping more work on you)
      • 2020-05-19 14049, 2020

      • shivam-kapila
        No no. Infact this is much needed. Thanks for pointing out
      • 2020-05-19 14056, 2020

      • shivam-kapila
        I will open a ticket.
      • 2020-05-19 14029, 2020

      • alastairp
        👍
      • 2020-05-19 14037, 2020

      • shivam-kapila
        Shall I create an epic love/hate so that its easy to manage tickets for this project?
      • 2020-05-19 14042, 2020

      • iliekcomputers
        shivam-kapila: yes
      • 2020-05-19 14049, 2020

      • iliekcomputers
        that would be very helpful
      • 2020-05-19 14019, 2020

      • alastairp
        iliekcomputers: does profile export just stream straight out of influx at the moment?
      • 2020-05-19 14036, 2020

      • iliekcomputers
        alastairp: yes
      • 2020-05-19 14052, 2020

      • alastairp
        with 2 different types of data, maybe we need to think about a differnt way of doing this
      • 2020-05-19 14012, 2020

      • alastairp
        we have similar requirements in AB, both for PII download and for dataset download
      • 2020-05-19 14042, 2020

      • alastairp
        there are 2 ways that we can approach it. One is to make a background processing system - log requests, build files, email users when it's ready, delete them after x days
      • 2020-05-19 14050, 2020

      • alastairp
        this is a lot of work and includes lots of moving parts
      • 2020-05-19 14026, 2020

      • alastairp
        currently in AB I'm planning on streaming zip files. Maybe this could be used in LB too. Not sure what happens when the data gets so big that it hits the http timeout though
      • 2020-05-19 14002, 2020

      • iliekcomputers
        we've hit the timeout problem
      • 2020-05-19 14013, 2020

      • iliekcomputers
      • 2020-05-19 14031, 2020

      • iliekcomputers
      • 2020-05-19 14055, 2020

      • alastairp
        nice
      • 2020-05-19 14029, 2020

      • iliekcomputers
        the string construction is a bit ugly, but hey, it works 🤷🏽
      • 2020-05-19 14018, 2020

      • alastairp
        oh, I see. you yield an object at a time
      • 2020-05-19 14023, 2020

      • shivam-kapila
        Ticket added
      • 2020-05-19 14039, 2020

      • shivam-kapila
        LB-598
      • 2020-05-19 14040, 2020

      • BrainzBot
        LB-598: Add "Export user's loved/hated" recordings https://tickets.metabrainz.org/browse/LB-598
      • 2020-05-19 14043, 2020

      • yokel has quit
      • 2020-05-19 14041, 2020

      • yokel joined the channel
      • 2020-05-19 14010, 2020

      • Leo_Verto
        Is anyone here familiar with Go?
      • 2020-05-19 14001, 2020

      • Leo_Verto
        I'm having a bit of trouble updating brainzbot-bot from Go 1.2
      • 2020-05-19 14028, 2020

      • alastairp
        I need help from someone who drinks chai
      • 2020-05-19 14044, 2020

      • alastairp
        do I make it with all hot milk, or with hot water and add some milk?
      • 2020-05-19 14021, 2020

      • alastairp
        I have a masala chai mix that I want to try tomorrow
      • 2020-05-19 14058, 2020

      • bitmap
        probably depends on your preference but I've made it with all milk & enjoyed it
      • 2020-05-19 14024, 2020

      • bitmap
        (seems like the indian places near me do the same since they always taste super milky)
      • 2020-05-19 14023, 2020

      • yvanzo
        bitmap: I tested the PR with docker run --rm --tmpfs=/dev/shm foo df -h /dev/shm
      • 2020-05-19 14055, 2020

      • SothoTalKer_ joined the channel
      • 2020-05-19 14016, 2020

      • sumedh has quit
      • 2020-05-19 14030, 2020

      • SothoTalKer has quit
      • 2020-05-19 14010, 2020

      • reosarevok
      • 2020-05-19 14010, 2020

      • bitmap
        yvanzo: we could try it on pink, just don't there are enough parallel queries going on there to see if it resolves the original issue
      • 2020-05-19 14017, 2020

      • bitmap
        don't think*
      • 2020-05-19 14011, 2020

      • BrainzGit
        [listenbrainz-server] vansika opened pull request #867 (master…request-rec): Request consumer: cf_recording recommendations from spark cluster https://github.com/metabrainz/listenbrainz-server…
      • 2020-05-19 14038, 2020

      • bitmap
        we'll have to restart floyd soon though
      • 2020-05-19 14058, 2020

      • yvanzo
        this issue is triggered by mb cron prod on hip at least
      • 2020-05-19 14018, 2020

      • bitmap
        the hourly or daily script?
      • 2020-05-19 14021, 2020

      • rdswift has quit
      • 2020-05-19 14035, 2020

      • yvanzo
        daily for sure
      • 2020-05-19 14052, 2020

      • yvanzo
        not in hourly.
      • 2020-05-19 14026, 2020

      • bitmap
        for a ton of reports it looks like
      • 2020-05-19 14053, 2020

      • yvanzo
        it's been triggered by sir as well.
      • 2020-05-19 14033, 2020

      • bitmap
        I mean we could try running some of those queries on pink (the read-only parts at least) but it might depend on the amount of concurrent access to trigger the error
      • 2020-05-19 14035, 2020

      • yvanzo
        (when resuming)
      • 2020-05-19 14054, 2020

      • yvanzo
        or we can just deploy to postgres-williams and run reports from test
      • 2020-05-19 14053, 2020

      • yvanzo
        anyway this issue is documented, it just hits shm limits.
      • 2020-05-19 14006, 2020

      • bitmap
        sure, but restarting the pg master requires downtime so it's best to be sure it works beforehand :)
      • 2020-05-19 14056, 2020

      • yvanzo
        right, do we go for trying it on slave or williams/test then?
      • 2020-05-19 14024, 2020

      • Lotheric_ joined the channel
      • 2020-05-19 14007, 2020

      • Lotheric has quit
      • 2020-05-19 14008, 2020

      • bitmap
      • 2020-05-19 14050, 2020

      • bitmap
        so let's just restart pink and see if we can run any of these report queries again with a larger shm size
      • 2020-05-19 14020, 2020

      • bitmap
        should we use --shm-size as zas suggested and try to figure out a reasonable value?
      • 2020-05-19 14013, 2020

      • rdswift joined the channel
      • 2020-05-19 14050, 2020

      • bitmap
        reading those links it doesn't sound like there's an easy formula, but we can err on the side of overestimating it, I guess
      • 2020-05-19 14055, 2020

      • zas
        I think you can easily thrown 1gb to it, I did some research and finding the "right" value is done by hit & miss method...
      • 2020-05-19 14011, 2020

      • yvanzo
      • 2020-05-19 14015, 2020

      • zas
        current value is very low: 64k
      • 2020-05-19 14059, 2020

      • yvanzo
        64M
      • 2020-05-19 14024, 2020

      • zas
        yup yes.. :)
      • 2020-05-19 14059, 2020

      • yvanzo
        another option might be to set dynamic_shared_memory_type to mmap
      • 2020-05-19 14024, 2020

      • bitmap
        iirc the docs didn't recommend it
      • 2020-05-19 14012, 2020

      • yvanzo
        :(
      • 2020-05-19 14000, 2020

      • yvanzo
        Ok with 1gb then, bitmap?
      • 2020-05-19 14036, 2020

      • bitmap
        not sure, but we can try it
      • 2020-05-19 14039, 2020

      • yvanzo
        will try this with postgres-williams & sir-test first.
      • 2020-05-19 14022, 2020

      • bitmap
        👍
      • 2020-05-19 14031, 2020

      • bitmap
        we could attempt an "online" restart of floyd by using PAUSE/RESUME in pgbouncer, though I've never tested it in production...
      • 2020-05-19 14003, 2020

      • bitmap
        (my feeling is that PAUSE will take too long to wait for queries to complete, and the listen_backlog will just max out immediately)
      • 2020-05-19 14013, 2020

      • bitmap
        perhaps if we distributed more ro queries to pink it'd be less crazy
      • 2020-05-19 14050, 2020

      • bitmap
        is that a known issue with the mb2wikidata bot? https://gist.github.com/mwiencek/96bdec27508ad464…
      • 2020-05-19 14015, 2020

      • bitmap
        looks like our IP has been blocked by wikimedia since november
      • 2020-05-19 14044, 2020

      • ruaok
        I *think* it has to do with the fact that they blocked a whole range at hetzer and we got hit as collateral damage.
      • 2020-05-19 14051, 2020

      • bitmap
        looks like it :(
      • 2020-05-19 14035, 2020

      • ruaok
        we need a find a different place to host it, I guess.
      • 2020-05-19 14044, 2020

      • ruaok
        it needs access to a live MB DB, yes?
      • 2020-05-19 14056, 2020

      • bitmap
        yes
      • 2020-05-19 14003, 2020

      • yvanzo
        bitmap: where is pgbouncer-williams? I would like to try using PAUSE/RESUME
      • 2020-05-19 14011, 2020

      • bitmap
        was just going to update it to connect to pink, but then saw that