#metabrainz

/

      • ishaanshah
        iliekcomputers: ping
      • 2020-06-01 15335, 2020

      • yvanzo
        resetting test.mb.o
      • 2020-06-01 15339, 2020

      • v6lur_ joined the channel
      • 2020-06-01 15301, 2020

      • Gazooo has quit
      • 2020-06-01 15342, 2020

      • Gazooo joined the channel
      • 2020-06-01 15354, 2020

      • iliekcomputers
        ishaanshah: morning
      • 2020-06-01 15315, 2020

      • iliekcomputers
        i haven't deployed master to the production API yet, so the 404 makes sense
      • 2020-06-01 15304, 2020

      • BrainzGit
        [bookbrainz-site] prabalsingh24 opened pull request #435 (UserCollection…search-table-add-to-collection): UserCollection: Add to collections from search results https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2020-06-01 15357, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #884 (master…master): LB-610: The URL in the browser should update with parameters for the history page https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15344, 2020

      • Leftmost
        Mr_Monkey, I'd say we publish -data-js for now. I think what I've done is sufficient to cover the work I'm doing.
      • 2020-06-01 15310, 2020

      • Mr_Monkey
        OK, I'll aim to do that today
      • 2020-06-01 15323, 2020

      • Leftmost
        👍
      • 2020-06-01 15335, 2020

      • Leftmost
        And anyways, version numbers are cheap. :)
      • 2020-06-01 15359, 2020

      • ishaanshah
        iliekcomputers: Please ping me when you are free, had to discuss some stuff about the request consumer code
      • 2020-06-01 15310, 2020

      • iliekcomputers
        i'm around
      • 2020-06-01 15339, 2020

      • ishaanshah
      • 2020-06-01 15312, 2020

      • ishaanshah
        This the new code for artist stats
      • 2020-06-01 15332, 2020

      • ishaanshah
        It will be similar for releases
      • 2020-06-01 15302, 2020

      • ishaanshah
        We can't store a list of messages and then send them via rmq because of memory issues right
      • 2020-06-01 15303, 2020

      • ishaanshah
        So we will have to write a similar function to this but which operates on the iterator
      • 2020-06-01 15304, 2020

      • ishaanshah
      • 2020-06-01 15304, 2020

      • ishaanshah
        But as that function is used for recommendation too, we cant change it
      • 2020-06-01 15358, 2020

      • ishaanshah
        So I was thinking that we should have messenger_map similar to query_map
      • 2020-06-01 15346, 2020

      • ishaanshah
        the messenger_map will map the query type to the appropriate messaging function
      • 2020-06-01 15344, 2020

      • jmp_music has quit
      • 2020-06-01 15309, 2020

      • iliekcomputers
        hmm, let me think
      • 2020-06-01 15355, 2020

      • iliekcomputers
        i was looking into exploring making classes that inherit from an abstract RequestConsumerQuery for each query
      • 2020-06-01 15320, 2020

      • ishaanshah
        So each class would implement its own handler and messenger?
      • 2020-06-01 15351, 2020

      • iliekcomputers
        right, we could have a default messenger, and the class could override it if it needs to
      • 2020-06-01 15315, 2020

      • reosarevok
        yvanzo: I guess the main issue is the lack of parity
      • 2020-06-01 15304, 2020

      • ishaanshah
        Hmm, that will work too, but wont we have multiple rmq connections open?
      • 2020-06-01 15324, 2020

      • shivam-kapila
        ruaok: Ping
      • 2020-06-01 15325, 2020

      • iliekcomputers
        hmm, i haven't fleshed it out yet. i'll try to write it up in some more detail today.
      • 2020-06-01 15311, 2020

      • ishaanshah
        Ok, I will keep the get_artist and get_release ready
      • 2020-06-01 15333, 2020

      • ruaok
        pong!
      • 2020-06-01 15310, 2020

      • shivam-kapila
        Hey
      • 2020-06-01 15331, 2020

      • shivam-kapila
        The failing dump manager test is also fixed now
      • 2020-06-01 15340, 2020

      • ruaok
        what was it?
      • 2020-06-01 15355, 2020

      • shivam-kapila
        Remember the 0 listens dumped log I sent you?
      • 2020-06-01 15348, 2020

      • shivam-kapila
        That was the cause. No listens had created in the dump formation range
      • 2020-06-01 15307, 2020

      • ruaok
        ah, yes.
      • 2020-06-01 15312, 2020

      • ruaok
        makes sense.
      • 2020-06-01 15318, 2020

      • ruaok
        push your change, please.
      • 2020-06-01 15303, 2020

      • shivam-kapila
        Pushed. timescale-rebased-again
      • 2020-06-01 15319, 2020

      • shivam-kapila
        This shouldn't happen though as the previous dump id is added before inserting listens. Anyways I just made the previous dump ID time to be less by 5 sec.
      • 2020-06-01 15305, 2020

      • shivam-kapila
        Took 2.5 days to finally dig the issue :-|
      • 2020-06-01 15317, 2020

      • ruaok
        one thing I was thinking of is that we should change the timestamps in our test data, to include a gap of more than 3 weeks.
      • 2020-06-01 15341, 2020

      • ruaok
        I'm glad you found it, it looked totally opaque to me.
      • 2020-06-01 15311, 2020

      • shivam-kapila
        > one thing I was thinking of is that we should change the timestamps in our test data, to include a gap of more than 3 weeks.
      • 2020-06-01 15311, 2020

      • shivam-kapila
        Why so?
      • 2020-06-01 15347, 2020

      • iliekcomputers
        ishaanshah: did you figure out the issue with CORS?
      • 2020-06-01 15320, 2020

      • ishaanshah
        Not yet, I am not sure why the server is not sending the header with 204 response
      • 2020-06-01 15330, 2020

      • ruaok
        shivam-kapila: that would force us to deal with the time-range issues correctly. I think having closely spaced listens may be hiding problems for us.
      • 2020-06-01 15346, 2020

      • ishaanshah
        Thats why the error boundary is not working
      • 2020-06-01 15350, 2020

      • iliekcomputers
        can you reproduce it in dev?
      • 2020-06-01 15315, 2020

      • ishaanshah
        It works on dev
      • 2020-06-01 15352, 2020

      • shivam-kapila
        ruaok: Hm. Yeah I will agree to that
      • 2020-06-01 15309, 2020

      • iliekcomputers
        yeah, it worked for me too.
      • 2020-06-01 15325, 2020

      • iliekcomputers
        i do wonder tho, why it works for the artist endpoint and not for the release endpoint
      • 2020-06-01 15343, 2020

      • ruaok
        shivam-kapila: can you please try it? add a few more listens that have a large gap and see what breaks?
      • 2020-06-01 15353, 2020

      • ishaanshah
        artist endpoint is on api
      • 2020-06-01 15354, 2020

      • ruaok
        integration tests pass!
      • 2020-06-01 15357, 2020

      • ruaok
        !m shivam-kapila
      • 2020-06-01 15357, 2020

      • BrainzBot
        You're doing good work, shivam-kapila!
      • 2020-06-01 15358, 2020

      • ishaanshah
        release is on beta-api
      • 2020-06-01 15309, 2020

      • ishaanshah
        maybe some config error on beta-api?
      • 2020-06-01 15353, 2020

      • iliekcomputers
        they're basically the same, but yeah, that could be a possibility
      • 2020-06-01 15319, 2020

      • shivam-kapila
        ruaok: Thanks.
      • 2020-06-01 15346, 2020

      • shivam-kapila
        > can you please try it? add a few more listens that have a large gap and see what breaks?
      • 2020-06-01 15346, 2020

      • shivam-kapila
        To the test JSON files right?
      • 2020-06-01 15352, 2020

      • ruaok
        yes
      • 2020-06-01 15304, 2020

      • shivam-kapila
        I will give that a try. If things break I guess they would be in timescale_listenstore tests only but lets see
      • 2020-06-01 15317, 2020

      • ruaok
        I'm not sure sure. all test pass now, thanks!!
      • 2020-06-01 15346, 2020

      • ruaok
        changes pushed to main branch
      • 2020-06-01 15316, 2020

      • BrainzGit
        [musicbrainz-android] amCap1712 merged pull request #39 (master…design-pattern): Refactor modules to avoid redundancy. https://github.com/metabrainz/musicbrainz-android…
      • 2020-06-01 15327, 2020

      • ishaanshah
        iliekcomputers: it seems that beta-api is the issue
      • 2020-06-01 15328, 2020

      • ishaanshah
      • 2020-06-01 15353, 2020

      • ishaanshah
        Even this doesn't return access-origin-control header
      • 2020-06-01 15300, 2020

      • iliekcomputers
        oh. ok. that means that this should be fixed in prod
      • 2020-06-01 15311, 2020

      • ishaanshah
        Yep
      • 2020-06-01 15313, 2020

      • iliekcomputers
        can you comment this to the ticket? I'll deploy it then
      • 2020-06-01 15326, 2020

      • ishaanshah
        Ok will do
      • 2020-06-01 15354, 2020

      • ishaanshah
        Should I close the issue too?
      • 2020-06-01 15323, 2020

      • iliekcomputers
        i would keep it open, because we'll have to fix it in beta eventually
      • 2020-06-01 15349, 2020

      • shivam-kapila
        ruaok: 13 failing. Mostly 1!=5 errors as it fetched only 1 listen in 3 week window
      • 2020-06-01 15356, 2020

      • ruaok
        as I suspected.
      • 2020-06-01 15300, 2020

      • ishaanshah
        iliekcomputers: Done
      • 2020-06-01 15336, 2020

      • shivam-kapila
        ruaok: Do we need to adapt the tests or keep the old setup?
      • 2020-06-01 15307, 2020

      • CatQuest has left the channel
      • 2020-06-01 15328, 2020

      • ruaok
        I would much prefer to adapt tests. we've introduced a very low level requirement and we should test for it.
      • 2020-06-01 15342, 2020

      • CatQuest joined the channel
      • 2020-06-01 15342, 2020

      • CatQuest has quit
      • 2020-06-01 15342, 2020

      • CatQuest joined the channel
      • 2020-06-01 15356, 2020

      • shivam-kapila
        A simple fix can be to set time_range = -1 for tests.
      • 2020-06-01 15331, 2020

      • CatQuest has quit
      • 2020-06-01 15341, 2020

      • CatQuest joined the channel
      • 2020-06-01 15324, 2020

      • shivam-kapila
        Another one could be to add a new test. Keep the old ones as it is and add a new test for largely spaced listens.
      • 2020-06-01 15346, 2020

      • shivam-kapila
        This sounds better to me though
      • 2020-06-01 15308, 2020

      • Nyanko-sensei has quit
      • 2020-06-01 15318, 2020

      • BrainzGit
        [musicbrainz-android] amCap1712 opened pull request #41 (master…circleci-project-setup): Setup CircleCI https://github.com/metabrainz/musicbrainz-android…
      • 2020-06-01 15339, 2020

      • Nyanko-sensei joined the channel
      • 2020-06-01 15357, 2020

      • jmp_music joined the channel
      • 2020-06-01 15340, 2020

      • iliekcomputers
        ishaanshah: question
      • 2020-06-01 15352, 2020

      • iliekcomputers
        if we return an iterator
      • 2020-06-01 15358, 2020

      • iliekcomputers
        shouldn't request consumer code just work
      • 2020-06-01 15311, 2020

      • iliekcomputers
      • 2020-06-01 15318, 2020

      • iliekcomputers
        this loop would still work
      • 2020-06-01 15310, 2020

      • BrainzGit
        [listenbrainz-server] vansika opened pull request #886 (master…rec-docs): Documentation for generating recommendations. https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15327, 2020

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #887 (master…dependabot/pip/numpy-1.18.4): Bump numpy from 1.18.3 to 1.18.4 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15343, 2020

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #888 (master…dependabot/pip/flask-sqlalchemy-2.4.3): Bump flask-sqlalchemy from 2.4.1 to 2.4.3 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15301, 2020

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #889 (master…dependabot/pip/six-1.15.0): Bump six from 1.10.0 to 1.15.0 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15328, 2020

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #890 (master…dependabot/pip/pytest-5.4.2): Bump pytest from 5.4.1 to 5.4.2 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15303, 2020

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #891 (master…dependabot/pip/google-api-python-client-1.8.4): Bump google-api-python-client from 1.8.2 to 1.8.4 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15312, 2020

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #892 (master…dependabot/pip/fabric-2.5.0): Bump fabric from 1.10.2 to 2.5.0 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15332, 2020

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #893 (master…dependabot/pip/pytest-cov-2.9.0): Bump pytest-cov from 2.8.1 to 2.9.0 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15348, 2020

      • ruaok
        oh dependabot, how I didn't miss you.
      • 2020-06-01 15301, 2020

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #894 (master…dependabot/pip/sphinx-3.0.4): Bump sphinx from 3.0.3 to 3.0.4 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15317, 2020

      • BrainzGit
        [listenbrainz-server] dependabot-preview[bot] opened pull request #895 (master…dependabot/pip/redis-3.5.2): Bump redis from 3.5.0 to 3.5.2 https://github.com/metabrainz/listenbrainz-server…
      • 2020-06-01 15335, 2020

      • BrainzGit
        [musicbrainz-android] amCap1712 merged pull request #41 (master…circleci-project-setup): Setup CircleCI https://github.com/metabrainz/musicbrainz-android…
      • 2020-06-01 15339, 2020

      • yvanzo
        Hi Leo_Verto: Any idea why BrainzBot is silent since yesterday?
      • 2020-06-01 15352, 2020

      • Leo_Verto
        Hm, I didn't touch nomo in the last week. Checking right now.
      • 2020-06-01 15342, 2020

      • Leo_Verto
        !ping
      • 2020-06-01 15355, 2020

      • Leo_Verto
        BrainzBot: ping
      • 2020-06-01 15356, 2020

      • BrainzBot
        Are you in need of my services, Leo_Verto?
      • 2020-06-01 15313, 2020

      • ruaok
        you're a slacker, BrainzBot
      • 2020-06-01 15317, 2020

      • ruaok
        just like reosarevok
      • 2020-06-01 15336, 2020

      • Leo_Verto
        MBS-10870
      • 2020-06-01 15307, 2020

      • Leo_Verto
        Jira plugin might be broken, will investigate after lunch.
      • 2020-06-01 15330, 2020

      • Leo_Verto
        Looks like one of the certificate trust paths for tickets.meb.org failed https://www.ssllabs.com/ssltest/analyze.html?d=ti…
      • 2020-06-01 15305, 2020

      • Leo_Verto
        nomo still running on Ubuntu 14.04 probably doesn't have the other roots in its trust store
      • 2020-06-01 15306, 2020

      • Leo_Verto
        MBS-10870
      • 2020-06-01 15307, 2020

      • BrainzBot
        MBS-10870: Beta: Banner warning can't be hidden https://tickets.metabrainz.org/browse/MBS-10870
      • 2020-06-01 15303, 2020

      • Leo_Verto
        I temporarily disabled certificate verification in the jira plugin but this should be properly solved with the Impending Dockerization™
      • 2020-06-01 15339, 2020

      • ishaanshah
        iliekcomputers: We add some info to each message
      • 2020-06-01 15346, 2020

      • yvanzo
        Thank you!
      • 2020-06-01 15346, 2020

      • ishaanshah
        Not sure how we would do that
      • 2020-06-01 15308, 2020

      • ishaanshah
        Otherwise yes the loop will work
      • 2020-06-01 15321, 2020

      • iliekcomputers
        We could create a iterator over the spark iterator
      • 2020-06-01 15330, 2020

      • iliekcomputers
        Do you know about `yeild`
      • 2020-06-01 15352, 2020

      • ishaanshah
        no
      • 2020-06-01 15357, 2020

      • iliekcomputers
      • 2020-06-01 15329, 2020

      • iliekcomputers
        I think we could create a generator over the spark iterator and then return that
      • 2020-06-01 15348, 2020

      • BrainzGit
        [musicbrainz-android] amCap1712 opened pull request #42 (master…unit-tests): Add unit and instrumentation tests https://github.com/metabrainz/musicbrainz-android…
      • 2020-06-01 15313, 2020

      • ishaanshah
        Hmm, so in the create messages functions we `yeild` instead of `return`?
      • 2020-06-01 15359, 2020

      • iliekcomputers
        The yield should just return one message, not a list
      • 2020-06-01 15305, 2020

      • iliekcomputers
        But essentially, yes
      • 2020-06-01 15337, 2020

      • iliekcomputers
        Basically, get the spark iterator, get one message from it, yield it
      • 2020-06-01 15341, 2020

      • iliekcomputers
        And so on
      • 2020-06-01 15356, 2020

      • ishaanshah
      • 2020-06-01 15316, 2020

      • ishaanshah
        data is the spark iterator