That should *finally* be fixed (on beta) for both editing an existing entity and indexing new entities
2020-06-12 16430, 2020
CatQuest
one is bad and the other is preferred. iirc
2020-06-12 16453, 2020
Mr_Monkey
There's only pull requests, but we do push our code commits up to the repository
2020-06-12 16401, 2020
CatQuest
ehhhh
2020-06-12 16409, 2020
Mr_Monkey
Pull because we pull some feature branch *into* the master branch (for example)
2020-06-12 16409, 2020
CatQuest
anyway i note full-url paste works too. yay
2020-06-12 16423, 2020
Mr_Monkey
👍
2020-06-12 16439, 2020
CatQuest
lemme see if i can come up with a new thing to create to link with another pre-exisiting thing :D
2020-06-12 16416, 2020
CatQuest
hmph
2020-06-12 16427, 2020
CatQuest
how do I add a 3 volume "release" ?
2020-06-12 16448, 2020
CatQuest
like it's clearly the same thing (think several discs in a jewel-box)
2020-06-12 16424, 2020
CatQuest
oh man, and this is a dictionary and there are MANY mini-works in it
2020-06-12 16439, 2020
shivam-kapila
Thanks CatQuest <3
2020-06-12 16442, 2020
CatQuest
there is a small article of for example sarrusophone and at the bottom there is "bibliohrapy" section and about the person who wrote that. so *technically* this is a BIG 3-volume edition with an extensive amount of mini-works in it... good gavd
2020-06-12 16453, 2020
CatQuest
we need to be able to create inøine works
2020-06-12 16423, 2020
CatQuest
shivam-kapila: very welcome. awe say in norwegian : Gratulerer med Bursdagen! (short from "Gebursdag" also we say "Gratulere med Fødselsdagen" and jsut "Gratulerer")
2020-06-12 16442, 2020
reosarevok
Mr_Monkey, CatQuest: I *think* it's fine like that, the different colours and boxes should hopefully avoid confusion with edit note
2020-06-12 16454, 2020
reosarevok
Only way to be sure is letting new users edit and see if they get confused tho
2020-06-12 16405, 2020
Mr_Monkey
Agreed
2020-06-12 16426, 2020
Mr_Monkey
If we're all OK with it as a first placement, then "adjugé-vendu" !
2020-06-12 16441, 2020
CatQuest
it's better atleast :D
2020-06-12 16419, 2020
shivam-kapila
CatQuest: Feels good to be wished in Norwegian :p
2020-06-12 16425, 2020
CatQuest
:P
2020-06-12 16441, 2020
CatQuest
it's the only "exotic" thing I have going for me :PPP
2020-06-12 16425, 2020
shivam-kapila
:D
2020-06-12 16435, 2020
reosarevok
CatQuest: the Æ Ø Å ?
2020-06-12 16415, 2020
CatQuest
reosarevok: link him it. i'm right in the middle of adding a publisher
2020-06-12 16438, 2020
CatQuest
Mr_Monkey: now pasting the new bbid works to link right away. but typing the name does not fetch it, still
2020-06-12 16441, 2020
CatQuest
ah, if I type it 1.1 (there was a "Ltd.") then it works. but it can't be just "The Bold Strummer" (it needed the Ltd)
2020-06-12 16419, 2020
CatQuest
oh for publisist box, not the relatioship box. apparently these do not use the same box?
2020-06-12 16428, 2020
CatQuest
shoudl we jsut put "publisist" into relationships?
2020-06-12 16441, 2020
sumedh joined the channel
2020-06-12 16452, 2020
Mr_Monkey
That's tricky. they're not technically a relationship but an attribute on the Edition.
2020-06-12 16455, 2020
CatQuest
yes. (this is a legacy thing left over from when they were mandatory)
2020-06-12 16436, 2020
CatQuest
we also have a !published by! relatinoship so I think it'd be better if we just moved that int orelationships
2020-06-12 16445, 2020
CatQuest
(it's something we'd want for mb too iirc)
2020-06-12 16424, 2020
CatQuest
i'll make a ticket for it,
2020-06-12 16439, 2020
CatQuest
also i 'll make a aticket for listenbrainz stats and this isbn issue i just found
2020-06-12 16406, 2020
CatQuest
Mr_Monkey: are you also working on the linespace problems?
2020-06-12 16412, 2020
CatQuest
(also allowing markup woudl be good)
2020-06-12 16435, 2020
Mr_Monkey
linescape, yes, actually on it right now. Markup is for another day
2020-06-12 16448, 2020
CatQuest
just ismple markup like mb annotation (bold, italic)
2020-06-12 16459, 2020
CatQuest
sure. i cna make a ticket for that too iyl?
2020-06-12 16405, 2020
Mr_Monkey
Jep
2020-06-12 16411, 2020
Mr_Monkey
Thanks :)
2020-06-12 16455, 2020
CatQuest is gonan put away bought food and have a cold shower since it's warm and i've been outside al lday (not exactly india but 28˚C! not tooo shabby?!)
2020-06-12 16459, 2020
CatQuest
ok I have a question. what does actulaly "wrote blurb" mean?
2020-06-12 16403, 2020
CatQuest
i've never seen this
2020-06-12 16414, 2020
CatQuest
I'm missing "foreword" and "preface" though
2020-06-12 16459, 2020
CatQuest
ahh. nad we're gonna need a work type "oreface, forword, note" as well
CatQuest: A blurb is a promotional paragraph you sometimes find on a book cover (or inner dust jacket)
2020-06-12 16441, 2020
Mr_Monkey
prabal: to align the button to the right, you can wrap it in a `<div class="text-right">` element
2020-06-12 16438, 2020
Mr_Monkey
Actually, simpler even, you can add the `text-right` class to its parent div
2020-06-12 16431, 2020
prabal
Is that it?
2020-06-12 16437, 2020
Mr_Monkey
Yup, simple as that :)
2020-06-12 16442, 2020
prabal
I was trying "pull right"
2020-06-12 16450, 2020
prabal
It was working properly with that
2020-06-12 16403, 2020
prabal
Okay thankss
2020-06-12 16429, 2020
Mr_Monkey
Yeah, that usually breaks layout a bit, and you have to use `clear:both` css property on the next element, but even then sometimes it just won't look right
2020-06-12 16450, 2020
Mr_Monkey
I wonder how easy it would be to change the dropdown button's text so that it says "Entity type" instead of "All types" by default
2020-06-12 16410, 2020
Mr_Monkey
Not super super important, but I guess it would be clearer
cool, i will try to merge 906 over the weekend. but either ways, feel better and rest. see ya monday, if you don't have anything else.
2020-06-12 16438, 2020
ishaanshah
Thanks a lot :)
2020-06-12 16451, 2020
ishaanshah
have a nice weekend
2020-06-12 16455, 2020
iliekcomputers
you too!
2020-06-12 16426, 2020
killme has quit
2020-06-12 16403, 2020
killme joined the channel
2020-06-12 16417, 2020
v6lur has quit
2020-06-12 16426, 2020
prabal
Mr_Monkey: Why is there three different react pages for different revision tables? `src/client/components/pages/editor-revision/ , `.../entity-revisions` and `.../revisions`. All three are almost identical - they use `RevisionsTable` and `PagerElement`. I know it was me only who made these three. But now that I think, I could've made only one page and re-used them for all three tables
2020-06-12 16428, 2020
v6lur joined the channel
2020-06-12 16454, 2020
prabal
`src/client/components/pages/editor-revision/` , `.../entity-revisions` and `.../revisions`
2020-06-12 16417, 2020
v6lur has quit
2020-06-12 16428, 2020
v6lur joined the channel
2020-06-12 16422, 2020
v6lur has quit
2020-06-12 16428, 2020
prabal
Because I am doing almost similar for collections - I've made `editor-collections` and now i was making `all-collections` it just struck me that i can reuse that page again
2020-06-12 16434, 2020
Mr_Monkey
I guess it would need a small refactor to define what columns to show on which page
2020-06-12 16450, 2020
Mr_Monkey
That would be the only reason why, I guess
2020-06-12 16444, 2020
prabal
Hmm I'll try to reuse the same react class for collections for now
2020-06-12 16446, 2020
Mr_Monkey
For example, editor-revision doesn't show the editor name (we know it's that person's page), while in the /revisions page we don't show the note (for lack of space if I remember correctly
2020-06-12 16408, 2020
Mr_Monkey
Yes, wise to do so for the collections tables
2020-06-12 16419, 2020
prabal
but that is handled by passing `showEditor`, `showEtc` boolean prop
2020-06-12 16415, 2020
prabal
yeah and later I will try to refactor revision tables if it's possible and if it doesn't complicate things
2020-06-12 16442, 2020
Mr_Monkey
It looks like it would be pretty easy. You'll have to move some items into properties (like `paginationUrl`) and create some other elements outside of the component (entity-revisions has a header, for example)
2020-06-12 16403, 2020
Mr_Monkey
But all in all they are indeed very similar, and a good target for refactoring in the near future
2020-06-12 16443, 2020
prabal
yes
2020-06-12 16403, 2020
Mr_Monkey
Nicely spotted :)
2020-06-12 16403, 2020
prabal
I am wondering why I didn't see it before
2020-06-12 16423, 2020
Mr_Monkey
Well, they came in stages, and now we're looking at them side-by-side
