0:36 AM
Zastai has quit
0:38 AM
Lotheric has quit
0:44 AM
supersandro2000 has quit
0:45 AM
supersandro2000 joined the channel
0:55 AM
ljunkie has quit
1:04 AM
ljunkie joined the channel
1:43 AM
d4rkie has quit
1:43 AM
D4RK-PH0ENiX joined the channel
2:12 AM
Gore has quit
2:12 AM
Gore joined the channel
2:35 AM
Mr_Monkey has quit
2:36 AM
diru1100 has quit
2:38 AM
pristine__ has quit
2:39 AM
outsidecontext has quit
2:54 AM
pristine__ joined the channel
3:01 AM
Mr_Monkey joined the channel
3:10 AM
pristine__ has quit
3:16 AM
pristine__ joined the channel
3:22 AM
outsidecontext joined the channel
3:26 AM
diru1100 joined the channel
3:38 AM
jtpavlock has quit
3:48 AM
outsidecontext has quit
3:48 AM
pristine__ has quit
3:52 AM
outsidecontext joined the channel
4:20 AM
pristine__ joined the channel
5:45 AM
supersandro2000 has quit
6:02 AM
supersandro2000 joined the channel
6:29 AM
tykling has quit
6:30 AM
tykling joined the channel
7:01 AM
rcombs is now known as ktkm
7:01 AM
ktkm is now known as rcombs
8:17 AM
BrainzGit
8:59 AM
zas
bitmap: I see there are ~200Gb used on pgdata-floyd volume by 9.5 backup, it'd be safer to free a bit of space on floyd and move that elsewhere (backup machine?)
9:05 AM
Gazooo has quit
9:06 AM
Gazooo joined the channel
9:09 AM
CatQuest
9:09 AM
(also i've added a handful of tickets)
9:21 AM
9:21 AM
BrainzBot
BB-492: Add edition country
9:21 AM
CatQuest
it'd very useful, sure (atleast for pre-internet things)
9:24 AM
supersandro2000 has quit
9:24 AM
9:24 AM
but perhaps we do need something for anonymous..
9:24 AM
BrainzBot
BB-488: Special Purpose Artists
9:25 AM
supersandro2000 joined the channel
9:26 AM
CatQuest
🎉 Happy BB issue 500! 🎊
9:27 AM
9:27 AM
BrainzBot
BB-500: Allow markup in annotations
9:32 AM
prabal
yaaay
9:44 AM
not sure if it's a good thing. More issues = more bugs
9:44 AM
but again more improvement/features too :P
10:47 AM
BrainzGit
10:57 AM
supersandro2000 has quit
11:01 AM
11:05 AM
travis-ci joined the channel
11:05 AM
travis-ci
11:05 AM
travis-ci has left the channel
11:13 AM
BrainzGit
11:13 AM
BrainzBot
11:13 AM
11:14 AM
iliekcomputers
People around the Internets are talking about using "main" instead of "master" for the default branch
11:20 AM
prabal
Mr_Monkey: I am getting this error `Cannot use import statement outside a module` when I do `npm test`
11:20 AM
are you also getting this ?
11:35 AM
v6lur joined the channel
11:53 AM
Mr_Monkey
prabal: Which branch? I can try
11:53 AM
prabal
master only
11:56 AM
Mr_Monkey
prabal: tests are running for me
11:56 AM
prabal
Hmm okay there must be something wrong with my config or setup
11:56 AM
i'll check
11:57 AM
Mr_Monkey
Good hunt :)
11:57 AM
Not sure where it's coming fro
11:57 AM
m
11:58 AM
prabal
they're working in my older branches
11:58 AM
ishaanshah
iliekcomputers: #913 is ready for review
12:01 PM
Mr_Monkey
prabal: you could try nuking your noe_modules folder and running `npm install` again, you never know…
12:01 PM
errr, node_modules*
12:01 PM
prabal
is it because i have done npm link bookbrainz-data?
12:02 PM
no i don't think so
12:02 PM
Mr_Monkey
hm. Maybe run the build task in bookbrainz-data repo?
12:02 PM
prabal
because it's wokring in older branches
12:02 PM
Mr_Monkey
Then probably not
12:02 PM
prabal
Thankss I'll look at it
12:04 PM
BrainzGit
12:04 PM
BrainzBot
12:11 PM
v6lur has quit
12:12 PM
v6lur joined the channel
12:15 PM
ishaanshah
iliekcomputers: #909 is ready for review now :P
12:15 PM
BrainzGit
12:16 PM
iliekcomputers
on it
12:23 PM
v6lur has quit
12:23 PM
ishaanshah: reviewed
12:25 PM
new release definitely looks much better on phone
12:26 PM
v6lur joined the channel
12:30 PM
v6lur has quit
12:31 PM
v6lur joined the channel
12:35 PM
Mr_Monkey
!m ishaanshah
12:35 PM
BrainzBot
You're doing good work, ishaanshah!
12:37 PM
v6lur has quit
12:45 PM
ishaanshah
12:45 PM
iliekcomputers: ^
12:46 PM
Thanks Mr_Monkey :)
12:46 PM
iliekcomputers
yep lgtm
12:46 PM
ishaanshah
Cool, just I will update test and push
12:46 PM
iliekcomputers
i got really excited and started coding it myself :D, but if you've got it, push and i'll merge
12:50 PM
Zastai joined the channel
12:53 PM
ishaanshah
Pushed
12:53 PM
>i got really excited
12:53 PM
Me too :D
13:07 PM
BrainzGit
13:07 PM
BrainzBot
13:19 PM
iliekcomputers
k, this is getting very nitpicky, but i think we have an extra space between the "of" and "All time" in "Top recordings of All Time"
13:20 PM
ishaanshah
seems like the validation error hasn't been fixed yet
13:20 PM
13:20 PM
BrainzGit
13:21 PM
ishaanshah
> k, this is getting very nitpicky, but i think we have an extra space between the "of" and "All time" in "Top recordings of All Time"
13:21 PM
I will change that in a future PR
13:22 PM
iliekcomputers
ishaanshah: :( that's weird.
13:22 PM
ishaanshah
I suspect somethings off with the model, not sure though
13:23 PM
iliekcomputers
we're also returning HTML for 500s on the API :/
13:23 PM
ishaanshah
I will have a deeper look at it
13:23 PM
iliekcomputers
thank you!
13:24 PM
ishaanshah
Ig we should access the time range needed directly and check for validation errors as a safety measure
13:25 PM
Instead of getting the json and then filtering the timerange
13:25 PM
That would make access times quicker too
13:26 PM
shivam-kapila
13:26 PM
ishaanshah
Yep, makes sense, I will do that
13:26 PM
iliekcomputers
13:27 PM
shivam-kapila
Thanks
13:27 PM
Tam only getting HTTP error in recording tab
13:27 PM
iliekcomputers
i feel we can also use a better spinner, something more in line with default spinners on Android or iOS
13:27 PM
shivam-kapila
I am *
13:28 PM
ishaanshah
shivam-kapila: designed one
13:28 PM
iliekcomputers: Just out of curiosity how many daily visitors do we get?
13:28 PM
iliekcomputers
i have no idea.
13:29 PM
ishaanshah
Do we track it?
13:29 PM
iliekcomputers
we don't have much data on usage...
13:29 PM
shivam-kapila
ishaanshah: That hexagonal one?
13:29 PM
ishaanshah
shivam-kapila: yeah
13:30 PM
shivam-kapila
Not sure how many will like it. Till now I only got 5 likes on the Discourse post. No feedback :(
13:30 PM
13:30 PM
ishaanshah
I think it looked pretty cool
13:39 PM
BrainzGit
13:51 PM
SothoTalKer
ah, i hate regex so much :<
13:58 PM
CatQuest
do you hate regexes the same way you "don't like music" or?...
14:02 PM
SothoTalKer
kind of
14:02 PM
so powerful, but so complicated :D
14:15 PM
CatQuest
just like great music
14:15 PM
(or not)
14:15 PM
:P
14:20 PM
SothoTalKer
capturing groups to the rescue ^^