ruaok, iliekcomputers: Someone wants to interview MeB for a Python podcast - obviously I'm not the right person for it given I have written like two lines of Python for MeB, but if you are interested see email ;)
white_snack joined the channel
white_shadow has quit
diru1100
Morning y'all!!
I think there's some glitch in apple music app for Android, I am using it for free after my membership is over :)
then `res.body.error`will have the error we're looking for
iliekcomputers
ruaok: I'm happy to take it.
ruaok
alastairp how do you feel about it?
Nyanko-sensei joined the channel
Darkloke joined the channel
sumedh has quit
sumedh joined the channel
iliekcomputers: did you see my questions from last night above? about the same/separate image?
iliekcomputers
I did not. Let me read the backlog
This is the messybrainz-labs code?
ruaok
yes
iliekcomputers
Do you think it'll eventually get merged into LB, given that messybrainz is in LB already?
ruaok
I've already got it working as a separate image and it would be easy, I think, to make a cron image out of it.
yes, that is the whole point -- how do we do this?
iliekcomputers
I don't have strong opinions on whether it should be a different image or not. If piggybacking gives us some benefit, we should do it, otherwise standalone sounds good to me too.
However, we should merge the code into LB eventually
ruaok
ok, great. I'm hoping to have a PR today or tomorrow. its been lingering for too long.
artist msid lookup is now live on labs.api -- please note that in this case the [artist_credit_mbids] was also renamed to [artist_credit_mbid] for consistency sake.
please use this endpoint from now on.
ishaanshah
Cool, I will update it
Thanks :)
ruaok
now I have a thicket of PRs to prepare.
np!
white_shadow has quit
v6lur joined the channel
white_shadow joined the channel
iliekcomputers
ruaok: Freso: can we reach out to this user to politely ask them to stop spamming the same artist every 2 minutes 24/7? https://listenbrainz.org/user/hds
1196 listens / day seems a bit much
ruaok
should we just log into the DB and change their submit key?
iliekcomputers
eh, i'd like to ping them once as a warning before disabling submissions etc.
also interested in how MusicBrainz handles cases like this, just outright ban or warning first?
ruaok
when its clearly spamming its delete account. if not clearly spamming, warn.
ruaok: Internal server error for the POST endpoint
ruaok
😭
shivam-kapila
uh oh
ruaok
ahhh, the tests I am writing *just* caught this. will have it fixed in a few.
ishaanshah
thanks :)
slriv has quit
slriv joined the channel
slriv has quit
slriv joined the channel
Mr_Monkey
Hi prabal! I don't think we need to return `sendErrorAsJSON`, as I'm sure I've dealt with errors with a regular `next(error)` in the recent past. Let me look for it.
OK. I'll start having a look at your newly opened PRs
Darkloke has quit
Darkloke joined the channel
iliekcomputers
ruaok: the PR looks good to me. Just a few nits, imo the files should be in `listenbrainz/labs/api` instead of `listenbrainz/api/labs` as i could see people thinking `listenbrainz/api` contains the actual API as well. Also, we should pin the dataset-hoster requirement to a git tag.
kieto joined the channel
ruaok
I'm cool with the tag...
And I see your point on the confusion.... But labs is under the api concept, not the other way around.
iliekcomputers
hmm
ruaok
Rename the top ish level dir to labs-api ?
iliekcomputers
maybe `listenbrainz/webserver/views/labs`
ruaok
Too hidden, I think.
iliekcomputers
that works too, but `labs_api` instead, so that it's a valid python name
ruaok
Yeah, ok.
Will fix after lunch.
iliekcomputers
thanks!
ruaok
I'll add a read me too to point out that this is not the main api.
Mr_Monkey
prabal: I just noticed something: in all three open PRs with tests, you use `beforeEach` to set up the loggedInUser and request agent, but it should be `before` instead, since it only needs to be done once.