ruaok, iliekcomputers: Someone wants to interview MeB for a Python podcast - obviously I'm not the right person for it given I have written like two lines of Python for MeB, but if you are interested see email ;)
2020-08-05 21848, 2020
white_snack joined the channel
2020-08-05 21837, 2020
white_shadow has quit
2020-08-05 21845, 2020
diru1100
Morning y'all!!
2020-08-05 21829, 2020
diru1100
I think there's some glitch in apple music app for Android, I am using it for free after my membership is over :)
then `res.body.error`will have the error we're looking for
2020-08-05 21826, 2020
iliekcomputers
ruaok: I'm happy to take it.
2020-08-05 21825, 2020
ruaok
alastairp how do you feel about it?
2020-08-05 21828, 2020
Nyanko-sensei joined the channel
2020-08-05 21829, 2020
Darkloke joined the channel
2020-08-05 21811, 2020
sumedh has quit
2020-08-05 21824, 2020
sumedh joined the channel
2020-08-05 21841, 2020
ruaok
iliekcomputers: did you see my questions from last night above? about the same/separate image?
2020-08-05 21830, 2020
iliekcomputers
I did not. Let me read the backlog
2020-08-05 21842, 2020
iliekcomputers
This is the messybrainz-labs code?
2020-08-05 21856, 2020
ruaok
yes
2020-08-05 21839, 2020
iliekcomputers
Do you think it'll eventually get merged into LB, given that messybrainz is in LB already?
2020-08-05 21840, 2020
ruaok
I've already got it working as a separate image and it would be easy, I think, to make a cron image out of it.
2020-08-05 21854, 2020
ruaok
yes, that is the whole point -- how do we do this?
2020-08-05 21842, 2020
iliekcomputers
I don't have strong opinions on whether it should be a different image or not. If piggybacking gives us some benefit, we should do it, otherwise standalone sounds good to me too.
2020-08-05 21806, 2020
iliekcomputers
However, we should merge the code into LB eventually
2020-08-05 21812, 2020
ruaok
ok, great. I'm hoping to have a PR today or tomorrow. its been lingering for too long.
artist msid lookup is now live on labs.api -- please note that in this case the [artist_credit_mbids] was also renamed to [artist_credit_mbid] for consistency sake.
2020-08-05 21804, 2020
ruaok
please use this endpoint from now on.
2020-08-05 21824, 2020
ishaanshah
Cool, I will update it
2020-08-05 21844, 2020
ishaanshah
Thanks :)
2020-08-05 21846, 2020
ruaok
now I have a thicket of PRs to prepare.
2020-08-05 21848, 2020
ruaok
np!
2020-08-05 21825, 2020
white_shadow has quit
2020-08-05 21852, 2020
v6lur joined the channel
2020-08-05 21854, 2020
white_shadow joined the channel
2020-08-05 21853, 2020
iliekcomputers
ruaok: Freso: can we reach out to this user to politely ask them to stop spamming the same artist every 2 minutes 24/7? https://listenbrainz.org/user/hds
2020-08-05 21809, 2020
iliekcomputers
1196 listens / day seems a bit much
2020-08-05 21826, 2020
ruaok
should we just log into the DB and change their submit key?
2020-08-05 21825, 2020
iliekcomputers
eh, i'd like to ping them once as a warning before disabling submissions etc.
2020-08-05 21806, 2020
iliekcomputers
also interested in how MusicBrainz handles cases like this, just outright ban or warning first?
2020-08-05 21845, 2020
ruaok
when its clearly spamming its delete account. if not clearly spamming, warn.
ruaok: Internal server error for the POST endpoint
2020-08-05 21826, 2020
ruaok
😭
2020-08-05 21832, 2020
shivam-kapila
uh oh
2020-08-05 21808, 2020
ruaok
ahhh, the tests I am writing *just* caught this. will have it fixed in a few.
2020-08-05 21821, 2020
ishaanshah
thanks :)
2020-08-05 21840, 2020
slriv has quit
2020-08-05 21802, 2020
slriv joined the channel
2020-08-05 21828, 2020
slriv has quit
2020-08-05 21846, 2020
slriv joined the channel
2020-08-05 21848, 2020
Mr_Monkey
Hi prabal! I don't think we need to return `sendErrorAsJSON`, as I'm sure I've dealt with errors with a regular `next(error)` in the recent past. Let me look for it.
OK. I'll start having a look at your newly opened PRs
2020-08-05 21857, 2020
Darkloke has quit
2020-08-05 21824, 2020
Darkloke joined the channel
2020-08-05 21835, 2020
iliekcomputers
ruaok: the PR looks good to me. Just a few nits, imo the files should be in `listenbrainz/labs/api` instead of `listenbrainz/api/labs` as i could see people thinking `listenbrainz/api` contains the actual API as well. Also, we should pin the dataset-hoster requirement to a git tag.
2020-08-05 21849, 2020
kieto joined the channel
2020-08-05 21857, 2020
ruaok
I'm cool with the tag...
2020-08-05 21840, 2020
ruaok
And I see your point on the confusion.... But labs is under the api concept, not the other way around.
2020-08-05 21853, 2020
iliekcomputers
hmm
2020-08-05 21808, 2020
ruaok
Rename the top ish level dir to labs-api ?
2020-08-05 21814, 2020
iliekcomputers
maybe `listenbrainz/webserver/views/labs`
2020-08-05 21836, 2020
ruaok
Too hidden, I think.
2020-08-05 21856, 2020
iliekcomputers
that works too, but `labs_api` instead, so that it's a valid python name
2020-08-05 21806, 2020
ruaok
Yeah, ok.
2020-08-05 21813, 2020
ruaok
Will fix after lunch.
2020-08-05 21815, 2020
iliekcomputers
thanks!
2020-08-05 21835, 2020
ruaok
I'll add a read me too to point out that this is not the main api.
2020-08-05 21827, 2020
Mr_Monkey
prabal: I just noticed something: in all three open PRs with tests, you use `beforeEach` to set up the loggedInUser and request agent, but it should be `before` instead, since it only needs to be done once.
