#metabrainz

/

      • iliekcomputers
        cool. let's do the backend first. i'm afraid the bump graph might just be a bunch of parallel lines.
      • 2020-08-06 21904, 2020

      • iliekcomputers
        we'll have to see when we have the data.
      • 2020-08-06 21908, 2020

      • ishaanshah
        yeah, I want to avoid that too
      • 2020-08-06 21930, 2020

      • ishaanshah
        thats why I was thinking about the time range we should be calculating it for
      • 2020-08-06 21934, 2020

      • iliekcomputers
        about time frames, should we do that same time frames we're doing for reports, week, month, year, all time
      • 2020-08-06 21941, 2020

      • ishaanshah
        Oh, all of them
      • 2020-08-06 21908, 2020

      • ishaanshah
        then bump won't work well for week
      • 2020-08-06 21924, 2020

      • ishaanshah
        and maybe also for month
      • 2020-08-06 21935, 2020

      • iliekcomputers
        i think most popular artist over different timeframes is valuable info.
      • 2020-08-06 21943, 2020

      • ishaanshah
        hmm
      • 2020-08-06 21953, 2020

      • ishaanshah
        tbh
      • 2020-08-06 21900, 2020

      • iliekcomputers
        we'll look at how the data is, maybe it's just a case of doing a bar graph if we don't find anything good.
      • 2020-08-06 21914, 2020

      • ishaanshah
        I feel something similar to the bar graph would be the most appropriate
      • 2020-08-06 21918, 2020

      • ishaanshah
        yeah exactly
      • 2020-08-06 21939, 2020

      • iliekcomputers
        hmm.
      • 2020-08-06 21945, 2020

      • iliekcomputers
        let's see when we have the data.
      • 2020-08-06 21949, 2020

      • ishaanshah
        yep
      • 2020-08-06 21956, 2020

      • iliekcomputers
        leave the worries for future us
      • 2020-08-06 21910, 2020

      • ishaanshah
        Also I think we should skip the msid fields this time
      • 2020-08-06 21925, 2020

      • ishaanshah
        cause different sources = different msids
      • 2020-08-06 21936, 2020

      • ishaanshah
        which will lead to incorrect data
      • 2020-08-06 21940, 2020

      • iliekcomputers
        do you want to group by just names, then?
      • 2020-08-06 21945, 2020

      • ishaanshah
        names and mbids
      • 2020-08-06 21925, 2020

      • iliekcomputers
        let's do with msid first and then see if it's too bad.
      • 2020-08-06 21935, 2020

      • iliekcomputers
        i want to have msids for the future
      • 2020-08-06 21952, 2020

      • ishaanshah
        But, it will cause a lot of duplicates
      • 2020-08-06 21931, 2020

      • iliekcomputers
        i'm hoping it won't for the top few artists.
      • 2020-08-06 21944, 2020

      • ishaanshah
        hmm
      • 2020-08-06 21950, 2020

      • iliekcomputers
        skipping the msid isn't ideal because we'll eventually want to use them.
      • 2020-08-06 21953, 2020

      • ishaanshah
        ok I will take it too
      • 2020-08-06 21905, 2020

      • iliekcomputers
        and skipping them now would just mean extra work when we do want to use them.
      • 2020-08-06 21908, 2020

      • ishaanshah
        we can always remove it easily if needed
      • 2020-08-06 21912, 2020

      • iliekcomputers
        yeah.
      • 2020-08-06 21951, 2020

      • ishaanshah
        so I will have to change my query a bit
      • 2020-08-06 21926, 2020

      • iliekcomputers
        ok. sorry about that! :D
      • 2020-08-06 21935, 2020

      • iliekcomputers
        but i'm sure it'll save us work in the future.
      • 2020-08-06 21948, 2020

      • ishaanshah
        what I was assuming was we will do something similar to normal top artist but for 12 different months right now
      • 2020-08-06 21957, 2020

      • ishaanshah
        Oh no, the msid thing is a minor issue
      • 2020-08-06 21908, 2020

      • iliekcomputers
        ah.
      • 2020-08-06 21920, 2020

      • iliekcomputers
        the 3 different timeframes
      • 2020-08-06 21931, 2020

      • ishaanshah
        I will use the timerange trick over here again
      • 2020-08-06 21941, 2020

      • ishaanshah
        `time_range_df`
      • 2020-08-06 21941, 2020

      • iliekcomputers
        sounds good.
      • 2020-08-06 21902, 2020

      • ishaanshah
        I will do that tommorrow
      • 2020-08-06 21912, 2020

      • iliekcomputers
        thanks!
      • 2020-08-06 21920, 2020

      • iliekcomputers
        i don't have anything else today.
      • 2020-08-06 21939, 2020

      • ishaanshah
        I will make the minor changes
      • 2020-08-06 21943, 2020

      • ishaanshah
        right now
      • 2020-08-06 21947, 2020

      • ishaanshah
        and ping you
      • 2020-08-06 21953, 2020

      • iliekcomputers
        thanks! I'll merge it after.
      • 2020-08-06 21933, 2020

      • ishaanshah
        iliekcomputers: tests passing
      • 2020-08-06 21935, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #985 (master…param/artist-map): LB-671: Add "Artist Origin" statistics (Frontend + Backend) https://github.com/metabrainz/listenbrainz-server…
      • 2020-08-06 21936, 2020

      • BrainzBot
        LB-671: Add "Artist Origin" statistics (Frontend + Backend) https://tickets.metabrainz.org/browse/LB-671
      • 2020-08-06 21955, 2020

      • iliekcomputers
        🎉
      • 2020-08-06 21948, 2020

      • ishaanshah
        noice
      • 2020-08-06 21958, 2020

      • reosarevok
        Whoo
      • 2020-08-06 21908, 2020

      • iliekcomputers
      • 2020-08-06 21914, 2020

      • iliekcomputers
        that doesn't seem right :P
      • 2020-08-06 21936, 2020

      • ishaanshah
        yep, thats wierd
      • 2020-08-06 21940, 2020

      • ishaanshah
        no india
      • 2020-08-06 21909, 2020

      • iliekcomputers
        yeah, and it's in the monthly stuff
      • 2020-08-06 21934, 2020

      • iliekcomputers
        not sure how to debug this.
      • 2020-08-06 21912, 2020

      • iliekcomputers
      • 2020-08-06 21933, 2020

      • ishaanshah
        > yeah, and it's in the monthly stuff
      • 2020-08-06 21938, 2020

      • ishaanshah
        I didnt get you
      • 2020-08-06 21949, 2020

      • iliekcomputers
        india is in my monthly stats
      • 2020-08-06 21952, 2020

      • iliekcomputers
        but not in all time
      • 2020-08-06 21912, 2020

      • ishaanshah
        oh
      • 2020-08-06 21920, 2020

      • shivam-kapila
        I get ISE on yearly & all time
      • 2020-08-06 21931, 2020

      • ishaanshah
        your monthly stuff is more detailed than all time :D
      • 2020-08-06 21914, 2020

      • ishaanshah
        shivam-kapila: I'll check sentry
      • 2020-08-06 21920, 2020

      • iliekcomputers
      • 2020-08-06 21906, 2020

      • iliekcomputers
        we'll need to add more detailed logs
      • 2020-08-06 21916, 2020

      • ishaanshah
        that looks like an error in labs api
      • 2020-08-06 21940, 2020

      • iliekcomputers
        yeah. i assume the API returns what the error was as well
      • 2020-08-06 21950, 2020

      • iliekcomputers
        we should log the response so that ruaok can look at it.
      • 2020-08-06 21950, 2020

      • ishaanshah
        yep
      • 2020-08-06 21956, 2020

      • ishaanshah
        I'll open a PR tomorrw
      • 2020-08-06 21901, 2020

      • ishaanshah
        tomorrow*
      • 2020-08-06 21902, 2020

      • iliekcomputers
        sounds good.
      • 2020-08-06 21912, 2020

      • iliekcomputers
        i'll hold off on deploying this to prod for now then.
      • 2020-08-06 21914, 2020

      • ishaanshah
        about the monthly stuff
      • 2020-08-06 21921, 2020

      • ishaanshah
        not sure whats happinging
      • 2020-08-06 21926, 2020

      • ishaanshah
        happening*
      • 2020-08-06 21955, 2020

      • ishaanshah
        I will have to look into it in more detail
      • 2020-08-06 21921, 2020

      • shivam-kapila
        oh I will have to wait :p
      • 2020-08-06 21922, 2020

      • ishaanshah
        iliekcomputers: Also I think we are missing a lot of data
      • 2020-08-06 21923, 2020

      • slriv_ has quit
      • 2020-08-06 21929, 2020

      • ishaanshah
      • 2020-08-06 21940, 2020

      • ishaanshah
      • 2020-08-06 21905, 2020

      • ishaanshah
        there's a huge difference in total number of artists and sum of the artists in artist origin map
      • 2020-08-06 21909, 2020

      • iliekcomputers
        yeah...
      • 2020-08-06 21925, 2020

      • slriv_ joined the channel
      • 2020-08-06 21928, 2020

      • shivam-kapila
        ruaok's all time has less data than year
      • 2020-08-06 21930, 2020

      • iliekcomputers
        let's add logs on what we send to the labs API and what it returns.
      • 2020-08-06 21939, 2020

      • ishaanshah
        yep
      • 2020-08-06 21948, 2020

      • iliekcomputers
        i think we might be sending too many artists in one request.
      • 2020-08-06 21901, 2020

      • iliekcomputers
        or something like that.
      • 2020-08-06 21906, 2020

      • ishaanshah
        hmm
      • 2020-08-06 21916, 2020

      • ishaanshah
        that may be the issue
      • 2020-08-06 21925, 2020

      • ishaanshah
        where should we log this
      • 2020-08-06 21926, 2020

      • iliekcomputers
        In the meanwhile, I'm gonna add a beta tag to the graph and release to prod
      • 2020-08-06 21929, 2020

      • ishaanshah
        sentry?
      • 2020-08-06 21936, 2020

      • iliekcomputers
        ishaanshah: sentry sounds reasonable.
      • 2020-08-06 21945, 2020

      • ishaanshah
        Even if it is not an error right
      • 2020-08-06 21908, 2020

      • iliekcomputers
        yeah. sentry is really the most convenient.
      • 2020-08-06 21912, 2020

      • ishaanshah
        ok
      • 2020-08-06 21922, 2020

      • ishaanshah
        I will open the PR tommorrow
      • 2020-08-06 21933, 2020

      • ishaanshah
        we will get to know more then
      • 2020-08-06 21942, 2020

      • ishaanshah
        also one more thing
      • 2020-08-06 21900, 2020

      • ishaanshah
        is it possible to bypass the limit on variable output in sentry
      • 2020-08-06 21909, 2020

      • iliekcomputers
        Not sure.
      • 2020-08-06 21923, 2020

      • ishaanshah
        that may cause some trouble
      • 2020-08-06 21942, 2020

      • iliekcomputers
        I'll have to look into it. Maybe just implement multiple requests anyways if it makes logging easier
      • 2020-08-06 21949, 2020

      • ishaanshah
        nginx has an upper limit of 1MB for post requests
      • 2020-08-06 21954, 2020

      • ishaanshah
        by default
      • 2020-08-06 21944, 2020

      • ishaanshah
        we might be clipping some artists off
      • 2020-08-06 21944, 2020

      • slriv_ has quit
      • 2020-08-06 21957, 2020

      • ishaanshah
        I think we should do multiple post requests
      • 2020-08-06 21907, 2020

      • ishaanshah
        ~100 artists per requests ig
      • 2020-08-06 21915, 2020

      • iliekcomputers
        yeah, me too.
      • 2020-08-06 21922, 2020

      • iliekcomputers
        100 sounds low though.
      • 2020-08-06 21939, 2020

      • slriv_ joined the channel
      • 2020-08-06 21902, 2020

      • iliekcomputers
        let's make it a value in config.py and we can change as needed.
      • 2020-08-06 21916, 2020

      • ishaanshah
        ok, sounds good
      • 2020-08-06 21928, 2020

      • iliekcomputers
        i'm gonna leave this in beta for now.
      • 2020-08-06 21911, 2020

      • ishaanshah
        yeah I think that makes sens
      • 2020-08-06 21921, 2020

      • iliekcomputers
        if we don't fix this soon-ish, we should just not render the graph on the reports page until the bug gets fixed.
      • 2020-08-06 21926, 2020

      • yvanzo
        Leo_Verto: not really, even though it works with less than that, 16c/16GB is the minimum to be safe, for now.
      • 2020-08-06 21927, 2020

      • slriv_ has quit
      • 2020-08-06 21949, 2020

      • ishaanshah
        yep yep
      • 2020-08-06 21951, 2020

      • slriv_ joined the channel
      • 2020-08-06 21915, 2020

      • iliekcomputers
        ruaok: we've caused some 500s on labs.api.listenbrainz.org, in case you have detailed logs there. we suspect it's because we're sending too much data in one request.
      • 2020-08-06 21920, 2020

      • ishaanshah
        I will put this on high priority thouugh
      • 2020-08-06 21931, 2020

      • iliekcomputers
        ishaanshah: cool, thanks!
      • 2020-08-06 21923, 2020

      • ruaok
        Make me a ticket, plz.
      • 2020-08-06 21940, 2020

      • ruaok
      • 2020-08-06 21945, 2020

      • ruaok
        I have things to explore.
      • 2020-08-06 21907, 2020

      • Leo_Verto
        Hey yvanzo! Thanks for the answer, I suppose the alternative then would be to keep using the MeB servers and to donate. Is just including the API key in the application possible or would we have to use some kind of proxy?
      • 2020-08-06 21926, 2020

      • Leo_Verto
        ruaok: Bavaria or Austria?
      • 2020-08-06 21946, 2020

      • iliekcomputers
        ruaok: np, just pinged you so that you're aware. LB-687
      • 2020-08-06 21946, 2020

      • BrainzBot
      • 2020-08-06 21928, 2020

      • ruaok
        K
      • 2020-08-06 21935, 2020

      • iliekcomputers
        have fun exploring!
      • 2020-08-06 21943, 2020

      • iliekcomputers signs off as well
      • 2020-08-06 21943, 2020

      • iliekcomputers
        ishaanshah: for tomorrow, another way to debug would be to get the artist list from the prod API and send the request to labs.api locally with that artist list.
      • 2020-08-06 21940, 2020

      • shivam-kapila
        Qiestio: Can I use falticon icons?
      • 2020-08-06 21959, 2020

      • shivam-kapila
        Question*
      • 2020-08-06 21906, 2020

      • shivam-kapila
        Mr_Monkey: iliekcomputers ^^
      • 2020-08-06 21952, 2020

      • iliekcomputers
        what icon do you want to use? does it have an alternative in fontawesome?