#metabrainz

/

      • ferbncode joined the channel
      • 2020-08-10 22300, 2020

      • MFCR_ColbyRay has quit
      • 2020-08-10 22303, 2020

      • supersandro2000 has quit
      • 2020-08-10 22312, 2020

      • supersandro2000 joined the channel
      • 2020-08-10 22344, 2020

      • supersandro2000 has quit
      • 2020-08-10 22305, 2020

      • supersandro2000 joined the channel
      • 2020-08-10 22325, 2020

      • Gore has quit
      • 2020-08-10 22337, 2020

      • Gore joined the channel
      • 2020-08-10 22355, 2020

      • d4rkie has quit
      • 2020-08-10 22337, 2020

      • Nyanko-sensei joined the channel
      • 2020-08-10 22337, 2020

      • ferbncode has quit
      • 2020-08-10 22336, 2020

      • MFCR_ColbyRay joined the channel
      • 2020-08-10 22358, 2020

      • MFCR_ColbyRay
      • 2020-08-10 22327, 2020

      • sumedh joined the channel
      • 2020-08-10 22325, 2020

      • sumedh has quit
      • 2020-08-10 22359, 2020

      • BestSteve has quit
      • 2020-08-10 22313, 2020

      • prabal
      • 2020-08-10 22351, 2020

      • prabal
        Mr_Monkey: I am surprised no one noticed this before. This function is used at SO many places
      • 2020-08-10 22301, 2020

      • prabal
        typo
      • 2020-08-10 22321, 2020

      • BestSteve joined the channel
      • 2020-08-10 22311, 2020

      • BrainzGit
        [bookbrainz-site] prabalsingh24 opened pull request #487 (UserCollection…addEntityToCollection-CollectionPage): Feat: Adding Entity from Collection Page https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2020-08-10 22348, 2020

      • sumedh joined the channel
      • 2020-08-10 22318, 2020

      • yvanzo
        mo’’in’
      • 2020-08-10 22354, 2020

      • MFCR_ColbyRay has quit
      • 2020-08-10 22313, 2020

      • MFCR_ColbyRay joined the channel
      • 2020-08-10 22336, 2020

      • diru1100
        morning!!
      • 2020-08-10 22320, 2020

      • ruaok has quit
      • 2020-08-10 22331, 2020

      • ruaok joined the channel
      • 2020-08-10 22325, 2020

      • supersandro2000 has quit
      • 2020-08-10 22324, 2020

      • djwhitey has quit
      • 2020-08-10 22354, 2020

      • sumedh has quit
      • 2020-08-10 22317, 2020

      • sumedh joined the channel
      • 2020-08-10 22347, 2020

      • sumedh has quit
      • 2020-08-10 22343, 2020

      • MFCR_ColbyRay has quit
      • 2020-08-10 22302, 2020

      • pristine___
        ruaok: hey
      • 2020-08-10 22354, 2020

      • ruaok
        hi!
      • 2020-08-10 22357, 2020

      • ruaok
        and moooin all!
      • 2020-08-10 22336, 2020

      • jmp_music_
        morning!
      • 2020-08-10 22301, 2020

      • BrainzGit
        [listenbrainz-server] vansika opened pull request #1023 (master…scaling-logs): log message to sentry to debug ratings out of expected range https://github.com/metabrainz/listenbrainz-server…
      • 2020-08-10 22322, 2020

      • BrainzGit
        [listenbrainz-server] vansika merged pull request #1023 (master…scaling-logs): log message to sentry to debug ratings out of expected range https://github.com/metabrainz/listenbrainz-server…
      • 2020-08-10 22353, 2020

      • pristine___
        ruaok: can you generate your and kapila's rec?
      • 2020-08-10 22356, 2020

      • antlarr has quit
      • 2020-08-10 22304, 2020

      • antlarr2 joined the channel
      • 2020-08-10 22316, 2020

      • ruaok
        update the requester first, I take it?
      • 2020-08-10 22345, 2020

      • pristine___
        ?
      • 2020-08-10 22348, 2020

      • ruaok
        request consumer updated. recommendations requested.
      • 2020-08-10 22302, 2020

      • Gazooo has quit
      • 2020-08-10 22307, 2020

      • Gazooo joined the channel
      • 2020-08-10 22306, 2020

      • pristine___
      • 2020-08-10 22320, 2020

      • pristine___
        ruaok: shouldn't this log to Sentry?
      • 2020-08-10 22338, 2020

      • pristine___
        Did not receive any email.
      • 2020-08-10 22352, 2020

      • ruaok
        not sure about critical, error does.
      • 2020-08-10 22330, 2020

      • ruaok
        its seems the job has completed.
      • 2020-08-10 22322, 2020

      • pristine___
        Phew. Should I change that to error?
      • 2020-08-10 22327, 2020

      • pristine___
        And run once again
      • 2020-08-10 22300, 2020

      • pristine___
        Or can you paste the logs somewhere for me to see
      • 2020-08-10 22321, 2020

      • ruaok
        the logs don't contain anything interesting sadly.
      • 2020-08-10 22324, 2020

      • ruaok
        so, rerun.
      • 2020-08-10 22356, 2020

      • ruaok
      • 2020-08-10 22308, 2020

      • pristine___
        Did you checkout master and restart consumer and other things which should be done to have the latest changes everywhere?
      • 2020-08-10 22345, 2020

      • pristine___
        Because the logs should at least have the ratings after I merged the recent PR.
      • 2020-08-10 22308, 2020

      • ruaok
        doh. checkout master. such a fundamental step.
      • 2020-08-10 22322, 2020

      • ruaok
        sorry, I'm distracted, trying to finish stuff before a very busy week.
      • 2020-08-10 22328, 2020

      • ruaok
        let me do it again
      • 2020-08-10 22330, 2020

      • ruaok
        running again.
      • 2020-08-10 22353, 2020

      • pristine___
        Sure. No problem
      • 2020-08-10 22324, 2020

      • ruaok
        I see one sentry message now.
      • 2020-08-10 22315, 2020

      • ruaok
      • 2020-08-10 22344, 2020

      • pristine___
        Yup. Everything is logged like we wanted to.... I will have a look and get back to you.
      • 2020-08-10 22355, 2020

      • v6lur joined the channel
      • 2020-08-10 22329, 2020

      • pristine___
        ruaok: no negative and greater than one rating this time.
      • 2020-08-10 22301, 2020

      • ruaok
        you didn't change any code that pertains to how the rating is calculated did you?
      • 2020-08-10 22308, 2020

      • pristine___
        Nope.
      • 2020-08-10 22307, 2020

      • pristine___
        Did you checkout master in the last run? Because of they weren't the latest changes then ratings beyond the bounds will be expected.
      • 2020-08-10 22341, 2020

      • ruaok
        yes
      • 2020-08-10 22356, 2020

      • pristine___
        Yes for?
      • 2020-08-10 22302, 2020

      • ruaok
        oh the run prior to this one?
      • 2020-08-10 22306, 2020

      • pristine___
        Yes
      • 2020-08-10 22311, 2020

      • ruaok
        I may have stuffed that one up too. sorry. :(
      • 2020-08-10 22323, 2020

      • ruaok
        not sure why I can never remember that step.
      • 2020-08-10 22329, 2020

      • ruaok
        so then it's working?
      • 2020-08-10 22316, 2020

      • pristine___
        Yes. Maybe we can re run a few more times with limited users and check the logs. Otherwise I think the scaling is working perfectly
      • 2020-08-10 22314, 2020

      • ruaok
        ok, tell me which users.
      • 2020-08-10 22317, 2020

      • pristine___
        Maybe re run later in the day Or tomorrow. I have to go for now.
      • 2020-08-10 22357, 2020

      • pristine___
        Should I give you the list in a while?
      • 2020-08-10 22319, 2020

      • ruaok
        ok
      • 2020-08-10 22326, 2020

      • pristine___
        Thank you 🌹
      • 2020-08-10 22321, 2020

      • iliekcomputers
        shivam-kapila: hey, any updates on those draft PRs?
      • 2020-08-10 22301, 2020

      • iliekcomputers
      • 2020-08-10 22335, 2020

      • BrainzGit
        [listenbrainz-server] mayhem opened pull request #1024 (master…msb-mapping): MSB Mapping https://github.com/metabrainz/listenbrainz-server…
      • 2020-08-10 22349, 2020

      • djwhitey joined the channel
      • 2020-08-10 22352, 2020

      • ruaok
        to me that is invalid data...
      • 2020-08-10 22335, 2020

      • ruaok responded
      • 2020-08-10 22316, 2020

      • iliekcomputers
        yeah, i mean, the timestamp is incorrect by definition. i'm happy with us pushing back on the request. if more people come complaining, then I can look at bringing an influx webserver back but it is work that I prefer we don't do.
      • 2020-08-10 22354, 2020

      • iliekcomputers
        (also I assume our data standards should be higher than early Last.fm at least)
      • 2020-08-10 22305, 2020

      • ruaok
        ding, exactly that.
      • 2020-08-10 22329, 2020

      • ishaanshah
      • 2020-08-10 22350, 2020

      • ishaanshah
        iliekcomputers^ with the logarithmic scale
      • 2020-08-10 22313, 2020

      • iliekcomputers
        nice
      • 2020-08-10 22320, 2020

      • ishaanshah
        the median thing did not work out
      • 2020-08-10 22328, 2020

      • ishaanshah
        theres a small issue with the legend
      • 2020-08-10 22337, 2020

      • ishaanshah
        I am trying to figure it out
      • 2020-08-10 22354, 2020

      • iliekcomputers
        what's the issue?
      • 2020-08-10 22314, 2020

      • ishaanshah
        NaN in the beginning
      • 2020-08-10 22325, 2020

      • ishaanshah
        cant get rid of it
      • 2020-08-10 22359, 2020

      • iliekcomputers
        huh, that's weird. is it because log 0 is not a number? :)
      • 2020-08-10 22330, 2020

      • ishaanshah
        Not sure, I tried inserting 1 separately
      • 2020-08-10 22335, 2020

      • ishaanshah
        Did not work
      • 2020-08-10 22305, 2020

      • ishaanshah
        I am using some d3-scale and d3-chromatic-scale
      • 2020-08-10 22330, 2020

      • ishaanshah
        nivo doesn't support logarithmic domain by default
      • 2020-08-10 22328, 2020

      • ishaanshah
        I will ask about it on their discord and look at the source code once
      • 2020-08-10 22318, 2020

      • iliekcomputers
        ok. sounds good.
      • 2020-08-10 22331, 2020

      • iliekcomputers
        i'd say ask on their discord before going down the source code rabbithole
      • 2020-08-10 22317, 2020

      • iliekcomputers
        ishaanshah: also maybe push the code so I can look at it too?
      • 2020-08-10 22352, 2020

      • zas
        ishaanshah: much better with log scale, just add 1 to values (log(1+n)) to get rid of NaN
      • 2020-08-10 22338, 2020

      • BrainzGit
        [listenbrainz-server] ishaanshah opened pull request #1025 (master…ishaan/artist_map_domain_improv): [WIP] Improve domain for "Artist Origin" graph https://github.com/metabrainz/listenbrainz-server…
      • 2020-08-10 22325, 2020

      • ishaanshah
      • 2020-08-10 22323, 2020

      • ishaanshah
        zas: I tried adding 1 explicitly, I did not work
      • 2020-08-10 22358, 2020

      • ishaanshah
        I think it's its because of limitation of the charting library we are using
      • 2020-08-10 22339, 2020

      • iliekcomputers
      • 2020-08-10 22350, 2020

      • iliekcomputers
        what happens if you put in a 0 in the result array here specifically
      • 2020-08-10 22338, 2020

      • iliekcomputers
        wait
      • 2020-08-10 22317, 2020

      • iliekcomputers
        not sure i completely understand the code
      • 2020-08-10 22330, 2020

      • iliekcomputers
        but isn't the domain supposed to be a array of size two?
      • 2020-08-10 22339, 2020

      • ishaanshah
      • 2020-08-10 22353, 2020

      • ishaanshah
        everything shifts by ahead
      • 2020-08-10 22314, 2020

      • ishaanshah
        > but isn't the domain supposed to be a array of size two?
      • 2020-08-10 22314, 2020

      • ishaanshah
        Thats the thing, this solution is a bit hacky
      • 2020-08-10 22317, 2020

      • ishaanshah
        initially, they didn't have a domain prop
      • 2020-08-10 22327, 2020

      • ishaanshah
        they meaning `nivo`
      • 2020-08-10 22304, 2020

      • ishaanshah
        You needed to use d3-scale for customising the domain
      • 2020-08-10 22344, 2020

      • ishaanshah
        later they added support for domain with using d3-scale but it doesn't support logarithmic scaling
      • 2020-08-10 22308, 2020

      • iliekcomputers
        ok, i think i understand what the code is doing now.
      • 2020-08-10 22318, 2020

      • iliekcomputers
        let me look into it a bit more too.
      • 2020-08-10 22355, 2020

      • white_shadow joined the channel
      • 2020-08-10 22311, 2020

      • shivam-kapila
        iliekcomputers: hi. Sorry had an apti. Will make PR today
      • 2020-08-10 22316, 2020

      • jmp_music_
        @alastairp: Hey Alastair! Do you have any time for meeting today?
      • 2020-08-10 22330, 2020

      • white_shadow has quit
      • 2020-08-10 22346, 2020

      • kieto joined the channel
      • 2020-08-10 22304, 2020

      • white_shadow joined the channel
      • 2020-08-10 22348, 2020

      • shivam-kapila
        ruaok: like GSoC
      • 2020-08-10 22309, 2020

      • ruaok
        shivam-kapila: I still do not have enough information to answer your question.
      • 2020-08-10 22318, 2020

      • ruaok
        yvanzo: great thanks!
      • 2020-08-10 22344, 2020

      • shivam-kapila
        ruaok: I mean like I want to add my intern in experience section on a portal. It asks for location of the job and thr dropdown has list of countries but no WFH option
      • 2020-08-10 22312, 2020

      • ruaok
        No online option?
      • 2020-08-10 22319, 2020

      • shivam-kapila
        Nope
      • 2020-08-10 22345, 2020

      • ruaok
        location of the job is India.
      • 2020-08-10 22305, 2020

      • ruaok
        because that is where you performed the job. that is what they are asking for in this context.
      • 2020-08-10 22334, 2020

      • shivam-kapila
        I will mention india
      • 2020-08-10 22348, 2020

      • shivam-kapila
        And then in city mention Una(WFH)