hi jmp_music_, yes, I'm around. how about in 1 hour?
2020-08-10 22357, 2020
white_snack joined the channel
2020-08-10 22332, 2020
white_shadow has quit
2020-08-10 22319, 2020
outsidecontext
rdswift: are you around? We are preparing the Picard 2.4 release today. What's needed for the docs site? I think you had the changes already lined up, right?
2020-08-10 22341, 2020
prabal
Mr_Monkey: https://test.bookbrainz.org/collection/caf53b17-3… you made me a collaborator of this collection. I should have an option to remove myself as a collaborator. I am thinking of adding a button `remove yourself as collaborator` in this page.
2020-08-10 22341, 2020
prabal
I am confused whether I should re-use the `delete-collection-modal` here or should i make a new `remove-collaborator` modal.
2020-08-10 22341, 2020
prabal
https://github.com/bookbrainz/bookbrainz-site/blo… . The structure of `remove-collaborator-modal` will be pretty much same as `delete-modal` which makes me think I should re-use the modal but there are few changes - postUrl, body-text, header, button-text - which will make reusing it little messy
2020-08-10 22310, 2020
prabal
what do you think?
2020-08-10 22304, 2020
Mr_Monkey
prabal: I think you could refactor to resuse the same modal. for the modal body, you could pass the contents to the component using `{children}` inside the modal component so you'd call it like this: `<RefactoredModal> <div>the modal body</div></RefactoredModal>
2020-08-10 22329, 2020
Mr_Monkey
That could save you a bit of trouble. The rest of the elements could be passed as props without problem I think
2020-08-10 22338, 2020
prabal
yeahh okayy
2020-08-10 22323, 2020
iliekcomputers
ishaanshah: awesome!
2020-08-10 22333, 2020
iliekcomputers
when in doubt, create your own component :D
2020-08-10 22307, 2020
ishaanshah
Yeah I just looked up the source code and reimplemented it with slight changes
and I'll let you and bitmap finish this one off -- the DB on paco is already restarted with the right setting, but bitmap may need to do more work on it.
2020-08-10 22348, 2020
abhinavohri joined the channel
2020-08-10 22311, 2020
sumedh joined the channel
2020-08-10 22337, 2020
white_snack has quit
2020-08-10 22332, 2020
white_shadow joined the channel
2020-08-10 22338, 2020
white_shadow has quit
2020-08-10 22309, 2020
abhinavohri
iliekcomputers: Can u help me with the` url_for`method? For my test ,i want that it does not return a trailing slash at the end of the url. How can i do it?
2020-08-10 22337, 2020
iliekcomputers
just put in the string directly, instead of using url_for
What is `self.assertContext('user', self.user)` doing?
2020-08-10 22332, 2020
abhinavohri
I am not using 'url_for' method so should i keep it or omit it?
2020-08-10 22326, 2020
iliekcomputers
ishaanshah: will have to cancel our meeting today. Apologies!
2020-08-10 22311, 2020
rdswift
outsidecontext, zas: I've been collecting the new version documentation changes in a separate branch, so all I should need to do is rebase it and merge.
2020-08-10 22357, 2020
zas
ok, thanks, we are preparing the release, binaries are built, website updated (but not deployed yet)
2020-08-10 22301, 2020
rdswift
Just waiting for the release before doing that, but I can start a pr for it now. Thanks for the "heads up".
iliekcomputers: hey, I guess you're working and then interview? I had some thoughts about spark that I wanted to run past you
2020-08-10 22343, 2020
alastairp
got some time around meeting-time?
2020-08-10 22354, 2020
ruaok
its an honor system drinks station. each drink 2€. some chap was there swapping out cooling packs.
2020-08-10 22358, 2020
ruaok
only in germany.
2020-08-10 22325, 2020
alastairp
ruaok: did you see the recent photos of the mini wine windows in italy?
2020-08-10 22334, 2020
iliekcomputers
alastairp: probably not today, is tomorrow ok?
2020-08-10 22344, 2020
alastairp
any day is fine
2020-08-10 22345, 2020
ruaok
yes, resurrected because of covid? great!
2020-08-10 22354, 2020
alastairp
let's talk tomorrow. thanks
2020-08-10 22358, 2020
iliekcomputers
sounds good.
2020-08-10 22324, 2020
iliekcomputers
pristine___ probably has more context on the collaborative filtering stuff re spark btw
2020-08-10 22353, 2020
alastairp
it's more about the workflow, rather than tools/algorithms
2020-08-10 22334, 2020
iliekcomputers
ok. cool. that's probably me then. :P
2020-08-10 22340, 2020
ruaok
iliekcomputers: "[2020-08-10 14:57:44,631] DEBUG in request_consumer: Pushing result to RabbitMQ..."
2020-08-10 22354, 2020
ruaok
is that stats being pushed? it takes a looong time....
2020-08-10 22311, 2020
iliekcomputers
Which stat is it?
2020-08-10 22309, 2020
iliekcomputers
Note that because spark is lazy, it only does the actual computations when it needs to start pushing stuff which means the logs aren't exact. It's calculating the stat after it logs the pushing message.
2020-08-10 22324, 2020
iliekcomputers
Still don't expect anything to take hours though...
2020-08-10 22330, 2020
ruaok
I dunno. I can't tell from the logs.
2020-08-10 22351, 2020
ruaok
and I requested some recs, buts its been stuck like this for a while.
2020-08-10 22307, 2020
alastairp
hey, so this is actually my question. maybe I'll open the discussion now, and we can continue it whenever
2020-08-10 22343, 2020
alastairp
I understand that after you send a message to compute something, it's sent back to the listenbrainz side over rabbitmq
2020-08-10 22326, 2020
alastairp
I was just thinking through this - is there a reason why we don't save it to hdfs and just return a filename? and then have listenbrainz download it from hdfs and do whatever with it
2020-08-10 22323, 2020
ruaok
alastairp: they are hosted in two different places.
2020-08-10 22349, 2020
ruaok
consider the machines at hetzner to be "permanent machines". We can expect them to be there at all times.
2020-08-10 22350, 2020
alastairp
right, so that would require opening hdfs up on the public internet?
2020-08-10 22325, 2020
ruaok
whereas the spark cluster is more flexible. right now its stored on 4 machines (dirt cheap, the stuff that someone has used before) at hetzner.
2020-08-10 22339, 2020
ruaok
if someone were to offer us a better cluster for free, we'd move there.
2020-08-10 22340, 2020
MFCR_ColbyRay joined the channel
2020-08-10 22310, 2020
ruaok
I'd love to have a 16 node cluster with loads of disk space, but alas, we're have a tiny 4 node cluster.
2020-08-10 22323, 2020
alastairp
I'm not sure that that strictly discounts my suggestion, but it seems likely that it introduces additional complexity to the idea
2020-08-10 22338, 2020
ruaok
this arrangement allows us to pass data back and forth using a mechanism we already rely on with minimal config exceptions.
2020-08-10 22300, 2020
ruaok
it doesn't... yet.
2020-08-10 22315, 2020
ruaok
the spark cluster is considered "disposable" and "batch oriented".
2020-08-10 22336, 2020
ruaok
whereas our productions servers are considered to be "stable" and "per request fast".
2020-08-10 22351, 2020
alastairp
right. it was just a thought that I had after looking through this part of the code, and after remembering these types of discussions happening a few times before (e.g. "does all of the data that we want to return fit inside rabbitmq?")
2020-08-10 22352, 2020
ruaok
so, results being stored in PG for fast response to the user.
2020-08-10 22307, 2020
alastairp
sure, I'm not suggesting removing results from pg
2020-08-10 22321, 2020
ruaok
loads of discussions, yes.
2020-08-10 22335, 2020
alastairp
the idea would be for the pg writer to request from hdfs, and then write to pg. instead of sending the results directly back in a rabbitmq message
2020-08-10 22336, 2020
ruaok
and its a shitty balance between what I am willing to open our wallets for and what we need to work extra for.
2020-08-10 22355, 2020
alastairp
instead, rabbitmq would just be a signaling mechanism
2020-08-10 22316, 2020
ruaok
I see where you're going with that.
2020-08-10 22324, 2020
ruaok
except docker. docker swarm in particular.
2020-08-10 22328, 2020
ruaok
its.. special.
2020-08-10 22301, 2020
ruaok
if you publish a port from a service, then docker goes and opens those ports for that server to the WORLD.
2020-08-10 22308, 2020
ruaok
and you CANNOT say don't do that.
2020-08-10 22310, 2020
alastairp
where does rabbitmq live? it's the main mb cluster, and is publicly accessible for spark to connect to?
2020-08-10 22322, 2020
alastairp
right, got it
2020-08-10 22354, 2020
ruaok
hetzer. lemmy has an opening that allows the spark leader to connect to rabbitmq. but lemmy only allows that from that one IP of the leader.
