#metabrainz

/

      • alastairp
        but I do think that setting up a full python 3 image would be the right thing to do, so that we don't have to make changes in the future
      • 2020-08-18 23107, 2020

      • alastairp
      • 2020-08-18 23114, 2020

      • alastairp
        copy it to `docker/Dockerfile.py3`
      • 2020-08-18 23139, 2020

      • alastairp
        and delete https://github.com/metabrainz/acousticbrainz-serv…, and change the `FROM` in the first line to 3.7
      • 2020-08-18 23103, 2020

      • jmp_music_
        ok!
      • 2020-08-18 23131, 2020

      • alastairp
        I'm around all day, so feel free to ask me any additional questions if you run into problems
      • 2020-08-18 23143, 2020

      • jmp_music_
        Another question, is how do you suggest to load the `models.sklearn.the_relevant_method` to the `dataset_eval.evaluate`?
      • 2020-08-18 23151, 2020

      • jmp_music_
        with relative imports for example?
      • 2020-08-18 23139, 2020

      • alastairp
        so, we actually run the program in the /data directory
      • 2020-08-18 23152, 2020

      • alastairp
        so, we don't do: cd dataset_eval; python evaluate.py
      • 2020-08-18 23102, 2020

      • alastairp
        we do `python -m dataset_eval.evaluate`
      • 2020-08-18 23117, 2020

      • alastairp
        (we don't do exactly that, we use worker_manage.py, but the principle is the same)
      • 2020-08-18 23128, 2020

      • alastairp
        that means you can just do "import models.sklearn" in evalaute.py and it'll work
      • 2020-08-18 23133, 2020

      • jmp_music_
        that's what I saw in the dockerfile
      • 2020-08-18 23144, 2020

      • jmp_music_
        ok cool!
      • 2020-08-18 23153, 2020

      • jmp_music_
        thanks Alastair!
      • 2020-08-18 23147, 2020

      • zas
      • 2020-08-18 23117, 2020

      • alastairp
        what better way to get bug reports than to release a new major version :)
      • 2020-08-18 23143, 2020

      • outsidecontext
        alastairp: this is very true ;) Also shows that we had two beta releases this time out for several weeks, but the real bug reports only came in after the final release
      • 2020-08-18 23134, 2020

      • outsidecontext
        Data about Picard installs from the Windows Store https://usercontent.irccloud-cdn.com/file/8bXPG7j…
      • 2020-08-18 23146, 2020

      • outsidecontext
        Picard - A software for old men :P
      • 2020-08-18 23130, 2020

      • v6lur has quit
      • 2020-08-18 23141, 2020

      • reosarevok
        A software for people who don't stream all their music
      • 2020-08-18 23143, 2020

      • reosarevok
        So, yeah
      • 2020-08-18 23141, 2020

      • sumedh joined the channel
      • 2020-08-18 23101, 2020

      • ruaok
      • 2020-08-18 23106, 2020

      • ruaok
        Speaking of lemmy!!
      • 2020-08-18 23126, 2020

      • MajorLurker joined the channel
      • 2020-08-18 23139, 2020

      • yvanzo
        Upgraded docker-compose to latest (1.26.2) on bono (in /usr/local/bin)
      • 2020-08-18 23153, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1654 (master…MBS-11041): MBS-11041: Make ModBot leave a note on autoremoval edits https://github.com/metabrainz/musicbrainz-server/…
      • 2020-08-18 23154, 2020

      • BrainzBot
        MBS-11041: ModBot should leave note on autoremoval edits https://tickets.metabrainz.org/browse/MBS-11041
      • 2020-08-18 23126, 2020

      • thomasross joined the channel
      • 2020-08-18 23158, 2020

      • thomasross has quit
      • 2020-08-18 23129, 2020

      • thomasross joined the channel
      • 2020-08-18 23116, 2020

      • yvanzo
        Is there any custom data in musicbrainz-docker db on bono that should be saved?
      • 2020-08-18 23158, 2020

      • yvanzo
        I will recreate that database from a fresh dump.
      • 2020-08-18 23147, 2020

      • alastairp
        check if there's a messybrainz schema, I believe this is the result of ruaok's matching code
      • 2020-08-18 23115, 2020

      • alastairp
        I think that it's easily reproduceable if you don't want to save and reload it
      • 2020-08-18 23158, 2020

      • ruaok
        Ding. Relations and mapping schemas exist. Feel free to blow away, I can recreate.
      • 2020-08-18 23155, 2020

      • yvanzo
        Ok, will do. Is MB search server useful on bono?
      • 2020-08-18 23156, 2020

      • alastairp
        I don't need it. I don't think the mapping stuff uses it either, we just connect directly to the db
      • 2020-08-18 23157, 2020

      • yvanzo
        Ok, built new images, downloading db dump.
      • 2020-08-18 23131, 2020

      • ruaok
        Not for me either.
      • 2020-08-18 23154, 2020

      • yvanzo
        Ok, I stopped it too.
      • 2020-08-18 23140, 2020

      • thomasross has quit
      • 2020-08-18 23134, 2020

      • iliekcomputers
        ishaanshah: hey, i have a conflict at our usual time, let's postpone by ~30 min, ok?
      • 2020-08-18 23145, 2020

      • iliekcomputers
        shivam-kapila: hey, how goes it?
      • 2020-08-18 23100, 2020

      • ishaanshah
        Sure
      • 2020-08-18 23139, 2020

      • shivam-kapila
        iliekcomputers: Last test left for frontend then only tests for backend left
      • 2020-08-18 23119, 2020

      • iliekcomputers
        cool, sounds good. thanks. if you need any help, ping here.
      • 2020-08-18 23121, 2020

      • yvanzo
        alastairp, iliekcomputers, ishaanshah, ruaok: I’m going to nuke MB DB on bono, unless you're currently working with it.
      • 2020-08-18 23131, 2020

      • alastairp
        fine by me
      • 2020-08-18 23129, 2020

      • yvanzo
        alastairp: after docker-compose upgrade, you probably need to specify 'acousticbrainzserver' as COMPOSE_PROJECT_NAME in .env to preserve current docker containers/volumes on bono
      • 2020-08-18 23130, 2020

      • alastairp
        thanks. is this a service that you saw running in docker ps?
      • 2020-08-18 23132, 2020

      • yvanzo
        (or alias to the old /usr/bin/docker-compose)
      • 2020-08-18 23138, 2020

      • ruaok
        Ok!
      • 2020-08-18 23148, 2020

      • alastairp
        I believe we use a launcher script to add -p to docker-compose call, so it should be OK
      • 2020-08-18 23158, 2020

      • alastairp
        what's the new behaviour?
      • 2020-08-18 23122, 2020

      • alastairp
        (having said all of that, there will be no problem to recreate all containers and volumes, so I don't think this is an issue)
      • 2020-08-18 23124, 2020

      • yvanzo
        alastairp: I saw some with docker system df -v
      • 2020-08-18 23143, 2020

      • yvanzo
        the old behaviour was to ignore '-' characters from the current working directory, the new one is to keep it
      • 2020-08-18 23125, 2020

      • alastairp
        ah, interesting. thanks for the info
      • 2020-08-18 23143, 2020

      • yvanzo
        I have set that var to 'musicbrainzdocker' cause I don't want to download dumps again
      • 2020-08-18 23108, 2020

      • alastairp
        we should double-check our develop.sh and test.sh scripts for this, because I believe we do some modifying of this value
      • 2020-08-18 23139, 2020

      • MFCR_ColbyRay joined the channel
      • 2020-08-18 23111, 2020

      • sumedh has quit
      • 2020-08-18 23124, 2020

      • yvanzo
        This is one motivation for requiring Docker Compose 1.21.1 at https://github.com/metabrainz/musicbrainz-docker#…
      • 2020-08-18 23150, 2020

      • sumedh joined the channel
      • 2020-08-18 23156, 2020

      • alastairp
        (next question: why does musicbrainz-docker require 1.21.1?)
      • 2020-08-18 23121, 2020

      • yvanzo
        (and Ubuntu 18.04 comes with 1.17.x but it is easy to install a newer version)
      • 2020-08-18 23147, 2020

      • yvanzo
        (did I just answered next question already?)
      • 2020-08-18 23113, 2020

      • alastairp
        I wasn't sure if there was a specific reason that you updated it. (I have no specific reason for asking, any version is fine for me)
      • 2020-08-18 23126, 2020

      • yvanzo
        That and probably annoying bugs that have been fixed since then
      • 2020-08-18 23114, 2020

      • alastairp
        cool, great
      • 2020-08-18 23114, 2020

      • alastairp
        thanks
      • 2020-08-18 23151, 2020

      • yvanzo
        no problem
      • 2020-08-18 23104, 2020

      • yvanzo
        10k
      • 2020-08-18 23118, 2020

      • yvanzo
        (did I just answered next question again?)
      • 2020-08-18 23135, 2020

      • yvanzo
        Stopped MB DB on bono.
      • 2020-08-18 23143, 2020

      • alastairp
        don't talk to me about that, talk to my boss
      • 2020-08-18 23145, 2020

      • pristine___
        iliekcomputers: can you take a quick loo at https://github.com/metabrainz/listenbrainz-server…
      • 2020-08-18 23152, 2020

      • pristine___
        I want to merge it today
      • 2020-08-18 23158, 2020

      • pristine___
        look*
      • 2020-08-18 23135, 2020

      • iliekcomputers
        pristine___: can't right now, will take a look today.
      • 2020-08-18 23107, 2020

      • pristine___
        thanks
      • 2020-08-18 23144, 2020

      • shivam-kapila
        iliekcomputers: ping
      • 2020-08-18 23109, 2020

      • shivam-kapila
        or ishaanshah
      • 2020-08-18 23117, 2020

      • iliekcomputers
        sup?
      • 2020-08-18 23129, 2020

      • shivam-kapila
        I was writing jest tests
      • 2020-08-18 23141, 2020

      • alastairp
        I was jest writing some tests
      • 2020-08-18 23126, 2020

      • shivam-kapila
      • 2020-08-18 23144, 2020

      • shivam-kapila
        This test is failing at line 18
      • 2020-08-18 23152, 2020

      • shivam-kapila
        saying no of calls = 0
      • 2020-08-18 23102, 2020

      • shivam-kapila
        Any idea what I am doing wrong
      • 2020-08-18 23147, 2020

      • iliekcomputers
        could be because your fetchCoverArt is called in componentDidMount and you're using `shallow`
      • 2020-08-18 23105, 2020

      • iliekcomputers
        can you try wrapper = mount(<ListenCard />)
      • 2020-08-18 23108, 2020

      • shivam-kapila
        same error
      • 2020-08-18 23115, 2020

      • iliekcomputers
        not sure then.
      • 2020-08-18 23157, 2020

      • iliekcomputers
        oh wait you were already calling componentDidMount explicitly
      • 2020-08-18 23158, 2020

      • iliekcomputers
        huh
      • 2020-08-18 23109, 2020

      • iliekcomputers
        then the mount not changing anything makes sense.
      • 2020-08-18 23149, 2020

      • MFCR_ColbyRay has quit
      • 2020-08-18 23105, 2020

      • iliekcomputers
        that's weird.
      • 2020-08-18 23124, 2020

      • iliekcomputers
        does the assert on line 19 pas?
      • 2020-08-18 23141, 2020

      • shivam-kapila
        nope
      • 2020-08-18 23147, 2020

      • shivam-kapila
        solved
      • 2020-08-18 23118, 2020

      • shivam-kapila
        line 8 is not needed and causing error.
      • 2020-08-18 23105, 2020

      • sumedh has quit
      • 2020-08-18 23110, 2020

      • sumedh joined the channel
      • 2020-08-18 23124, 2020

      • shivam-kapila
        iliekcomputers: 1038 is ready
      • 2020-08-18 23129, 2020

      • iliekcomputers
        awesome, did you do the integration into the current listens page as well?
      • 2020-08-18 23146, 2020

      • shivam-kapila
        Nope
      • 2020-08-18 23158, 2020

      • shivam-kapila
        I mean the code is ready with me
      • 2020-08-18 23122, 2020

      • iliekcomputers
        could you do that as well? I'd prefer to do it in the same PR
      • 2020-08-18 23138, 2020

      • shivam-kapila
        So we will release it?
      • 2020-08-18 23146, 2020

      • iliekcomputers
        the card?
      • 2020-08-18 23147, 2020

      • iliekcomputers
        yes.
      • 2020-08-18 23100, 2020

      • shivam-kapila
        Shall I also add the listen count card impllementation code
      • 2020-08-18 23122, 2020

      • iliekcomputers
        the count card, not in this one
      • 2020-08-18 23128, 2020

      • shivam-kapila
        okk
      • 2020-08-18 23134, 2020

      • shivam-kapila
        I will push for this
      • 2020-08-18 23102, 2020

      • iliekcomputers
        sounds good, thanks
      • 2020-08-18 23116, 2020

      • yvanzo
        alastairp, iliekcomputers, ishaanshah, ruaok: MB DB @ bono is back, starting replication now.
      • 2020-08-18 23137, 2020

      • iliekcomputers
        yvanzo: i don't have anything on bono, no need to ping me.
      • 2020-08-18 23100, 2020

      • alastairp
        thanks yvanzo
      • 2020-08-18 23105, 2020

      • alastairp
        send the invoice to ruaok
      • 2020-08-18 23106, 2020

      • yvanzo
        iliekcomputers: it relates to MeB dataset hoster IUC
      • 2020-08-18 23114, 2020

      • shivam-kapila
        iliekcomputers: done
      • 2020-08-18 23144, 2020

      • iliekcomputers
        shivam-kapila: thanks, i'll take a look today.
      • 2020-08-18 23157, 2020

      • yvanzo
        alastairp, ruaok: mb mirror @ bono is set to query search.musicbrainz.org if needed. ('indexer' & 'search' containers are stopped.)
      • 2020-08-18 23108, 2020

      • yvanzo
        also set website hostname to fix bundling of scripts/static resources.
      • 2020-08-18 23145, 2020

      • alastairp
        is it publicly accessible?
      • 2020-08-18 23116, 2020

      • alastairp
        I'm not sure if we have anything that uses the webservice, we just use it for the db
      • 2020-08-18 23154, 2020

      • ishaanshah
        iliekcomputers: hello
      • 2020-08-18 23156, 2020

      • yvanzo
        yes, it is
      • 2020-08-18 23141, 2020

      • iliekcomputers
        Hey, give me a sec
      • 2020-08-18 23152, 2020

      • iliekcomputers
        hey ishaanshah i don't think we need to do the entire jira shindig this and the next week.
      • 2020-08-18 23158, 2020

      • yvanzo
        stopping search container saved a few GBs of RAM at least
      • 2020-08-18 23100, 2020

      • ishaanshah
        yep yep
      • 2020-08-18 23113, 2020

      • ishaanshah
        just wanted to update you on what I did today
      • 2020-08-18 23114, 2020

      • iliekcomputers
        i assume you'll be continuing on the artist graph and then start incremental dumps as soon as the artist graph is done
      • 2020-08-18 23120, 2020

      • ishaanshah
        yep
      • 2020-08-18 23125, 2020

      • iliekcomputers
        awesome.
      • 2020-08-18 23107, 2020

      • ishaanshah
        I worked on the tests
      • 2020-08-18 23116, 2020

      • ishaanshah
        couldn't complete them unfortunately
      • 2020-08-18 23137, 2020

      • iliekcomputers
        not a problem.
      • 2020-08-18 23140, 2020

      • ishaanshah
        I would prefer if you have a quick look at the non tests part
      • 2020-08-18 23146, 2020

      • iliekcomputers
        when do you think you'll be able to finish?
      • 2020-08-18 23158, 2020

      • iliekcomputers
        ok, that sounds good, i'll add it to my list for today
      • 2020-08-18 23123, 2020

      • ishaanshah
        I'll try tomorrow, but not sure, I have a ton of classes tomorrow