#metabrainz

_lucifer: found it at https://musicbrainz.org/artist/164f0d73-1234-4e...

yeah it showed up after all release groups

also yvanzo, EPs are exported in a dump as well right?

i am trying to track down a bug in CB where all release groups are shown but EPs are missing

_lucifer: yup, it's included in sample dump

👍

pristine___: excited for the recs

Do we actually import listens from Spotify (as in past listening history) or do we only use Spotify's "scrobbling" functionality?

From what I've seen its only the later, but I may be incorrect...

snazz: Yep spotify only allows the past 50 listens for an user

So we cant import the whole history

Actually theres a workaround

But havent got to that

That's actually a good thing, it makes it much easier to word on the website what we are doing with Spotify

The way we optimised spotify imports that can be used to import whole history

pristine___: jest is easier than react

pristine___: jest is easier than react

Phew!

iliekcomputers: #1082 is ready for review

I'll open a separate PR for frontend so that we can deploy it a week after this PR has been deployed

lmao

I forgot that pytest made my laptop feel like it was taking off

any rust dev here

poor thinkpad is about to burn a hole in my lap

[listenbrainz-server] tomnieuwland opened pull request #1086 (master…LB-686-user-information-cleanup): LB-686 Cleaned up a variety of user information pages https://github.com/metabrainz/listenbrainz-serv...

LB-686: Separate, obvious page for ways to scrobble and import listens https://tickets.metabrainz.org/browse/LB-686

iliekcomputers: By any chance do you remember the other newbie ticket that was floating around? Something about local time?

LB-642

LB-642: Specify a field for "local time" for listens https://tickets.metabrainz.org/browse/LB-642

snazz: ^^

shivam-kapila: cheers! ^_^

snazz: thanks for the PR!

No worries. I went a little outside the scope of the original ticket, because I noticed a lot of information was either seemingly in the wrong spot on the website, or was being repeated elsewhere...

I'm sure it will make sense with the PR... I hope!

iliekcomputers: doesnt add to whitelist work for brainzbot now

ruaok: https://tickets.metabrainz.org/browse/LB-723

LB-723: Labs recording MBID lookup API doesn't return anything for merged recordings

shivam-kapila: ping

pristine___: pong

`Object is possibly 'undefined'` , error for offset line 4 and listens line 8

it works fine though.

I don't understanf the error since i have defined both of them in props and state

shivam-kapila: ^

1.

```

if (offset && offset >= this.expectedRecommendationsPerPage) {

```

why so?

thats typescript at work

ooo

in case offset is not defined it cant effectively check that inequalty

and for listens?

`listens?.slice` ?

```

listens: listens?.slice(0, this.expectedRecommendationsPerPage),

```

you got that already

:)

`offset < (recommendationLength - this.expectedRecommendationsPerPage)`

shivam-kapila: it says that right side should be a number etc

so that means i cannot write a var in here?

didnt get ya

`recommendationLength - this.expectedRecommendationsPerPage`

`The right-hand side of an arithmetic operation must be of type 'any', 'number', 'bigint' or an enum type.`

the error ^

can you pastebin the fxn plz

not sure about the aim

recommendationLength = length of listen array.

double &&

line 5

gaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaah

don't look at me :p

🙈

shivam-kapila: line 11, i am assigning a value to here, so ideally there shouldn't be any prob but it say `Type 'Listen[] | undefined' is not assignable to type 'Listen[]'`

i understand why there should be a check in if else, but why a check when we are assigning value to something.

```listens: listens?.slice(0, this.expectedRecommendationsPerPage) || [],

```

why so? even if it is an empty listen it will work

i think

listens can be undefined

in that case it wont slice

and return undefined

ah! but isn't it wow. I mean this strictness, little room for bugs

this is typescript magic

Js is weakly typed

typescript makes sure that we exploit the weekness properly

weakness* properlt

shivam-kapila: a && a < b && b

is this valid?

interview scenes lol

a && b && a < b is better IG

L to R associativity

haha. interviews.

they are scary

for me atleast :p

me too

[listenbrainz-server] MonkeyDo opened pull request #1087 (master…follow-button-animation): Animate the follow button https://github.com/metabrainz/listenbrainz-serv...