-
reosarevok
And after that I do sudo docker-compose restart musicbrainz ?
2020-09-14 25827, 2020
-
yvanzo
reosarevok: Not sure which file you edited?
2020-09-14 25840, 2020
-
reosarevok
DBDefs.pm I mean
2020-09-14 25845, 2020
-
yvanzo
in the container?
2020-09-14 25827, 2020
-
yvanzo
or in build/musicbrainz-dev/ or build/musicbrainz/ ?
2020-09-14 25827, 2020
-
reosarevok
No, locally. But I guess I should edit it in the container, from that question
2020-09-14 25849, 2020
-
yvanzo
you mean in your local git working tree?
2020-09-14 25810, 2020
-
reosarevok
Ye
2020-09-14 25812, 2020
-
reosarevok
*Yes
2020-09-14 25815, 2020
-
yvanzo
make a copy of that file just in case docker reset it.
2020-09-14 25853, 2020
-
yvanzo
I’m not sure restarting the container is even required but it should do no harm.
2020-09-14 25844, 2020
-
yvanzo
Oops, no, it will reset it :P
2020-09-14 25803, 2020
-
reosarevok
Ok
2020-09-14 25805, 2020
-
reosarevok
Will check again
2020-09-14 25818, 2020
-
yvanzo
Modify /DBDefs.pm in the container instead.
2020-09-14 25820, 2020
-
reosarevok
So far, it all seems to be ignored and it still uses the sample DB
2020-09-14 25837, 2020
-
reosarevok
In the container as in, after docker-compose exec musicbrainz bash ?
2020-09-14 25851, 2020
-
yvanzo
/musicbrainz-server/lib/DBDefs.pm is replaced with /DBDefs.pm on container startup.
2020-09-14 25856, 2020
-
yvanzo
yes
2020-09-14 25827, 2020
-
c1e0 has quit
2020-09-14 25831, 2020
-
yvanzo
You can try something as: cat /musicbrainz-server/lib/DBDefs.pm > /DBDefs.pm
2020-09-14 25857, 2020
-
reosarevok
Ok, so if I have ssh -L 172.17.0.1:65401:localhost:65401 pink -N
2020-09-14 25840, 2020
-
reosarevok
Then I should have host => "127.17.0.1", port => "65401" inside the container?
2020-09-14 25847, 2020
-
reosarevok
Or is the host different inside there?
2020-09-14 25816, 2020
-
yokel has quit
2020-09-14 25836, 2020
-
yvanzo
?
2020-09-14 25852, 2020
-
yvanzo
No, just copy the PROD_STANDBY :)
2020-09-14 25815, 2020
-
yvanzo
You can find the original values in build/musicbrainz-dev/DBDefs.pm (in musicbrainz-docker)
2020-09-14 25839, 2020
-
yvanzo
s/127/172/ probably
2020-09-14 25851, 2020
-
yokel joined the channel
2020-09-14 25848, 2020
-
yvanzo
nelgin: interesting
2020-09-14 25840, 2020
-
iliekcomputers
ooh, LB crossed 11k users today
2020-09-14 25843, 2020
-
iliekcomputers
fun
2020-09-14 25851, 2020
-
shivam-kapila
congrats
2020-09-14 25824, 2020
-
reosarevok
yvanzo: duh, typo, thanks
2020-09-14 25837, 2020
-
reosarevok
yvanzo: ok, changed this:
2020-09-14 25844, 2020
-
reosarevok
2020-09-14 25853, 2020
-
reosarevok
(so, more or less what I used to do locally to get what I wanted)
2020-09-14 25809, 2020
-
reosarevok
But it's still using the old DB. Do I need to tell it something so that it will re-check this and change DBs?
2020-09-14 25817, 2020
-
yvanzo
not sure, RT_SLAVE maybe?
2020-09-14 25853, 2020
-
yvanzo
Restarting the container should be fine if you modified /DBDefs.pm
2020-09-14 25800, 2020
-
yvanzo
You can also backup this file as follows: sudo docker cp musicbrainz-docker_musicbrainz_1:/DBDefs.pm /tmp/backup-DBDefs.pm
2020-09-14 25800, 2020
-
v6lur has quit
2020-09-14 25828, 2020
-
v6lur joined the channel
2020-09-14 25822, 2020
-
reosarevok
Restarting the container overwrote it again :)
2020-09-14 25851, 2020
-
reosarevok
So I guess that can't be the way to do this
2020-09-14 25818, 2020
-
reosarevok
With my usual plackup thing IIRC any changes to dbdefs would be understood and dealt with without any extra changes on my part
2020-09-14 25824, 2020
-
reosarevok
But this doesn't seem to do the same
2020-09-14 25800, 2020
-
reosarevok
Unless I'm changing something weird. I should still be changing lib/DBDefs.pm, just inside the container, right? There's no separate DBDefs this uses
2020-09-14 25858, 2020
-
iliekcomputers
the LB user growth chart would be interesting to see, i have a feeling the rate has increased since we shipped stats
2020-09-14 25848, 2020
-
yokel has quit
2020-09-14 25828, 2020
-
yvanzo
reosarevok: are you changing /DBDefs.pm (at container's root /)?
2020-09-14 25837, 2020
-
reosarevok
No, the lib one, I didn't realize there was a second
2020-09-14 25856, 2020
-
yvanzo
13:21 < yvanzo> /musicbrainz-server/lib/DBDefs.pm is replaced with /DBDefs.pm on container startup.
2020-09-14 25806, 2020
-
reosarevok
Yeah
2020-09-14 25809, 2020
-
yvanzo
:)
2020-09-14 25815, 2020
-
reosarevok
I thought you meant my local one with the container one
2020-09-14 25826, 2020
-
reosarevok
Didn't notice this has a separate one in a place I didn't expect :D
2020-09-14 25833, 2020
-
reosarevok
Ok, let's change that :D
2020-09-14 25839, 2020
-
yvanzo
Oh sorry, I didn't imagine your local one was installed under /musicbrainz-server as well.
2020-09-14 25816, 2020
-
reosarevok
Well, it's under home, whatever, musicbrainz-server, but I didn't think that much :D
2020-09-14 25823, 2020
-
reosarevok
Aaanyway
2020-09-14 25831, 2020
-
reosarevok
Let's try again :)
2020-09-14 25833, 2020
-
reosarevok
Sorry I'm slow
2020-09-14 25836, 2020
-
yvanzo
2020-09-14 25811, 2020
-
reosarevok
whoo, I'm in pink
2020-09-14 25801, 2020
-
reosarevok
(that sounds like I'm wearing a princess dress... sadly I don't own any)
2020-09-14 25824, 2020
-
ruaok
I'd pay good $$$ to see that!
2020-09-14 25841, 2020
-
ruaok
sigh. which is it that they never sell pink pricess dresses for adult males??
2020-09-14 25849, 2020
-
ruaok would've mailed one to reosarevok
2020-09-14 25858, 2020
-
reosarevok
No you wouldn't
2020-09-14 25810, 2020
-
reosarevok
You wouldn't wait 3 to 5 hours even for that
2020-09-14 25824, 2020
-
ruaok
ok, fair, I'd order you one online
2020-09-14 25828, 2020
-
yokel joined the channel
2020-09-14 25831, 2020
-
shivam-kapila
ruaok planning to order summit dresses instead of tees for reo?
2020-09-14 25800, 2020
-
reosarevok
Fuck it
2020-09-14 25801, 2020
-
ruaok
shivam-kapila: yep. are you more of a pink sort of programmer or a light blue one??
2020-09-14 25805, 2020
-
reosarevok
Summit dresses for everyone
2020-09-14 25828, 2020
-
shivam-kapila
ruaok: light blue... blue is my fav
2020-09-14 25804, 2020
-
shivam-kapila
reosarevok: the only satidfied customer will be pristine___
2020-09-14 25850, 2020
-
ruaok
customink doesn't sell mini dresses. that would've been perfect.
2020-09-14 25848, 2020
-
ruaok
oh good. I found a supplier.
2020-09-14 25856, 2020
-
ruaok
😈
2020-09-14 25809, 2020
-
pristine___ like dresses. Will suit her new look.
2020-09-14 25801, 2020
-
yokel has quit
2020-09-14 25820, 2020
-
Lotheric
reosarevok, get kilts
2020-09-14 25826, 2020
-
Lotheric
:)
2020-09-14 25820, 2020
-
yokel joined the channel
2020-09-14 25805, 2020
-
reosarevok
2020-09-14 25849, 2020
-
ruaok
2020-09-14 25850, 2020
-
ruaok
niiice!
2020-09-14 25820, 2020
-
ruaok wants one
2020-09-14 25815, 2020
-
diru1100
That's my school's kindergarten dress 😮
2020-09-14 25838, 2020
-
shivam-kapila
lmao
2020-09-14 25856, 2020
-
yokel has quit
2020-09-14 25810, 2020
-
shivam-kapila
ruaok: I think diru1100 also wantys one
2020-09-14 25841, 2020
-
diru1100
thank you, next 😂
2020-09-14 25833, 2020
-
diru1100
Also LB got 11k+ users, noice !!
2020-09-14 25847, 2020
-
shivam-kapila
I am tired of assignments
2020-09-14 25825, 2020
-
diru1100
iliekcomputers: looking forward to read more blogs of yours!!
2020-09-14 25844, 2020
-
diru1100
I don't have assignments, but tests started :/
2020-09-14 25825, 2020
-
yokel joined the channel
2020-09-14 25836, 2020
-
diru1100
lol what
2020-09-14 25856, 2020
-
diru1100
you can always upgrade
2020-09-14 25807, 2020
-
diru1100
btw by gamification in cb mean like a reward point system?
2020-09-14 25822, 2020
-
shivam-kapila
maybe badges?
2020-09-14 25824, 2020
-
shivam-kapila
like bb
2020-09-14 25835, 2020
-
diru1100
yea
2020-09-14 25844, 2020
-
diru1100
i am taking a poll from my friend circle what they wish they want in CB. And also about BB and CB integration
2020-09-14 25803, 2020
-
diru1100
goodreads is famous among people who read a lot of books
2020-09-14 25842, 2020
-
diru1100
I thought of having an upvote option instead of "was it useful" will make the user interface more
2020-09-14 25806, 2020
-
diru1100
Also a thread kinda thing for each review to extend the discussion
2020-09-14 25820, 2020
-
shivam-kapila
reddit
2020-09-14 25857, 2020
-
diru1100
yea...
2020-09-14 25800, 2020
-
shivam-kapila
list them in a doc... we will add
2020-09-14 25807, 2020
-
diru1100
quora and reddit basically.
2020-09-14 25810, 2020
-
diru1100
will do :)
2020-09-14 25841, 2020
-
shivam-kapila
then discuss with the team what to hack on
2020-09-14 25853, 2020
-
CatQuest
I think we should keep "was it useful" up/down but i think a reply fucntion might be interesting
2020-09-14 25814, 2020
-
yokel has quit
2020-09-14 25837, 2020
-
yokel joined the channel
2020-09-14 25823, 2020
-
yokel has quit
2020-09-14 25800, 2020
-
yokel joined the channel
2020-09-14 25814, 2020
-
pristine___
ishaanshah: shivam-kapila can you please review #1042. I really need a lot of react tips
2020-09-14 25834, 2020
-
pristine___
And shivam-kapila thank you so much for helping me all along the way :)
2020-09-14 25843, 2020
-
yokel has quit
2020-09-14 25820, 2020
-
ruaok
19 files changed. :(
2020-09-14 25834, 2020
-
shivam-kapila
pristine___: most welcome
2020-09-14 25808, 2020
-
pristine___
ruaok: only two python files.
2020-09-14 25848, 2020
-
pristine___
But all of this should be done in one PR :(
2020-09-14 25836, 2020
-
ruaok
something is odd about this PR. how come it adds a view for delete_listen?
2020-09-14 25849, 2020
-
pristine___
Link?
2020-09-14 25858, 2020
-
ruaok
2020-09-14 25853, 2020
-
diru1100
why does CB have a like option as well as a was it useful thing?
2020-09-14 25819, 2020
-
diru1100
like option looks like its linked with fb but i dont think it is
2020-09-14 25854, 2020
-
yokel joined the channel
2020-09-14 25844, 2020
-
yokel has quit
2020-09-14 25843, 2020
-
ruaok
pristine___: that's quite a of tests you've written for these features. which is great in general. but....
2020-09-14 25805, 2020
-
ruaok
isn't this basically for a feature for a limited time?
2020-09-14 25821, 2020
-
ruaok
I'm just wondering about spending so much time on tests for a feature that might go away in a few weeks.
2020-09-14 25825, 2020
-
pristine___
Yes. But it should work well in that limited time.
2020-09-14 25830, 2020
-
pristine___
Hmm.
2020-09-14 25834, 2020
-
ruaok
oh, for sure.
2020-09-14 25845, 2020
-
ruaok
few things are going to get past those tests!
2020-09-14 25802, 2020
-
pristine___
Hmmm.
2020-09-14 25813, 2020
-
ruaok
you see my point?
2020-09-14 25824, 2020
-
pristine___
Yeah, I understand.
2020-09-14 25838, 2020
-
pristine___
Will keep this in mind.
2020-09-14 25836, 2020
-
pristine___
ruaok: so should I remove a few tests?
2020-09-14 25857, 2020
-
ruaok
no, not at all.
