(everything else has been changed, except the url is still /delete)
2020-09-24 26807, 2020
ruaok
ishaanshah: ooops, sorry for that. we were trying to debug a filespace issue on paco yesterday and the mapping didn't regenerate correctly. I'll have it fixed in an hour.
2020-09-24 26852, 2020
reosarevok
outsidecontext: are you maintaining libdiscid now? Wondering if the bug mentioned in MBS-1588 still exists at all
reosarevok: I don't know if I do maintain it :D I did not intent to actually, but applied some changes recently so probably that means I volunteered
2020-09-24 26804, 2020
reosarevok
haha
2020-09-24 26811, 2020
reosarevok
I just asked because it's all you in recent history
2020-09-24 26825, 2020
outsidecontext
about the issue not sure, my gut feeling would be that the underlying issue is probably solved. that bug report is rather old, and there had been quite a few changes afterwards in around 2013. but hard to tell without knowing the actual disc and how the TOC was bad
2020-09-24 26852, 2020
reosarevok
Ok
2020-09-24 26804, 2020
reosarevok
Well, improving the error page won't hurt either way
2020-09-24 26813, 2020
reosarevok
But good to know the whole thing has been improved in the meantime anyway
reosarevok: can be changed if needed, it will probably break URLs for that ticket only.
2020-09-24 26854, 2020
kori joined the channel
2020-09-24 26838, 2020
outsidecontext
reosarevok: I really can't tell for sure, the info is very sparse there. The issue on that TOC is really that the total sectors are smaller then the last offset. but to see how this came to be one would need to check an actual disc producing something like this. can also be OS dependent, a glitch in reading the disc or maybe even have been generated with something other than libdiscid.
2020-09-24 26838, 2020
outsidecontext
anyway, I guess improving the error page for wrongly submitted TOCs wouldn't hurt and is basically independent of this.
2020-09-24 26809, 2020
outsidecontext
explaining that the submitted TOC has some invalid format and maybe link to discid documentation would help
2020-09-24 26846, 2020
outsidecontext
tested libdiscid, at least it does not accept the offsets if you feed it the TOC directly
2020-09-24 26855, 2020
_lucifer
alastairp: two queries regarding the PRs
2020-09-24 26858, 2020
_lucifer
> My preference is for these error messages to not have a . at the end of them
2020-09-24 26816, 2020
_lucifer
so only "You have to select a license" right?
2020-09-24 26844, 2020
_lucifer
second, i am not sure how to add a test case for the cache issue ?
2020-09-24 26848, 2020
v6lur has quit
2020-09-24 26828, 2020
v6lur joined the channel
2020-09-24 26828, 2020
kori has quit
2020-09-24 26801, 2020
Gazooo794 has quit
2020-09-24 26849, 2020
Gazooo794 joined the channel
2020-09-24 26827, 2020
alastairp
reosarevok: off the top of your head do you know if flash messages in MB end with a . ?
hah, and here is me saying ! at the end of a message is a bit naff and we shouldn't use them
2020-09-24 26816, 2020
alastairp
_lucifer: does CB have any tests where we mock the cache? I think I have a few of that kind in AB
2020-09-24 26852, 2020
alastairp
we could have a test where we test the specific get_x_by_id, mocking the cache and the BU get method, and just put in each of the types of necessary data
2020-09-24 26827, 2020
alastairp
e.g., mock cache.get returns None, verify that the db get method is called. mock cache.get returns something, verify that db get isn't called
2020-09-24 26843, 2020
alastairp
also, verify that the argument to mock cache.get is expected (e.g. 'artist_[artistid]')
(that's a yes..., I was just checking so that we can do a test that actually loads this data from the musicbrainz database)
2020-09-24 26811, 2020
_lucifer
yeah, this db will be empty or it has some sample data we can use right away?
2020-09-24 26854, 2020
kori joined the channel
2020-09-24 26810, 2020
heyoni has quit
2020-09-24 26832, 2020
alastairp
that's what I'm asking you
2020-09-24 26836, 2020
alastairp
I don't know
2020-09-24 26853, 2020
_lucifer
oh ok! i'll check that
2020-09-24 26811, 2020
heyoni joined the channel
2020-09-24 26841, 2020
_lucifer
it's empty alastairp
2020-09-24 26823, 2020
kori has quit
2020-09-24 26825, 2020
d4rkie joined the channel
2020-09-24 26837, 2020
Nyanko-sensei has quit
2020-09-24 26808, 2020
kori joined the channel
2020-09-24 26851, 2020
alastairp
_lucifer: right. I don't know if the tests do anything to load dummy data into the db or not. Perhaps all we should do is mock the call to the brainzutils method too?
2020-09-24 26831, 2020
alastairp
I don't like this much, because we're basically mocking everything, but I think the actual method is tested in BU anyway, so perhaps it's not strictly necessary
2020-09-24 26822, 2020
_lucifer
yeah, i agree. the get_x_by_id method is just choosing between the cache and db
