13:10 PM
ruaok
no
2020-09-24 26817, 2020
13:11 PM
ruaok
(yes, should not be removed)
2020-09-24 26806, 2020
13:23 PM
ruaok
pristine___: hang on.
2020-09-24 26835, 2020
13:23 PM
ruaok
where do you need to deal with this? I sense things might be more complicated than they need to be.
2020-09-24 26835, 2020
13:23 PM
pristine___
ruaok: so if & comes in name as well, and in join phrase too,
2020-09-24 26838, 2020
13:23 PM
pristine___
Okay
2020-09-24 26850, 2020
13:23 PM
reosarevok
You'll have plenty of join phrases that are only punctuation FWIW
2020-09-24 26810, 2020
13:24 PM
pristine___
ruaok: Converting artist and track names to matchable
2020-09-24 26822, 2020
13:24 PM
pristine___
The 4 steps you told me that day
2020-09-24 26845, 2020
13:24 PM
pristine___
Remove whitespace, punctuation, accent and convert to lower
2020-09-24 26855, 2020
13:24 PM
ruaok
yes, clearly. it sounds like you are constructing an artist_credit_name from its components. is that right?
2020-09-24 26814, 2020
13:27 PM
pristine___
I will have a df of listens, I will convert the artist_name and track _name to Matchable texts so that I can join listens with the mapping on these Matchable fields.
2020-09-24 26844, 2020
13:27 PM
ruaok
ok, where in that process do you need to construct an artist credit name?
2020-09-24 26809, 2020
13:30 PM
travis-ci joined the channel
2020-09-24 26809, 2020
13:30 PM
travis-ci
2020-09-24 26809, 2020
13:30 PM
travis-ci has left the channel
2020-09-24 26814, 2020
13:31 PM
pristine___
Isn't artist credit name is same as artist name in listens?
2020-09-24 26842, 2020
13:31 PM
ruaok
yes and there are no join phrases in listens, which is why I am confused as to what you're doing.
2020-09-24 26849, 2020
13:32 PM
pristine___
2020-09-24 26816, 2020
13:33 PM
pristine___
we are joining here on msid, we want to join on matchable texts, no?
2020-09-24 26823, 2020
13:33 PM
ruaok
correct.
2020-09-24 26846, 2020
13:33 PM
pristine___
2020-09-24 26850, 2020
13:33 PM
pristine___
here too.
2020-09-24 26850, 2020
13:34 PM
ruaok
ok, when I say "constructing an artist credit name", I meant constructing a text from these three tables
2020-09-24 26851, 2020
13:34 PM
ruaok
2020-09-24 26857, 2020
13:34 PM
pristine___
so I need to convert the `artist_name` and `track_name` col of listens to matchable (remove whitespace, punctuations etc)
2020-09-24 26803, 2020
13:35 PM
ruaok
those three tables do not exist in the LB listens.
2020-09-24 26844, 2020
13:35 PM
ruaok
so, ignore artist credits. simply carry out the 4 steps on the artist_name and track_name fields without worrying about join phrases.
2020-09-24 26801, 2020
13:36 PM
pristine___
so that i can join like this: `listens_df.artist_name_matchable == 'msb_artist_credit_name_matchable'
2020-09-24 26836, 2020
13:36 PM
pristine___
yeah, so that was what i was asking, should i need to keep join phrases while removing whitespaces
2020-09-24 26839, 2020
13:36 PM
pristine___
okay
2020-09-24 26846, 2020
13:54 PM
pristine___
2020-09-24 26823, 2020
13:55 PM
pristine___
2020-09-24 26834, 2020
13:55 PM
pristine___
ruaok: ^^
2020-09-24 26848, 2020
13:55 PM
pristine___
The labs API returned 500
2020-09-24 26819, 2020
14:03 PM
ruaok
pristine___: what is your exact query?
2020-09-24 26819, 2020
14:03 PM
ruaok
2020-09-24 26807, 2020
14:05 PM
travis-ci joined the channel
2020-09-24 26807, 2020
14:05 PM
travis-ci
2020-09-24 26807, 2020
14:05 PM
travis-ci has left the channel
2020-09-24 26827, 2020
14:07 PM
kori has quit
2020-09-24 26847, 2020
14:08 PM
kori joined the channel
2020-09-24 26825, 2020
14:16 PM
v6lur has quit
2020-09-24 26834, 2020
14:17 PM
pristine___
ruaok: yup, got the issue. Opening a PR.
2020-09-24 26800, 2020
15:03 PM
_lucifer
2020-09-24 26815, 2020
15:03 PM
_lucifer
if these changes are ok, i'll add the same for other entities as well
2020-09-24 26821, 2020
15:05 PM
alastairp
that looks perfect. exactly the series of tests that are needed
2020-09-24 26830, 2020
15:06 PM
reosarevok
Whoo
2020-09-24 26832, 2020
15:06 PM
reosarevok
Tests
2020-09-24 26836, 2020
15:06 PM
reosarevok
That I didn't need to write
2020-09-24 26839, 2020
15:06 PM
reosarevok
The best kind of tests
2020-09-24 26810, 2020
15:08 PM
_lucifer
👍
2020-09-24 26843, 2020
15:08 PM
alastairp
_lucifer: so the only reason that we were getting the weird behaviour was because the mbid was cached?
2020-09-24 26802, 2020
15:09 PM
alastairp
now if we use the wrong entity it'll return 404?
2020-09-24 26809, 2020
15:09 PM
_lucifer
yes
2020-09-24 26813, 2020
15:09 PM
alastairp
right
2020-09-24 26816, 2020
15:09 PM
alastairp
sneaky bug
2020-09-24 26823, 2020
15:10 PM
_lucifer
i saw that the sqlalchemy logs were not fetching the artist so i came to probe the cache and after adding entity to the mbid it went away
2020-09-24 26845, 2020
15:10 PM
_lucifer
so i think this should be the only issue
2020-09-24 26857, 2020
15:13 PM
alastairp
pristine___: btw, "API didn't send a valid responce due to Internal Server Error." -> should be response
2020-09-24 26822, 2020
15:14 PM
pristine___
yeah, thanks
2020-09-24 26835, 2020
15:14 PM
pristine___
I corrected this in the PR i am writing rn :p
2020-09-24 26841, 2020
15:14 PM
alastairp
cool
2020-09-24 26841, 2020
15:33 PM
BrainzGit
2020-09-24 26842, 2020
15:33 PM
BrainzBot
2020-09-24 26826, 2020
15:38 PM
reosarevok
Whoops :D
2020-09-24 26842, 2020
15:38 PM
reosarevok
I did wonder for a moment why we even had that there if it was useless, but :D
2020-09-24 26852, 2020
15:38 PM
bitmap
sshhh
2020-09-24 26843, 2020
15:39 PM
bitmap
actually, I'll add a comment there too saying when it's NaN, because it already confused me once
2020-09-24 26854, 2020
15:40 PM
reosarevok
Probably smart
2020-09-24 26816, 2020
15:46 PM
reosarevok
bitmap: this is added by you and currently set to decision required. What do we need to decide, other than "yes/no"?
2020-09-24 26817, 2020
15:46 PM
reosarevok
2020-09-24 26818, 2020
15:46 PM
BrainzBot
MBS-2704: Return release labels/catalog numbers in /ws/2 release group request
2020-09-24 26841, 2020
15:49 PM
reosarevok
2020-09-24 26842, 2020
15:49 PM
BrainzBot
MBS-2962: Enable MB server to run under proxy.
2020-09-24 26855, 2020
15:49 PM
reosarevok
The comment suggested "There is some remaining work here updating a few of the javascript files to not use absolute URLs."
2020-09-24 26822, 2020
15:54 PM
bitmap
that is going to be all broken if MBS isn't running at /
2020-09-24 26809, 2020
15:56 PM
bitmap
though I'm not sure how well that worked before
2020-09-24 26838, 2020
15:56 PM
bitmap
we didn't port uri_for to JS anyway, so any React code will assume / is the server root
2020-09-24 26814, 2020
15:58 PM
reosarevok
Ok, so basically that's a lot further away than before rather than the other way around
2020-09-24 26821, 2020
15:58 PM
reosarevok
Good to know. I'll leave a comment
2020-09-24 26853, 2020
15:59 PM
bitmap
re: MBS-2704 I'm not sure, but probably whether it makes sense to return the info there
2020-09-24 26853, 2020
15:59 PM
BrainzBot
2020-09-24 26815, 2020
16:00 PM
reosarevok
Ok
2020-09-24 26822, 2020
16:00 PM
reosarevok
Maybe we can decide :)
2020-09-24 26854, 2020
16:00 PM
reosarevok
I understand we don't want to add even more stuff to ws responses - this won't usually be *a lot* per release but...
2020-09-24 26857, 2020
16:00 PM
bitmap
tbh I think the inc=releases thing (which only returns a max of 25 iirc?) should be deprecated anyway
2020-09-24 26830, 2020
16:01 PM
bitmap
the proper way is via a browse request, which if it doesn't return that info we should add it there, but
2020-09-24 26837, 2020
16:01 PM
reosarevok
And just use browse only?
2020-09-24 26850, 2020
16:01 PM
reosarevok
Well, that's certainly the way we should do it for ws3 at the very least
2020-09-24 26858, 2020
16:01 PM
bitmap
yeah
2020-09-24 26803, 2020
16:02 PM
reosarevok
I *assume* a browse shows this, but let me check
2020-09-24 26821, 2020
16:02 PM
bitmap
if it does I wouldn't bother improving inc=releases tbh
2020-09-24 26859, 2020
16:02 PM
reosarevok
It does with inc=labels, yes
2020-09-24 26806, 2020
16:03 PM
reosarevok
Well, it's your ticket, you close it ;p
2020-09-24 26829, 2020
16:03 PM
bitmap
fair enough :)
2020-09-24 26831, 2020
16:11 PM
bitmap
re: MBS-1575 we could change it to /remove while still supporting /delete
2020-09-24 26832, 2020
16:11 PM
BrainzBot
2020-09-24 26846, 2020
16:11 PM
reosarevok
Just detach delete to remove?
2020-09-24 26812, 2020
16:12 PM
bitmap
yeah
2020-09-24 26821, 2020
16:12 PM
bitmap
or s/detach/forward/
2020-09-24 26821, 2020
16:16 PM
reosarevok
Guess we might as well
2020-09-24 26800, 2020
16:19 PM
SothoTalKer_
the documentation does not mention that you can inc multiple values
2020-09-24 26822, 2020
16:19 PM
SothoTalKer_
and it also does not mention which seperator shall be used then
2020-09-24 26835, 2020
16:19 PM
reosarevok
The examples do, but I'll take a look
2020-09-24 26856, 2020
16:19 PM
SothoTalKer_
and " " is a strange delimiter, when used in urls
2020-09-24 26830, 2020
16:20 PM
SothoTalKer_
i'd love to have maybe "," as additional one
2020-09-24 26814, 2020
16:21 PM
SothoTalKer_
and the URL it spits out when the query is incorrect is outdated aswell
2020-09-24 26853, 2020
16:22 PM
reosarevok
Is it? give me an incorrect query so I can check and maybe fix it, please :)
2020-09-24 26800, 2020
16:25 PM
SothoTalKer_
2020-09-24 26822, 2020
16:25 PM
SothoTalKer_
it is luckily a redirect
2020-09-24 26827, 2020
16:25 PM
v6lur joined the channel
2020-09-24 26812, 2020
16:26 PM
SothoTalKer_
but nowhere it is mentioned that you can use multiple inc statements in a single query ^^
2020-09-24 26851, 2020
16:26 PM
SothoTalKer_
ah, there:
2020-09-24 26852, 2020
16:26 PM
SothoTalKer_
To include more than one subquery in a single request, separate the arguments to inc= with a + (plus sign), like inc=recordings+labels.
2020-09-24 26856, 2020
16:26 PM
SothoTalKer_
but it says +
2020-09-24 26859, 2020
16:26 PM
SothoTalKer_
not space
2020-09-24 26836, 2020
16:29 PM
bitmap
in www-form-urlencoded data + is interchangeable with %20
2020-09-24 26805, 2020
16:35 PM
BrainzGit
2020-09-24 26807, 2020
16:35 PM
BrainzBot
2020-09-24 26843, 2020
16:35 PM
reosarevok
Oh, the mmd link has always been a redirect
2020-09-24 26853, 2020
16:35 PM
reosarevok
I've always used +, I didn't know that you could use space, even
2020-09-24 26854, 2020
16:36 PM
SothoTalKer_
ok, its all settled then ^^
2020-09-24 26854, 2020
16:39 PM
reosarevok
bitmap: heh, all our entities have /delete, not just release
2020-09-24 26829, 2020
16:40 PM
bitmap
oh, really?
2020-09-24 26834, 2020
16:40 PM
bitmap
maybe I was thinking of collections
2020-09-24 26856, 2020
16:40 PM
bitmap
something used add/remove
2020-09-24 26833, 2020
16:42 PM
reosarevok
cdtoc and entities-from-collection, yes
2020-09-24 26850, 2020
16:42 PM
reosarevok
I guess we also use "Remove whatever" for other entities, but
2020-09-24 26830, 2020
16:43 PM
bitmap
do we use 'Delete whatever' anywhere still?
2020-09-24 26812, 2020
16:44 PM
reosarevok
Delete user and delete account only
2020-09-24 26813, 2020
16:44 PM
reosarevok
It seems
2020-09-24 26842, 2020
16:44 PM
bitmap
hmm. well, not sure this is a real issue
2020-09-24 26820, 2020
16:45 PM
bitmap
unless we want to change everything to /remove
2020-09-24 26856, 2020
16:45 PM
bitmap
I suppose we could do that and change the user/account strings, but
2020-09-24 26854, 2020
16:46 PM
reosarevok
I think I might just close it
2020-09-24 26825, 2020
16:47 PM
bitmap
fine with that
2020-09-24 26806, 2020
16:50 PM
thomasross joined the channel
2020-09-24 26828, 2020
16:51 PM
diru1100
CatQuest: Android 11 has this new feature
2020-09-24 26838, 2020
16:51 PM
diru1100
I think you might like it
2020-09-24 26855, 2020
16:51 PM
diru1100
It's more an Easter egg 🥚 than a feature ig
2020-09-24 26825, 2020
16:52 PM
diru1100
2020-09-24 26855, 2020
17:07 PM
BrainzGit
2020-09-24 26829, 2020
17:16 PM
ruaok pays for the summit shirts
2020-09-24 26814, 2020
17:17 PM
shivam-kapila
Yay
2020-09-24 26816, 2020
17:19 PM
ruaok
at least you'll get *one* t-shirt that way, shivam-kapila :p
2020-09-24 26848, 2020
17:22 PM
kori has quit
2020-09-24 26832, 2020
17:26 PM
kori joined the channel
2020-09-24 26832, 2020
17:26 PM
kori has quit
2020-09-24 26832, 2020
17:26 PM
kori joined the channel
