#metabrainz

/

      • MajorLur_ joined the channel
      • 2020-10-09 28345, 2020

      • MajorLurker_ has quit
      • 2020-10-09 28356, 2020

      • MajorLur_ is now known as MajorLurker__
      • 2020-10-09 28314, 2020

      • supersandro2000 has quit
      • 2020-10-09 28335, 2020

      • supersandro2000 joined the channel
      • 2020-10-09 28349, 2020

      • MajorLur_ joined the channel
      • 2020-10-09 28350, 2020

      • MajorLur_ is now known as MajorLurker_
      • 2020-10-09 28350, 2020

      • MajorLurker__ has quit
      • 2020-10-09 28351, 2020

      • MajorLur_ joined the channel
      • 2020-10-09 28352, 2020

      • MajorLurker_ has quit
      • 2020-10-09 28314, 2020

      • MajorLur_ is now known as MajorLurker__
      • 2020-10-09 28315, 2020

      • BestSteve has quit
      • 2020-10-09 28349, 2020

      • BestSteve joined the channel
      • 2020-10-09 28354, 2020

      • livingsilver94 joined the channel
      • 2020-10-09 28352, 2020

      • livingsilver94_ has quit
      • 2020-10-09 28334, 2020

      • Gazooo79494 joined the channel
      • 2020-10-09 28342, 2020

      • Gazooo7949 has quit
      • 2020-10-09 28317, 2020

      • kori has quit
      • 2020-10-09 28327, 2020

      • rdswift_ joined the channel
      • 2020-10-09 28335, 2020

      • rdswift has quit
      • 2020-10-09 28341, 2020

      • rdswift_ is now known as rdswift
      • 2020-10-09 28331, 2020

      • rdswift_ joined the channel
      • 2020-10-09 28348, 2020

      • rdswift has quit
      • 2020-10-09 28355, 2020

      • rdswift_ is now known as rdswift
      • 2020-10-09 28325, 2020

      • MajorLurker__ has quit
      • 2020-10-09 28358, 2020

      • MajorLur_ joined the channel
      • 2020-10-09 28358, 2020

      • MajorLur_ is now known as MajorLurker_
      • 2020-10-09 28303, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1740 (master…MBS-11162): MBS-11162: Show correct work type description if preselected https://github.com/metabrainz/musicbrainz-server/…
      • 2020-10-09 28305, 2020

      • BrainzBot
        MBS-11162: Work type description bubble starts as default even if type is selected https://tickets.metabrainz.org/browse/MBS-11162
      • 2020-10-09 28309, 2020

      • supersandro2000 has quit
      • 2020-10-09 28330, 2020

      • supersandro2000 joined the channel
      • 2020-10-09 28355, 2020

      • adhawkins
        Hi all. Just to let you know that since I put the postgres memory back to 'standard', and increased the VM to 6 Gig RAM, I haven't had any OOM errors (been running about 2 days). Might be worth considering an update to the instructions for the docker images to reflect suggested RAM size?
      • 2020-10-09 28303, 2020

      • adhawkins
        I think the page says 4 Gig without indexes at the moment.
      • 2020-10-09 28306, 2020

      • yvanzo
        Hi adhawkins, thanks for your feedback, I will update that.
      • 2020-10-09 28346, 2020

      • adhawkins
        6 Gig does sound rather a lot though. My previous VM only had 4 Gig and didn't seem to run into these issues.
      • 2020-10-09 28327, 2020

      • yvanzo
        adhawkins: one possible improvement here would be to not build/run the search container when it is not used.
      • 2020-10-09 28339, 2020

      • adhawkins
        Oh that's interesting, hadn't considered that. If only there were a way to disable a docker container from docker-compose. It seems there isn't.
      • 2020-10-09 28314, 2020

      • adhawkins
        You'd need to disable indexer too, as it depends on search
      • 2020-10-09 28324, 2020

      • adhawkins
        Be nice to find a way of doing that without having to modify docker-compose?
      • 2020-10-09 28334, 2020

      • adhawkins
        (docker-compose.yml that is)
      • 2020-10-09 28343, 2020

      • yvanzo
        The issue is that dependencies are hardcoded in some scripts, that would need a bit of refactoring.
      • 2020-10-09 28310, 2020

      • yvanzo
        Alternatively, you can replace the search container with a netcat listening to the same port.
      • 2020-10-09 28302, 2020

      • Gazooo79494 has quit
      • 2020-10-09 28343, 2020

      • Gazooo79494 joined the channel
      • 2020-10-09 28325, 2020

      • livingsilver94 has quit
      • 2020-10-09 28305, 2020

      • livingsilver94 joined the channel
      • 2020-10-09 28312, 2020

      • adhawkins
        Yeah, but either way, if I need to modify docker-compose.yml directly, that introduces more work as and when you release new versions.
      • 2020-10-09 28328, 2020

      • adhawkins
        Would be nice to come up with a way around that, if such a thing is possible.
      • 2020-10-09 28339, 2020

      • adhawkins
        I guess two compose files perhaps?
      • 2020-10-09 28315, 2020

      • reosarevok
        yvanzo: any idea why https://app.circleci.com/pipelines/github/metabra… is still looking at flow-typed/ files despite https://github.com/metabrainz/musicbrainz-server/… ?
      • 2020-10-09 28300, 2020

      • adhawkins
      • 2020-10-09 28357, 2020

      • yvanzo
        adhawkins: yes but musicbrainz-docker has not been made with optional search in mind, there are dockerize commands that wait for search.
      • 2020-10-09 28320, 2020

      • yvanzo
        adhawkins: simply replacing search with netcat in docker-compose.yml should work though
      • 2020-10-09 28335, 2020

      • v6lur joined the channel
      • 2020-10-09 28354, 2020

      • yvanzo
        adhawkins: that should do the trick: https://gist.github.com/yvanzo/3b5f3f6940170d2ae7…
      • 2020-10-09 28333, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1730 (master…MBS-11152): MBS-11152: Convert entity/ratings page to React https://github.com/metabrainz/musicbrainz-server/…
      • 2020-10-09 28334, 2020

      • adhawkins
        How about indexer yvanzo? Surely that doesn't need to run?
      • 2020-10-09 28335, 2020

      • BrainzBot
        MBS-11152: Convert entity/ratings page to React https://tickets.metabrainz.org/browse/MBS-11152
      • 2020-10-09 28310, 2020

      • yvanzo
        adhawkins: yes but there is no dependency to it, it does nothing by default.
      • 2020-10-09 28336, 2020

      • adhawkins
        Indexer depends on search.
      • 2020-10-09 28359, 2020

      • yvanzo
        You can just remove the "indexer:" entry from docker.compose.yml if you don't use it.
      • 2020-10-09 28330, 2020

      • adhawkins
        Yeah, but the issue there is that when there's a new release of the docker stuff, it'll mean I'm no longer working with the same files as you.
      • 2020-10-09 28333, 2020

      • yvanzo
        It depends on search, but nothing depends on indexer, it runs only if you run it manually or if you enable live-indexing.
      • 2020-10-09 28341, 2020

      • adhawkins
        Would be 'nice' if there was some way to do that.
      • 2020-10-09 28307, 2020

      • yvanzo
        That's right, modifying docker-compose.yml is just an immediate quick fix for now, nothing more.
      • 2020-10-09 28335, 2020

      • yvanzo
        Will check about how to refactor the repository to make this possible.
      • 2020-10-09 28344, 2020

      • adhawkins
        Understood. Thanks for that yvanzo.
      • 2020-10-09 28309, 2020

      • adhawkins
        Looking at what's actually using the memory, apart from the database most of it seems to be the perl processes: https://paste.debian.net/1166469/
      • 2020-10-09 28315, 2020

      • adhawkins
        Any way to reduce the number of them perhaps?
      • 2020-10-09 28357, 2020

      • d4rkie joined the channel
      • 2020-10-09 28347, 2020

      • D4RK-PH0ENiX has quit
      • 2020-10-09 28304, 2020

      • reosarevok
        yvanzo: available for a moment?
      • 2020-10-09 28322, 2020

      • reosarevok
        I'll just leave a PR comment
      • 2020-10-09 28303, 2020

      • reosarevok
      • 2020-10-09 28312, 2020

      • BrainzGit
        [bookbrainz-site] MonkeyDo merged pull request #522 (master…dont-deduplicate-editions): Name deduplication improvements https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2020-10-09 28325, 2020

      • alastairp
      • 2020-10-09 28338, 2020

      • alastairp
        looks like nproc is the setting
      • 2020-10-09 28339, 2020

      • BrainzGit
        [bookbrainz-site] MonkeyDo merged pull request #504 (master…snyk-upgrade-fff6cc38ae4faf842b27222274345028): [Snyk] Upgrade react-datepicker from 2.15.0 to 2.16.0 https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2020-10-09 28333, 2020

      • travis-ci joined the channel
      • 2020-10-09 28333, 2020

      • travis-ci
        Project bookbrainz-site build #3485: passed in 4 min 44 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2020-10-09 28333, 2020

      • travis-ci has left the channel
      • 2020-10-09 28304, 2020

      • travis-ci joined the channel
      • 2020-10-09 28304, 2020

      • travis-ci
        Project bookbrainz-site build #3486: passed in 4 min 48 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2020-10-09 28304, 2020

      • travis-ci has left the channel
      • 2020-10-09 28325, 2020

      • reg[m] has quit
      • 2020-10-09 28326, 2020

      • kepstin has quit
      • 2020-10-09 28333, 2020

      • joshuaboniface has quit
      • 2020-10-09 28345, 2020

      • maverickfox3[m] has quit
      • 2020-10-09 28348, 2020

      • maxlath[m] has quit
      • 2020-10-09 28349, 2020

      • MagnusSvensson[m has quit
      • 2020-10-09 28351, 2020

      • goldenshimmer has quit
      • 2020-10-09 28352, 2020

      • reg[m] joined the channel
      • 2020-10-09 28334, 2020

      • MajorLurker_ has quit
      • 2020-10-09 28326, 2020

      • MajorLurker has quit
      • 2020-10-09 28349, 2020

      • SothoTalKer has quit
      • 2020-10-09 28351, 2020

      • SothoTalKer joined the channel
      • 2020-10-09 28325, 2020

      • reg[m] has quit
      • 2020-10-09 28325, 2020

      • d4rkie has quit
      • 2020-10-09 28325, 2020

      • Gazooo79494 has quit
      • 2020-10-09 28325, 2020

      • rdswift has quit
      • 2020-10-09 28325, 2020

      • slriv has quit
      • 2020-10-09 28338, 2020

      • Gazooo79494 joined the channel
      • 2020-10-09 28345, 2020

      • slriv joined the channel
      • 2020-10-09 28307, 2020

      • reg[m] joined the channel
      • 2020-10-09 28310, 2020

      • d4rkie joined the channel
      • 2020-10-09 28310, 2020

      • rdswift joined the channel
      • 2020-10-09 28358, 2020

      • kepstin joined the channel
      • 2020-10-09 28359, 2020

      • MagnusSvensson[m joined the channel
      • 2020-10-09 28359, 2020

      • maxlath[m] joined the channel
      • 2020-10-09 28359, 2020

      • joshuaboniface joined the channel
      • 2020-10-09 28359, 2020

      • goldenshimmer joined the channel
      • 2020-10-09 28305, 2020

      • maverickfox3[m] joined the channel
      • 2020-10-09 28344, 2020

      • slriv has quit
      • 2020-10-09 28314, 2020

      • slriv joined the channel
      • 2020-10-09 28355, 2020

      • BrainzGit
        [musicbrainz-server] mwiencek merged pull request #1737 (master…selenium-json5): Convert Selenium tests to JSON5 https://github.com/metabrainz/musicbrainz-server/…
      • 2020-10-09 28356, 2020

      • adhawkins
        alastairp: Ah ok, so no 'easy' way of changing that. Any chance of making that an environment variable that can be passed in perhaps?
      • 2020-10-09 28344, 2020

      • d4rkie has quit
      • 2020-10-09 28342, 2020

      • D4RK-PH0ENiX joined the channel
      • 2020-10-09 28313, 2020

      • travis-ci joined the channel
      • 2020-10-09 28313, 2020

      • travis-ci
        Project bookbrainz-site build #3487: failed in 4 min 49 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2020-10-09 28313, 2020

      • travis-ci has left the channel
      • 2020-10-09 28333, 2020

      • alastairp
        adhawkins: you're right, that should probably be an environment variable. The current "easy" way to do it is to edit that file, and then rebuild the docker image. However, you'll have same issue of having to coordinate edited files when new releases are made
      • 2020-10-09 28312, 2020

      • yvanzo
        That seems sensible to add such variable to the repository too.
      • 2020-10-09 28321, 2020

      • alastairp
      • 2020-10-09 28345, 2020

      • kori joined the channel
      • 2020-10-09 28335, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1741 (master…MBS-11163): MBS-11163: Show type descriptions when editing more entities https://github.com/metabrainz/musicbrainz-server/…
      • 2020-10-09 28337, 2020

      • BrainzBot
        MBS-11163: Show type descriptions when editing entities https://tickets.metabrainz.org/browse/MBS-11163
      • 2020-10-09 28340, 2020

      • adhawkins
        Yeah, that sounds like something that's worth doing alastairp and yvanzo
      • 2020-10-09 28307, 2020

      • yvanzo
        Slowdowns might occur on tickets.metabrainz.org while Jira 8.13 test instance is running on the same server.
      • 2020-10-09 28349, 2020

      • livingsilver94 has quit
      • 2020-10-09 28349, 2020

      • livingsilver94 joined the channel
      • 2020-10-09 28336, 2020

      • alastairp
        hi _lucifer
      • 2020-10-09 28341, 2020

      • alastairp
        I released CB on prod!
      • 2020-10-09 28355, 2020

      • alastairp
        thank you for all of your work. I'm going to post on the forums now
      • 2020-10-09 28311, 2020

      • _lucifer
        hooray!!!
      • 2020-10-09 28319, 2020

      • _lucifer
        thanks alastairp
      • 2020-10-09 28343, 2020

      • alastairp
        _lucifer: I added label and work to the entity_types enum
      • 2020-10-09 28354, 2020

      • alastairp
        but they don't show up in the search menu. is that expected?
      • 2020-10-09 28309, 2020

      • alastairp
        I don't know if there's something else that we need to configure
      • 2020-10-09 28317, 2020

      • alastairp
        they show in beta
      • 2020-10-09 28342, 2020

      • _lucifer
        yeah, right
      • 2020-10-09 28316, 2020

      • alastairp
      • 2020-10-09 28327, 2020

      • alastairp
        which makes me think that I didn't do the release properly
      • 2020-10-09 28307, 2020

      • _lucifer
        maybe need to rebuild the static files ?
      • 2020-10-09 28346, 2020

      • alastairp
        oh yes. I forgot to pull the configuration on the server
      • 2020-10-09 28351, 2020

      • alastairp
        ok, _now_ it's released!
      • 2020-10-09 28323, 2020

      • _lucifer
        🎉
      • 2020-10-09 28344, 2020

      • BrainzGit
        [critiquebrainz] release v-2020-10-09.0 has been published by alastair: https://github.com/metabrainz/critiquebrainz/rele…
      • 2020-10-09 28319, 2020

      • alastairp
        Freso: was there a blog post or forum post about the summit this year? Somewhere that I can link to from a forum post
      • 2020-10-09 28337, 2020

      • alastairp
        what is code-master5's mb id, anyone know?