#metabrainz

/

      • Freso
        People up for reviews: bitmap, yvanzo, ruaok, Freso, alastairp, reosarevok, zas, Mr_Monkey, pristine___, jmp_music, _lucifer, shivam-kapila, CatQuest – anyone else who want to give review, let me know ASAP!
      • 2020-10-26 30023, 2020

      • Freso
        bitmap: Go!
      • 2020-10-26 30029, 2020

      • bitmap
        hey
      • 2020-10-26 30045, 2020

      • bitmap
        last week I worked on converting the artist credit renamer (part of the artist edit form) to React https://github.com/metabrainz/musicbrainz-server/…
      • 2020-10-26 30046, 2020

      • CatQuest
        bitmap!
      • 2020-10-26 30005, 2020

      • bitmap
        that PR also fixed some bugs (previews not updating correctly) and usability issues (MBS-6666) with it and made the previews look nicer
      • 2020-10-26 30005, 2020

      • BrainzBot
        MBS-6666: Artist credits not renamed from artist edit page unless the artist name is changed https://tickets.metabrainz.org/browse/MBS-6666
      • 2020-10-26 30009, 2020

      • CatQuest
        :O
      • 2020-10-26 30011, 2020

      • _lucifer
        alastairp: yeah, let's consider this later again. for now keep the defaults and add docs?
      • 2020-10-26 30031, 2020

      • bitmap
        also updated https://github.com/metabrainz/musicbrainz-server/… based on review feedback and got that merged, so more progress on the entity forms
      • 2020-10-26 30050, 2020

      • bitmap
        did a bunch of code review and opened some small PRs for upgrading Flow/React
      • 2020-10-26 30006, 2020

      • bitmap
        spent some time working on the relationship editor conversion branch outside of that
      • 2020-10-26 30016, 2020

      • bitmap
        fin! yvanzo go
      • 2020-10-26 30022, 2020

      • yvanzo
        hi!
      • 2020-10-26 30040, 2020

      • CatQuest
        hi
      • 2020-10-26 30000, 2020

      • yvanzo
        Last week I reviewed some MBS PRs, triaged and resolved a few MBBE tasks.
      • 2020-10-26 30030, 2020

      • yvanzo
        Otherwise I mostly spent time working on search components and got started with a new VM to test indexing load thanks to zas.
      • 2020-10-26 30045, 2020

      • yvanzo
        Fin, go ruaok!
      • 2020-10-26 30018, 2020

      • yvanzo
        Or go Freso?
      • 2020-10-26 30022, 2020

      • Freso
        Or… alastairp, go!
      • 2020-10-26 30025, 2020

      • ruaok
        sorry.
      • 2020-10-26 30027, 2020

      • Freso
        Or me :p
      • 2020-10-26 30028, 2020

      • Freso
        Or Rob
      • 2020-10-26 30035, 2020

      • ruaok
        pick on.
      • 2020-10-26 30036, 2020

      • ruaok
        one
      • 2020-10-26 30037, 2020

      • Freso
        Go ruaok :)
      • 2020-10-26 30039, 2020

      • ruaok
        k
      • 2020-10-26 30001, 2020

      • ruaok
        last week was mostly troi work with alastair and also moving some PRs for the recommendation stuff forward.
      • 2020-10-26 30027, 2020

      • ruaok
        I did more work in shaking out the daily jams and working with pristine___ to ensure that this feature is moving in the right direction.
      • 2020-10-26 30054, 2020

      • ruaok
        I also did emails and working to get a new customer signed -- hopefully that will happen very soon. 🤞
      • 2020-10-26 30026, 2020

      • ruaok
        I also did more wrangling of banks for the purpose of moving money to the EU ahead of the silly election that will happen across the atlantic soon.
      • 2020-10-26 30045, 2020

      • ruaok
        that was about it. freso, go!
      • 2020-10-26 30049, 2020

      • Freso
        o/
      • 2020-10-26 30007, 2020

      • Freso
        So, pretty much like last week, I’m slowly being more active, but still not much to report.
      • 2020-10-26 30010, 2020

      • BrainzGit
        [troi-recommendation-playground] mayhem merged pull request #20 (main…test-args): Pass all test subcommand arguments and options to pytest https://github.com/metabrainz/troi-recommendation…
      • 2020-10-26 30015, 2020

      • Freso
        :p
      • 2020-10-26 30037, 2020

      • Freso
        I think that’s it.
      • 2020-10-26 30040, 2020

      • BrainzGit
        [troi-recommendation-playground] mayhem merged pull request #19 (main…more-tests): Adding more tests https://github.com/metabrainz/troi-recommendation…
      • 2020-10-26 30042, 2020

      • Freso
        alastairp: Go!
      • 2020-10-26 30056, 2020

      • alastairp
        good evening from a dark and wintery barcelona
      • 2020-10-26 30011, 2020

      • ruaok
        brr. the snow drifts are killer!!
      • 2020-10-26 30012, 2020

      • alastairp
        close enough
      • 2020-10-26 30015, 2020

      • ruaok
        lol
      • 2020-10-26 30019, 2020

      • alastairp
        dark, at least
      • 2020-10-26 30023, 2020

      • pristine___
        (Can I go after alastairp ?)
      • 2020-10-26 30026, 2020

      • ruaok
        I heard that it snowed in Chicago today. poor bitmap
      • 2020-10-26 30040, 2020

      • alastairp
        as ruaok said, last week we worked on a bunch of troi stuff, including improving some tests, making stuff work on pypi, and docs on readthedocs
      • 2020-10-26 30041, 2020

      • bitmap
        it did ;_;
      • 2020-10-26 30052, 2020

      • CatQuest
        bitmap: :o
      • 2020-10-26 30055, 2020

      • alastairp
        I also made a first cut of acousticbrainz-based acoustic similarity
      • 2020-10-26 30005, 2020

      • alastairp
        I also set up readthedocs for brainzutils
      • 2020-10-26 30052, 2020

      • alastairp
        on Friday I worked with zas to release our metrics/logging system for LB and AB. Our results showed that my initial proposal was far too complex, and so we pared it right down to a much simpler system, thanks zas!
      • 2020-10-26 30019, 2020

      • alastairp
        and I spent some time reviewing CB tickets, thanks _lucifer and AbhinavOhri
      • 2020-10-26 30038, 2020

      • alastairp
        this afternoon I released a new version of CB fixing some showstoppers causing front page to not load
      • 2020-10-26 30040, 2020

      • alastairp
        fin. pristine___ ?
      • 2020-10-26 30046, 2020

      • pristine___
        Hey
      • 2020-10-26 30049, 2020

      • pristine___
        Thanks!
      • 2020-10-26 30053, 2020

      • pristine___
        Hi everyone :)
      • 2020-10-26 30019, 2020

      • Freso
        (People still up for reviews: reosarevok, zas, Mr_Monkey, jmp_music, _lucifer, shivam-kapila, CatQuest – anyone else who want to give review, let me know ASAP!)
      • 2020-10-26 30041, 2020

      • pristine___
        I have been working on recommendation feedback and continued the work last week. We are on the last PR of it, and I really hope to release it asap. I am struggling a bit with the CSS part.
      • 2020-10-26 30059, 2020

      • pristine___
        But it makes sense now as Mr_Monkey has helped me to move forward
      • 2020-10-26 30033, 2020

      • pristine___
        Also, ruaok and I decided to work on generating artist recommendations
      • 2020-10-26 30001, 2020

      • pristine___
        I opened a few PRs for the same.
      • 2020-10-26 30015, 2020

      • pristine___
        Coming weeks are really exciting <3
      • 2020-10-26 30026, 2020

      • pristine___
        fin! Mr_Monkey go!
      • 2020-10-26 30030, 2020

      • Mr_Monkey
        Hello !
      • 2020-10-26 30033, 2020

      • BrainzGit
        [musicbrainz-server] mwiencek merged pull request #1758 (master…mbs-11195): MBS-11195: Convert the artist-credit-renamer to React https://github.com/metabrainz/musicbrainz-server/…
      • 2020-10-26 30034, 2020

      • BrainzBot
        MBS-11195: Convert the artist credit renamer to React https://tickets.metabrainz.org/browse/MBS-11195
      • 2020-10-26 30008, 2020

      • Mr_Monkey
        Short week last week (and this week) for me, as I have family in town visiting (gasp! corona-era visits !?)
      • 2020-10-26 30031, 2020

      • supersandro2000
        putting opened in the list of keywords that send notifications was a bad idea...
      • 2020-10-26 30047, 2020

      • Mr_Monkey
        I worked on some PRs and PR reviews for LB, mainly what pristine___ mentionned and a PR to improve error displaying with BrainzPlayer
      • 2020-10-26 30009, 2020

      • CatQuest
        :D
      • 2020-10-26 30017, 2020

      • Mr_Monkey
        I also continued work on improving search configuration in BookBrainz, and fixed a user signup issue
      • 2020-10-26 30041, 2020

      • Mr_Monkey
        Finally, some database cleanup and forum discussions, moving small things forward
      • 2020-10-26 30002, 2020

      • Mr_Monkey
        And some serious thinking about how I'm going to implement a play queue for BrainzPlayer.
      • 2020-10-26 30022, 2020

      • Mr_Monkey
        That's it for my half week ! zas you're up !
      • 2020-10-26 30027, 2020

      • zas
        Hey
      • 2020-10-26 30039, 2020

      • zas
        last week we released Picard 2.5 (https://blog.metabrainz.org/2020/10/22/picard-2-5…)
      • 2020-10-26 30015, 2020

      • zas
        I guess 2.5.1 will be due in next days (some annoying bugs were found in final release)
      • 2020-10-26 30057, 2020

      • zas
        apart that, I handled the case of a distributed bot crawling MB website, blacklisted 3,2k IPs
      • 2020-10-26 30040, 2020

      • Mr_Monkey
      • 2020-10-26 30048, 2020

      • yvanzo
        !m zas
      • 2020-10-26 30048, 2020

      • BrainzBot
        You're doing good work, zas!
      • 2020-10-26 30054, 2020

      • zas
        also gave an hand to alastairp from LB stats stuff (using telegraf/influxdb/grafana stack)
      • 2020-10-26 30020, 2020

      • zas
        and created an hetzner VM for yvanzo MB related stuff
      • 2020-10-26 30040, 2020

      • zas
        plus usual supervision, user support, PR reviews, etc... fin. reosarevok ?
      • 2020-10-26 30045, 2020

      • reosarevok
        Hi!
      • 2020-10-26 30055, 2020

      • reosarevok
        I'm still converting the alias edit form to react
      • 2020-10-26 30002, 2020

      • CatQuest
        :D
      • 2020-10-26 30028, 2020

      • reosarevok
        That's quite harder than any other React thing I've played with so far, just because we haven't done many forms at all yet :)
      • 2020-10-26 30037, 2020

      • reosarevok
        Other than that, a bunch of small recent tickets
      • 2020-10-26 30055, 2020

      • reosarevok
        I'll get that finished this week, and then we'll see :)
      • 2020-10-26 30003, 2020

      • reosarevok
        CatQuest: you?
      • 2020-10-26 30009, 2020

      • CatQuest
        Meow! `😺`
      • 2020-10-26 30009, 2020

      • CatQuest
      • 2020-10-26 30010, 2020

      • BrainzBot
        INST-576: Portative organ
      • 2020-10-26 30018, 2020

      • CatQuest
        did work on https://tickets.metabrainz.org/browse/INST-996 (which included also adding a LOT of other aliases and updating/removing child-of and INST-798'ing instruments)
      • 2020-10-26 30019, 2020

      • BrainzBot
        INST-996: Chinese aliases for instruments
      • 2020-10-26 30019, 2020

      • BrainzBot
        INST-798: Review descriptions and change any that are still Wikipedia copy-pastes https://tickets.metabrainz.org/browse/INST-798
      • 2020-10-26 30025, 2020

      • CatQuest
        complained (yet again) to reo about our locale/alias list
      • 2020-10-26 30025, 2020

      • CatQuest
        adding several books/works/authors to Bookbrainz
      • 2020-10-26 30025, 2020

      • CatQuest
        also added a few tickets BookBrainz then
      • 2020-10-26 30039, 2020

      • CatQuest
        finally I am making preparations for All Hallows Eve 🦇
      • 2020-10-26 30039, 2020

      • CatQuest
      • 2020-10-26 30039, 2020

      • CatQuest
        fin, go shivam-kapila ?
      • 2020-10-26 30011, 2020

      • Mr_Monkey
        I forgot to mention we got the first BookBrainz editor to pass 10000 edits last week !
      • 2020-10-26 30017, 2020

      • reosarevok
        Oh, wow
      • 2020-10-26 30018, 2020

      • CatQuest
        :O
      • 2020-10-26 30019, 2020

      • reosarevok
        Not bad
      • 2020-10-26 30025, 2020

      • Freso
        Nice!
      • 2020-10-26 30033, 2020

      • Mr_Monkey
        Especially for a user that signed up this summer…
      • 2020-10-26 30035, 2020

      • Freso
        shivam-kapila: Ping?
      • 2020-10-26 30048, 2020

      • Freso
        If not… _lucifer: Go!
      • 2020-10-26 30000, 2020

      • _lucifer
        Hi all!
      • 2020-10-26 30004, 2020

      • CatQuest
        hi!
      • 2020-10-26 30025, 2020

      • Freso
        (Only jmp_music__ and possibly shivam-kapila left on my list! Last call for anyone else who want to give review!)
      • 2020-10-26 30030, 2020

      • pristine___
        (Mr_Monkey I would like to add books to BB. Maybe tell me about it tomorrow)
      • 2020-10-26 30046, 2020

      • CatQuest
        hey, you can also talk to me about it ;)
      • 2020-10-26 30059, 2020

      • _lucifer
        I continued working on a few CB tickets last week. Nothing much else
      • 2020-10-26 30004, 2020

      • _lucifer
        jmp_music__: next?
      • 2020-10-26 30023, 2020

      • jmp_music__
        Hi everyone! o/
      • 2020-10-26 30027, 2020

      • CatQuest
        \o
      • 2020-10-26 30051, 2020

      • jmp_music__
        last week I finally finished with the exams, now I have to arrange some things with my work but definitely I'll start contributing to the project again.
      • 2020-10-26 30005, 2020

      • ruaok
        yaay!
      • 2020-10-26 30033, 2020

      • jmp_music__
        I have searched some things in Gaia's code see how I can continue the sklearn tool, especially with the exports
      • 2020-10-26 30036, 2020

      • CatQuest
        yay!
      • 2020-10-26 30055, 2020

      • jmp_music__
        I had already today a short meeting with @alastairp on how to proceed.
      • 2020-10-26 30010, 2020

      • jmp_music__
        fin for now! :)
      • 2020-10-26 30016, 2020

      • jmp_music__
        shivam-kapila: next?
      • 2020-10-26 30047, 2020

      • Freso
        I guess no shivam-kapila today.
      • 2020-10-26 30018, 2020

      • Freso
        (Maybe shivam-kapila forgot the DST change?)
      • 2020-10-26 30033, 2020

      • Freso
        Anyway, that wraps up tonight’s meeting then!
      • 2020-10-26 30054, 2020

      • Freso
        Thank you everyone who gave reviews!
      • 2020-10-26 30025, 2020

      • Freso
        And thank you all for your time! Make sure to stay warm and hydrated!
      • 2020-10-26 30027, 2020

      • Freso
        </BANG>
      • 2020-10-26 30028, 2020

      • Mr_Monkey
        Thank you Freso !
      • 2020-10-26 30016, 2020

      • yvanzo
        Thanks!
      • 2020-10-26 30002, 2020

      • Mr_Monkey
        pristine___: about the screenshot you sent, I think it would be better to use the abundant horizontal space by having the thumbs up icon and like text in a row, instead of one on top of the other (which I find looks a bit blocky)
      • 2020-10-26 30042, 2020

      • alastairp
        _lucifer: the thing about the defaults is that it doesn't even work very well
      • 2020-10-26 30014, 2020

      • alastairp
        take https://www.critiquebrainz.org/release-group/e623… as an example, there's no [unknown artist], and there's still a "Write a review" button
      • 2020-10-26 30034, 2020

      • Mr_Monkey
        I was also reading up the bootstrap documentation, to check if it's possible to have a mous-hover-activated dropdown. Unfortunately not: From https://getbootstrap.com/docs/4.5/components/drop… documentation
      • 2020-10-26 30034, 2020

      • Mr_Monkey
        > They’re toggled by clicking, not by hovering; this is an intentional design decision.
      • 2020-10-26 30037, 2020

      • pristine___
        Mr_Monkey: yeah, I want to do the same, it's just I am not able to
      • 2020-10-26 30046, 2020

      • Mr_Monkey
        Ah, I see :)
      • 2020-10-26 30052, 2020

      • alastairp
        reosarevok: bitmap: is there a way to see what an item was before it was deleted? is there an edit for it? Or is the only way to find an old mirror and check there?
      • 2020-10-26 30005, 2020

      • pristine___
        Idk why they are one on top of other
      • 2020-10-26 30017, 2020

      • _lucifer
        right, should we hide these review alastairp ?
      • 2020-10-26 30019, 2020

      • CatQuest
        wow trying to login on that page gives error https://beta.musicbrainz.org/oauth2/authorize?res…
      • 2020-10-26 30027, 2020

      • CatQuest
        "Error: invalid_request
      • 2020-10-26 30028, 2020

      • CatQuest
        Mismatched redirect URI"