#metabrainz

/

      • sumedh joined the channel
      • 2020-10-29 30333, 2020

      • pristine___
        Mr_Monkey: why do we need this check(`icon? `) here at all?
      • 2020-10-29 30336, 2020

      • pristine___
      • 2020-10-29 30359, 2020

      • Mr_Monkey
        No idea
      • 2020-10-29 30332, 2020

      • Mr_Monkey
        (I didn't implement this, so not sure. shivam-kapila might know?)
      • 2020-10-29 30314, 2020

      • pristine___
        Hmm. I think I will remove it
      • 2020-10-29 30326, 2020

      • pristine___
        From rec control
      • 2020-10-29 30313, 2020

      • BrainzGit
        [troi-recommendation-playground] mayhem merged pull request #26 (main…no-more-travis): Stop using travis in favor of brainzbot. https://github.com/metabrainz/troi-recommendation…
      • 2020-10-29 30313, 2020

      • v6lur has quit
      • 2020-10-29 30328, 2020

      • v6lur joined the channel
      • 2020-10-29 30311, 2020

      • pristine___
      • 2020-10-29 30321, 2020

      • pristine___
        makes sense to you?
      • 2020-10-29 30359, 2020

      • v6lur has quit
      • 2020-10-29 30319, 2020

      • v6lur joined the channel
      • 2020-10-29 30324, 2020

      • piano_it_guy has quit
      • 2020-10-29 30347, 2020

      • piano_it_guy joined the channel
      • 2020-10-29 30353, 2020

      • piano_it_guy has quit
      • 2020-10-29 30342, 2020

      • piano_it_guy joined the channel
      • 2020-10-29 30313, 2020

      • sumedh has quit
      • 2020-10-29 30323, 2020

      • pristine___
      • 2020-10-29 30304, 2020

      • pristine___
        Mr_Monkey: for your reference, as I mentioned in the comment on #1149
      • 2020-10-29 30338, 2020

      • ishaanshah
        ruaok: Hi, I thanks a lot for the Summit TShirt, it was a pleasant surprise <3
      • 2020-10-29 30359, 2020

      • ishaanshah
        I love the design, especially the cities of team members
      • 2020-10-29 30321, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1767 (master…eslint-no-extra-semi): Eslint fixes (few more rules for CI) https://github.com/metabrainz/musicbrainz-server/…
      • 2020-10-29 30331, 2020

      • BrainzGit
        [listenbrainz-server] ishaanshah opened pull request #1157 (master…fix-incremental-dump-creation): Fix incremental dump creation https://github.com/metabrainz/listenbrainz-server…
      • 2020-10-29 30309, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1768 (master…MBS-10664): MBS-10664: Allow more tags in expand2react https://github.com/metabrainz/musicbrainz-server/…
      • 2020-10-29 30311, 2020

      • BrainzBot
      • 2020-10-29 30328, 2020

      • reosarevok
        hibiscuskazeneko: that should hopefully fix your bio ^ :) Not much of a birthday present (I understand it's your birthday?) but better than nothing I guess :p
      • 2020-10-29 30335, 2020

      • ruaok
        bitmap: you about perchance?
      • 2020-10-29 30305, 2020

      • bitmap
        ruaok: yup
      • 2020-10-29 30317, 2020

      • ruaok
        hiya! thanks for knocking out that PR so quickly!
      • 2020-10-29 30339, 2020

      • ruaok
        and I'm working on paco, but PG is acting weird there.
      • 2020-10-29 30303, 2020

      • ruaok
        connections kept crashing, so I decided to stop PG and restart it. not it won't restart:
      • 2020-10-29 30304, 2020

      • bitmap
        no problem :)
      • 2020-10-29 30317, 2020

      • ruaok
        > Error response from daemon: strconv.Atoi: parsing "5,max-size=1GB": invalid syntax
      • 2020-10-29 30332, 2020

      • ruaok
        is all I get in the logs. any idea where I might look to fix this?
      • 2020-10-29 30351, 2020

      • bitmap
        huh. let me see
      • 2020-10-29 30326, 2020

      • bitmap
        that wasn't a problem before, I wonder if the logging options changed somehow?
      • 2020-10-29 30343, 2020

      • ruaok
        I personally didn't change anything.
      • 2020-10-29 30342, 2020

      • bitmap
        I think --log-opt "max-file=5,max-size=1GB"\ is just broken syntax but we never had to restart it before, not sure
      • 2020-10-29 30345, 2020

      • bitmap
        I'll push a fix
      • 2020-10-29 30356, 2020

      • ruaok
        thanks!
      • 2020-10-29 30350, 2020

      • bitmap
        ruaok: seems to work now (at least the container started)
      • 2020-10-29 30359, 2020

      • ruaok
        thanks!
      • 2020-10-29 30305, 2020

      • reosarevok
        ruaok: we'll still add the first recording date to the XML WS I guess, but it'd be nice to decide on a time to be like "from now on, let's make improvements only to JSON"
      • 2020-10-29 30318, 2020

      • reosarevok
        Any ideas about when that should be?
      • 2020-10-29 30337, 2020

      • ruaok
        Im fine with now, actually.
      • 2020-10-29 30342, 2020

      • reosarevok
        Hmm
      • 2020-10-29 30339, 2020

      • reosarevok
        Well it's currently only on JSON, so maybe we should keep it that way. I feel a bit bad about not doing it with parity because this is an old request with a ton of votes, but at the same time, maybe an old request with a ton of votes is what might make people move their ass and change to JSON
      • 2020-10-29 30332, 2020

      • ruaok
        if people bitch very loudly, we can always add the feature to XML and then say: this was the last time!
      • 2020-10-29 30354, 2020

      • reosarevok
        Hmm, that seems like a sensible approach I guess
      • 2020-10-29 30311, 2020

      • reosarevok
        But does that mean we should officially deprecate XML? That's kinda what it sounds like
      • 2020-10-29 30354, 2020

      • reosarevok
        Like "hey, so this is deprecated, we'll fix bugs in it for $amount_of_time but add new features only to JSON, and after that we'll only support JSON"
      • 2020-10-29 30338, 2020

      • reosarevok
        bitmap, yvanzo ^ we should probably all agree on whatever we decide to do here
      • 2020-10-29 30320, 2020

      • bitmap
        yes, but I think a good time to do that would be when we work on adding api keys and making whatever minor breaking changes we still need to the JSON ws
      • 2020-10-29 30330, 2020

      • bitmap
        so that anyone switching from xml doesn't have to do work twice
      • 2020-10-29 30341, 2020

      • reosarevok
        Wanna add API keys for next release? :p
      • 2020-10-29 30332, 2020

      • bitmap
        nope :P I mean, I'll need more time to sort out the minor changes we want to make first
      • 2020-10-29 30343, 2020

      • reosarevok
        Ok, fair enough
      • 2020-10-29 30354, 2020

      • bitmap
        since those should be released at the same time
      • 2020-10-29 30341, 2020

      • reosarevok
        But then we should probably still release the XML change...
      • 2020-10-29 30346, 2020

      • BrainzGit
        [musicbrainz-server] yvanzo opened pull request #1769 (beta…msg-no-ph): Remove unneeded placeholder from message https://github.com/metabrainz/musicbrainz-server/…
      • 2020-10-29 30359, 2020

      • yvanzo
        bitmap, reosarevok, ruaok: we currently use XML for search server, we would need a replacement if you want to drop it.
      • 2020-10-29 30310, 2020

      • yvanzo
        this has been discussed it during the summit IIRC.
      • 2020-10-29 30341, 2020

      • outsidecontext
        API keys should probably be a ws/3 or be optional for an extended period of time
      • 2020-10-29 30333, 2020

      • yvanzo
        Yes, it will be required for ws/2.5 (same as ws/2 but with API keys) then for ws/3 but ws/2 will continue to be available without API keys in parallel.
      • 2020-10-29 30308, 2020

      • yvanzo
        (until it gets discontinued like we did with ws/1)
      • 2020-10-29 30332, 2020

      • outsidecontext
        ok, great :D
      • 2020-10-29 30309, 2020

      • yvanzo
        (this is what I recall from early summits at least :)
      • 2020-10-29 30331, 2020

      • BrainzGit
        [mmd-schema] mwiencek opened pull request #23 (master…mbs-1424): MBS-1424: Add a first-release-date field to recordings https://github.com/metabrainz/mmd-schema/pull/23
      • 2020-10-29 30331, 2020

      • BrainzBot
        MBS-1424: Add a 'First release date' field to recordings https://tickets.metabrainz.org/browse/MBS-1424
      • 2020-10-29 30355, 2020

      • bitmap
        afaict we don't return or index first-release-date for release groups in solr either atm
      • 2020-10-29 30333, 2020

      • CatQuest joined the channel
      • 2020-10-29 30321, 2020

      • BrainzGit
        [listenbrainz-server] vansika opened pull request #1158 (master…rec-recording-path-update): Prepend `recording` to recommendations path to distinguish between recording and artist recommendations https://github.com/metabrainz/listenbrainz-server…
      • 2020-10-29 30326, 2020

      • BrainzGit
        [musicbrainz-server] yvanzo merged pull request #1769 (beta…msg-no-ph): Remove unneeded placeholder from message https://github.com/metabrainz/musicbrainz-server/…
      • 2020-10-29 30332, 2020

      • yvanzo
        bitmap, reosarevok: Updating beta and transifex with ^
      • 2020-10-29 30335, 2020

      • sumedh joined the channel
      • 2020-10-29 30307, 2020

      • v6lur has quit
      • 2020-10-29 30320, 2020

      • sumedh has quit
      • 2020-10-29 30305, 2020

      • niceplace has quit
      • 2020-10-29 30306, 2020

      • v6lur joined the channel
      • 2020-10-29 30314, 2020

      • Zastai|2
        any listenbrainz people here? is the spotify integration broken? playing-now is returning the last song played (and then stops returning anything at all until the current song finishes)
      • 2020-10-29 30322, 2020

      • Zastai|2 is now known as Zastai
      • 2020-10-29 30351, 2020

      • Zastai
        and now, going from the Reports tab to Listens without in any way interacting with the embedded Spotify player, interrupted my playback in the Spotify app, with the embedded player switching back and forth across the three most recent tracks in my history
      • 2020-10-29 30354, 2020

      • reosarevok
        ruaok, Mr_Monkey ^
      • 2020-10-29 30303, 2020

      • reosarevok
        (you might be a bit late to catch them, but let's see)
      • 2020-10-29 30358, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1770 (master…dates-flow): Add flow types to utility/dates.js https://github.com/metabrainz/musicbrainz-server/…
      • 2020-10-29 30314, 2020

      • niceplace joined the channel
      • 2020-10-29 30357, 2020

      • d4rkie joined the channel
      • 2020-10-29 30338, 2020

      • D4RK-PH0ENiX has quit
      • 2020-10-29 30319, 2020

      • niceplaces joined the channel
      • 2020-10-29 30305, 2020

      • niceplace has quit
      • 2020-10-29 30325, 2020

      • v6lur has quit
      • 2020-10-29 30310, 2020

      • Gore has quit
      • 2020-10-29 30349, 2020

      • d4rkie has quit
      • 2020-10-29 30346, 2020

      • D4RK-PH0ENiX joined the channel
      • 2020-10-29 30301, 2020

      • yokel has quit
      • 2020-10-29 30351, 2020

      • yokel joined the channel