someone sent us a PR, but really wants to remain anonymous.
2020-11-16 32115, 2020
alastairp
interesting
2020-11-16 32137, 2020
shivam-kapila
Maybe they like the project n use it but werent on gh
2020-11-16 32148, 2020
alastairp
well, they made an account, so I don't think that was it. we have plenty of other ways of them getting information to us
2020-11-16 32102, 2020
alastairp
it seems like they just don't want their contribution to be public, which is fine
2020-11-16 32106, 2020
Rotab has quit
2020-11-16 32129, 2020
ruaok
I don't have a problem with it at all -- its just a rather specific PR with a new account.
2020-11-16 32151, 2020
ruaok
which is interesting from a "how much adoption is LB getting perspective"
2020-11-16 32101, 2020
Gazooo79494 has quit
2020-11-16 32108, 2020
alastairp
it seems like they're running the code and found a bug, but don't want their involvement to be known
2020-11-16 32111, 2020
alastairp
which is super interesting
2020-11-16 32124, 2020
shivam-kapila
Sherlock holmes needed
2020-11-16 32156, 2020
ruaok
> which is super interesting
2020-11-16 32103, 2020
ruaok
yes, exactly.
2020-11-16 32147, 2020
ruaok
no need to dig up who this person is, that is far from my point. just interesting that someone did this. could be a "we should be paying for support, but we want to stay off the freaky haired guy's radar".
2020-11-16 32147, 2020
Gazooo79494 joined the channel
2020-11-16 32134, 2020
shivam-kapila
Lol
2020-11-16 32116, 2020
ruaok
yep.
2020-11-16 32143, 2020
Rotab joined the channel
2020-11-16 32123, 2020
alastairp
ruaok: any pending PRs needed?
2020-11-16 32115, 2020
alastairp
I was going to take a look at integrating year + artist into the annoy patch, then take a look at some of the open issues
2020-11-16 32125, 2020
ruaok
Come again?
2020-11-16 32134, 2020
alastairp
do you have any PRs that you need me to review
2020-11-16 32148, 2020
ruaok
Ah. Hang on
2020-11-16 32121, 2020
ruaok
no, looks like we're all caught up.
2020-11-16 32133, 2020
ruaok
a couple of things I'd like to discuss though.
2020-11-16 32150, 2020
Mr_Monkey
Alternatively, maybe the mystery contributor's work contract prevents them from contributing code to other projects.
2020-11-16 32103, 2020
ruaok
first, having year is good -- that was a pile of effort and that will solve some problems, but I am not sure it alone can solve my daily jams issues.
2020-11-16 32144, 2020
ruaok
I want to be able to filter on genre, but that is another whole can of worms really. any thoughts on how to deal with genres in this context?
I made a start on that, though we have to make some decisions about if we should try and match similar-but-not-quite genres compared to ones that are already in MB, or if we just import them as-is
2020-11-16 32113, 2020
alastairp
however, this is only going to handle the small subset of recordings for which we have this data
ohhh, with official sanction from reosarevok. yes, this sounds great.
2020-11-16 32149, 2020
ruaok
> however, this is only going to handle the small subset of recordings for which we have this data
2020-11-16 32158, 2020
alastairp
should we get a move-on with jmp_music__'s classifier tools, and build a better model based on this data? we have some baselines from UPF which are much better than what we have
2020-11-16 32105, 2020
ruaok
I wonder if ACRM could also aggregate these.
2020-11-16 32108, 2020
alastairp
though that's a 2-month job, not a 2-day job
2020-11-16 32138, 2020
ruaok
maybe early next year on that, methinks.
2020-11-16 32145, 2020
alastairp
yeah, sure
2020-11-16 32155, 2020
ruaok
I could help, but right now there are other low hanging fruit I would like to pursue.
2020-11-16 32131, 2020
ruaok
actually I'm happy with that as a road-map for genres for troi. let me stew on that a bit and then figure out how to schedule that.
2020-11-16 32135, 2020
alastairp
OK, I'll take a look at the genre import again then. there are few things I'd like to talk about with someone regarding this. maybe you or reosarevok or both
2020-11-16 32155, 2020
ruaok
also, playing with funkwhale over the weekend....
2020-11-16 32110, 2020
ruaok
Mr_Monkey: this addresses one of your concerns about lack of playlist import/export.
2020-11-16 32152, 2020
ruaok
FW has plugin support -- I haven't dug in yet, but if plugins can create playlists, then it should be pretty simple to make a troi plugin for FW.
2020-11-16 32114, 2020
ruaok
which is *really* neat if you think about it. FW has context over the users collection...
2020-11-16 32152, 2020
ruaok
so that CF and annoy results can be constrained to the available tracks in the pod.
2020-11-16 32112, 2020
ruaok
or in the case of aggregated pods, don't bother with that can just make playlists.
2020-11-16 32129, 2020
Mr_Monkey
> if plugins can create playlists
2020-11-16 32129, 2020
Mr_Monkey
Do you mean create a playlist in FW or in LB? Because FW (and soon™ LB) has an API endpoint for that, which could be all we need
2020-11-16 32144, 2020
ruaok
right now I am feeling pretty happy about some troi decisions (no data to download, small footprint)
2020-11-16 32119, 2020
ruaok
Mr_Monkey: in FW. it may be a shorter route than adding playlist import support to FW.
2020-11-16 32138, 2020
alastairp
for FW -> recommendations, are you thinking that a pod will have to submit data (AB, listening data?) to MeB sites in order to get data, or do you see a version which is fully self-contained?
2020-11-16 32123, 2020
ruaok
alastairp: FW can scrobble already, so I am using that as the base assumption. If you scrobble your listens to LB, troi works better than if you dont
2020-11-16 32137, 2020
alastairp
sure, makes sense
2020-11-16 32145, 2020
ruaok
and still heavily lean on the MeN hosted data sets to generate playlists.
2020-11-16 32102, 2020
ruaok
first cut I am thinking about a very simple drop in.
2020-11-16 32128, 2020
ruaok
in any case there will need to be a content resolve built for FW, which is likely going to be the largest amount of work in this context.
2020-11-16 32137, 2020
ruaok
*resolver
2020-11-16 32115, 2020
ruaok
Mr_Monkey: which also applies to the approach of creating playlists in FW via their API endpoint.
2020-11-16 32149, 2020
Mr_Monkey
Yes, the content resolver will be key.
2020-11-16 32156, 2020
ruaok
I think I might make FW my project of choice for between xmas and nye.
reosarevok: FYI there seem to be two problems, I'm expecting ws/2/work JSON to return type_id attributes when it actually returns type-id (has something changed recently?)
2020-11-16 32152, 2020
loujine
and I don't pass the key tonality correctly in my POST
2020-11-16 32103, 2020
loujine
I remember already having problems with that before
I'm working on the weekly-jams-flashback patch in troi. fetch all the recs for a user, sort by year and then make decade playlists if at least X tracks are present for a decade.
2020-11-16 32136, 2020
ruaok
this means the playlister now needs to output more than 1 playlist.
2020-11-16 32147, 2020
ruaok
I could make a new playlister element that is specific for this.
2020-11-16 32133, 2020
ruaok
or the flashback element could output N sets of recordings and we could adapt the playlister to write a playlist for each of the sets of recordings.
2020-11-16 32149, 2020
alastairp
mmm
2020-11-16 32159, 2020
ruaok
the playlister with more than one set for recordings would need to have some playlist metadata passed to it.
2020-11-16 32106, 2020
ruaok
(e.g. 80s playlist, 90s playlist, etc)
2020-11-16 32127, 2020
alastairp
I like the second idea
2020-11-16 32139, 2020
ruaok
I'm learning towards that as well for resuability sake.
2020-11-16 32151, 2020
ruaok
but the playlist metadata bit is... unclear at best.
2020-11-16 32156, 2020
alastairp
so the input of that element could be [Playlist], rather than [Recording]
2020-11-16 32107, 2020
alastairp
then class Playlist has metadata, and a [Recording]
2020-11-16 32108, 2020
ruaok
oh!
2020-11-16 32130, 2020
ruaok
I had originally thought [[Recording], .. ]
2020-11-16 32150, 2020
ruaok
and playlist contains metadata. yes. that is a good solution.
2020-11-16 32113, 2020
ruaok
more work, but it makes sense to have Playlist as a troi entity
2020-11-16 32128, 2020
alastairp
great
2020-11-16 32141, 2020
alastairp
anything you want me to work on for that, or do you have it?
2020-11-16 32151, 2020
ruaok
and then the playlister could be adapted to take [Recording] and output one playlist or [Playlist] and dump a series of playlists.
2020-11-16 32114, 2020
ruaok
I should be fine. I'd love to see the similar tracks element moved along.
2020-11-16 32126, 2020
ruaok
s/element/patch
2020-11-16 32100, 2020
alastairp
the "playlister", do you mean the playlist method in cli? or the Playlist element?
2020-11-16 32109, 2020
ruaok
the latter.
2020-11-16 32142, 2020
ruaok
hmm. my daily jams is doing a good job of playing tracks I like from artists whom I generally dislike.
2020-11-16 32143, 2020
alastairp
oh yeah, I see now.
2020-11-16 32144, 2020
alastairp
sounds good
2020-11-16 32150, 2020
ruaok
k
2020-11-16 32107, 2020
alastairp
I guess we don't have a lot of negative feedback yet
2020-11-16 32108, 2020
ruaok
I'll get moving on that. I wanna finish the weekly flashbacks element.
2020-11-16 32124, 2020
ruaok
s/negative //
2020-11-16 32130, 2020
alastairp
I mean, no way of specifying negative feedback, and having that integrated in results
2020-11-16 32140, 2020
ruaok
soon.
2020-11-16 32146, 2020
alastairp
could always temporarily have a "remove artist x" filter
2020-11-16 32158, 2020
ruaok
>could always temporarily have a "remove artist x" filter
2020-11-16 32115, 2020
ruaok
don't get me wrong, I'm praising our work!
2020-11-16 32132, 2020
loujine
reosarevok: the latest version should solve the problem, test when you can and ping me if there is still a problem
2020-11-16 32137, 2020
ruaok
and troi already has the RemoveArtistFilter. I nearly called it the RemoveRadioheadFilter()....
