I thought I fixed everything, but it's still failing only on jenkins
2020-12-11 34607, 2020
Mr_Monkey
Let me know if you need another pair of eyes
2020-12-11 34617, 2020
Mr_Monkey
or brain
2020-12-11 34610, 2020
alastairp
sigh
2020-12-11 34611, 2020
alastairp
ok
2020-12-11 34612, 2020
alastairp
timescale_writer_1 | ImportError: cannot import name 'config' from 'listenbrainz' (/code/listenbrainz/listenbrainz/__init__.py)
2020-12-11 34629, 2020
alastairp
yeah, no data in timescale, because the timescale writer exited :D
2020-12-11 34603, 2020
alastairp
ohhhh, yeah. that'll be why it works on my machine, because I have a config.py for my local development
2020-12-11 34621, 2020
alastairp
so, what we thought were timing issues were a bit of a red herring
2020-12-11 34635, 2020
ruaok
ø/
2020-12-11 34637, 2020
ruaok
moin!
2020-12-11 34643, 2020
ruaok
need any help on anything?
2020-12-11 34638, 2020
D4RK-PH0ENiX joined the channel
2020-12-11 34623, 2020
v6lur has quit
2020-12-11 34617, 2020
v6lur joined the channel
2020-12-11 34658, 2020
alastairp
if this jenkins run passes, no!
2020-12-11 34643, 2020
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews, Jenkins number of executors
2020-12-11 34636, 2020
alastairp
ruaok: ^ now that we have more tests on jenkins, there is the possibility of queues when lots of people are making changes. Not sure if we should increase number of workers on williams or...?
2020-12-11 34655, 2020
alastairp
probably not worth it financially to have an entire machine dedicated to it, because load isn't constant
2020-12-11 34621, 2020
ruaok
yeah, fine. load is 12% cpu.
2020-12-11 34626, 2020
alastairp
ok
2020-12-11 34640, 2020
alastairp
bitmap: hi, we should update jenkins executors to 4, what do you think?
2020-12-11 34646, 2020
TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | Channel is logged; see https://musicbrainz.org/doc/IRC for details | Agenda: Reviews
2020-12-11 34612, 2020
alastairp
ok, int tests work now!
2020-12-11 34621, 2020
shivam-kapila
Phew
2020-12-11 34623, 2020
alastairp
I've lost a commit :(
2020-12-11 34652, 2020
shivam-kapila
How old
2020-12-11 34611, 2020
shivam-kapila
I can help probably
2020-12-11 34641, 2020
shivam-kapila
I checked out the pr
2020-12-11 34617, 2020
D4RK-PH0_ joined the channel
2020-12-11 34627, 2020
alastairp
nah, I found it. it turns out that I didn't fix all files that should have in that commit
alastairp: one thing we didn't discuss on wednesday.
2020-12-11 34631, 2020
alastairp
uh oh
2020-12-11 34643, 2020
Mr_Monkey
Sure. I'm going to checkout the master version of the lockfile, then run npm install and commit the lockfile again.
2020-12-11 34632, 2020
ruaok
the JSPF code that we have in troi and in LB. I think the right way forward is to make a package python-metabrainz-jspf -- that does serializing/validating including MeB extension fields.
2020-12-11 34617, 2020
alastairp
yeah, I was thinking about that
2020-12-11 34614, 2020
alastairp
I think that's a good solution. how much do you think it should include? e.g. it could have the pydantic models as part of it, allowing people to build playlists themselves in python easily
2020-12-11 34638, 2020
alastairp
and then I guess it should depend on pylistenbrainz for submission?
2020-12-11 34643, 2020
alastairp
or the other way around
2020-12-11 34652, 2020
ruaok
I was hoping to start simpler and to really only have serialization/validation in it. I just want to share some code, not start yet another project right this second.
just waiting on Mr_Monkey to help with resolving the conflict
2020-12-11 34611, 2020
ruaok nods
2020-12-11 34622, 2020
Mr_Monkey
npm doing its thing as we speak
2020-12-11 34648, 2020
Gore joined the channel
2020-12-11 34602, 2020
alastairp
I need to write some notes about how to set up tests on jenkins, because I remember that I solved many of these issues the last time that I set something up, and I forgot about them all again
2020-12-11 34610, 2020
alastairp
especially about the config file and volumes
2020-12-11 34652, 2020
ruaok
do you need me to review it line-by-line again or just a quick sanity check, alastairp ?
2020-12-11 34603, 2020
alastairp
just a quick sanity check would be fine
2020-12-11 34609, 2020
ruaok
on the surface it looks good to me, given that I've worked on it too.
2020-12-11 34614, 2020
alastairp
all 4 of our tests (spark, unit, int, js) are working now
2020-12-11 34625, 2020
ruaok
super!
2020-12-11 34628, 2020
Mr_Monkey
!m alastairp
2020-12-11 34628, 2020
BrainzBot
You're doing good work, alastairp!
2020-12-11 34652, 2020
ruaok
I can't wait to merge this and then the nuke travis PR. and then we can clean up our backlog or broken PRs. lol
2020-12-11 34618, 2020
alastairp
I'm holding off on adding flake8 jenkins job until we go through and clean up the code a little bit first ;)
2020-12-11 34612, 2020
alastairp
that's something that I want to think about too - try and work out a way to share linting config file between all of our python brainzes, and make a decision of if we use squeaks, or jenkins, and which specific tool
Mr_Monkey: the ini fix, what's the story with that?
2020-12-11 34632, 2020
alastairp
I see that dependabot updates package-lock. Is that the right way to do it?
2020-12-11 34646, 2020
Mr_Monkey
Yes, cause it's not a direct dependency of the project
2020-12-11 34649, 2020
alastairp
because I guess this is a dependency of something else
2020-12-11 34655, 2020
Mr_Monkey
I've had the same advisory on BB repos too
2020-12-11 34630, 2020
alastairp
yeah, I have about 17 notifications for it
2020-12-11 34637, 2020
alastairp
can you approve and merge it if you think it's fine?
2020-12-11 34600, 2020
Mr_Monkey
I don't think we would be directly affected, but I've taken to merging advisory fixes after a cursory check that everything works fine.
2020-12-11 34602, 2020
Mr_Monkey
Sure thing
2020-12-11 34635, 2020
alastairp
yeah, I guess I have no idea how to test this :)
2020-12-11 34606, 2020
alastairp
hmmm, one annoying thing is that it seems that with all of our currently open PRs, jenkins won't pick up and add the new tests to the status that we've since added, even if we rebase it against master
doesn't look like it :( let me look at the pull request hooks on jenkins
2020-12-11 34649, 2020
alastairp
ruaok: want to collaborate on working through these old PRs on LB? I see that many of them are almost there, perhaps we could go through and merge them if they're good
2020-12-11 34619, 2020
ruaok
sure, let me finish the troi flashback-jams update, I'd love to see that merged today.
2020-12-11 34621, 2020
ruaok
then I can help.
2020-12-11 34623, 2020
alastairp
oh yeah, I had that pending to re-review your 2 PRs. tell me when those are ready for me to look at
2020-12-11 34653, 2020
ruaok
2?
2020-12-11 34611, 2020
ruaok
oh right. the merged mbid-mapping one.
2020-12-11 34614, 2020
alastairp
mmm, one on troi and one somewhere else
2020-12-11 34618, 2020
alastairp
oh, that was merged? great!
2020-12-11 34653, 2020
ruaok
yeah. I've started working on deploying the typesense PR.
2020-12-11 34618, 2020
alastairp
pristine___: hi! Hope your move is going well. I'm just checking how you're doing and what your plans are for this new spark work that you were planning on doing.
2020-12-11 34635, 2020
alastairp
No hurry if you're still settling in, I'm just planning what I'll be doing next week
2020-12-11 34649, 2020
alastairp
(when I moved house within the same city it took me 3 weeks to get back into the swing of things, please take care of yourself moving to a new country! I've done it twice and it's amazing but very tiring in the first few months)
2020-12-11 34623, 2020
pristine___
alastairp: hi. I am planning to first get the feedback PR merged into master. I think I will need this weekend for that and then carry on with spark stuff. I will mostly work on weekends. Rn I am hunting for a house :(
2020-12-11 34650, 2020
alastairp
pristine___: yeah, as I said I absolutely understand. I was just seeing how you are. Good luck with finding a house!
2020-12-11 34653, 2020
pristine___
Yup yup. Thank you! Searching for a house (with all the features you want) is difficult :p
