Mr_Monkey: moin! can a playlist description contain HTML elements? If not, can we make that happen without a lot of drama? I'd like links within the meb domain, <p>, <div> and maybe <ul> if we're feeling sassy.
2020-12-23 35801, 2020
Gazooo79494 has quit
2020-12-23 35847, 2020
Gazooo79494 joined the channel
2020-12-23 35800, 2020
alastairp
ruaok: maybe it's worth filtering those at the webserver side. I've had success with https://github.com/mozilla/bleach doing exactly this
2020-12-23 35811, 2020
alastairp
I'm just fixing one last bug then I can look at that if you want
2020-12-23 35817, 2020
alastairp
should we coordinate a release today?
2020-12-23 35825, 2020
ruaok
+1 to both.
2020-12-23 35838, 2020
ruaok
I'm available until about 3pm today.
2020-12-23 35850, 2020
alastairp
cool
2020-12-23 35805, 2020
alastairp
let me finish morning stuff, and then I'll do one final run through that PR
2020-12-23 35819, 2020
ruaok
I've got both types of playlists generating, now I need to test the created-for subission.
And there's html tags on the descriptions but you probably noticed that bit :D
2020-12-23 35802, 2020
reosarevok
The previous one I can't access
2020-12-23 35815, 2020
ruaok
look at the last link I posted.
2020-12-23 35825, 2020
ruaok
I keep deleting old ones as I improve the text.
2020-12-23 35836, 2020
alastairp
yeah, once I add in html filtering we'll be able to treat the html as trustworthy and render it on the page
2020-12-23 35838, 2020
ruaok
and yes, tags and spaces are what alastairp is working on now.
2020-12-23 35834, 2020
reosarevok
"apoligize"
2020-12-23 35846, 2020
reosarevok
"Double click on any recording to start playing it -- we'll do our best to find a matching recording to play -- if you have Spotify we recommend connecting your account for a better playback experience. "
2020-12-23 35808, 2020
reosarevok
Maybe two sentences? "to play. If you have"
2020-12-23 35809, 2020
reosarevok
?
2020-12-23 35824, 2020
ruaok
my spelling abilities seem to have suffered recently. was that my covid present?
2020-12-23 35859, 2020
reosarevok
And I guess e.g. Some should be e.g. some, lowercased?
ruaok: oh, did you fix the descriptions in creating playlists by changing description -> annottion?
2020-12-23 35845, 2020
alastairp
that's a yes, just pulled your changes. thanks
2020-12-23 35829, 2020
ruaok
I hope that `annottion` is an unintentional spelling mistake.
2020-12-23 35831, 2020
ruaok
but yes, that was it.
2020-12-23 35805, 2020
alastairp
yes, you spelled it correctly this time
2020-12-23 35822, 2020
ruaok
never had problems with annotation, but collbartors? sheesh.
2020-12-23 35850, 2020
alastairp
> but subitting user is not an approved playlist bot
2020-12-23 35854, 2020
alastairp quietly fixes
2020-12-23 35803, 2020
ruaok
how exactly is the "quiet"? (asking for a friend)
2020-12-23 35826, 2020
alastairp
yeah, I realised that showing of my spelling prowess publicly isn't very quiet...
2020-12-23 35832, 2020
alastairp
mmm
2020-12-23 35859, 2020
alastairp
if someone wants to set the description to empty, they should submit an edit with annotation: ""
2020-12-23 35817, 2020
alastairp
or should it be set to null?
2020-12-23 35848, 2020
alastairp
because if there is no description, we omit the annotation key in the returned json. if a PL has a description and then it's edited to set it to "", we'll return the key with an empty value.
2020-12-23 35816, 2020
alastairp
I think if there is a presence of the key, but its value is empty (null or ""), we should set the value in the database to NULL
2020-12-23 35821, 2020
alastairp
thanks for the ideas
2020-12-23 35826, 2020
MajorLurker has quit
2020-12-23 35823, 2020
sumedh joined the channel
2020-12-23 35848, 2020
ruaok returns with a giant salad in hand
2020-12-23 35855, 2020
ruaok
still need feedback, alastairp ?
2020-12-23 35815, 2020
alastairp
just read what I said and tell me if you agree
2020-12-23 35823, 2020
alastairp
at least there's not a giant hand in your salad
2020-12-23 35855, 2020
ruaok
I like the idea of no desc vs empty desc. follows DB patterns nicely.
2020-12-23 35812, 2020
alastairp
> # If the annotation key exists, but the value is empty ("" or None), unset the description
2020-12-23 35818, 2020
alastairp
OK, going with that in the edit endpoint then
2020-12-23 35817, 2020
alastairp
ruaok: Mr_Monkey: pushed fixes to allow unsetting of collaborators and descriptions, descriptions are now html-filtered to only approved tags
2020-12-23 35856, 2020
alastairp
just updating checks now to make the public field optional when editing a playlist
2020-12-23 35813, 2020
alastairp
new dependency, ./develop.sh build required
2020-12-23 35833, 2020
ruaok
ok
2020-12-23 35804, 2020
ruaok
pushing to test
2020-12-23 35853, 2020
ruaok
now just need to allow html in our playlist descriptions. do you know how to make that happen?
[listenbrainz-server] dependabot-preview[bot] closed pull request #1205 (master…dependabot/npm_and_yarn/ini-1.3.8): [Security] Bump ini from 1.3.5 to 1.3.8 https://github.com/metabrainz/listenbrainz-server…
2020-12-23 35824, 2020
alastairp
wow, this is a big release notes. we should definitely have released more often :)
2020-12-23 35815, 2020
ruaok misses iliekcomputers
2020-12-23 35820, 2020
alastairp
yeah, absolutely
2020-12-23 35821, 2020
ruaok
shit.
2020-12-23 35828, 2020
ruaok
consul changes.
2020-12-23 35835, 2020
ruaok
let me make a PR to undo those.
2020-12-23 35851, 2020
alastairp
I thought we undid them before we updated the last time?
2020-12-23 35856, 2020
alastairp
or did you make more again?
2020-12-23 35803, 2020
ruaok
I had to redo to push to test.
2020-12-23 35835, 2020
alastairp
right, it passed my mind but I didn't think that we made them again
2020-12-23 35849, 2020
ruaok
I didn't communicate that, sorry.
2020-12-23 35846, 2020
ruaok
pushed to master, can you please careully review, alastairp ?
2020-12-23 35852, 2020
ruaok
let me do the docker configs.
2020-12-23 35856, 2020
alastairp
looking now
2020-12-23 35835, 2020
alastairp
I was thinking - should we release with the feature flag set to false, then make the tables in timescale, then update the feature flag and reset?
2020-12-23 35843, 2020
ruaok
we could also run the ts update script by hand to create the table/schemas.
