#metabrainz

moin!

Mr_Monkey: moin! can a playlist description contain HTML elements? If not, can we make that happen without a lot of drama? I'd like links within the meb domain, <p>, <div> and maybe <ul> if we're feeling sassy.

ruaok: maybe it's worth filtering those at the webserver side. I've had success with https://github.com/mozilla/bleach doing exactly this

I'm just fixing one last bug then I can look at that if you want

should we coordinate a release today?

+1 to both.

I'm available until about 3pm today.

cool

let me finish morning stuff, and then I'll do one final run through that PR

I've got both types of playlists generating, now I need to test the created-for subission.

alastairp: https://datasets.listenbrainz.org/mbid-mapping?...

new endpoint based on mbid typesense stuff, complete with troi plugin.

the stats needed translating as wel..

:D

Mr_Monkey: are you displaying playlist descriptions?

hmm, doesn't look like they are being ingested properly.

oops. is that me again?

no, me.

fixing.

fixed: https://test.listenbrainz.org/playlist/dae4e51b...

reosarevok: if you're around, care to review that english?

ruaok: br, p, div, ul, li, a href="any metabrainz domain" ?

👍

That last link has an unneeded space before !

And there's html tags on the descriptions but you probably noticed that bit :D

look at the last link I posted.

I keep deleting old ones as I improve the text.

yeah, once I add in html filtering we'll be able to treat the html as trustworthy and render it on the page

and yes, tags and spaces are what alastairp is working on now.

"apoligize"

"Double click on any recording to start playing it -- we'll do our best to find a matching recording to play -- if you have Spotify we recommend connecting your account for a better playback experience. "

Maybe two sentences? "to play. If you have"

?

my spelling abilities seem to have suffered recently. was that my covid present?

And I guess e.g. Some should be e.g. some, lowercased?

The rest seems good

Let's see the other one

Same comments, nothing else that seems a problem

ok, should all be fixed now.

thanks reosarevok

ruaok: oh, did you fix the descriptions in creating playlists by changing description -> annottion?

that's a yes, just pulled your changes. thanks

I hope that `annottion` is an unintentional spelling mistake.

but yes, that was it.

yes, you spelled it correctly this time

never had problems with annotation, but collbartors? sheesh.

> but subitting user is not an approved playlist bot

how exactly is the "quiet"? (asking for a friend)

yeah, I realised that showing of my spelling prowess publicly isn't very quiet...

mmm

if someone wants to set the description to empty, they should submit an edit with annotation: ""

or should it be set to null?

because if there is no description, we omit the annotation key in the returned json. if a PL has a description and then it's edited to set it to "", we'll return the key with an empty value.

I think if there is a presence of the key, but its value is empty (null or ""), we should set the value in the database to NULL

thanks for the ideas

still need feedback, alastairp ?

just read what I said and tell me if you agree

at least there's not a giant hand in your salad

I like the idea of no desc vs empty desc. follows DB patterns nicely.

> # If the annotation key exists, but the value is empty ("" or None), unset the description

OK, going with that in the edit endpoint then

ruaok: Mr_Monkey: pushed fixes to allow unsetting of collaborators and descriptions, descriptions are now html-filtered to only approved tags

just updating checks now to make the public field optional when editing a playlist

new dependency, ./develop.sh build required

ok

pushing to test

now just need to allow html in our playlist descriptions. do you know how to make that happen?

someone is beating us to our own game! https://twitter.com/netwt187g/status/1341677735...

Mr_Monkey: needs to tell the frontend that the html is safe and that it doesn't need to be escaped

maybe he's preparing christmas dinner

let me look at the frontend

test updated.

Oh no.

Well, the code is all your own, so dangerouslySetInnerHTML should be fine

the HTML gets sanitized on the server side.

pushed

pushing to test

looks good. thanks for taking care of the last bit, alastairp.

what's next?

I think that's it from me

ok, then merge into master, then master into production. then see that all tests pass and we can proceed.

🎉

I'll go massage some salsas and pack my stuff. that should let me stay a bit longer than 15h.

which is coming super fast.

what's your availability look like this afternoon?

right

do you want me to take care of the merges?

master -> production via a PR?

one thing that I noticed when loading playlists locally. Is there a link "my playlists" somewhere easily accessible? I Don't see anything in the menu

yes, please on the merges.

no the links are pretty slim.

I guess the easiest is to add a user menu -> My playlists

like we have My listens already

yeah.

[listenbrainz-server] alastair merged pull request #1206 (master…playlist-feature-cacapoopoo): Playlist feature PR for beta release (on production) https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] alastair opened pull request #1207 (production…master): Merge to production for playlists release (2020-12-23) https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] dependabot-preview[bot] closed pull request #1205 (master…dependabot/npm_and_yarn/ini-1.3.8): [Security] Bump ini from 1.3.5 to 1.3.8 https://github.com/metabrainz/listenbrainz-serv...

wow, this is a big release notes. we should definitely have released more often :)

yeah, absolutely

shit.

consul changes.

let me make a PR to undo those.

I thought we undid them before we updated the last time?

or did you make more again?

I had to redo to push to test.

right, it passed my mind but I didn't think that we made them again

I didn't communicate that, sorry.

pushed to master, can you please careully review, alastairp ?

let me do the docker configs.

looking now

I was thinking - should we release with the feature flag set to false, then make the tables in timescale, then update the feature flag and reset?

we could also run the ts update script by hand to create the table/schemas.

git diff v-2020-11-03.0..master consul_config.py.ctmpl

this shows some removals in addition to the 2 new config options that you added

oh, I guess we can even run the db scripts before we do the release, it'll be completely isolated

good point

the two commented out lines where already commented out before we started.

why were we setting POSTGRES_ADMIN_URI in the TIMESCALE section?

that makes no sense to me.

I bet it was copy/paste

Thanks for taking over! In thralls of dinner prep.

ah, I see. so there is POSTGRES_ADMIN_URI in the pgbouncer-master service, and TIMESCALE_ADMIN_URI in the timescale-listenbrainz section

makes sense to remove the duplicate one