zas: alastairp : did we chat more about moving jenkins from williams. I also want to deploy a typesense instance and using williams without jenkins might be a good fit.
ah, ok. when that is done, I'll start typesense on williams
2021-01-12 01232, 2021
alastairp
what's your thoughts on the cost of the VM? is there a limit we shouldn't go over? is it worth spending admin time trying to configure it to shut down when not in use?
2021-01-12 01248, 2021
alastairp
(were you even thinking of using a vm? It was a suggestion that zas had while you were on the way to the office yesterday)
2021-01-12 01204, 2021
ruaok
I wasn't thinking VM, but that doesn't rule it out.
2021-01-12 01226, 2021
ruaok
I think many of our bare metal machines are running below reasonable utilization and we should first look there.
2021-01-12 01255, 2021
alastairp
sure thing, let's go back and look at those when zas is available
2021-01-12 01245, 2021
v6lur joined the channel
2021-01-12 01201, 2021
Gazooo79494 has quit
2021-01-12 01249, 2021
Gazooo79494 joined the channel
2021-01-12 01239, 2021
Darkloke has quit
2021-01-12 01252, 2021
zas
alastairp, ruaok: I was checking VM prices, but we still have machines with enough cpu/ram/disk to host jenkins, for example cage, which is not overused atm
2021-01-12 01237, 2021
ruaok
then lets use cage.
2021-01-12 01253, 2021
zas
alastairp: ^^
2021-01-12 01200, 2021
alastairp
do we see any issues with running jenkins alongside mb website?
2021-01-12 01214, 2021
ruaok
I have no idea -- do you?
2021-01-12 01204, 2021
alastairp
bitmap mentioned yesterday that sometimes MBS selinium tests fail when json dumps are being generated, but that's the opposite - server load causing problems with tests
2021-01-12 01218, 2021
alastairp
let me compare load stats on williams and cage
2021-01-12 01226, 2021
zas
well, I guess high cpu usage can slow down things
2021-01-12 01239, 2021
zas
but if it becomes an issue we'll adapt
2021-01-12 01248, 2021
ruaok
if jenkins causes web site degration, it will show up on the graphs and zas will be on you like... a sysadmin on high latency...
2021-01-12 01212, 2021
alastairp
yeah, and it appears that there's no degradation by jenkins, it's the other way around
2021-01-12 01215, 2021
alastairp
OK, will do the migration
2021-01-12 01249, 2021
alastairp
zas: can you check if I have an account on cage?
2021-01-12 01200, 2021
zas
now you haver
2021-01-12 01213, 2021
alastairp
I'm in. thanks
2021-01-12 01246, 2021
sumedh has quit
2021-01-12 01200, 2021
_lucifer
alastairp: ruaok: Mr_Monkey mentioned in his review that you have discussed how to send updates automatically when the playlist is updated through the api. Can you fill me in as well :) ?
2021-01-12 01251, 2021
_lucifer
(in context of the lb websockets feature)
2021-01-12 01220, 2021
_lucifer
I had thought about it and am thinking of doing it using a rabbitmq queue. Wanted to know if you had the same approach or some other in mind?
2021-01-12 01223, 2021
Mr_Monkey
I'll add some more context: PR #1212 implements playlist updates through websockets, but currently requires the front-end to send a message announcing the playlist has changed (i.e user 1 modifies a collab playlist, once that succeeds the front-end page sends a WS message, then WS server broadcasts updated playlist to other users).
_lucifer: the whole thing depends on alastairp and I writing another "service layer" that emits the right sort of messages via web sockets based on the API calls that are being made. hopefully alastairp and I can work on that, (at least define it) this friday, if we can meet.
2021-01-12 01221, 2021
Chinmay3199 joined the channel
2021-01-12 01216, 2021
adhi001 joined the channel
2021-01-12 01248, 2021
sumedh joined the channel
2021-01-12 01232, 2021
reosarevok grumbles at https://tickets.metabrainz.org/browse/MBS-11291
2021-01-12 01213, 2021
reosarevok
yvanzo: the report should have run with the new code already today, right?
2021-01-12 01217, 2021
BrainzGit
[listenbrainz-server] alastair opened pull request #1231 (master…mock-playlist-metadata-lookup): Mock call to fetch_playlist_recording_metadata when getting playlists https://github.com/metabrainz/listenbrainz-server…
[listenbrainz-server] MonkeyDo merged pull request #1228 (master…listening-activity-test-bug): LB-781: Fix failure in UserListeningActivity.test.tsx due to new year https://github.com/metabrainz/listenbrainz-server…
2021-01-12 01204, 2021
alastairp
I think it's merge day in LB today. will try and get through most of the open ones
2021-01-12 01249, 2021
alastairp
ruaok: if you have time for reviews today it'd be great to get your feedback on the 5 recent PRs that I opened on LB. they're all equally important, but there's no rush to get them all done today
2021-01-12 01242, 2021
_lucifer
ruaok: sounds great, thanks for the info!
2021-01-12 01244, 2021
ruaok
alastairp: I'm hoping to get to that later today. I've been reviewing the smaller ones already.
2021-01-12 01244, 2021
sumedh has quit
2021-01-12 01251, 2021
alastairp
thanks
2021-01-12 01206, 2021
yvanzo
reosarevok: sorry, I forgot to update cron container, that's why.
2021-01-12 01217, 2021
alastairp
I'll run through the depndabot ones now and then take a look at some of the older unmerged ones
2021-01-12 01211, 2021
yvanzo
reosarevok: updated
2021-01-12 01258, 2021
alastairp
ruaok: I'm still confused as to why we get this sporadic integration test failure, "psycopg2.errors.ObjectInUse: source database "template1" is being accessed by other users. DETAIL: There is 1 other session using the database."
alastairp: I dont think its the consul bit in this case, since jenkins is unlikely to use that. however, the create_db.sql for timescale has a reference to template1. maybe that is it?
2021-01-12 01219, 2021
alastairp
ruaok: agreed that it's not consul config. the timescale part is "create database using template1", which as far as I can tell shouldn't be a problem; it's just making the defaults explicit
I would prefer to either add a separate ignore/config file for eslint, or see what items we were actually ignoring and explicitly ignore them on the commandline
2021-01-12 01240, 2021
d4rkie joined the channel
2021-01-12 01214, 2021
D4RK-PH0_ has quit
2021-01-12 01223, 2021
alastairp
Mr_Monkey: got some minutes to help me debug this?
alastairp: About the .gitignore file in LB, first of all if we want to ignore some files we can use the existing `.eslintrc.js` file (`ignorePatterns` option : https://eslint.org/docs/user-guide/configuring#ig… ).
2021-01-12 01213, 2021
Mr_Monkey
I'm not sure exactly why the gitignore file was passed in the `format` command; the only path in there that could concern eslint is `node_modules`, which is ignored by default by ESLint (just checked the docs).
