#metabrainz

[musicbrainz-android] akshaaatt closed pull request #63 (master…dev): Fixed: API Level 30 Migrations https://github.com/metabrainz/musicbrainz-andro...

[musicbrainz-android] akshaaatt reopened pull request #63 (master…dev): Fixed: API Level 30 Migrations https://github.com/metabrainz/musicbrainz-andro...

[listenbrainz-server] jdaok opened pull request #1242 (master…iterativeAPIService): [LB-516] Rewrite the APIService retries to be iterative https://github.com/metabrainz/listenbrainz-serv...

hope that time travler dude fond what he was looking for

found*

whatever it was

Afternoon!!

Good afternoon diru1100!

good after nood from morning norway :D

Good afternoon

[listenbrainz-server] alastair opened pull request #1243 (master…remove-unused-nginx): Remove unused nginx docker configuration https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] r0han22 opened pull request #1244 (master…master): LB-509: Instructions to run on port other than 80 https://github.com/metabrainz/listenbrainz-serv...

hello

ruaok: mmm, you might be right about twitter emails. It seems that you can configure _push_ notifications to choose that you only want to receive notifications for certain actions (mention, reply, like), but for emails it seems like it's all or nothing (including things like 'new user followed you')

I turned off as many items as I can. maybe we just turn it on for a week or so and see what happens?

or we build a twitter account filter, where all the messages are sent to, then filtered and sent to a google group where everything who wants to be in the known can sub.

ruaok: Hi! I'm looking at LB playlists, specifically LB-787.

My gut instinct is that a playlist's collaborators shouldn't be copied at all when copying a playlist. Can you think of a reason why we would want to keep the collaborators as-is when copying?

LB-787: Duplicating a playlist also copies collaborators https://tickets.metabrainz.org/browse/LB-787

not really.

google docs has a "share with the same people" options for cloning docs.

that is one way to do it, but I dont see it as necessary

I don't either. Perhaps we can implement that mechanism if we get user requests or we find a good reason to.

+1

Thanks !

(Much easier for my python level too :p )

heh. ;)

[listenbrainz-server] alastair opened pull request #1245 (master…skip-test): Skip randomly failing test until we can fix it https://github.com/metabrainz/listenbrainz-serv...

[metabrainz.org] mayhem opened pull request #349 (master…baseimage-upgrade): Upgrade base image, thus python and therefor a bunch of dependencies.… https://github.com/metabrainz/metabrainz.org/pu...

alastairp: shall we do a quick counter-review on these PRs?

sure thing

alastairp: no tags. I'll pin to a commit.

that's fine

would you like me to build and test the site? I assume that you got it building, and you got it running

shouldn't be needed -- I do have it running. I'll test deploy to test.mb.org before pushing to prod

pinned version pushed.

when I run develop.sh I get an error

> ModuleNotFoundError: No module named 'flask_uploads'

not sure if something is a bit different here? Shouldn't be

https://test.metabrainz.org runs fine and uploads logos fine.

weiiird

[metabrainz.org] mayhem merged pull request #349 (master…baseimage-upgrade): Upgrade base image, thus python and therefor a bunch of dependencies.… https://github.com/metabrainz/metabrainz.org/pu...

deployed.

sweet, so now we can stop maintaining the 3.6-1 python image. that's great

in fact, LB is on 3.8 and CB is on 3.8, so we might even have migrated off 3.6 completely

LB is on 3.7

[musicbrainz-server] reosarevok opened pull request #1869 (master…MBS-11337): MBS-11337: Prioritize link to URL page on URL reports https://github.com/metabrainz/musicbrainz-serve...

Mr_Monkey: even after airing the kitchen all morning it still smells of citra

[musicbrainz-server] reosarevok opened pull request #1870 (master…MBS-11336): MBS-11336: Don't show ended rels in DeprecatedRelationshipURL https://github.com/metabrainz/musicbrainz-serve...

alastairp: Yum! :p

[listenbrainz-server] alastair opened pull request #1246 (master…cron-user): Add username to system crontab files https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] alastair merged pull request #1243 (master…remove-unused-nginx): Remove unused nginx docker configuration https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] MonkeyDo opened pull request #1247 (master…playlist-copy-fixes): Don't allow playlist owner to be collaborator https://github.com/metabrainz/listenbrainz-serv...

github is having some problems at the moment, PRs are taking ~5 minutes to close after merging

[musicbrainz-server] reosarevok opened pull request #1871 (master…MBS-11335): MBS-11335: Report for reused Wikidata items https://github.com/metabrainz/musicbrainz-serve...

alastairp: https://github.com/metabrainz/listenbrainz-serv... is nothing more than adding usernames, right? no need to examine the PR more closely than that?

ruaok: yes, it only added the extra column

k

however, it'd be good to have someone else look over it to make sure I didn't miss a line, or miss a space between columns

[listenbrainz-server] alastair merged pull request #1245 (master…skip-test): Skip randomly failing test until we can fix it https://github.com/metabrainz/listenbrainz-serv...

I see no problems.

nice

[listenbrainz-server] alastair opened pull request #1248 (master…coverage-on-failure): Don't run coverage if tests fail https://github.com/metabrainz/listenbrainz-serv...

OK, that wasn't in my plan for today, but every time I tried to add a new function to the consul PR I saw another small niggle

lots of small improvements here

one more thing that I'd like to do is combine all of the spark-specific scripts and configs in ./docker into a `spark` subfolder, but I'm not sure exactly what each one is used for and it's possible that some can be removed. Maybe someone else can take a look at that.

gah. I've been trying to get started on my own work since 11am.

but I keep getting interrupted all the time. sigh.

yep, I know that feeling

[listenbrainz-server] alastair merged pull request #1248 (master…coverage-on-failure): Don't run coverage if tests fail https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] alastair merged pull request #1246 (master…cron-user): Add username to system crontab files https://github.com/metabrainz/listenbrainz-serv...

may I ask for votes https://beta.musicbrainz.org/edit/76531926 :D

Done.

bitmap, reosarevok: when you have a bit of time, can you please review the new search dev doc page?

[musicbrainz-docker] yvanzo opened pull request #183 (master…drop-default-port): MBVM-65: Drop port numbers 80 and 443 from base URL https://github.com/metabrainz/musicbrainz-docke...

[bookbrainz-site] MonkeyDo merged pull request #546 (master…webpack5): Migrate to Webpack 5 and improve bundle size https://github.com/bookbrainz/bookbrainz-site/p...

[bookbrainz-site] MonkeyDo merged pull request #547 (master…show-new-entity-name-in-relationships): feat(relationships): Show new entity name in relationship editor https://github.com/bookbrainz/bookbrainz-site/p...

Project bookbrainz-site build #3606: passed in 5 min 10 sec: https://travis-ci.org/bookbrainz/bookbrainz-sit...

yvanzo: for https://github.com/metabrainz/musicbrainz-serve... - are you thinking of just having a separate check in cleanURL for decoda or something? Or have a separate list in the same file as URL_SHORTENERS for blacklisted domains?

?

Seems sensible enough to me, but do confirm

reosarevok: cleanURL should probably do? there already are rules for some unwanted links IIRC.

Not that I can see. Not site-wide anyway

The closest I can see is the URL shortener code

[musicbrainz-docker] yvanzo merged pull request #183 (master…drop-default-port): MBVM-65: Drop port numbers 80 and 443 from base URL https://github.com/metabrainz/musicbrainz-docke...

yvanzo: Also, https://github.com/metabrainz/musicbrainz-serve... is not really what causes a difference, right? What you want me to not change is actually https://github.com/metabrainz/musicbrainz-serve... right?

reosarevok: yes but then you should probably remove lib/MusicBrainz/Server/Entity/URL/Decoda.pm too.