alastairp: Hi! I was trying to prepare the CB for consul upgrade. I think cron jobs for CB are run in the same container as the website. Is that right?
2021-01-21 02118, 2021
alastairp
hi _lucifer. that might be the case, I'm not sure
2021-01-21 02129, 2021
alastairp
however it makes sense that we split it out into a separate container like LB and AB
2021-01-21 02147, 2021
ruaok
pristine___: spark-request-consumer updated in case it was necessary. :)
2021-01-21 02158, 2021
ruaok
TFW you mark a sentry issue as fixed and it instantly marks it as a regression.
Guys, just found this - https://observablehq.com/@d3/versor-dragging, would it be better than the present data visualization presentation? The library too looks good, we can make use of other animations too.
2021-01-21 02121, 2021
_lucifer
adhi001, you'll need to provide more context
2021-01-21 02119, 2021
adhi001
I thought this can be used in listenbrainz artist origins data representation
2021-01-21 02101, 2021
_lucifer
ishaanshah and iliekcomputers worked on that. they'll be able to answer that.
alastairp: i have made the changes for consul upgrade of CB. does AB also need something similiar?
2021-01-21 02155, 2021
_lucifer
i saw that most of the changes for CB and LB are already present in AB.
2021-01-21 02147, 2021
iliekcomputers
adhi001: i think the map is more maintainable in the long term for us + personally I prefer the map where I can click whatever country I want without needing to drag as I'd have to in the globe.
2021-01-21 02100, 2021
alastairp
_lucifer: we have the split into separate services, but not the new base image version
2021-01-21 02105, 2021
alastairp
feel free to make that change too!
2021-01-21 02150, 2021
alastairp
other projects that need this - sir, artwork-redirect, and mb2wikidatabot
Mr_Monkey: js tests fail because eslint has errors and returns an error status code. If we want the test execution to pass but then report it as a degraded status in jenkins we should add `|| true` to the end of the test command
2021-01-21 02147, 2021
Mr_Monkey
OK, thanks
2021-01-21 02110, 2021
Mr_Monkey
I'm actually looking into why the lint command fails, but I was thinking about what you propose
you should also add this to the docker cp commands, because if the test command fails and doesn't create the file, the cp will also fail causing the test to completely fail and meaning that there are no stats for that job run
2021-01-21 02104, 2021
alastairp
ruaok: Mr_Monkey: ishaanshah: shivam-kapila: iliekcomputers: I'm merging https://github.com/metabrainz/listenbrainz-server…, which combines the postgres and timescale databases in development which will mean that if you have local user data or messybrainz data it will disappear the next time you update. If this is a problem let me know and we can work out how to migrate data
2021-01-21 02143, 2021
alastairp
any timescale/listen data that you have stored will stay there
Mr_Monkey: interestingly, jenkins says "JSLint Warnings: 55 warnings from one analysis", but eslint says "✖ 55 problems (10 errors, 45 warnings)"
2021-01-21 02133, 2021
alastairp
so it's possible that jenkins isn't correctly separating them by category (or the jslint output format doesn't support it, or the jenkins output parser doesn't support it)