#metabrainz

/

      • zas
        alastairp: which commands did you use?
      • 2021-02-10 04143, 2021

      • zas
        ah you ran start_services.sh
      • 2021-02-10 04109, 2021

      • zas
        so yes, it called start_registrator, which rm the running container and start a new one
      • 2021-02-10 04113, 2021

      • alastairp
        this is how I've always done it. is there a better way that doesn't try and restart all services?
      • 2021-02-10 04124, 2021

      • zas
        I just copy the run script (cp cage.sh cage_tmp.sh), remove unneeded lines to keep only the concerned service, and run it, then if all is ok, then copy changes to real scripts, remove tmp script, commti changes, push
      • 2021-02-10 04135, 2021

      • zas
        but we could seriously improve this... ;)
      • 2021-02-10 04159, 2021

      • alastairp
        right
      • 2021-02-10 04153, 2021

      • alastairp
        I guess we could also source services.sh in the shell and just run the start_ method too
      • 2021-02-10 04129, 2021

      • zas
      • 2021-02-10 04127, 2021

      • alastairp
        _lucifer: the `pytest -m "not database"` on the python2 tests is amazing. I'm glad it works!
      • 2021-02-10 04102, 2021

      • alastairp
        just waiting for travis to run and I'll merge 44
      • 2021-02-10 04153, 2021

      • _lucifer
        yeah, worked like a charm :D
      • 2021-02-10 04111, 2021

      • alastairp
        _lucifer: hmm, I'm just thinking about https://github.com/metabrainz/brainzutils-python/…
      • 2021-02-10 04121, 2021

      • alastairp
        in the context of the other stuff that we've discussed
      • 2021-02-10 04152, 2021

      • alastairp
        I wonder if psycopg2 should be installed in requirements_dev, not requirements?
      • 2021-02-10 04105, 2021

      • alastairp
        technically, it's only needed for the tests?
      • 2021-02-10 04132, 2021

      • _lucifer
        sqlalchemy uses it under the hood or no?
      • 2021-02-10 04143, 2021

      • alastairp
        only if you connect to a postgres database
      • 2021-02-10 04156, 2021

      • alastairp
        (yes, sure all of our downstream packages do, but...)
      • 2021-02-10 04132, 2021

      • alastairp
        I agree, it's probably not too much of an issue to have it there, but I think in this context it makes sense to add it to requirements_dev instead
      • 2021-02-10 04136, 2021

      • alastairp
        I'll do it
      • 2021-02-10 04153, 2021

      • _lucifer
        sure makes sense
      • 2021-02-10 04108, 2021

      • alastairp
        travis passed!
      • 2021-02-10 04133, 2021

      • BrainzGit
        [brainzutils-python] alastair merged pull request #44 (master…mbdb-test): Test musicbrainz db methods against a real musicbrainz sample database https://github.com/metabrainz/brainzutils-python/…
      • 2021-02-10 04107, 2021

      • BrainzGit
        [brainzutils-python] alastair merged pull request #45 (master…version-ranges): Use open-ended versions so that downstream projects can pin exact versions https://github.com/metabrainz/brainzutils-python/…
      • 2021-02-10 04124, 2021

      • alastairp
        _lucifer: 46 is all yours
      • 2021-02-10 04143, 2021

      • alastairp
        after that it might be nice to double-check https://github.com/metabrainz/listenbrainz-server… again :)
      • 2021-02-10 04113, 2021

      • zas
        ignore alerts
      • 2021-02-10 04150, 2021

      • ruaok
        alastairp: are you on the telegram group for nagios and for MB Alerts?
      • 2021-02-10 04146, 2021

      • alastairp
        I am no
      • 2021-02-10 04150, 2021

      • alastairp
        not
      • 2021-02-10 04101, 2021

      • alastairp
        in fact, I've made it this far without even installing telegram
      • 2021-02-10 04112, 2021

      • ruaok
        I was just made aware of that fact. plz to be installing it.
      • 2021-02-10 04148, 2021

      • alastairp
        done. same number as always
      • 2021-02-10 04123, 2021

      • ruaok
        ok, added you.
      • 2021-02-10 04137, 2021

      • AmandeepKumar joined the channel
      • 2021-02-10 04157, 2021

      • AmandeepKumar has quit
      • 2021-02-10 04152, 2021

      • reosarevok
        I like it when we wait long enough to deal with an "add autoselect to domain X" that domain X is no longer active
      • 2021-02-10 04157, 2021

      • reosarevok
        Saved us the time I guess
      • 2021-02-10 04140, 2021

      • CatQuest
        oh you
      • 2021-02-10 04111, 2021

      • reosarevok
        yvanzo, bitmap: do you think it's important to maintain consistency in this case? https://github.com/metabrainz/musicbrainz-server/…
      • 2021-02-10 04136, 2021

      • reosarevok
        We shouldn't do center-alignment on the release view because the display of rels and recording artists expect the main content to be on top
      • 2021-02-10 04151, 2021

      • reosarevok
        But I'm fine with top-aligning in edits unless you think it should stay like that
      • 2021-02-10 04106, 2021

      • _lucifer
        alastairp: 46 ready to merge
      • 2021-02-10 04136, 2021

      • BrainzGit
        [listenbrainz-server] MonkeyDo opened pull request #1276 (master…playlist_collaborators): Allow playlist collaborators to access private playlist https://github.com/metabrainz/listenbrainz-server…
      • 2021-02-10 04118, 2021

      • Mr_Monkey
        More pairs of eyes welcome on this python ^
      • 2021-02-10 04158, 2021

      • BrainzGit
        [brainzutils-python] alastair merged pull request #46 (master…bugfix2): Use correct number of variables in unpacking merged entities https://github.com/metabrainz/brainzutils-python/…
      • 2021-02-10 04110, 2021

      • alastairp
        thanks _lucifer! that's it for BU, right?
      • 2021-02-10 04141, 2021

      • alastairp
        do you want to test LB and CB again with the latest master (check that it installs, check that stuff like CB database lookups work), and confirm with me?
      • 2021-02-10 04159, 2021

      • alastairp
        then we can merge the LB change, I'll schedule a CB merge party for Friday
      • 2021-02-10 04107, 2021

      • _lucifer
        CPU usage on cage spiked again
      • 2021-02-10 04153, 2021

      • _lucifer
        alastairp: yes that's for BU. sure, i'll check again with LB and then later for CB as well
      • 2021-02-10 04127, 2021

      • _lucifer
        zas: ^^
      • 2021-02-10 04119, 2021

      • alastairp
        let me turn jenkins workers down to 3
      • 2021-02-10 04129, 2021

      • ruaok
        and with CPU spikes come MB service degradations. boo.
      • 2021-02-10 04114, 2021

      • ruaok
        zas: do you have a machine at hetzerner dedicated to "processing" tasks that are not impacting services with sensitive response times?
      • 2021-02-10 04135, 2021

      • zas
        ruaok: best choice atm would be paco
      • 2021-02-10 04108, 2021

      • zas
        gateways-redis isn't used anymore (but I keep it for now in case keydb has issues)
      • 2021-02-10 04119, 2021

      • ruaok looks
      • 2021-02-10 04124, 2021

      • zas
        and there's pg-williams (<-- why???)
      • 2021-02-10 04132, 2021

      • ruaok
        lol.
      • 2021-02-10 04145, 2021

      • ruaok
        yes, that used to be on.. williams. but the service was never renamed.
      • 2021-02-10 04104, 2021

      • zas
        services shouldn't be named after machines
      • 2021-02-10 04111, 2021

      • ruaok
        agreed.
      • 2021-02-10 04111, 2021

      • zas
        but nvm
      • 2021-02-10 04147, 2021

      • ruaok
        ok, looking at the weekly load graph, I see that paco would be pretty good.
      • 2021-02-10 04114, 2021

      • ruaok
        there are two loads spikes that go to 2. and no time sensitive services.
      • 2021-02-10 04146, 2021

      • ruaok
        alastairp: what is needed to move the service from cage to paco? just editing the nodes file and stopping/starting services or more than that?
      • 2021-02-10 04112, 2021

      • ruaok
        > Formatting correction: i hate this
      • 2021-02-10 04119, 2021

      • ruaok
        I feel you Mr_Monkey
      • 2021-02-10 04121, 2021

      • Mr_Monkey
        I really do.
      • 2021-02-10 04146, 2021

      • Mr_Monkey
      • 2021-02-10 04100, 2021

      • alastairp
        ruaok: we need to copy the jenkins-data volume too: /var/lib/docker/volumes/jenkins-data/_data
      • 2021-02-10 04123, 2021

      • ruaok
        want me to do that?
      • 2021-02-10 04137, 2021

      • alastairp
        yes please, I don't really have any time left today to look at this
      • 2021-02-10 04141, 2021

      • ruaok
        ok.
      • 2021-02-10 04152, 2021

      • ruaok
        what is the procedure for migrating a volume?
      • 2021-02-10 04157, 2021

      • alastairp
        rsync :)
      • 2021-02-10 04103, 2021

      • ruaok
        take containers down, create new volume, rsync?
      • 2021-02-10 04125, 2021

      • alastairp
        note that ci.metabrainz.org is magic based on the service existing, so you'll have to shut down on cage before starting up on paco, then it should just magically work
      • 2021-02-10 04132, 2021

      • alastairp
        at least that's what happened when I migrated from williams
      • 2021-02-10 04136, 2021

      • ruaok
        k
      • 2021-02-10 04130, 2021

      • zas
        I wonder why a cpu load on cage affects all mbs services
      • 2021-02-10 04156, 2021

      • ruaok
      • 2021-02-10 04147, 2021

      • alastairp
        ruaok: looks good
      • 2021-02-10 04156, 2021

      • alastairp
        can you just check while you have this PR open
      • 2021-02-10 04105, 2021

      • alastairp
        I think I may have forgotten to remove start_jenkins from williams
      • 2021-02-10 04113, 2021

      • alastairp
      • 2021-02-10 04108, 2021

      • ruaok
        cage is cleaned up.
      • 2021-02-10 04115, 2021

      • _lucifer
        why do we host our own jenkins instance instead of using a third party service? wouldn't that save resources?
      • 2021-02-10 04156, 2021

      • ruaok
        alastairp: removed that line from williams setup. approve the PR after that plz.
      • 2021-02-10 04101, 2021

      • alastairp
        approved, thanks
      • 2021-02-10 04116, 2021

      • alastairp
        _lucifer: yeah, it's a tradeoff. some of it comes from the fact that we've had it for a long time
      • 2021-02-10 04144, 2021

      • alastairp
        keep in mind also all the trouble that we had with travis, just by moving it to another service isn't going to guarantee that all the problems go away
      • 2021-02-10 04116, 2021

      • _lucifer
        troubles like docker limits?
      • 2021-02-10 04125, 2021

      • alastairp
        we also have a few musicbrainz-specific tasks that run on jenkins for which it is nice to have access to the rest of our servers
      • 2021-02-10 04139, 2021

      • alastairp
        troubles like travis taking 30 minutes before it would start running tests, because they had load issues too
      • 2021-02-10 04140, 2021

      • zas
      • 2021-02-10 04104, 2021

      • zas
        during first cage load
      • 2021-02-10 04109, 2021

      • _lucifer
        yeah that makes sense
      • 2021-02-10 04110, 2021

      • alastairp
        load shot up to 90 when I logged in after _lucifer said so
      • 2021-02-10 04114, 2021

      • alastairp
        (_lucifer why did you know??)
      • 2021-02-10 04122, 2021

      • alastairp
        but dropped almost immediately
      • 2021-02-10 04138, 2021

      • zas
      • 2021-02-10 04157, 2021

      • _lucifer
        zas had shared the link and it was open in a tab. i was closing tabs when it just spiked, alastairp :)
      • 2021-02-10 04158, 2021

      • alastairp
        but there were also LB js tests running. oddly, `ps` hung while printing info about js processes :/
      • 2021-02-10 04123, 2021

      • alastairp
        I hope jest doesn't spawn a million threads for whatever reason
      • 2021-02-10 04154, 2021

      • alastairp
        Mr_Monkey: when my time frees up next month, I agree that we should sit down and try and improve python style guides. This should include instructions to make vscode do the right thing when you press return, consolidation of the tools that we have locally, in jenkins and squaking, and removal of stupid warnings that we don't want
      • 2021-02-10 04101, 2021

      • BrainzGit
        [listenbrainz-server] MonkeyDo opened pull request #1277 (master…react-api-errors): Improve API error management on front-end https://github.com/metabrainz/listenbrainz-server…
      • 2021-02-10 04139, 2021

      • Mr_Monkey
        Yeah, that would be nice. I kept looking in the repo for a tool I can run to fix such issues
      • 2021-02-10 04120, 2021

      • alastairp
        it's unfortunate that there's only 1 python tool that does it automatically (black), and I'm not a big fan of it
      • 2021-02-10 04133, 2021

      • alastairp
        all of the other tools only warn, rather than actually fixing it :(
      • 2021-02-10 04141, 2021

      • Mr_Monkey
        Ah, yes, we talked about opinionated formatters
      • 2021-02-10 04145, 2021

      • Mr_Monkey
        Meh.
      • 2021-02-10 04145, 2021

      • ruaok
        alastairp: and they should allow for others to use different editors than just VScode
      • 2021-02-10 04142, 2021

      • _lucifer
        alastairp: autopep8?
      • 2021-02-10 04120, 2021

      • Mr_Monkey
        And even as an automatic github action: https://github.com/marketplace/actions/autopep8
      • 2021-02-10 04158, 2021

      • ruaok
        jenkins starting on paco.
      • 2021-02-10 04115, 2021

      • ruaok
        someone push jenkins to retest a project so we can see if it worked.
      • 2021-02-10 04100, 2021

      • ruaok
        #1276, alastairp ?
      • 2021-02-10 04112, 2021

      • alastairp
        there are already a million things (still?) in the queue
      • 2021-02-10 04115, 2021

      • alastairp
        let me cancel them
      • 2021-02-10 04135, 2021

      • ruaok
        > java.lang.Exception: Could not cancel run for id 12583
      • 2021-02-10 04150, 2021

      • ruaok
        maybe we should've cleared the queue before moving?
      • 2021-02-10 04154, 2021

      • alastairp
        so, it's definitely responding then :)
      • 2021-02-10 04101, 2021

      • alastairp
        I think it's because I tried to delete something twice
      • 2021-02-10 04109, 2021

      • ruaok
        seems positive so far.
      • 2021-02-10 04138, 2021

      • alastairp
        ok, all queues and workers cleared. I'll trigger a job
      • 2021-02-10 04156, 2021

      • alastairp
        yep, everything's fine
      • 2021-02-10 04148, 2021

      • ruaok
        williams docker configs updated.
      • 2021-02-10 04156, 2021

      • alastairp
        good idea
      • 2021-02-10 04103, 2021

      • ruaok
        should I nuke the old volume on cage?
      • 2021-02-10 04125, 2021

      • ruaok
        I still have tar archive of the volume, just in case.
      • 2021-02-10 04121, 2021

      • alastairp
        yes, I guess so
      • 2021-02-10 04132, 2021

      • alastairp
        in fact, lol. good timing. I forgot to set up backups on cage ;)
      • 2021-02-10 04104, 2021

      • alastairp
        the volume is still on williams too, and I have a task for friday to remove it
      • 2021-02-10 04112, 2021

      • ruaok
        I can do that too.
      • 2021-02-10 04141, 2021

      • _lucifer
        alastairp: tested LB with latest BU, works.
      • 2021-02-10 04150, 2021

      • alastairp
        _lucifer: great, let me make a release then
      • 2021-02-10 04110, 2021

      • alastairp
        oh, it'd be good to test CB too, with the db changes
      • 2021-02-10 04144, 2021

      • _lucifer
        yeah, that will need manual testing.
      • 2021-02-10 04102, 2021

      • zas
      • 2021-02-10 04110, 2021

      • _lucifer
        and full mb db. let me setup a dev instance on bono.
      • 2021-02-10 04143, 2021

      • ruaok
        the jenkins container was stopped, but still alive on williams.
      • 2021-02-10 04111, 2021

      • ruaok
        cage is cleaned up, williams is cleaned up.
      • 2021-02-10 04124, 2021

      • alastairp
        thanks
      • 2021-02-10 04130, 2021

      • ruaok
        np.
      • 2021-02-10 04139, 2021

      • ruaok
        lets hope that things are more stable going forward.
      • 2021-02-10 04149, 2021

      • alastairp
        there will still be docker images on cage, because we haven't merged 1256 yet
      • 2021-02-10 04119, 2021

      • ruaok
        I removed everything that looked to be jenkinsy.