#metabrainz

Project bookbrainz-site build #3643: passed in 67 min 6 sec: https://travis-ci.org/bookbrainz/bookbrainz-sit...

yvanzo: did your work on entity attributes include any validation? https://tickets.metabrainz.org/browse/MBS-11377 asks for it

MBS-11377: Work Identifier Validation

I expect not, but just in case

mo’’in’

reosarevok: no

Ok :)

[musicbrainz-server] reosarevok merged pull request #1863 (master…MBS-11329): MBS-11329: Return privileges as a number in internal editor JSON https://github.com/metabrainz/musicbrainz-serve...

[musicbrainz-server] reosarevok merged pull request #1899 (master…MBS-11370): MBS-11370: display track lengths of 0 ms or -1 ms as unknown https://github.com/metabrainz/musicbrainz-serve...

[brainzutils-python] release v1.16.0 has been published by github-actions[bot]: https://github.com/metabrainz/brainzutils-pytho...

_lucifer: I just tagged BU v1.16.0

great, thanks!

the dev instance is still up for CB at http://bono.metabrainz.org:666/ for testing but the MB database is currently down on bono.

"up 5 seconds"

its been like that for over an hour now.

ah, right

moooin!

db_1 | 2021-02-11 09:13:48.527 UTC [1] LOG: startup process (PID 24) was terminated by signal 6: Aborted

mmm, so it appears to be trying to start up, and then gets shut down again, and repeats

ruaok: ^ musicbrainz-docker on bono, any thoughts?

I haven't a clue -- odd.

it started here

let me shut it down and restart, maybe that will help.

yeah, I just down'd it

ah ok.

_lucifer: by any chance you didn't try and start it up yourself yesterday while it was still running?

alastairp: i think i might have done something stupid yesterday while cleaning up my containers

yeah :) it's possible that something got confused

the timeline aligns with 😓

nope, still has the error:

db_1 | 2021-02-11 09:24:32.123 UTC [25] LOG: invalid primary checkpoint record

I'm trying https://stackoverflow.com/questions/8799474/pos..., but if that doesn't work it might be less work to just blow it away and reload

looks good now

yup, thanks :D

EP Fix: http://bono.metabrainz.org:666/artist/164f0d73-...

Merge Entity Fix: https://critiquebrainz.org/release-group/9120f5..., http://bono.metabrainz.org:666/release-group/91...

other errors i found in sentry were dupliates of these with different entity ids, so i think both issues are now fixed?

https://phabricator.wikimedia.org/T273741#6815828 I feel your pain wikimedia.

!m _lucifer

You're doing good work, _lucifer!

_lucifer: I'm busy the next 2 days, but if you give me a list of PRs in CB to merge I'll be able to do a release

the merged entities fix is completely in BU? so we just need the version upgrades?

alastairp: i think first we should do https://github.com/metabrainz/critiquebrainz/pu.... it may reveal issues in other PRs.

yes

[critiquebrainz] alastair merged pull request #339 (master…uwsgi-logging): Disable uwsgi request logging https://github.com/metabrainz/critiquebrainz/pu...

[critiquebrainz] alastair merged pull request #342 (master…dependabot/npm_and_yarn/marked-2.0.0): [Security] Bump marked from 1.1.1 to 2.0.0 https://github.com/metabrainz/critiquebrainz/pu...

[critiquebrainz] alastair merged pull request #316 (master…CB-388): CB-388: Reduce scope of mocks https://github.com/metabrainz/critiquebrainz/pu...

_lucifer: I think #326 is basically ready, could you give it a look over? I think 330 is probably good too

I think we can release just those ones for now, then I'll try and review all of the other open ones too and get them merged in the coming week for another release

#326 looks good.

sure, let's do that.

let me update the BU versions PR as well. we should release that too due to the bug fixes.

I'd like to update translations too. jesus2099 did some updates to the french one ages ago and I still didn't get them done

(translations - related to 326, we should update transifex)

ok, how about we just do the version upgrade, test it, and release it

that works too.

then we can pick up another 4-5 PRs and maybe consider releasing tomorrow if we can get them in a working state

👍

Updating beta

bitmap: https://tickets.metabrainz.org/browse/MBS-11379 is one for you

MBS-11379: Beta redirect breaks origin in "Confirm Form Submission"

[musicbrainz-server] reosarevok opened pull request #1907 (master…MBS-11378): MBS-11378: Use lp_attributes for gender https://github.com/metabrainz/musicbrainz-serve...

alastairp: https://github.com/metabrainz/critiquebrainz/pu... is ready

_lucifer: nice, thanks

shall we do a release, then?

yes

https://github.com/metabrainz/listenbrainz-serv... is ready as well.

[critiquebrainz] alastair merged pull request #341 (master…fix-versions): Pin package versions and upgrade brainzutils https://github.com/metabrainz/critiquebrainz/pu...

[critiquebrainz] release v-2021-02-11.0 has been published by github-actions[bot]: https://github.com/metabrainz/critiquebrainz/re...

building

_lucifer: building CB I get

ERROR: requests 2.23.0 has requirement urllib3!=1.25.0,!=1.25.1,<1.26,>=1.21.1, but you'll have urllib3 1.26.3 which is incompatible.

though it seems to have built cleanly anyway

ah, we're still using the old 2019 base image, which has the old version of pip

ah yes, i removed the pip install line because i saw we were fixing it everywhere

*pip upgrade

only if we use the correct base image though :)

should i update the base image or upgrade pip?

base image

on it

3.8-20201201, because that still has consul 0.16 (until we merge #336)

oh, interesting

[critiquebrainz] amCap1712 opened pull request #343 (master…fix-versions): Upgrade base python image https://github.com/metabrainz/critiquebrainz/pu...

but that image actually only has pip 20.2.3. sigh

(the change came in 20.3). I guess we did that intentionally?

I'll be glad once we clean up all of this

lb will be using 20.2.4 after we merge #1271.

right. but keep in mind that the reason we added these version ranges is so that it would actually work with pip >= 20.3

so I guess it makes sense that we actually test it like that ;)

right, its working with pip 21

because i did all the testing with upgrading to latest pip

do you follow? I understand that it's really convoluted atm, which is annoying. It'll clear up once we merge a few more PRs

oh cool.

I'd prefer to do that for now, then

can you add to 343 to install a specific version of pip 21? (whatever is the latest version)

ishaanshah: you about?

_lucifer: interesting. pip 21 actually installed a different version of urllib3 automatically. I guess that's fine then

_lucifer: I see CB install both psycopg2 _and_ psycopg2-binary. any idea?

ah, we didn't move https://github.com/metabrainz/brainzutils-pytho... to requirements_dev

we can do some dependency cleanup in all of the projects. i'll take that up over the weekend

yeah 😓

[brainzutils-python] alastair opened pull request #51 (master…psycopg2-testonly): Don't install psycopg2 in requirements/dependencies https://github.com/metabrainz/brainzutils-pytho...

[brainzutils-python] alastair merged pull request #51 (master…psycopg2-testonly): Don't install psycopg2 in requirements/dependencies https://github.com/metabrainz/brainzutils-pytho...

alastairp: updated the PR, also the test and dev images. https://ci.metabrainz.org/job/critiquebrainz-py... seems to be fine

[brainzutils-python] release v1.16.1 has been published by github-actions[bot]: https://github.com/metabrainz/brainzutils-pytho...

there's no requests issue now

cool 👍

could you open a ticket to try and unify the Dockerfiles in CB? Not sure why we have 3 of them