#metabrainz

/

      • _lucifer
        now to fix it, i guess the easiest way would be to set a date before which it should never look and just error out
      • another way would be to just look at most a year or few months and error out otherwise?
      • i don't think we want to further back than that to find the latest listen
      • iliekcomputers: thoughts?
      • iliekcomputers
        sorry what's the bug?
      • the function you mention is used to find the latest listen in the spark cluster.
      • _lucifer
        the cluster was empty and it went back till the medivial times to find a listen
      • iliekcomputers
        ah, interesting.
      • yeah, we should have a lower limit there i guess.
      • hesitant to set it to the current year as it could lead to errors on jan 1.
      • the year before the current year maybe.
      • _lucifer
        6 months or 1 year back from today sounds good to me
      • iliekcomputers
        yeah, sounds reasonable to me.
      • _lucifer
        šŸ‘
      • d4rkie joined the channel
      • ruaok
        the absolute lower limit is jan 1 2005.
      • Gore joined the channel
      • yay dump is nearly imported.
      • then mapping
      • I'll test my code to write user similarity locally now.
      • Gore has quit
      • _lucifer: import succeeded. now importing mapping.
      • _lucifer
        yay!
      • Done! Time taken: 0.04
      • lol
      • ruaok
        do we have any code yet to display the user similarities?
      • _lucifer
        shivam-kapila shared a mockup for that yesterday. he might know
      • shivam-kapila
        The semi circular dial is almost done.
      • ruaok
        got link?
      • shivam-kapila
        To the mockup or code?
      • ruaok
        mockup
      • shivam-kapila
        A sec please
      • ruaok
        I was also wondering about the similar users that would be shown on your own friends page.
      • BrainzGit
        [listenbrainz-server] paramsingh opened pull request #1316 (masterā€¦param-recommend-recordings-from-listens-page): [wip] Allow users to recommend recordings from the listens page https://github.com/metabrainz/listenbrainz-serv...
      • shivam-kapila
        ruaok: 'You mean people similar to people I follow?
      • ruaok
        I think so, yes.
      • shivam-kapila
        I added something to the figmas board. something like that works?
      • mckean_ has quit
      • *figma
      • ruaok
        hmm. tightly packed sidebar, empty main space.
      • what else goes into the main space here?
      • shivam-kapila
        we were not yet sure. I think we were gonna ask users to pin something (like their fav. recordings) to their profile?
      • ruaok
        how about putting the "similar users" into the main area for now?
      • shivam-kapila
        I have a few questions
      • _lucifer
        mapping import done
      • iliekcomputers
        does the similarity need to be a dial?
      • how does it fit on the listens page?
      • shivam-kapila
        we can use linear scale if thats preferable
      • iliekcomputers
        last.fm does a simple progress bar line which fills up and changes color with different levels of compatability.
      • shivam-kapila
        (I mean thats an easier react component :D)
      • ruaok
        _lucifer: dataframes requested, with 365 days to start with.
      • shivam-kapila
        > I have a few questions
      • Do we want to make the profile page for those whom I follow and whom I dont exactly to be same
      • _lucifer
        šŸ‘
      • shivam-kapila
        2. Do we show similarity score on profile of people whom I already follow?
      • _lucifer
        ruaok: did you send job_type for similarity?
      • ruaok
        python3 manage.py spark request_dataframes --days=365 --job-type=user_similarity
      • shivam-kapila
        3. Do we show people similar to John Doe(whom I dont follow yet) when I visit their profile
      • ruaok
        we should rename the job type to "similar_users" which is what we call this feature in other places.
      • _lucifer
        i have renamed it and pushed the change
      • but its not updated in the container yet
      • test1651 joined the channel
      • ruaok
        thanks.
      • mckean joined the channel
      • shivam-kapila
      • iliekcomputers
        shivam-kapila: yep, something exactly like that
      • test1651 has left the channel
      • shivam-kapila
        okay
      • 1. Do we want to make the profile page for those whom I follow and whom I dont exactly to be same
      • 2. Do we show similarity score on profile of people whom I already follow?
      • 3. Do we show people similar to John Doe(whom I dont follow yet) when I visit their profile
      • ruaok: Mr_Monkey: iliekcomputers: _lucifer: alastairp Can you share your preferences for these
      • ruaok
        my take: 1. not sure. 2. sure. 3. yes, I think so.
      • _lucifer
        are we going to followers while fetching similarity? if not, might as well display it for all users
      • Mr_Monkey
        1. probably? What would be the differences?
      • 2. yes
      • 3. I think that's a good way for users to explore more music tastes without being too invasive. Definite yes for me.
      • iliekcomputers
        Mr_Monkey: can you review https://github.com/metabrainz/listenbrainz-serv... Once this is done, I can get started on the changes we need to make to feed API endpoint.
      • shivam-kapila
        I am also not quite sure about the differences yet
      • Mr_Monkey
        iliekcomputers: OK!
      • shivam-kapila
        iliekcomputers: Where should we place the similarity score component on listens page
      • Mr_Monkey
        Food first, but top of my list.
      • shivam-kapila
        Above BP?
      • BrainzGit
        [mbsssss] reosarevok opened pull request #60 (masterā€¦SEARCH-646): SEARCH-646: Prioritize exact matches for tag search https://github.com/metabrainz/mbsssss/pull/60
      • Mr_Monkey
        Under the user name?
      • iliekcomputers
        shivam-kapila: i'd say we can put it somewhere just above the listens or something.
      • v6lur joined the channel
      • Mr_Monkey
        We should probably refactor in the future and have a UserName component we can drop in anywhere that has the user name (duh!), compatibility score and follow button.
      • reosarevok
        yvanzo: ^ can you see if that PR seems legit? If so, how do we test it? :)
      • ruaok
        _lucifer: cron snook an incremental import into the mix. lets see how that goes. :)
      • iliekcomputers
        Mr_Monkey: yep, and the supporter badge idea we had.
      • Mr_Monkey
        That too !
      • And anything else we end up with that we want to associate with a short presentation of the user
      • D4RK-PH0_ joined the channel
      • D4RK-PH0_ has quit
      • D4RK-PH0_ joined the channel
      • d4rkie has quit
      • shivam-kapila
        iliekcomputers: Reg. the failing build numpy has dropped support for python 3.6.x and we are using 3.6.9
      • iliekcomputers
        :/
      • did it happen like yesterday?
      • _lucifer
        i think numpy 1.20.1 and a pr was recently merged to update numpy
      • we need to revert that for spark, i'll open a PR
      • alastairp
        shivam-kapila: oops, good catch. that was my fault
      • let's downgrade again
      • shivam-kapila
        what version were we previously using?
      • alastairp
      • could you revert that and also add a comment that explains why we use this version?
      • shivam-kapila
        sure thing
      • alastairp
        I think that _lucifer was looking at upgrading the java version of the spark images, so once we do that we can also upgrade python (see https://github.com/metabrainz/listenbrainz-serv...)
      • _lucifer
        ruaok: this incremental dump import is taking a long time ;)
      • ruaok
        ` __init__: Copying old listens into '/temp'`
      • if this is moving a whole dump out of the way... yeah.
      • not the best timing, cron.
      • iliekcomputers
        yeah, that's a thing we need to fix.
      • ruaok
        sheesh, cron. timing is supposed to be your one job.
      • iliekcomputers
        it wouldn't be a problem if our data in spark was partitioned by day instead of month.
      • ruaok
        _lucifer: gives me a moment to debug my code. :)
      • v6lur has quit
      • iliekcomputers
        Mr_Monkey: once you're back from lunch, let's chat about the things i should return from the feed endpoint once before i get started.
      • BrainzGit
        [listenbrainz-server] shivam-kapila opened pull request #1317 (masterā€¦revert-numpy-version): Revert numpy version to 1.19.4 https://github.com/metabrainz/listenbrainz-serv...
      • shivam-kapila
        alastairp: done
      • alastairp
        shivam-kapila: there is a 1.19.5 released too
      • shivam-kapila
        oh yes it also supports 3.6. Updating
      • iliekcomputers
        shivam-kapila: can you add a comment explaining why we can't upgrade in the requirements.txt
      • shivam-kapila
        done
      • alastairp
        shivam-kapila: sorry, one more thing. can you put the comment one line above, instead of on the same line?
      • BrainzGit
        [listenbrainz-server] amCap1712 merged pull request #1295 (masterā€¦spotify): Check if user has revoked authorization if refreshing token fails https://github.com/metabrainz/listenbrainz-serv...
      • _lucifer
        ruaok: alastairp: if its fine i'd like to make a release to beta to test the above PR
      • shivam-kapila
        alastairp: done
      • alastairp
        _lucifer: what service does this affect? spotify reader?
      • iliekcomputers
        _lucifer: we don't run spotify reader in beta, so it'll go in prod.
      • alastairp
        it's only present on prod
      • _lucifer
        oh ok!
      • alastairp
        maybe we should take a bit more time and set up a full stack on test?
      • _lucifer
      • oh come on another one :(
      • shivam-kapila
        get some popcorn _lucifer
      • _lucifer
        ruaok, can you please check the queue and cancel in case there are more?
      • ruaok
        only our request.
      • _lucifer
        šŸ˜„
      • ruaok
        I just finished debugging my code. let me push a new image and get that deployed.
      • Mr_Monkey
        iliekcomputers: I'm back !
      • ruaok
        but I am happy to terminate the request consumer to allows us to move on.
      • iliekcomputers
        Mr_Monkey: hey.
      • _lucifer
        sure if it won't end up corrupting the dump
      • Mr_Monkey
      • ruaok
        unsure. let's hope for the best.
      • _lucifer
        šŸ¤ž
      • iliekcomputers
        yo