#metabrainz

/

      • bitmap
        reosarevok: we might be able to acquire some more fine grained locks instead of locking the whole table there, but I haven't looked into it closely
      • 2021-03-05 06430, 2021

      • bitmap
        those are for merges
      • 2021-03-05 06422, 2021

      • yvanzo
        reosarevok: no but I looked into the similar https://github.com/metabrainz/musicbrainz-docker/…
      • 2021-03-05 06404, 2021

      • yvanzo
        oh, it's the same :)
      • 2021-03-05 06433, 2021

      • _lucifer
        ruaok: there were a few more bugs after that. i fixed and restarted the consumer it seems to work now.
      • 2021-03-05 06439, 2021

      • _lucifer
      • 2021-03-05 06412, 2021

      • _lucifer
      • 2021-03-05 06448, 2021

      • _lucifer
        i'll fix the message format to include the type expected by spark_reader
      • 2021-03-05 06432, 2021

      • mckean joined the channel
      • 2021-03-05 06451, 2021

      • ruaok
        niiiiice!
      • 2021-03-05 06404, 2021

      • iliekcomputers
        that's pretty cool, _lucifer
      • 2021-03-05 06430, 2021

      • _lucifer
        ruaok, iliekcomputers: even nicer took less than 5 mins to complete :-D
      • 2021-03-05 06447, 2021

      • iliekcomputers
        isn't spark nice :)
      • 2021-03-05 06451, 2021

      • _lucifer
        actually only 1 min
      • 2021-03-05 06455, 2021

      • ruaok
        has the data been written to lemmy successfully?
      • 2021-03-05 06407, 2021

      • _lucifer
        no, i am deploying that fix
      • 2021-03-05 06415, 2021

      • _lucifer
        the next request should do that
      • 2021-03-05 06426, 2021

      • ruaok
        <bounce> <bounce>
      • 2021-03-05 06458, 2021

      • _lucifer
        we'll need to restart the spark reader container as well
      • 2021-03-05 06410, 2021

      • shivam-kapila
        !m _lucifer
      • 2021-03-05 06410, 2021

      • BrainzBot
        You're doing good work, _lucifer!
      • 2021-03-05 06419, 2021

      • ruaok
        ok, happy to do that once you get the commit in
      • 2021-03-05 06427, 2021

      • _lucifer
        pushed
      • 2021-03-05 06447, 2021

      • _lucifer
        also, let me know if the changes look good to you
      • 2021-03-05 06453, 2021

      • BrainzGit
        [listenbrainz-server] shivam-kapila opened pull request #1319 (master…similarity-score-component): Add similarity score component https://github.com/metabrainz/listenbrainz-server…
      • 2021-03-05 06429, 2021

      • ruaok
        building.
      • 2021-03-05 06426, 2021

      • ruaok
        changes look good, thanks!
      • 2021-03-05 06422, 2021

      • shivam-kapila
        How about showing the similarity score in the "People similar to you" list itself?
      • 2021-03-05 06448, 2021

      • ruaok
        _lucifer: data was written to the table. :) and I see why you fixed the format. :)
      • 2021-03-05 06443, 2021

      • ruaok
        _lucifer: have you restarted the request reader?
      • 2021-03-05 06422, 2021

      • _lucifer
        ruaok: the lemmy container? no.
      • 2021-03-05 06434, 2021

      • _lucifer
        spark one yes
      • 2021-03-05 06437, 2021

      • ruaok
        no, on leader.
      • 2021-03-05 06442, 2021

      • ruaok
        I am doing the lemmy one.
      • 2021-03-05 06446, 2021

      • ruaok
        ah, ok.
      • 2021-03-05 06456, 2021

      • ruaok
        just waiting for the image to finish pushign
      • 2021-03-05 06459, 2021

      • ruaok
        slooooooooow
      • 2021-03-05 06408, 2021

      • _lucifer
        👍
      • 2021-03-05 06459, 2021

      • ruaok
        oh. I didn't filter the data, only the keys.
      • 2021-03-05 06422, 2021

      • ruaok
        meaning that data is going to be user_id : { user_name : .45 }
      • 2021-03-05 06454, 2021

      • ruaok
        I sure hope that will be ok.
      • 2021-03-05 06402, 2021

      • Mr_Monkey
        > shivam-kapila: How about showing the similarity score in the "People similar to you" list itself?
      • 2021-03-05 06403, 2021

      • Mr_Monkey
        Yes !
      • 2021-03-05 06415, 2021

      • ruaok
        in the end its for URL construction, so I think it should be ok.
      • 2021-03-05 06419, 2021

      • sumedh joined the channel
      • 2021-03-05 06414, 2021

      • ruaok
        _lucifer: restarted, request issued.
      • 2021-03-05 06422, 2021

      • ruaok goes to buy some veggies for dinner
      • 2021-03-05 06437, 2021

      • shivam-kapila
        send some chocolate :p
      • 2021-03-05 06424, 2021

      • iliekcomputers
        Mr_Monkey: I've ironed out bugs, the API endpoint should work now.
      • 2021-03-05 06431, 2021

      • Mr_Monkey
        🍫
      • 2021-03-05 06439, 2021

      • Mr_Monkey
        OK, will test now
      • 2021-03-05 06458, 2021

      • shivam-kapila
        lol iliekcomputers got my bar
      • 2021-03-05 06402, 2021

      • _lucifer
        ruaok: results pushed :-D
      • 2021-03-05 06443, 2021

      • _lucifer
      • 2021-03-05 06449, 2021

      • sumedh has quit
      • 2021-03-05 06401, 2021

      • Mr_Monkey
        iliekcomputers: Nice ! I'm seeing some stuff !
      • 2021-03-05 06416, 2021

      • iliekcomputers
        yay!
      • 2021-03-05 06421, 2021

      • Mr_Monkey
        I don't have any listens for my testing account locally, but I'm seeing the follow events
      • 2021-03-05 06422, 2021

      • iliekcomputers
        now to add some more tests and docstrings
      • 2021-03-05 06444, 2021

      • shivam-kapila
        Mr_Monkey: can you share an SS please
      • 2021-03-05 06400, 2021

      • Mr_Monkey
        Just an API payload :)
      • 2021-03-05 06406, 2021

      • ruaok
        _lucifer: I'm busy for the next hour or so. if you want to keep playing with it, please do.
      • 2021-03-05 06407, 2021

      • Mr_Monkey
        { "payload": { "count": 1, "events": [ { "created": 1614966577, "event_type": "follow", "metadata": { "created": 1614966577, "relationship_type": "follow", "user_name_0": "mr_monkey_test_account", "user_name_1": "mr_monkey" }, "user_name": "mr_monkey_test_account" } ], "user_id": "mr_monkey" } }
      • 2021-03-05 06423, 2021

      • shivam-kapila
        oh lol 🤣
      • 2021-03-05 06416, 2021

      • _lucifer
        great. but this current issue seems that it need to be fixed while writing to the db. i'll fix or share the details if i am able to diagnose it
      • 2021-03-05 06438, 2021

      • shivam-kapila
      • 2021-03-05 06438, 2021

      • shivam-kapila
        Are you suggesting to show the progress bar also in the similar users list?
      • 2021-03-05 06430, 2021

      • MajorLurker joined the channel
      • 2021-03-05 06436, 2021

      • Mr_Monkey
        I think that was you suggestion, I do think it would be a good idea
      • 2021-03-05 06414, 2021

      • Mr_Monkey
        For clarity, I'm talking about the "users you might want to follow" that will appear on the feed page
      • 2021-03-05 06445, 2021

      • Mr_Monkey
        Progress bar + a compact "X/10"
      • 2021-03-05 06434, 2021

      • shivam-kapila
        My initial thought was to just show the score but I like what you proposed
      • 2021-03-05 06405, 2021

      • shivam-kapila
      • 2021-03-05 06446, 2021

      • Mr_Monkey
        I think it would be a shame not to use those nice and clear colors and progress bar
      • 2021-03-05 06410, 2021

      • MajorLurker has quit
      • 2021-03-05 06413, 2021

      • shivam-kapila
        I agree. Once I thought about it. I definitely liked it
      • 2021-03-05 06439, 2021

      • v6lur joined the channel
      • 2021-03-05 06431, 2021

      • v6lur has quit
      • 2021-03-05 06444, 2021

      • v6lur joined the channel
      • 2021-03-05 06448, 2021

      • Mr_Monkey
        iliekcomputers: regarding follow event, I'm seeing an event for a user following me, but no event for myself following the other user. Is that expected? I think it's good information to show on the timeline
      • 2021-03-05 06423, 2021

      • iliekcomputers
        oh I was only showing events where someone you follow follows someone.
      • 2021-03-05 06433, 2021

      • iliekcomputers
        should we show events when you follow someone as well?
      • 2021-03-05 06450, 2021

      • iliekcomputers
        it wouldn't be much work.
      • 2021-03-05 06447, 2021

      • Mr_Monkey
        Yes I think so. It's relevant in the context of the timeline
      • 2021-03-05 06448, 2021

      • iliekcomputers
        cool, do we also want an event for when you recommend a track?
      • 2021-03-05 06456, 2021

      • iliekcomputers
        i think yes.
      • 2021-03-05 06451, 2021

      • v6lur has quit
      • 2021-03-05 06408, 2021

      • Mr_Monkey
        I'd say so, for the same reason. It's good to have confirmation of one's actions visible somewhere
      • 2021-03-05 06432, 2021

      • _lucifer finishes watching "The Corporation"
      • 2021-03-05 06435, 2021

      • _lucifer
        on a side note, has anyone watched "The Yes Men Fix The World"?
      • 2021-03-05 06403, 2021

      • shivam-kapila
        Mr_Monkey: compact mode added
      • 2021-03-05 06415, 2021

      • Mr_Monkey
        Nice !
      • 2021-03-05 06436, 2021

      • Mr_Monkey
        iliekcomputers and shivam-kapila: the feed with data from the API endpoint: https://usercontent.irccloud-cdn.com/file/PQG5KZ4…
      • 2021-03-05 06405, 2021

      • shivam-kapila
        🎉
      • 2021-03-05 06411, 2021

      • shivam-kapila
        looks awesome
      • 2021-03-05 06412, 2021

      • ruaok
        so, eggxiting
      • 2021-03-05 06428, 2021

      • shivam-kapila
        eggjacktlee
      • 2021-03-05 06438, 2021

      • iliekcomputers
        nice
      • 2021-03-05 06401, 2021

      • Mr_Monkey
        BrainzPlayer was somehow remove by my screenshot extension. Repost: https://usercontent.irccloud-cdn.com/file/zced7sg…
      • 2021-03-05 06435, 2021

      • shivam-kapila
        spotify?
      • 2021-03-05 06454, 2021

      • Mr_Monkey
        Not sure what the question is
      • 2021-03-05 06431, 2021

      • shivam-kapila
        using spotify playback? (YT playback is broken IG)
      • 2021-03-05 06438, 2021

      • Mr_Monkey
        Yes
      • 2021-03-05 06432, 2021

      • iliekcomputers
        Mr_Monkey: I pushed the change, you should now see your own events as well (excluding own listens)
      • 2021-03-05 06427, 2021

      • Mr_Monkey
        Confirmed! Nice !
      • 2021-03-05 06432, 2021

      • Mr_Monkey
        Well, it's all coming along nicely, I'd say. I *could* rebase my PR on your PR, or otherwise wait until your PR is merged before merging master. In any case I'm done for the day, and I'm really excited by our progress this week, y'all !
      • 2021-03-05 06423, 2021

      • davic joined the channel
      • 2021-03-05 06447, 2021

      • iliekcomputers
        yep, that's me for today as well. Hopefully we can merge and release this soon.
      • 2021-03-05 06405, 2021

      • zas
        bitmap: paco disk usage is worrying, that's mainly postgres-williams, can you have a look?
      • 2021-03-05 06428, 2021

      • bitmap
        okay
      • 2021-03-05 06405, 2021

      • adhi001 has quit
      • 2021-03-05 06437, 2021

      • bitmap
        the sentry db could use some cleanup, I can do that at least
      • 2021-03-05 06414, 2021

      • bitmap
        zas: do you remember off the top of your head where the gateway logs are? I'm wondering why we get so many errors from people fetching StaticBrainz scripts https://sentry.metabrainz.org/metabrainz/musicbra…
      • 2021-03-05 06442, 2021

      • bitmap
        I'm wondering if it's juust due to rate limiting
      • 2021-03-05 06431, 2021

      • bitmap
        the sentry error doesn't include the reason the request failed
      • 2021-03-05 06418, 2021

      • bitmap
        if it's rate limiting maybe we could increase it slightly for SB since we get tons of these errors (I just deleted thousands)
      • 2021-03-05 06400, 2021

      • zas
        ls /var/docker-logs/openresty/var/log/nginx/staticbrainz.* on kiki
      • 2021-03-05 06408, 2021

      • bitmap
        thanks
      • 2021-03-05 06417, 2021

      • MRiddickW joined the channel
      • 2021-03-05 06428, 2021

      • MRiddickW has quit
      • 2021-03-05 06436, 2021

      • MRiddickW_ has quit
      • 2021-03-05 06410, 2021

      • bitmap
        well, all of the ones I looked at were a 200 (with a few 304s), so dunno. a good chunk of these are from mobile so it could just be poor connection...
      • 2021-03-05 06446, 2021

      • zas
        weird
      • 2021-03-05 06431, 2021

      • zas
        while at it, have a look at staticbrainz.error.log there are a bunch of files which are requested but not available, prolly due to errors in code somewhere
      • 2021-03-05 06426, 2021

      • alastairp
        zas: bitmap: I cleaned up 17gb docker images on paco from jenkins. we still need to release the fix to LB tests to properly clean up images
      • 2021-03-05 06435, 2021

      • MRiddickW joined the channel
      • 2021-03-05 06409, 2021

      • MajorLurker joined the channel
      • 2021-03-05 06440, 2021

      • MajorLurker has quit