the issue I found was that a user was doing that and wanted a built in method for that. the sentry devs had replied that there is ignroe_errors but it was probably not documented.
[listenbrainz-server] mayhem merged pull request #1366 (master…listen-threshold): LB-851: Calculate similar users only for users who have a minimum number of listens https://github.com/metabrainz/listenbrainz-server…
2021-03-31 09023, 2021
ruaok
!m _lucifer
2021-03-31 09023, 2021
BrainzBot
You're doing good work, _lucifer!
2021-03-31 09059, 2021
ruaok
_lucifer: on leader you were smart to save the spark_config.py, but we didn't save spark_config.sh . :(
2021-03-31 09023, 2021
ruaok
lets hope that there were no changes from the default version. heh.
2021-03-31 09046, 2021
_lucifer
oh! i forgot about. 🤞
2021-03-31 09022, 2021
_lucifer
if it works fine now, i'll add spark_config.sh as well to docker-server-configs
_lucifer: hi, just to confirm - when you were originally working on this task you performed the upgrade on all downstream apps and tried to send an error?
2021-03-31 09041, 2021
_lucifer
alastairp, yes.
2021-03-31 09028, 2021
_lucifer
but i do not remember whether I tested `capture_message` specifically.
2021-03-31 09007, 2021
BharatKalluri joined the channel
2021-03-31 09011, 2021
_lucifer
I found my old branch. I tested that as well.
2021-03-31 09019, 2021
alastairp
🎉
2021-03-31 09038, 2021
ruaok
_lucifer: can I try regenerating the dataframes now?
2021-03-31 09025, 2021
_lucifer
ruaok, no i figured the hotfix won't work because the workers won't get the updated code. i am working on a PR as we speak.
[listenbrainz-server] amCap1712 opened pull request #1368 (master…listen-threshold): Update filter condition to tell spark we want the field and fix a regression https://github.com/metabrainz/listenbrainz-server…
2021-03-31 09000, 2021
_lucifer
let's wait for the tests to pass.
2021-03-31 09029, 2021
_lucifer
in case this fix doesn't work, i'll rename the count field to soemthing but that'll probably need changes elsewhere as well.
2021-03-31 09007, 2021
alastairp
_lucifer: I noticed that in docker-server-configs we are using the old deprecated dsn with a secret for most services
2021-03-31 09019, 2021
_lucifer
yes right.
2021-03-31 09026, 2021
alastairp
I'll open a PR to update that to the public DSN for these apps
2021-03-31 09038, 2021
_lucifer
cool thanks!
2021-03-31 09032, 2021
_lucifer
huh, we also have bono-ds-hoster. I forgot to test that.
2021-03-31 09005, 2021
alastairp
hmm, but I may have set that up manually instead of using BU
2021-03-31 09015, 2021
alastairp
I remember that one of these services I did manually
2021-03-31 09042, 2021
BharatKalluri has quit
2021-03-31 09044, 2021
_lucifer
yeah right that uses sentry-sdk directly
2021-03-31 09054, 2021
_lucifer
its already using new sentry
2021-03-31 09015, 2021
alastairp
great
2021-03-31 09049, 2021
alastairp
just jumping ahead a moment here - in order to merge the cache updates in BU we need to merge the CB release which does manual cache expiration?
so it seems that there was some way of passing generic information to raven (including environment), by using SENTRY_CONFIG. You're not using **options in the call to sentry_sdk.init
2021-03-31 09052, 2021
_lucifer
ah ok, remove SENTRY_CONFIG and just pass **options to init?
2021-03-31 09027, 2021
alastairp
I'm not sure. give me a moment to think it through
_lucifer: I'm digging further into sentry config in consul, and have written comments on LB and CB
2021-03-31 09026, 2021
alastairp
while we're touching this code we should get rid of the out-of-date config options and structure. It looks like AB is fine in this regard
2021-03-31 09050, 2021
_lucifer
ruaok, i had pushed the fix for that. i see you merged it. thanks!
2021-03-31 09005, 2021
_lucifer
alastairp, yeah makes sense to cleanup the config.
2021-03-31 09014, 2021
_lucifer
i have updated LB PR.
2021-03-31 09022, 2021
alastairp
!m _lucifer
2021-03-31 09022, 2021
BrainzBot
You're doing good work, _lucifer!
2021-03-31 09034, 2021
alastairp
two people dragging you in 2 directions and you still manage to get stuff updated
2021-03-31 09040, 2021
_lucifer
regarding CB, should we do lazy-loading or usual?
2021-03-31 09042, 2021
BrainzGit
[listenbrainz-server] mayhem merged pull request #1368 (master…listen-threshold): Update filter condition to tell spark we want the field and fix a regression https://github.com/metabrainz/listenbrainz-server…
