#metabrainz

OK. I'll make these same changes to LB?

yeah sue

*sure

did you remove SENTRY_DSN_PUBLIC from config in LB? (I can do it if you haven't yet, but I don't see a commit)

no, that's pending.

thanks!

done

I just had a thought that there's absolutely no reason why we need to release all of these at the same time 🤷

_lucifer: I did an exhaustive research over Musicbrainz and the entire Metabrainz Foundation. I have to admit, I'm blown away by the features and abilities provided. I feel we can incorporate many more features like Acousticbrainz, Listenbrainz and Critiquebrainz to the Musicbrainz Android App!

The tagger feature can support the ability to lookup the songs in browser.

And do you think adding a webview to the app will be a good addition?

ruaok: do you use the local consul setup/config in MeB repo under docker/config and docker git2consul?

not sure I really understand that question.

in the meb repo there's an infrastructure to run a local version of consul and git2consul in order to run development more like prod

docker-compose.consul.yml

no, I don't use that.

akshaaatt[m]: sure, we could add it but I would prefer that the existing tagger is tested and fixed before adding the webview one.

*tagger feature

ok. maybe it's a candidate for deletion to remove unused features, but that's a story for another day

[bookbrainz-site] akashgp09 opened pull request #587 (master…refactor-achievement): Refactor(achievement): Converted promise.then(...) to async/wait syntax https://github.com/bookbrainz/bookbrainz-site/p...

_lucifer: I am aiming for features like: complete tagger implementation, UI revamp with grid views instead of linear layouts to beautify the results, auto search results upon query changes, advent of Acousticbrainz and critiquebrainz and a few more details over this summer.

_lucifer: Any additions or deletions that you would suggest?

akshaaatt[m]: that's ambitious. keep in mind GSoC workload has been cut down to half ;)

_lucifer: I made my first pull request for the app without even knowing it was a part of GSoC. I want to stick around and complete this amazing app!

ah! ok. I was under the you asked wrt to the GSoC proposal.

I would suggest to leave out AB and CB for now then. If you finish up other things you mentioned, there's a listen submitter also in the application which is pretty much limited right now.

_lucifer: Sure! Right.

_lucifer: it's getting to the end of the day here, I can stick around for about 30m more. do you think we should try and go for a release?

alastairp, yeah, sure. let's do the ones we can.

I think AB is good

I pushed changes to LB

the CB js is not working currently, i'll need to look into it.

we need to release BU and update requirements for those

what's not working for you? I'm trying and can't get the custom error page to work

the feedback box is not showing up.

ah, but you get the error page to show? how?

you'll need to set DEBUG to False

run the server in non-development mode?

in custom_config.py

yes

ah, and DEBUG, got it

also, i pushed a fix just now to the CB branch.

looks like we're missing a <script> tag ;)

that's in the fix I pushed.

but it doesn't show up after that as well.

hah, conflict in index.py

we both made an error in the same place ;)

lol

i wonder if that has something to do with which bundle we are using https://docs.sentry.io/platforms/javascript/ins...

or if sentry.init is running before the js can download

i think the scripts are executed in order we place them

i would expect it to complete the load before proceeding but let me check

alastairp: 🤦 i forgot to add the call to reportDialog

yeah, I just found that

I'll release BU

👍

done, updating AB and LB requirements. do you want to do CB?

yup on it

can you also update consul_config template to read sentry/dsn instead of dsn_private

yeah sure

up to you if you want to use config.LOG_SENTRY.dsn or keep the PUBLIC_DSN variable in the config file too

in my changes I kept both of them, but populated them from the same key in consul

let's just use config.LOG_SENTRY.dsn. we have much unneeded configs lying around already.

ok. can you confirm that if there is no LOG_SENTRY set that it will still work?

(behaviour should be that dialog doesn't appear. I'm 99.9% sure that flask template is happy with that)

[brainzutils-python] alastair merged pull request #59 (master…sentry-additional-settings): BU-44: Allow downstream apps to pass options to sentry init https://github.com/metabrainz/brainzutils-pytho...

[brainzutils-python] release v1.18.1 has been published by alastair: https://github.com/metabrainz/brainzutils-pytho...

alastairp, no it'll crash with an error. i have updated the template to config.LOG_SENTRY and config.LOG_SENTRY.dsn

thanks for checking!

I merged the docker-server-configs item, that should turn up in consul

requirements.txt on CB has to be updated

just pushed that

I saw 1 / 0 briefly but it disappeared. did you remove it?

yes

feedback on https://github.com/metabrainz/acousticbrainz-se... ?

lgtm. approved.

great!

maybe we should hold off on LB release until tomorrow? it's afternoon in europe and daytime in US

sure.

CB probably OK if you want to go for that one?

yeah, i'll do CB.

[acousticbrainz-server] alastair merged pull request #395 (master…sentry-upgrade): Read sentry environment from consul, use docker build arg to set release https://github.com/metabrainz/acousticbrainz-se...

[acousticbrainz-server] release v-2021-03-31.0 has been published by github-actions[bot]: https://github.com/metabrainz/acousticbrainz-se...

[critiquebrainz] amCap1712 merged pull request #354 (master…sentry-upgrade): Upgrade brainzutils and sentry-sdk https://github.com/metabrainz/critiquebrainz/pu...

[critiquebrainz] release v-2021-03-31.0 has been published by github-actions[bot]: https://github.com/metabrainz/critiquebrainz/re...

AB released and running

CB also deployed and working as expected

thanks _lucifer!

alastairp, should we do MeB or shift that to tomorrow?

I had a great time working with you today :)

same here. thanks for all the help! :D

interesting to see how what we think is a simple deploy turns into a whole bunch of other related things

true.

but I think it was good that while we were touching this part of the code that we could make some general improvements across the board

let's hope it remains to be a simple deploy tomorrow with the cache changes.

hah, we'll see...

yup ;)

as I mentioned earlier, there's really no reason that we had to rush on this deploy, there's no urgent interdependencies that need to be released immediately

so let's just leave as-is for today (I need to go now)

and we can do the other two tomorrow morning-ish

I think LB is ready to go, you could take care of that even if I'm not around

sure, let's regroup tommorrow.

MeB should be updated to read from the new sentry/dsn consul key, and we decide if we want to add the release tag to it

I have some time and can do that. if something goes wrong, i'll revert?

yeah, just deploy the old version again.

thanks! have a good evening

cool, i'll update LB as well then.

Good Night!

>Trapped template1 access error, FFS! Sleeping, trying again.

bummer.

the hope was that it was a transient error and that a retry would work.

[listenbrainz-server] amCap1712 opened pull request #1369 (master…fix-key-name): Fix KeyError in spark reader https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] amCap1712 merged pull request #1367 (master…sentry-upgrade): Upgrade brainzutils and sentry-sdk https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] amCap1712 opened pull request #1370 (master…calculate-stats): Decrease logging level when stats for deleted user are calculated https://github.com/metabrainz/listenbrainz-serv...

[listenbrainz-server] release v-2021-03-31.0 has been published by github-actions[bot]: https://github.com/metabrainz/listenbrainz-serv...

[mb-rngpy] dependabot[bot] opened pull request #6 (master…dependabot/pip/lxml-4.6.3): Bump lxml from 4.6.2 to 4.6.3 https://github.com/metabrainz/mb-rngpy/pull/6

yvanzo: help. what else than boats with servers.

you say you've not good at humour but it was a great idea. got any more ideas to exapnd?

so the boats are sent with boats through the usez channal, what kidn of thing after that?

how would you write that happening for actual real. super seriously

all LB services + beta updated.

sentry and logs seems normal as well. 🎉

!m _lucifer

You're doing good work, _lucifer!

ok, we have 5 new server for the spark cluster now. tito, jackie, germaine, marlon and michael.

zas will set them up and then I will start the cluster on the new servers.

cheers!

should we use this as a test cluster?

pristine___: iliekcomputers _lucifer : please save anything on the existing spark cluster that you may need. I'd like to get rid of the machines in less than a week, if possible.

_lucifer: I think we should.

zas is hoping to setup a virtual network between the first.

awesome.

if that works, then we should setup spark with yarn and maybe even forgot about docker in this case.

so, lets wait to hear back from zas, then we can dive in and clean this up.