did you remove SENTRY_DSN_PUBLIC from config in LB? (I can do it if you haven't yet, but I don't see a commit)
2021-03-31 09056, 2021
_lucifer
no, that's pending.
2021-03-31 09058, 2021
_lucifer
thanks!
2021-03-31 09043, 2021
alastairp
done
2021-03-31 09007, 2021
alastairp
I just had a thought that there's absolutely no reason why we need to release all of these at the same time 🤷
2021-03-31 09019, 2021
akshaaatt[m]
_lucifer: I did an exhaustive research over Musicbrainz and the entire Metabrainz Foundation. I have to admit, I'm blown away by the features and abilities provided. I feel we can incorporate many more features like Acousticbrainz, Listenbrainz and Critiquebrainz to the Musicbrainz Android App!
2021-03-31 09007, 2021
akshaaatt[m]
The tagger feature can support the ability to lookup the songs in browser.
2021-03-31 09039, 2021
akshaaatt[m]
And do you think adding a webview to the app will be a good addition?
2021-03-31 09056, 2021
alastairp
ruaok: do you use the local consul setup/config in MeB repo under docker/config and docker git2consul?
2021-03-31 09032, 2021
ruaok
not sure I really understand that question.
2021-03-31 09006, 2021
alastairp
in the meb repo there's an infrastructure to run a local version of consul and git2consul in order to run development more like prod
2021-03-31 09012, 2021
alastairp
docker-compose.consul.yml
2021-03-31 09038, 2021
ruaok
no, I don't use that.
2021-03-31 09053, 2021
_lucifer
akshaaatt[m]: sure, we could add it but I would prefer that the existing tagger is tested and fixed before adding the webview one.
2021-03-31 09019, 2021
_lucifer
*tagger feature
2021-03-31 09028, 2021
alastairp
ok. maybe it's a candidate for deletion to remove unused features, but that's a story for another day
2021-03-31 09040, 2021
BrainzGit
[bookbrainz-site] akashgp09 opened pull request #587 (master…refactor-achievement): Refactor(achievement): Converted promise.then(...) to async/wait syntax https://github.com/bookbrainz/bookbrainz-site/pul…
2021-03-31 09018, 2021
culinko_ is now known as culinko
2021-03-31 09008, 2021
akshaaatt[m]
_lucifer: I am aiming for features like: complete tagger implementation, UI revamp with grid views instead of linear layouts to beautify the results, auto search results upon query changes, advent of Acousticbrainz and critiquebrainz and a few more details over this summer.
2021-03-31 09026, 2021
mckean has quit
2021-03-31 09049, 2021
akshaaatt[m]
_lucifer: Any additions or deletions that you would suggest?
2021-03-31 09057, 2021
_lucifer
akshaaatt[m]: that's ambitious. keep in mind GSoC workload has been cut down to half ;)
2021-03-31 09047, 2021
akshaaatt[m]
_lucifer: I made my first pull request for the app without even knowing it was a part of GSoC. I want to stick around and complete this amazing app!
2021-03-31 09054, 2021
_lucifer
ah! ok. I was under the you asked wrt to the GSoC proposal.
2021-03-31 09046, 2021
_lucifer
I would suggest to leave out AB and CB for now then. If you finish up other things you mentioned, there's a listen submitter also in the application which is pretty much limited right now.
2021-03-31 09029, 2021
akshaaatt[m]
_lucifer: Sure! Right.
2021-03-31 09039, 2021
tykling_ joined the channel
2021-03-31 09008, 2021
tykling has quit
2021-03-31 09035, 2021
alastairp
_lucifer: it's getting to the end of the day here, I can stick around for about 30m more. do you think we should try and go for a release?
2021-03-31 09017, 2021
_lucifer
alastairp, yeah, sure. let's do the ones we can.
2021-03-31 09027, 2021
alastairp
I think AB is good
2021-03-31 09033, 2021
alastairp
I pushed changes to LB
2021-03-31 09036, 2021
_lucifer
the CB js is not working currently, i'll need to look into it.
2021-03-31 09045, 2021
alastairp
we need to release BU and update requirements for those
2021-03-31 09000, 2021
alastairp
what's not working for you? I'm trying and can't get the custom error page to work
maybe we should hold off on LB release until tomorrow? it's afternoon in europe and daytime in US
2021-03-31 09048, 2021
_lucifer
sure.
2021-03-31 09008, 2021
alastairp
CB probably OK if you want to go for that one?
2021-03-31 09024, 2021
_lucifer
yeah, i'll do CB.
2021-03-31 09041, 2021
BrainzGit
[acousticbrainz-server] alastair merged pull request #395 (master…sentry-upgrade): Read sentry environment from consul, use docker build arg to set release https://github.com/metabrainz/acousticbrainz-serv…
alastairp, should we do MeB or shift that to tomorrow?
2021-03-31 09005, 2021
alastairp
I had a great time working with you today :)
2021-03-31 09017, 2021
_lucifer
same here. thanks for all the help! :D
2021-03-31 09022, 2021
alastairp
interesting to see how what we think is a simple deploy turns into a whole bunch of other related things
2021-03-31 09032, 2021
_lucifer
true.
2021-03-31 09047, 2021
alastairp
but I think it was good that while we were touching this part of the code that we could make some general improvements across the board
2021-03-31 09051, 2021
_lucifer
let's hope it remains to be a simple deploy tomorrow with the cache changes.
2021-03-31 09059, 2021
alastairp
hah, we'll see...
2021-03-31 09006, 2021
_lucifer
yup ;)
2021-03-31 09034, 2021
alastairp
as I mentioned earlier, there's really no reason that we had to rush on this deploy, there's no urgent interdependencies that need to be released immediately
2021-03-31 09042, 2021
alastairp
so let's just leave as-is for today (I need to go now)
2021-03-31 09050, 2021
alastairp
and we can do the other two tomorrow morning-ish
2021-03-31 09001, 2021
alastairp
I think LB is ready to go, you could take care of that even if I'm not around
2021-03-31 09001, 2021
_lucifer
sure, let's regroup tommorrow.
2021-03-31 09028, 2021
alastairp
MeB should be updated to read from the new sentry/dsn consul key, and we decide if we want to add the release tag to it
2021-03-31 09028, 2021
_lucifer
I have some time and can do that. if something goes wrong, i'll revert?
you say you've not good at humour but it was a great idea. got any more ideas to exapnd?
2021-03-31 09020, 2021
CatQuest
so the boats are sent with boats through the usez channal, what kidn of thing after that?
2021-03-31 09041, 2021
CatQuest
how would you write that happening for actual real. super seriously
2021-03-31 09028, 2021
_lucifer
all LB services + beta updated.
2021-03-31 09002, 2021
_lucifer
sentry and logs seems normal as well. 🎉
2021-03-31 09037, 2021
Rohan_Pillai has quit
2021-03-31 09029, 2021
Rohan_Pillai joined the channel
2021-03-31 09034, 2021
ruaok
!m _lucifer
2021-03-31 09034, 2021
BrainzBot
You're doing good work, _lucifer!
2021-03-31 09008, 2021
ruaok
ok, we have 5 new server for the spark cluster now. tito, jackie, germaine, marlon and michael.
2021-03-31 09023, 2021
ruaok
zas will set them up and then I will start the cluster on the new servers.
2021-03-31 09032, 2021
_lucifer
cheers!
2021-03-31 09041, 2021
_lucifer
should we use this as a test cluster?
2021-03-31 09012, 2021
ruaok
pristine___: iliekcomputers _lucifer : please save anything on the existing spark cluster that you may need. I'd like to get rid of the machines in less than a week, if possible.
2021-03-31 09017, 2021
ruaok
_lucifer: I think we should.
2021-03-31 09033, 2021
ruaok
zas is hoping to setup a virtual network between the first.
2021-03-31 09047, 2021
_lucifer
awesome.
2021-03-31 09052, 2021
ruaok
if that works, then we should setup spark with yarn and maybe even forgot about docker in this case.
2021-03-31 09009, 2021
ruaok
so, lets wait to hear back from zas, then we can dive in and clean this up.
