#metabrainz

/

      • _lucifer
        we can add an integer type hint i think
      • 2021-04-06 09601, 2021

      • alastairp
        actually, same issue if you use pexpire with 1500.0
      • 2021-04-06 09623, 2021

      • alastairp
        so, here's a question
      • 2021-04-06 09641, 2021

      • alastairp
        obviously no one is using float expiries, otherwise we'd have an error
      • 2021-04-06 09656, 2021

      • alastairp
        but if we change from pexpire to expire we wouldn't be able to do 1.5 seconds, only 1 or 2
      • 2021-04-06 09657, 2021

      • _lucifer
        that isn't too bad imo, but if we do want that we can keep using pexpire underneath our expire function
      • 2021-04-06 09604, 2021

      • alastairp
        yeah
      • 2021-04-06 09624, 2021

      • alastairp
        OK, let's do pexpire, but add in a `int(timein*1000)` just in case
      • 2021-04-06 09604, 2021

      • _lucifer
        šŸ‘
      • 2021-04-06 09601, 2021

      • _lucifer
        that closes all BU PRs, i'll finish up work on the redis sets and we can do a release then
      • 2021-04-06 09626, 2021

      • _lucifer
        other than that do you want to release LB service startup improvements today?
      • 2021-04-06 09605, 2021

      • alastairp
        not today! it's almost 5pm
      • 2021-04-06 09641, 2021

      • _lucifer
        ah sure! maybe tomorrow then
      • 2021-04-06 09637, 2021

      • alastairp
        if you want we could make a beta release and update some PRs to be based off of that
      • 2021-04-06 09656, 2021

      • alastairp
        do you think it's worth it, or should we just test them against the commit hash?
      • 2021-04-06 09641, 2021

      • _lucifer
        for testing the LB service startup?
      • 2021-04-06 09657, 2021

      • BrainzGit
        [bookbrainz-site] MonkeyDo merged pull request #591 (master…badges-fix): fixes badges visibility in editor's achievements tab https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2021-04-06 09654, 2021

      • BrainzGit
        [brainzutils-python] amCap1712 opened pull request #62 (master…python3): Remove python2 support https://github.com/metabrainz/brainzutils-python/…
      • 2021-04-06 09613, 2021

      • travis-ci joined the channel
      • 2021-04-06 09613, 2021

      • travis-ci
        Project bookbrainz-site build #3835: passed in 4 min 33 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2021-04-06 09613, 2021

      • travis-ci has left the channel
      • 2021-04-06 09653, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #2042 (master…public-privs): Pass public editor privs when converting editor to JSON https://github.com/metabrainz/musicbrainz-server/…
      • 2021-04-06 09641, 2021

      • alastairp
        _lucifer: yes, for general testing on LB
      • 2021-04-06 09618, 2021

      • _lucifer
        let's do beta release
      • 2021-04-06 09600, 2021

      • _lucifer
        for beta, in LB we just deploy the commit so doesn't make any difference i think.
      • 2021-04-06 09616, 2021

      • alastairp
        mmm, maybe we're mis-understanding
      • 2021-04-06 09623, 2021

      • alastairp
        I mean to make a beta release of BU 2.0
      • 2021-04-06 09646, 2021

      • _lucifer
        ah ok!
      • 2021-04-06 09653, 2021

      • alastairp
        so that we can set a tag in requirements.txt of LB for a pr or to make a test deploy
      • 2021-04-06 09629, 2021

      • _lucifer
        sure let's do a beta release
      • 2021-04-06 09633, 2021

      • alastairp
        great
      • 2021-04-06 09655, 2021

      • alastairp
        I need to look at your comment on #61, and I also added some feedback to #58
      • 2021-04-06 09603, 2021

      • _lucifer
        yes, i agree with the feedback on 58.
      • 2021-04-06 09636, 2021

      • _lucifer
        there are multiple other changes some we already discussed earlier today that we should do in 2.0.
      • 2021-04-06 09653, 2021

      • sumedh joined the channel
      • 2021-04-06 09628, 2021

      • CardinalWolseley joined the channel
      • 2021-04-06 09655, 2021

      • alastairp
        yeah
      • 2021-04-06 09600, 2021

      • _lucifer
        plus now that we are breaking compatibility let's go through the entire BU code base once to see if there are some more backward incompatible change we like
      • 2021-04-06 09607, 2021

      • alastairp
        and the ones that I mentioned on the PR that removed the namespace versions
      • 2021-04-06 09613, 2021

      • alastairp
        yeah, good idea
      • 2021-04-06 09624, 2021

      • alastairp
        maybe iliekcomputers can get on board with this plan too
      • 2021-04-06 09642, 2021

      • _lucifer
        yup good idea
      • 2021-04-06 09607, 2021

      • _lucifer
        for the separate branch name, v1.18 sounds good?
      • 2021-04-06 09616, 2021

      • _lucifer
        or maybe python2 is more apt?
      • 2021-04-06 09640, 2021

      • alastairp
        let's use the version number
      • 2021-04-06 09647, 2021

      • alastairp
        yes, v1.18
      • 2021-04-06 09647, 2021

      • _lucifer
        šŸ‘
      • 2021-04-06 09620, 2021

      • _lucifer
        alastairp, can you take a look at BU permissions? I am getting 403 while pushing to it.
      • 2021-04-06 09631, 2021

      • _lucifer
        *BU github permissions
      • 2021-04-06 09631, 2021

      • alastairp
        I invited coreteam to be admin on BU. You should have full access now
      • 2021-04-06 09625, 2021

      • _lucifer
        thanks!
      • 2021-04-06 09626, 2021

      • BrainzGit
        [brainzutils-python] alastair closed pull request #48 (master…jenkins-tests): WIP: Simplify BU tests and configure to run in Jenkins https://github.com/metabrainz/brainzutils-python/…
      • 2021-04-06 09632, 2021

      • _lucifer
        i have created v1.18 in the repo and disabled force push and enabled protection against delete on it
      • 2021-04-06 09650, 2021

      • alastairp
        cool!
      • 2021-04-06 09603, 2021

      • alastairp
        that's me done for the day, then. let's talk tomorrow!
      • 2021-04-06 09621, 2021

      • _lucifer
        šŸ‘
      • 2021-04-06 09617, 2021

      • CardinalWolseley has quit
      • 2021-04-06 09643, 2021

      • ruaok
      • 2021-04-06 09643, 2021

      • BrainzBot
        LB-858: Add report user feature
      • 2021-04-06 09610, 2021

      • alastairp
        šŸ˜ what a wonderfully written ticket
      • 2021-04-06 09624, 2021

      • ruaok
        not urgent. but we should hash out how this should work, based on some of the feedback we've already gotten about how to deal with reported.
      • 2021-04-06 09641, 2021

      • ruaok
        sadly, it isn't actionable and has too many open questions, but thanks. :)
      • 2021-04-06 09611, 2021

      • alastairp
        yeah, but it's already 1000x better than if it just had the title and "implement this please" as the body
      • 2021-04-06 09643, 2021

      • ruaok
        given our limited community moderation ability, I think we should examine ways in which we can enage our community to help while not violating our privacy policy.
      • 2021-04-06 09612, 2021

      • alastairp
        I opened a bunch of tickets today and tried to add in as much detail as possible, because I find that often we think of great ideas when talking among ourselves but by the time we get to implementing it I've forgotten everything we discussed
      • 2021-04-06 09626, 2021

      • ruaok nods
      • 2021-04-06 09633, 2021

      • alastairp
        yeah, agreed. so reporting is good, but addressing the reports can be more difficult
      • 2021-04-06 09643, 2021

      • ruaok
        over lunch a pile of things I wished to see about this feature became clear, so I wanted to jot them down.
      • 2021-04-06 09608, 2021

      • ruaok
        and hopefully avoid the drama around the metrics feature, lol.
      • 2021-04-06 09617, 2021

      • alastairp
        :( yeah
      • 2021-04-06 09603, 2021

      • alastairp
        btw, current priority list for me is 1) consul startup improvements over all projects, 2) metrics
      • 2021-04-06 09651, 2021

      • ruaok
        3) real features, regardless of which project ?
      • 2021-04-06 09606, 2021

      • alastairp
        1) consul startup, 1) metrics, 1) real features
      • 2021-04-06 09625, 2021

      • alastairp
        speaking of adding detail to tickets, _lucifer: I'm adding some stuff to LB-849. again, it's good to have the ticket but better to have some details about the discussion that we had
      • 2021-04-06 09626, 2021

      • BrainzBot
        LB-849: Should we require users to have a confirmed email before creating an LB account? https://tickets.metabrainz.org/browse/LB-849
      • 2021-04-06 09650, 2021

      • ruaok
        maaan, I miss anon.penet.fi -- this would be great to have for the reporting feature.
      • 2021-04-06 09634, 2021

      • ruaok
      • 2021-04-06 09644, 2021

      • _lucifer
        alastairp, šŸ‘ thanks for updating the ticket
      • 2021-04-06 09623, 2021

      • prabal_ joined the channel
      • 2021-04-06 09636, 2021

      • v6lur joined the channel
      • 2021-04-06 09635, 2021

      • v6lur has quit
      • 2021-04-06 09657, 2021

      • v6lur joined the channel
      • 2021-04-06 09642, 2021

      • prabal_ has quit
      • 2021-04-06 09626, 2021

      • prabal joined the channel
      • 2021-04-06 09605, 2021

      • BrainzGit
        [bookbrainz-site] akashgp09 opened pull request #598 (master…update-username): FIX(editor): Update username in navbar after update in editor profile https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2021-04-06 09607, 2021

      • BrainzGit
        [listenbrainz-server] MonkeyDo merged pull request #1357 (master…monkey-dockerfile-order): Reorganize Dockerfile sequence of events https://github.com/metabrainz/listenbrainz-server…
      • 2021-04-06 09606, 2021

      • BrainzGit
        [bookbrainz-site] MonkeyDo merged pull request #594 (master…react-select): FIX(BB-527): Paste values into react-select input using mouse https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2021-04-06 09653, 2021

      • prabal
        Mr_Monkey: have a look at my proposal whenever you're free
      • 2021-04-06 09654, 2021

      • prabal
      • 2021-04-06 09638, 2021

      • Mr_Monkey
        Hi prabal ! I saw the proposal, it's on my list for tomorrow (just came back from a week AFK)
      • 2021-04-06 09600, 2021

      • prabal
        oh okayy, i didn't know that you took a week off :)
      • 2021-04-06 09645, 2021

      • Mr_Monkey
        Yeah, perfect timing with the opening of GSoC proposals…
      • 2021-04-06 09602, 2021

      • travis-ci joined the channel
      • 2021-04-06 09602, 2021

      • travis-ci
        Project bookbrainz-site build #3837: passed in 4 min 36 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2021-04-06 09602, 2021

      • travis-ci has left the channel
      • 2021-04-06 09613, 2021

      • Mr_Monkey
        Next time I'll ask Spain to push back easter. It's all arbitrary dates anyway, right? :p
      • 2021-04-06 09652, 2021

      • sumedh has quit
      • 2021-04-06 09619, 2021

      • ShivamAwasthi joined the channel
      • 2021-04-06 09657, 2021

      • BrainzGit
        [bookbrainz-site] MonkeyDo merged pull request #598 (master…update-username): FIX(editor): Update username in navbar after update in editor profile https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2021-04-06 09628, 2021

      • travis-ci joined the channel
      • 2021-04-06 09628, 2021

      • travis-ci
        Project bookbrainz-site build #3838: passed in 4 min 42 sec: https://travis-ci.org/bookbrainz/bookbrainz-site/…
      • 2021-04-06 09628, 2021

      • travis-ci has left the channel
      • 2021-04-06 09625, 2021

      • ShivamAwasthi has quit
      • 2021-04-06 09653, 2021

      • jasondk joined the channel
      • 2021-04-06 09613, 2021

      • prabal has quit
      • 2021-04-06 09637, 2021

      • Sophist-UK has quit
      • 2021-04-06 09611, 2021

      • v6lur has quit
      • 2021-04-06 09645, 2021

      • jasondk
        Hi _lucifer, do you know if there are plans to add recordings/tracks as a reviewable entity on CritiqueBrainz?
      • 2021-04-06 09648, 2021

      • jasondk
        I saw that there was a project that added new entities a while back but recordings weren't included
      • 2021-04-06 09625, 2021

      • adhi001 has quit