#metabrainz

reosarevok: careful with that, I think it's windows/mac only

which is why you'll have to find the ip address yourself

_lucifer: can you add that as a comment, I don't have time to follow it up right now

docker network inspect bridge

sure!

your host is the gateway

That does show 172.17.0.1 but it doesn't seem to work either, wat

reosarevok: your tunnel points to 172.17.0.1 too?

I use ssh -L 172.17.0.1:65401:localhost:65401 pink -N

_lucifer: ah, I see the issue now. we need to do pull, cache, build in the action in that order

yes.

yvanzo:

but because two services use the same image, we use the build/image trick to make it label the built image so that we can use it in timescale_writer

yeah, not much we can do about that then. no problem

precisely.

I just worry that we'll forget to add it here if we add a new service

reosarevok: define a new host in your ssh config or run: ssh -L 172.17.0.1:65401:localhost:65401 pink.metabrainz.org -N

we can add --ignore-pull-failures instead

ah, I didn't know that exists, that's nice

yvanzo: oh, that did it. So what's the difference? Just that I specify 172.17.0.1 on my side?

yes

should that work also when I don't have docker on? Like, could this also be used for the MB one and not need to define two tunnels?

Anyway, I can work with this :) Awesome, thanks

!m _lucifer, yvanzo, alastairp

You're doing good work, _lucifer, yvanzo, alastairp!

I did not test that but you can probably set your local MB to connect to 172.17.0.1

reosarevok: the issue is because it was doing local forward to just 127.0.0.1, not to 0.0.0.0

ruaok, zas: what's the vlan or internal ip for newleader?

i see the worker ones are here https://github.com/metabrainz/syswiki/commit/3f...

192.168.100.5

if you do ifconfig on newleader you'll see the IPs

oh! my bad. michael is the newleader 😓. makes sense. thanks!

oh, michael is the leader/name node. the others are worker/data nodes.

yes understood

michael is also bitmap, so don't get confused

hah! :D

ruaok, adding above ip entries to /etc/hosts to all node in the cluster.

k

i am documenting side by side in a file as well.

though, lets not use master. this is why we chose leader...

👍

next for installing java, i am plannng to use https://adoptopenjdk.net/installation.html#linu...

it offers a wide range of java versions and is updated often so we can switch easily if needed at anytime

ruaok, fine to add their repository and gpg key?

yvanzo: That's a good point. But what I mean by 'ExternalLinksEditor UI' only includes the list of external links, without the dialog, is it OK that I implement the list first and then the dialog?

Sure, _lucifer

Hi yvanzo, I've rearranged the schedule into small tasks grouped by deliverable features, please have a look: https://gist.github.com/y-young/d8f3a0bede06962...

yyoung: yes, it is ok to rework the list first, then make use of relationship editor dialog, then add a bubble, and so on.

yyoung: that looks more praticable now, thanks :)

yvanzo: Thanks for your generous help :)

I'll update the proposal, do you have any other suggestions?

from your current draft, move "

Support bypassing validation rules in some cases

" to stretch goals?

Sure, I'll do it right now.

and drop documentation and react from stretch goals, that's all :)

I've updated my proposal, thanks again for your valuable advice :)

hey bitmap yvanzo reosarevok I have made changes to the proposal, do review and suggest changes when you are free :) . Thanks.

[critiquebrainz] reosarevok opened pull request #357 (master…CB-415): CB-414 / CB-415: Fix issues with event artist display https://github.com/metabrainz/critiquebrainz/pu...

Maybe GitBrainz is a better name for the bot ?

ruaok: ping

pong

time to add netwwork interface configuration :)

k

i think we can reuse this file directly https://github.com/metabrainz/hadoop-cluster-do...

I had one more thought on this.

yes

I dont think we need to do anything special at all. Since we're not using docker, which opens the firewall, whether you like it or not, and we have a firewall, any ports we open should not be accessible from the outside.

so, for now lets just set it up with not special regard to which interfaces it binds to.

core-site looks sane, yes.

so reuse this?

if we don't want to configure the interface.

yeah, let's.

👍

Cyna[m]: the schedule makes more sense to me now, and seems to follow bitmap’s suggestions

Cyna[m]: however the "How will translations be handled" is probably not up-to-date (?)

Hmm... What do you mean. I thought it makes sense.

Can you give me some tips on what you are expecting ? I'll try to make the change somewhere around the lines of it

"Two plan" and you list 3 below

[critiquebrainz] reosarevok opened pull request #358 (master…CB-409): CB-409: Add name/link for artist reviews in user page https://github.com/metabrainz/critiquebrainz/pu...

only the first plan makes sense

Ohh yea sorry. I initially thought of two plans and then made a third one

See bitmap’s comment about that topic

Ok

Also Transifex is not called at run time, translations are statically bundled at release time.

!m reosarevok

You're doing good work, reosarevok!

alastairp: do I need to do anything else with any CB PRs?

(request reviews, set labels or something)

nope

I think _lucifer should be taking over CB reviews and releases though :)

Cyna[m]: There is still one mention of "Mock API" even though you correctly removed it from other parts.

yeah, sure. I'll keep in mind to review CB PRs and releases, alastairp. but your reviews are more insightful and useful :D

yeah, happy to continue giving feedback

thanks!

Hmm might be a left over. I'll quickly go throught the proposal again.

And remove any stragglers.

_lucifer, alastairp: I'm no python expert, so all my small fixes are "this works", not "I'm confident this is the best way" :) Feel free to suggest improvements whenever needed

Now that I know how to set the site up for testing I might send some more if I find more while browsing around from MB, who knows

reosarevok: yeah, many of the "copy/paste and add another if statement" are mostly OK

though sometimes I look at them and think "oh we could redo this better!"... if only we had the time

Yeah, the code for the titles seems like it could be improved, but "non-broken" is better than "broken until someone improves it more"

similar users on LB are finally working better. :)

meaning that they show up, but the scores are still low until freso gets rid of spammers.

Hi RikkoM, your post looks nice (but okno_ is the best qualified to review it), thanks! It would be even nicer if you could get more involved too :) For example: give a try to using MusicBrainz/Picard for yourself, share about your activity at MeB weekly meetings, …

yvanzo: I've added some details to the translation part of the proposal. although I am a bit confused and dont understand the entire way its done currently... Plan on reading it through the community bonding period or maybe even before it.

🤦

XD

Typo or intentional... bit confusing

interesting, after LB's big year last year, there is only one proposal this year. and I thought last year's proposals were tougher than what we proposed this year. huh

the number of proposals overall seems to have decreased as well ?

only by a few.

Yea when i participated before... there were a lot of proposals that this time. Also many last year.

Tbh I was expecting good LB candidates too

Many came and said but only jason continued

Idk why others left :/

There are still many last minute proposals to arrive I guess. Many people do them and hope to get selected as a candidate

[listenbrainz-server] mayhem opened pull request #1387 (master…fix-user-similarity-thresholding): Fix user similarity thresholding https://github.com/metabrainz/listenbrainz-serv...

_lucifer: a quickie PR fo you if you have some time

ruaok: lgtm

thx

click the approve button, _lucifer ?

I'll make sure the tests pass before merging.

thanks!

done :D

Mr_Monkey: thanks for the review, sorry i got busy and couldn't get it done before :)

Same here, too many things, not enough time !

2 more weeks left in college. lots of ongoing assignments :)

ruaok, i need to add ssh login from newleader to workers. what's the easiest way to do it? generate key pair on newleader, download and upload to workers?

yeah.