#metabrainz

/

      • reosarevok
        alastairp: not from memory. We trim artist names so we wouldn't accept a whitespace only name iirc
      • 2021-04-14 10443, 2021

      • ruaok
        _lucifer: replace the last line with just bash to drop you into a bash shell . then keep that up and then we can poke it.
      • 2021-04-14 10458, 2021

      • _lucifer
        šŸ‘
      • 2021-04-14 10443, 2021

      • Etua has quit
      • 2021-04-14 10453, 2021

      • _lucifer
        something weird is happening, the container immediately exits without any logs
      • 2021-04-14 10412, 2021

      • Etua joined the channel
      • 2021-04-14 10407, 2021

      • _lucifer
        docker run -v /spark:/spark -v /hadoop:/hadoop -v "/usr/lib/jvm/adoptopenjdk-11-hotspot-amd64":"/usr/lib/jvm/adoptopenjdk-11-hotspot-amd64" -v `pwd`:/rec --network host --name "spark-request-consumer" metabrainz/listenbrainz-spark-new-cluster:latest bash
      • 2021-04-14 10424, 2021

      • _lucifer
        ah! let me paste it
      • 2021-04-14 10437, 2021

      • _lucifer
      • 2021-04-14 10450, 2021

      • BrainzGit
        [musicbrainz-server] mwiencek merged pull request #2047 (master…mbs-11563): MBS-11563: Invalidate entity_link_type_counts on relationship inserts https://github.com/metabrainz/musicbrainz-server/…
      • 2021-04-14 10404, 2021

      • ruaok
        i wonder if docker is setup correctly.
      • 2021-04-14 10421, 2021

      • Glycem has quit
      • 2021-04-14 10413, 2021

      • _lucifer
        do you want to try without docker once?
      • 2021-04-14 10435, 2021

      • ruaok
        hang on. still doing 15 things at the same time.
      • 2021-04-14 10456, 2021

      • BrainzGit
        [musicbrainz-android] akshaaatt opened pull request #67 (master…starting_with_tests): Starting with Tests and DI Clean Up https://github.com/metabrainz/musicbrainz-android…
      • 2021-04-14 10410, 2021

      • _lucifer
        sure!
      • 2021-04-14 10418, 2021

      • Glycem joined the channel
      • 2021-04-14 10427, 2021

      • ruaok
        testing docker now. I've got a busybox container up and it can ping and reach google.
      • 2021-04-14 10457, 2021

      • sumedh has quit
      • 2021-04-14 10459, 2021

      • ruaok
        works in host mode too.
      • 2021-04-14 10407, 2021

      • ruaok
        so, it seems that docker is setup ok.
      • 2021-04-14 10419, 2021

      • ruaok
        what are you trying to reach right now? do you have an example ip:port I can try?
      • 2021-04-14 10405, 2021

      • ruaok
        _lucifer: OT: it is uncustomary to install anything in root on a host OS. ( /spark ) better in /usr/local
      • 2021-04-14 10447, 2021

      • _lucifer
        192.168.100.6:9866
      • 2021-04-14 10446, 2021

      • _lucifer
        oh! i'll move that. i had looked up a couple of guides and both of installed at /spark so i got the opposite impression.
      • 2021-04-14 10401, 2021

      • v6lur joined the channel
      • 2021-04-14 10418, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #2058 (master…MBS-11581): MBS-11581: Don't try to display / offer darkened art as RG cover art https://github.com/metabrainz/musicbrainz-server/…
      • 2021-04-14 10418, 2021

      • ruaok
        hmm, ok.
      • 2021-04-14 10431, 2021

      • ruaok
        then leave it there. there might be something with that assumption.
      • 2021-04-14 10433, 2021

      • _lucifer
        i made a modification to the spark-submit script and now the conatiner is up
      • 2021-04-14 10442, 2021

      • ruaok
        fine in this case since they are dedicated machines.
      • 2021-04-14 10407, 2021

      • ruaok
        docker seems installed fine, what I can tell.
      • 2021-04-14 10431, 2021

      • ruaok
        though 192.168.100.6:9866 gives me a 'Resource temporarily unavailable'
      • 2021-04-14 10428, 2021

      • ruaok
        works from inside the request consumer container.
      • 2021-04-14 10430, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #2035 (master…MBS-11500): MBS-11500: Do not pass GID of removed release to avoid linking https://github.com/metabrainz/musicbrainz-server/…
      • 2021-04-14 10437, 2021

      • ruaok
        are you unstuck now?
      • 2021-04-14 10400, 2021

      • _lucifer
        yeah seems so.
      • 2021-04-14 10405, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #2044 (master…MBS-11564): MBS-11564: Don't block Niconi Commons links with Nicovideo cleanup https://github.com/metabrainz/musicbrainz-server/…
      • 2021-04-14 10406, 2021

      • ruaok
        woo!
      • 2021-04-14 10441, 2021

      • _lucifer
        should i modify rabbitmq config in this container so that we can test it with lemmy?
      • 2021-04-14 10401, 2021

      • ruaok
        sure.
      • 2021-04-14 10444, 2021

      • Etua has quit
      • 2021-04-14 10440, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #2060 (master…no-parent-format-jsonld-warning): Fix Catalyst warning: ensure parent format id is not undef https://github.com/metabrainz/musicbrainz-server/…
      • 2021-04-14 10404, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #2059 (master…edit-preview-relationship-warning): Fix Catalyst warning: don't try using undef to access hash https://github.com/metabrainz/musicbrainz-server/…
      • 2021-04-14 10408, 2021

      • alastairp
        reosarevok: thanks. just related to LB-510
      • 2021-04-14 10409, 2021

      • BrainzBot
        LB-510: Minor text issue in error response for submit-listens https://tickets.metabrainz.org/browse/LB-510
      • 2021-04-14 10431, 2021

      • alastairp
        so we can specifically say that if the field is there but it's blank then it's an error
      • 2021-04-14 10425, 2021

      • akshaaatt[m]
        Hi _lucifer šŸ˜€ I have been working on writing tests and following up on DI lately. I am still new to the areas and hence will take a while. I have just made the tests-pull request rn so that it will be convenient for you to catch up on my progress. I want to have a dedicated session with you in future where we could chat and talk about any pointers for me since I'm sure there are a few and I could use some advice.
      • 2021-04-14 10425, 2021

      • akshaaatt[m]
        just completed courses on Dagger-Hilt and Android Testing šŸ¤“ I'll make a different PR and work on some other stuff as well soon. Just let me know 1-2 days before when you would review my tests PR. I am highly flexible on when we can do this, probably like April end/May beginning. Thanks a lot! šŸ˜€
      • 2021-04-14 10417, 2021

      • _lucifer
        ruaok: done.
      • 2021-04-14 10435, 2021

      • _lucifer
        let's stop the container on leader and send a request from lemmy.
      • 2021-04-14 10437, 2021

      • ruaok
        so the consumer is up and running?
      • 2021-04-14 10445, 2021

      • ruaok
        puurfect.
      • 2021-04-14 10445, 2021

      • _lucifer
        yes.
      • 2021-04-14 10458, 2021

      • ruaok
        I guess start by importing a data dump?
      • 2021-04-14 10409, 2021

      • _lucifer
        yup let's do that
      • 2021-04-14 10436, 2021

      • ruaok
        I'll let you do that, I'm still buried in biz dev nonsense.
      • 2021-04-14 10419, 2021

      • _lucifer
        šŸ‘
      • 2021-04-14 10415, 2021

      • _lucifer
        akshaaatt[m]: sure, let's do it sometime later this week. i'll ping you once I have reviewed your PRs.
      • 2021-04-14 10421, 2021

      • akshaaatt[m]
        <_lucifer "akshaaatt: sure, let's do it som"> Great!
      • 2021-04-14 10422, 2021

      • _lucifer
        huh! leader is named `newleader`. i guess it was always that way and i forgot :p.
      • 2021-04-14 10458, 2021

      • ruaok
        which newleader? lol
      • 2021-04-14 10426, 2021

      • reosarevok
        bitmap, yvanzo: so, does it seem sensible to change https://github.com/metabrainz/musicbrainz-server/… to just drop rand sort
      • 2021-04-14 10427, 2021

      • reosarevok
        ?
      • 2021-04-14 10440, 2021

      • reosarevok
        Is there any way to see stats of how many times it has been requested? Guess not?
      • 2021-04-14 10436, 2021

      • _lucifer
        yeah lol. leader.listenbrainz.org -> newleader and newleader.listenbrainz.org -> michael šŸ˜†
      • 2021-04-14 10443, 2021

      • bitmap
        we could check recent nginx logs, I guess
      • 2021-04-14 10401, 2021

      • ruaok
        remind me to clean up once we get the old new cluster ditched
      • 2021-04-14 10432, 2021

      • _lucifer
        sure. i sent the request but does not seem the container received it.
      • 2021-04-14 10445, 2021

      • _lucifer
        can we check the rabbitmq queue?
      • 2021-04-14 10429, 2021

      • ruaok
        1 request in the queu.
      • 2021-04-14 10443, 2021

      • ruaok
        on prince you can `docker exec -it rabbitmq-prince rabbitmqadmin -V /listenbrainz -u guest -p guest list queues`
      • 2021-04-14 10445, 2021

      • reosarevok
        bitmap: could I convince you to do that? :p
      • 2021-04-14 10411, 2021

      • ruaok
        what rmq port are you trying to connect to? we're on a non-standard port.
      • 2021-04-14 10443, 2021

      • _lucifer
        cool thanks. i copied the configuration from the old request consumer container
      • 2021-04-14 10402, 2021

      • _lucifer
        should i PM you the config file?
      • 2021-04-14 10404, 2021

      • bitmap
        reosarevok: in the past ~10 hours, I see 19 requests with &order=rand and 474 with &order=desc. so some, but not a ton
      • 2021-04-14 10410, 2021

      • ruaok
        naw, hang on
      • 2021-04-14 10424, 2021

      • reosarevok
        Wonder how many of those are us testing it :p
      • 2021-04-14 10429, 2021

      • ruaok
        62673 is the port.
      • 2021-04-14 10439, 2021

      • bitmap
        at least one from me :)
      • 2021-04-14 10455, 2021

      • ruaok
        aaaand, that doesn't connect.
      • 2021-04-14 10411, 2021

      • _lucifer
        firewall?
      • 2021-04-14 10429, 2021

      • ruaok
        likely, but unlikely to be on on the (new)leader side
      • 2021-04-14 10446, 2021

      • ruaok
        zas: remember that firewall hole you made for us? it seems to not work anymore.
      • 2021-04-14 10450, 2021

      • ruaok
        until zas comes to rescue us, we're dead in the water. :(
      • 2021-04-14 10402, 2021

      • bitmap
        reosarevok: what do you thinkabout renaming it to something like "unspecified (faster)"?
      • 2021-04-14 10419, 2021

      • reosarevok
        Is it *significantly* faster?
      • 2021-04-14 10430, 2021

      • _lucifer
        no worries, i'll pick up the a couple other pending PRs in the meantime then
      • 2021-04-14 10432, 2021

      • reosarevok
        Like, enough to make some timeouty queries not time out
      • 2021-04-14 10414, 2021

      • bitmap
        I haven't measured it. do you have a link to a slow-ish edit search that you use handy?
      • 2021-04-14 10424, 2021

      • yvanzo
        Possibly, I’m fine with either option.
      • 2021-04-14 10446, 2021

      • reosarevok
        chaban: ^ do you have a link like that we could test with?
      • 2021-04-14 10442, 2021

      • chaban
        Some of the searches I have for closed edits are awfully slow: https://musicbrainz.org/collection/ece5ad67-e46a-…
      • 2021-04-14 10457, 2021

      • chaban
        Especially those I limited to past 30 days
      • 2021-04-14 10420, 2021

      • chaban
        Well, that made them faster :P
      • 2021-04-14 10410, 2021

      • yvanzo
        Thanks, +1 to rename it then :)
      • 2021-04-14 10431, 2021

      • chaban
      • 2021-04-14 10432, 2021

      • BrainzBot
        MBS-10846: BookBrainz edit searches don't work
      • 2021-04-14 10437, 2021

      • chaban
        Another kind of search I had to limit was personal label rel: https://musicbrainz.org/collection/6f7767ba-9d63-…
      • 2021-04-14 10414, 2021

      • chaban
        At first 360 days was enough but eventually I had to reduce to 180 days
      • 2021-04-14 10456, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #2063 (master…EditReleaseEvents-map-keys): Add keys to EditReleaseEvents to stop warning https://github.com/metabrainz/musicbrainz-server/…
      • 2021-04-14 10453, 2021

      • chaban
        Weird. Personal label rel search seems to works fine now.
      • 2021-04-14 10417, 2021

      • chaban
        A while ago it timed out
      • 2021-04-14 10408, 2021

      • _lucifer
        alastairp: around?
      • 2021-04-14 10403, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #2023 (master…MBS-11533): MBS-11533: Block smart links: snd.click https://github.com/metabrainz/musicbrainz-server/…
      • 2021-04-14 10414, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #2016 (master…MBS-11527): MBS-11527: Block smart links: music.indiefy.net https://github.com/metabrainz/musicbrainz-server/…
      • 2021-04-14 10431, 2021

      • jasondk joined the channel
      • 2021-04-14 10428, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #2065 (master…MBS-11582): MBS-11582: Add a sortname method for instrument guess case https://github.com/metabrainz/musicbrainz-server/…
      • 2021-04-14 10449, 2021

      • reosarevok
        bitmap, yvanzo ^ another tiny bug that can't hurt to fix if you have the time to check
      • 2021-04-14 10405, 2021

      • reosarevok
        CatQuest: thanks for finding that one - I guess the guess button for instrument sortnames was broken forever, wonder if before React it just copied it or something...
      • 2021-04-14 10455, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #1850 (master…MBS-11303): MBS-11514 / MBS-11515 / MBS-11516 / MBS-11517: Use React.useContext in more places rather than passing $c around https://github.com/metabrainz/musicbrainz-server/…
      • 2021-04-14 10420, 2021

      • alastairp
        _lucifer: if it's a small question
      • 2021-04-14 10454, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #2062 (master…missing-link-type-id-warning): Fix Catalyst warning: don't try undef linktype id to access $loaded https://github.com/metabrainz/musicbrainz-server/…
      • 2021-04-14 10447, 2021

      • _lucifer
        alastairp: i actually updated the https://github.com/metabrainz/listenbrainz-server… and wanted to talk about the script reuse thing
      • 2021-04-14 10429, 2021

      • _lucifer
      • 2021-04-14 10450, 2021

      • _lucifer
        it'll now continue on error but still report it as overall failed
      • 2021-04-14 10423, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #2065 (master…MBS-11582): MBS-11582: Add a sortname method for instrument guess case https://github.com/metabrainz/musicbrainz-server/…
      • 2021-04-14 10421, 2021

      • alastairp
        _lucifer: cool, so if any one fails it'll mark as failed. if all pass it'll mark as ok?
      • 2021-04-14 10436, 2021

      • alastairp
        script reuse - you mean test.sh?
      • 2021-04-14 10437, 2021

      • _lucifer
        yup!
      • 2021-04-14 10407, 2021

      • alastairp
        I'd prefer to talk about that tomorrow if you don't mind
      • 2021-04-14 10417, 2021

      • _lucifer
        sure!
      • 2021-04-14 10421, 2021

      • zas
        ruaok: what's the problem?
      • 2021-04-14 10407, 2021

      • ruaok
        the king of pop can reach the recently deceased king of r&b. :(
      • 2021-04-14 10400, 2021

      • ruaok
        *can't
      • 2021-04-14 10437, 2021

      • ruaok
        we had it working, but that was pre-firewall setup. I didn't think that the firewall would block outbound connections, so I'm at a loss.
      • 2021-04-14 10446, 2021

      • ruaok
        did something revert on prince?
      • 2021-04-14 10438, 2021

      • BrainzGit
        [brainzutils-python] amCap1712 opened pull request #65 (master…junit): Publish Unit Test Results https://github.com/metabrainz/brainzutils-python/…
      • 2021-04-14 10411, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #2054 (master…MBS-9631): MBS-9631: Add 1200px to available image sizes https://github.com/metabrainz/musicbrainz-server/…
      • 2021-04-14 10439, 2021

      • zas
        I don't think so, but the IP of the incoming connection perhaps changed?
      • 2021-04-14 10418, 2021

      • ruaok
        136.243.155.251 is external IP
      • 2021-04-14 10403, 2021

      • ruaok
      • 2021-04-14 10414, 2021

      • ruaok
        and it times out.
      • 2021-04-14 10440, 2021

      • RikkoM has quit
      • 2021-04-14 10432, 2021

      • zas
        why is the IP always changing?
      • 2021-04-14 10421, 2021

      • zas
        that's the third IP
      • 2021-04-14 10435, 2021

      • zas
        I allowed this one on port 62673
      • 2021-04-14 10404, 2021

      • zas
        but you may want to fix the core issue: origin IP isn't constant it seems
      • 2021-04-14 10425, 2021

      • zas
        I had 94.130.35.211
      • 2021-04-14 10436, 2021

      • zas
        is this IP still valid?
      • 2021-04-14 10404, 2021

      • _lucifer
        i do not know for sure but that IP with 94 might be of the old cluster setup. the IP starting with 136 is of michael where the new setup will be located.
      • 2021-04-14 10407, 2021

      • _lucifer
        ruaok can verify that.
      • 2021-04-14 10448, 2021

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #2048 (master…MBS-11569): MBS-11569: Limit entity types when creating collection from sidebar https://github.com/metabrainz/musicbrainz-server/…
      • 2021-04-14 10451, 2021

      • prabal has quit
      • 2021-04-14 10450, 2021

      • reosarevok
        Updating beta
      • 2021-04-14 10427, 2021

      • ruaok
        zas: 94.130.35.211 is bono. still valid, yes.
      • 2021-04-14 10440, 2021

      • ruaok
        its not that the IP keeps changing, we're adding and removing services.
      • 2021-04-14 10407, 2021

      • ruaok
        and third IP is right. soon we will get rid of the old cluster and thus get rid of one.
      • 2021-04-14 10429, 2021

      • ruaok
        _lucifer: works now. thanks zas.