should i modify rabbitmq config in this container so that we can test it with lemmy?
2021-04-14 10401, 2021
ruaok
sure.
2021-04-14 10444, 2021
Etua has quit
2021-04-14 10440, 2021
BrainzGit
[musicbrainz-server] reosarevok merged pull request #2060 (masterā¦no-parent-format-jsonld-warning): Fix Catalyst warning: ensure parent format id is not undef https://github.com/metabrainz/musicbrainz-server/ā¦
2021-04-14 10404, 2021
BrainzGit
[musicbrainz-server] reosarevok merged pull request #2059 (masterā¦edit-preview-relationship-warning): Fix Catalyst warning: don't try using undef to access hash https://github.com/metabrainz/musicbrainz-server/ā¦
so we can specifically say that if the field is there but it's blank then it's an error
2021-04-14 10425, 2021
akshaaatt[m]
Hi _lucifer š I have been working on writing tests and following up on DI lately. I am still new to the areas and hence will take a while. I have just made the tests-pull request rn so that it will be convenient for you to catch up on my progress. I want to have a dedicated session with you in future where we could chat and talk about any pointers for me since I'm sure there are a few and I could use some advice.
2021-04-14 10425, 2021
akshaaatt[m]
just completed courses on Dagger-Hilt and Android Testing š¤ I'll make a different PR and work on some other stuff as well soon. Just let me know 1-2 days before when you would review my tests PR. I am highly flexible on when we can do this, probably like April end/May beginning. Thanks a lot! š
2021-04-14 10417, 2021
_lucifer
ruaok: done.
2021-04-14 10435, 2021
_lucifer
let's stop the container on leader and send a request from lemmy.
2021-04-14 10437, 2021
ruaok
so the consumer is up and running?
2021-04-14 10445, 2021
ruaok
puurfect.
2021-04-14 10445, 2021
_lucifer
yes.
2021-04-14 10458, 2021
ruaok
I guess start by importing a data dump?
2021-04-14 10409, 2021
_lucifer
yup let's do that
2021-04-14 10436, 2021
ruaok
I'll let you do that, I'm still buried in biz dev nonsense.
2021-04-14 10419, 2021
_lucifer
š
2021-04-14 10415, 2021
_lucifer
akshaaatt[m]: sure, let's do it sometime later this week. i'll ping you once I have reviewed your PRs.
2021-04-14 10421, 2021
akshaaatt[m]
<_lucifer "akshaaatt: sure, let's do it som"> Great!
2021-04-14 10422, 2021
_lucifer
huh! leader is named `newleader`. i guess it was always that way and i forgot :p.
bitmap, yvanzo ^ another tiny bug that can't hurt to fix if you have the time to check
2021-04-14 10405, 2021
reosarevok
CatQuest: thanks for finding that one - I guess the guess button for instrument sortnames was broken forever, wonder if before React it just copied it or something...
2021-04-14 10455, 2021
BrainzGit
[musicbrainz-server] reosarevok merged pull request #1850 (masterā¦MBS-11303): MBS-11514 / MBS-11515 / MBS-11516 / MBS-11517: Use React.useContext in more places rather than passing $c around https://github.com/metabrainz/musicbrainz-server/ā¦
2021-04-14 10420, 2021
alastairp
_lucifer: if it's a small question
2021-04-14 10454, 2021
BrainzGit
[musicbrainz-server] reosarevok merged pull request #2062 (masterā¦missing-link-type-id-warning): Fix Catalyst warning: don't try undef linktype id to access $loaded https://github.com/metabrainz/musicbrainz-server/ā¦
but you may want to fix the core issue: origin IP isn't constant it seems
2021-04-14 10425, 2021
zas
I had 94.130.35.211
2021-04-14 10436, 2021
zas
is this IP still valid?
2021-04-14 10404, 2021
_lucifer
i do not know for sure but that IP with 94 might be of the old cluster setup. the IP starting with 136 is of michael where the new setup will be located.