LordSputnik, do you mind if we change object-curly-spacing to always? I find it more readable.
2015-11-19 32308, 2015
LordSputnik
Is it never now?
2015-11-19 32329, 2015
Leftmost
Yeah.
2015-11-19 32359, 2015
LordSputnik
Eww
2015-11-19 32306, 2015
LordSputnik
I guess I could go for always
2015-11-19 32314, 2015
LordSputnik
But I do prefer never
2015-11-19 32303, 2015
Leftmost
Eh, it's bikeshedding.
2015-11-19 32308, 2015
LordSputnik
Should we drop Node 0.12 as a supported version?
2015-11-19 32354, 2015
Leftmost
That's what I was asking about the other day. If we're doing use strict, we can't use const with 0.12.
2015-11-19 32337, 2015
LordSputnik
Yeah, I want to keep using both strict and const
2015-11-19 32335, 2015
Leftmost
As do I. I figure that, since we're the only people using the code right now, dropping 0.12 support isn't a big deal. If anyone else wants to run it down the road, I doubt they'll still be on 0.12.
2015-11-19 32320, 2015
LordSputnik
Yup
2015-11-19 32315, 2015
Leftmost
I'll start working on merging the refactor into direct-database.
2015-11-19 32359, 2015
LordSputnik
Leftmost: OK, don't know if you want to wait until I've merged the RE in a few minutes
2015-11-19 32324, 2015
LordSputnik
Oh, and I didn't see you dropped 0.12 before I asked :P
2015-11-19 32337, 2015
LordSputnik
I wasn't questioning that commit, just suggesting cause I hadn't seen!
Leftmost: no, that's something on the long todo list
2015-11-19 32342, 2015
Leftmost
Any reason it can't go on the short TODO?
2015-11-19 32352, 2015
Leftmost
I can start working on it.
2015-11-19 32308, 2015
Leftmost
It'd help for being able to do things like fetching editor revisions.
2015-11-19 32305, 2015
LordSputnik
Well, any dumped/upgraded DB should have the FKs
2015-11-19 32320, 2015
LordSputnik
It's only for "from-scratch" DBs that there are no FKs (so for testing)
2015-11-19 32319, 2015
LordSputnik
That's why it wasn't a priority, but you can sort it out if you like, shouldn't be a huge task, just a case of going through the -schema models and adding to the scripts/create_foreign_keys.sql file
I filed an issue with lodash for their compounder functions breaking 2b into two separate chunks. We'll see what they say.
2015-11-19 32352, 2015
LordSputnik
For the language iso codes?
2015-11-19 32310, 2015
Leftmost
Yeah. It seems like odd behavior to me to break it apart that way.
2015-11-19 32332, 2015
LordSputnik
I had tons of problems with those fields previously
2015-11-19 32350, 2015
LordSputnik
eg. isoCode2b would get converted to iso_code2b
2015-11-19 32357, 2015
Leftmost
Yeah, I think we're going to have to do a certain degree of mucking about regardless.
2015-11-19 32358, 2015
LordSputnik
I have a feeling I updated the conversion functions for language specifically to deal with that
2015-11-19 32355, 2015
LordSputnik
Haha, new RE has 200+ ES6/style errors
2015-11-19 32314, 2015
Leftmost
Yeah, there's a special format function. For now, I'll fix that up and put in a special parse function as well.
2015-11-19 32346, 2015
LordSputnik
I didn't previously need a special parse function
2015-11-19 32310, 2015
LordSputnik
Because iso_code_2b goes correctly to isoCode2b (unless it's a temp fix for lodash)
2015-11-19 32326, 2015
Leftmost
It's a temp fix for lodash, especially since the issue I just filed was closed as fixed in master.
2015-11-19 32344, 2015
Leftmost
(lodash has _zero_ open issues. What the eff.)
2015-11-19 32324, 2015
LordSputnik
Oh, they apparently have a fix somewhere else
2015-11-19 32307, 2015
LordSputnik
Ah, I think it might've been fixed since the last lodash version, perhaps?
2015-11-19 32326, 2015
Leftmost
Yes.
2015-11-19 32349, 2015
LordSputnik
0 open issues is quite impressive
2015-11-19 32310, 2015
LordSputnik
Makes me even happier to be using it
2015-11-19 32348, 2015
Leftmost
Anyhow, ping me when the RE PR is ready for review. I'm thinking that once it's pulled we should do some testing and release so we can focus on finishing up the -data-js migration. Seem reasonable?
2015-11-19 32346, 2015
LordSputnik
Yeah, I'll have to go once the RE PR is ready, perhaps you could update beta to the latest master? Then we can have that up for testing until Monday and do the proper release then?
2015-11-19 32337, 2015
Leftmost
Okay. That's on rika, right?
2015-11-19 32300, 2015
Freso
bitmap, around and do you have @metabrainz admin access? Can you give me push permission to @meb/metabrainz-logos?
2015-11-19 32312, 2015
LordSputnik
Leftmost: Yup, you should be able to see the BookBrainz startup doc in Google Drive, I've written down the steps there cause I always used to have to make it up as I went along
2015-11-19 32313, 2015
Leftmost
Cool, thanks.
2015-11-19 32321, 2015
Freso
LordSputnik Leftmost, FWIW, I don't think you should bother much with backwards compatibility for now. BB is very much a moving target right now, so you may as well go with the newest/most convenient available, and then once the dust is settling, you can set a minimum version based on that. No need to artificially limiting yourself at this stage.
2015-11-19 32303, 2015
LordSputnik
Freso: yup, good advice. I think the 0.12 testing was more of a "Oh, let's see how far back all this new stuff works" experiment
2015-11-19 32340, 2015
LordSputnik
I don't think we're using anything *bleeding* edge right now, so anything higher than Node 4 should work for the forseeable future
2015-11-19 32359, 2015
Freso
Bleeding edge is best edge though. <3
2015-11-19 32317, 2015
Freso
<3'? How would you make a bleeding heart? :p
2015-11-19 32326, 2015
LordSputnik
I've tried, not possible without going multi-line :(
