Though, by and large, I'd recommend against force-pushing.
2015-12-12 34634, 2015
stanislas
Leftmost: what would be the alternative ?
2015-12-12 34614, 2015
Gentlecat
should be fine on feature branches if you are the only one working on it
2015-12-12 34626, 2015
Techtronix has quit
2015-12-12 34633, 2015
Gentlecat
but definitely not on master, beta, etc. unless something really bad happened
2015-12-12 34602, 2015
Leftmost
stanislas, in this case it's probably fine, but force-pushing destroys history and can cause problems for other people using the branch, so if you're on a shared repo, it should be avoided.
2015-12-12 34654, 2015
Leo_Verto has quit
2015-12-12 34650, 2015
stanislas
Leftmost, Gentlecat: Don't worry. After deleting my whole system once, i am seriously rethinking doing every command with sudo or --force :) I've made a local copy before.
2015-12-12 34609, 2015
UmkaDK_ joined the channel
2015-12-12 34614, 2015
UmkaDK has quit
2015-12-12 34619, 2015
Gentlecat
there's usually a way to recover, but don't get to that point
2015-12-12 34640, 2015
The_Catman
stanislas, don't tell me you fell for "sudo rm -rf /"?
2015-12-12 34605, 2015
stanislas
it was apt-get, and i placed * in the wrong place
2015-12-12 34616, 2015
Leftmost
Eek.
2015-12-12 34626, 2015
The_Catman
wow
2015-12-12 34605, 2015
Ramswaroop_ has quit
2015-12-12 34611, 2015
svineet joined the channel
2015-12-12 34613, 2015
stanislas
Gentlecat: it closed itself
2015-12-12 34611, 2015
stanislas
Gentlecat: because tabulations showed different on my computer and in github i had to force push about 6 times
2015-12-12 34625, 2015
stanislas
Gentlecat: I hope it is ok now.
2015-12-12 34648, 2015
stanislas
Gentlecat: i've seen your comments and solved new issues
2015-12-12 34630, 2015
ruaok
zas: search is borked. I'm on it.
2015-12-12 34647, 2015
CallerNo6
did the text in the wiki get smaller? stupid old age, <grumble grumble>
CB: Add link to Cover Art Archive on artist and release group pages || 3 days || Code, User Interface || MetaBrainz Foundation || Currently claimed
2015-12-12 34630, 2015
Gentlecat
because right now I can't approve it
2015-12-12 34643, 2015
stanislas
GentleCat: of course
2015-12-12 34631, 2015
stanislas
GentleCat: i just don't like situations that looks like this : 1.submit, 2.more work, 3. submit, 4. more work, 5 ...
2015-12-12 34637, 2015
stanislas
*look
2015-12-12 34627, 2015
Gentlecat
I'm not the one who designed GCI website :)
2015-12-12 34646, 2015
Leftmost
That's how a lot of code reviews look anyhow.
2015-12-12 34635, 2015
stanislas
Gentlecat: But i should aspire to 1.submit 2.accepted :)
2015-12-12 34659, 2015
Gentlecat
see Leftmost's comment
2015-12-12 34649, 2015
Leftmost
You should always aspire to that, but I've been coding since I was a wee lad and I still don't get there. :)
2015-12-12 34614, 2015
opatel99
My tasks are pretty much that... Submit... more work. Rinse. Repeat
2015-12-12 34658, 2015
stanislas
Gentlecat: Where ?
2015-12-12 34630, 2015
Gentlecat
all over the place, really
2015-12-12 34654, 2015
stanislas
Gentlecat: really sorry, but i have no idea what particular comment you are talking about
2015-12-12 34600, 2015
stanislas
Gentlecat: :)
2015-12-12 34636, 2015
reosarevok
"That's how a lot of code reviews look anyhow."
2015-12-12 34640, 2015
stanislas
got it
2015-12-12 34609, 2015
opatel99 has quit
2015-12-12 34633, 2015
stanislas
i thought that Leftmost left some additional comment on github or on gci page :)
2015-12-12 34602, 2015
stanislas
which might be crucial to my task
2015-12-12 34613, 2015
svineet has quit
2015-12-12 34628, 2015
regagain_ joined the channel
2015-12-12 34630, 2015
yeeeargh has quit
2015-12-12 34615, 2015
regagain_ has quit
2015-12-12 34636, 2015
bsammon joined the channel
2015-12-12 34603, 2015
opatel99 joined the channel
2015-12-12 34631, 2015
bsammon has quit
2015-12-12 34610, 2015
Freso
"stanislas | GentleCat: i just don't like situations that looks like this : 1.submit, 2.more work, 3. submit, 4. more work, 5 ..." -- so wait with your first (or second, following a "more work") submission until you've got the "go ahead" in the PR.
2015-12-12 34612, 2015
stanislas
Freso: that's actually a good idea :)
2015-12-12 34647, 2015
Freso
And if it looks like you're about to run out of time, we're at least 7 admins who can extend your deadline, and maybe the "mortal" mentors can too.
2015-12-12 34616, 2015
Freso
So just give us a heads up. (I try to keep my eye on task instances that are about to expire, but it's better to double check. :))
2015-12-12 34651, 2015
stanislas
Freso: thanks for help
2015-12-12 34606, 2015
stanislas
Leftmost, LordSputnik: I've done my second calibre plugin (the one about BBID search). What do you think ?
but it work for 32f78c16-39d0-4595-afe0-974f89dd71ad
2015-12-12 34619, 2015
stanislas
:)
2015-12-12 34629, 2015
LordSputnik
stanislas: OK, got it working for hobbit as you say - it would be good if we could close the window when the data is applied
2015-12-12 34642, 2015
stanislas
why ?
2015-12-12 34612, 2015
stanislas
you can still change text to search and mark another book
2015-12-12 34634, 2015
LordSputnik
OK, in that case, display something so thatSo that the user knows that something has happened
2015-12-12 34653, 2015
LordSputnik
err, ... "so that the user knows something has happened"
2015-12-12 34613, 2015
LordSputnik
At the moment, I pressed "Apply" but didn't see much going on until I looked at the book itself
2015-12-12 34641, 2015
stanislas
I was even thinking about adding a progress bar, users like that
2015-12-12 34625, 2015
LordSputnik
Perhaps a popup dialog saying "Metadata applied" would be best in this case?
2015-12-12 34628, 2015
stanislas
This one would be easier than adding a progress bar
2015-12-12 34634, 2015
stanislas
which one do you prefer ?
2015-12-12 34636, 2015
opatel99 has quit
2015-12-12 34634, 2015
Leo_Verto joined the channel
2015-12-12 34623, 2015
LordSputnik
stanislas: I don't think we have enough information to do a good progress bar
2015-12-12 34607, 2015
opatel99 joined the channel
2015-12-12 34615, 2015
opatel99
Perhaps a spinner ^
2015-12-12 34616, 2015
stanislas
I am looking in sequence for title, author, language, ... publisher (something like that)
2015-12-12 34612, 2015
stanislas
I can change the progress bar after each of these
2015-12-12 34657, 2015
LordSputnik
Ahhh OK, then yes, a progress bar would make sense for fetching data, and a dialog for applying
2015-12-12 34635, 2015
stanislas
LordSputnik: you mean to show to user some other dialog with the changes i want to make ?
2015-12-12 34606, 2015
stanislas
opatel99: do you know any spinner in pyQt5 ?
2015-12-12 34609, 2015
LordSputnik
stanislas: actually, that's a good idea - show the current metadata vs the new metaata and get the user to confirm
2015-12-12 34635, 2015
stanislas
I think that's doable
2015-12-12 34600, 2015
stanislas
And should i do that in the same Dialog ?
2015-12-12 34628, 2015
Freso
stanislas: I may need some help. :) I could never get your first Calibre plugin to work at all, I think.
2015-12-12 34646, 2015
Freso tries to update as well as fetch the new one
2015-12-12 34617, 2015
stanislas
LordSputnik: I've some other idea, i can show to user his metadata and my actual metadata as i am downloading it and then make a button 'apply'
2015-12-12 34633, 2015
stanislas
it wouldn't require a progress bar
2015-12-12 34651, 2015
stanislas
Freso : The first one ?
2015-12-12 34614, 2015
stanislas
Freso : how have you tried to install it?
2015-12-12 34630, 2015
stanislas
like this : calibre -a CalibreBookBrainzPlugin_v1.0.0.zip ?
2015-12-12 34655, 2015
Freso
stanislas: No, via the GUI.
2015-12-12 34627, 2015
stanislas
it can be done using GUI :) ?
2015-12-12 34630, 2015
Freso
Settings → Plugins → Install plugin from file
2015-12-12 34651, 2015
stanislas
and you provided .zip ?
2015-12-12 34653, 2015
Freso
(Wording might be slightly different: I'm using a translation. :))
2015-12-12 34655, 2015
Freso
Yes.
2015-12-12 34614, 2015
stanislas
from release or from "download zip" button on githyb
2015-12-12 34621, 2015
Freso
I can see it in the list as being installed.
2015-12-12 34633, 2015
Freso
From cloning the repository and .zip'ing it up myself. ;)
2015-12-12 34654, 2015
stanislas
Freso: and you don't see the shortcut ?
2015-12-12 34605, 2015
Freso
stanislas: No. But I'm also not sure where I should be looking.
2015-12-12 34612, 2015
stanislas
Freso: because you shouldn't
2015-12-12 34627, 2015
stanislas
Freso: it is not possible to automatically add it
2015-12-12 34639, 2015
Freso
Yeah. So how do I confirm that the plugin is working?
2015-12-12 34655, 2015
Freso
(Same for BBID one now. :))
2015-12-12 34656, 2015
stanislas
Freso: you should add it via preferences->toolbar
2015-12-12 34610, 2015
stanislas
->main bar
2015-12-12 34636, 2015
stanislas
i also use some other translation than english, so it might be slightly different
2015-12-12 34652, 2015
Freso
Yeah, I've been there, but I don't see anything that says anything "BookBrainz".
2015-12-12 34607, 2015
Freso
Or has the BB icon.
2015-12-12 34631, 2015
stanislas
in fact, i didn't even got to this
2015-12-12 34646, 2015
stanislas
when i try to add it using gui it says that The plugin in u'/home/stas/Pobrane/CalibreBookBrainzPlugin-master.zip' is invalid. It does not contain a top-level __init__.py file
2015-12-12 34655, 2015
stanislas
which i am sure it does
2015-12-12 34607, 2015
stanislas
i can ask about it on calibre dev forums tomorow
2015-12-12 34607, 2015
Freso
That's because you're using the GitHub download.
2015-12-12 34619, 2015
Freso
Which has all the files stored in a folder inside the .zip.
2015-12-12 34634, 2015
stanislas
ah, that may be true
2015-12-12 34647, 2015
Freso
(So the __init__.py is at CalibreBookBrainzPlugin-master.zip/CalibreBookBrainzPlugin/__init__.py)
2015-12-12 34621, 2015
Freso
But as I said, I .zip'd it up myself to avoid this (it wouldn't even install using the GH d/l).
2015-12-12 34631, 2015
stanislas
i am pretty sure what's happeniing
2015-12-12 34607, 2015
stanislas
my old plugin doesn't work on the newest version of calibre, which i've learned today from the creator of calibre
