#metabrainz

/

      • opatel99
        bitmap: Is there something I am missing from Lock? Something in the code perhaps?
      • 2015-12-19 35358, 2015

      • opatel99
        Do I have to do Read Lock?
      • 2015-12-19 35335, 2015

      • Nyanko-sensei has quit
      • 2015-12-19 35336, 2015

      • bitmap
        what's the problem with it right now? I'm not sure what to look for
      • 2015-12-19 35354, 2015

      • opatel99
        Just doesnt cluster all the files
      • 2015-12-19 35332, 2015

      • bitmap
        it might help if I could see a diff of the branch against master
      • 2015-12-19 35343, 2015

      • opatel99
        ok
      • 2015-12-19 35357, 2015

      • bitmap
        maybe push the branch to github
      • 2015-12-19 35310, 2015

      • opatel99
        ok
      • 2015-12-19 35303, 2015

      • opatel99
      • 2015-12-19 35329, 2015

      • opatel99
        bitmap ^
      • 2015-12-19 35338, 2015

      • bitmap
        yup, looking
      • 2015-12-19 35307, 2015

      • Bookzombie
        LordSputnik pushed 2 commits to bookbrainz-data-js: https://github.com/bookbrainz/bookbrainz-data-js/…
      • 2015-12-19 35306, 2015

      • bitmap
        is there a reason you're not just doing self.count_dir.int == self.total_dir.int
      • 2015-12-19 35309, 2015

      • bitmap
        ?
      • 2015-12-19 35316, 2015

      • bitmap
        the len(set(dir_progress)) == 1: thing is confusing
      • 2015-12-19 35300, 2015

      • opatel99
        bitmap: That makes more sense haha. chaging
      • 2015-12-19 35337, 2015

      • opatel99
        cahnged for file too
      • 2015-12-19 35305, 2015

      • opatel99
        Now there was a reason. Maximum recursion depth hit
      • 2015-12-19 35328, 2015

      • opatel99
        It is virtually the same thing however. Just checks if both of them are the same
      • 2015-12-19 35319, 2015

      • bitmap
        how is max recursion depth hit?
      • 2015-12-19 35325, 2015

      • Nyanko-sensei joined the channel
      • 2015-12-19 35309, 2015

      • bitmap
        let me run the code to see what's going on
      • 2015-12-19 35314, 2015

      • opatel99
        ok
      • 2015-12-19 35324, 2015

      • opatel99
        send it or you got the chnge?
      • 2015-12-19 35300, 2015

      • bitmap
      • 2015-12-19 35304, 2015

      • opatel99
        ok
      • 2015-12-19 35326, 2015

      • JonnyJD has quit
      • 2015-12-19 35316, 2015

      • ruaok
        Discourse. :-)
      • 2015-12-19 35336, 2015

      • triggerwarning joined the channel
      • 2015-12-19 35307, 2015

      • triggerwarning has quit
      • 2015-12-19 35307, 2015

      • triggerwarning joined the channel
      • 2015-12-19 35306, 2015

      • zas
        basic setup done, remaining things: setup S3 account for backup
      • 2015-12-19 35320, 2015

      • bitmap
        opatel99: oh, I can't enable the setting without the full branch, I guess
      • 2015-12-19 35326, 2015

      • zas
        configuration (logos, titles, etc...)
      • 2015-12-19 35353, 2015

      • zas
        see if we can import old forums
      • 2015-12-19 35300, 2015

      • opatel99
        bitm let me push
      • 2015-12-19 35331, 2015

      • zas
        many import scripts exist, but we'll only know if they work for us when we'll try
      • 2015-12-19 35354, 2015

      • zas
        i'll set up a parallel install of discourse for import tests
      • 2015-12-19 35356, 2015

      • opatel99
        bitmap: pushed to pull request
      • 2015-12-19 35316, 2015

      • bitmap
        ok
      • 2015-12-19 35327, 2015

      • opatel99
      • 2015-12-19 35332, 2015

      • bitmap
        do I need a really big folder for it to break?
      • 2015-12-19 35314, 2015

      • bitmap gets his external hd
      • 2015-12-19 35309, 2015

      • bitmap
        ok, now it breaks
      • 2015-12-19 35305, 2015

      • D4RK-PH0ENiX has quit
      • 2015-12-19 35303, 2015

      • bitmap
        I see at least one issue in the code
      • 2015-12-19 35332, 2015

      • bitmap
      • 2015-12-19 35309, 2015

      • bitmap
        there's no guarantee that self.count_file.int on the next line is what you incremented it to
      • 2015-12-19 35339, 2015

      • bitmap
        you should have the increment method return that value if it's important
      • 2015-12-19 35331, 2015

      • IGLC joined the channel
      • 2015-12-19 35316, 2015

      • bitmap
        also, setting count_file on the instance seems wrong, if it's only applicable to the new_files in that function
      • 2015-12-19 35358, 2015

      • bitmap
        a different thread could easily be reading from the self.count_file you assigned from another
      • 2015-12-19 35308, 2015

      • ruaok goes to fix #search
      • 2015-12-19 35321, 2015

      • chirlu`
        zas: Edits for subscribed editors page should be working on beta now.
      • 2015-12-19 35358, 2015

      • ariscop joined the channel
      • 2015-12-19 35334, 2015

      • D4RK-PH0ENiX joined the channel
      • 2015-12-19 35335, 2015

      • Nyanko-sensei has quit
      • 2015-12-19 35352, 2015

      • Leo_Verto has quit
      • 2015-12-19 35342, 2015

      • Nyanko-sensei joined the channel
      • 2015-12-19 35346, 2015

      • D4RK-PH0ENiX has quit
      • 2015-12-19 35311, 2015

      • oliverl_ has quit
      • 2015-12-19 35346, 2015

      • Bookzombie
        LordSputnik pushed 1 commits to bookbrainz-data-js: https://github.com/bookbrainz/bookbrainz-data-js/…
      • 2015-12-19 35356, 2015

      • Bookzombie
        LordSputnik pushed 1 commits to bookbrainz-data-js: https://github.com/bookbrainz/bookbrainz-data-js/…
      • 2015-12-19 35320, 2015

      • Leftmost
        LordSputnik, might wanna touch the copyright header in the files you added. :)
      • 2015-12-19 35302, 2015

      • Lotheric has quit
      • 2015-12-19 35349, 2015

      • Lotheric joined the channel
      • 2015-12-19 35323, 2015

      • opatel99
        bitmap: Sorry my internet died.
      • 2015-12-19 35347, 2015

      • xtifr joined the channel
      • 2015-12-19 35336, 2015

      • bitmap
        opatel99, wb
      • 2015-12-19 35359, 2015

      • opatel99
        wb?
      • 2015-12-19 35312, 2015

      • Leftmost
        Welcome back.
      • 2015-12-19 35320, 2015

      • opatel99
        Oh haha
      • 2015-12-19 35302, 2015

      • opatel99
        So this lock thing. Hair loss level? Or am I making it hard on myself?
      • 2015-12-19 35357, 2015

      • D4RK-PH0ENiX joined the channel
      • 2015-12-19 35323, 2015

      • Nyanko-sensei has quit
      • 2015-12-19 35315, 2015

      • bitmap
        I don't think I would've reccomended publishing this as a GCI task :)
      • 2015-12-19 35347, 2015

      • bitmap
        recommended?
      • 2015-12-19 35312, 2015

      • opatel99
        why?
      • 2015-12-19 35335, 2015

      • Leftmost
        Recommended, yes.
      • 2015-12-19 35300, 2015

      • bitmap
        too hairy, I guess
      • 2015-12-19 35313, 2015

      • Leftmost
        (Nice mnemonic: related to "commend".)
      • 2015-12-19 35346, 2015

      • opatel99
        bitmap: What do I do haha
      • 2015-12-19 35334, 2015

      • opatel99
        What if I delay lookup until the end too? The album art is really hogging threads
      • 2015-12-19 35343, 2015

      • bitmap
        I'll try to think if there's a simpler approach. this counter stuff doesn't seem like a good idea
      • 2015-12-19 35359, 2015

      • opatel99
        bitmap: This is my 6th day on this :/
      • 2015-12-19 35309, 2015

      • opatel99
        7th now my bad.
      • 2015-12-19 35346, 2015

      • opatel99
        bitmap: Would coming back to this task be petty?
      • 2015-12-19 35352, 2015

      • opatel99
        When 3-5 hours turns into 20plus hours, I start to get worried. ^
      • 2015-12-19 35345, 2015

      • bitmap
        yeah, idk, it might take me longer than 3-5 hours to fix too
      • 2015-12-19 35346, 2015

      • opatel99
        bitmap: You want to test out a tagger.py? :)
      • 2015-12-19 35352, 2015

      • bitmap
        I'm not a mentor for this task, though, so I'll refrain from discouraging you any further until Mineo reappears :P
      • 2015-12-19 35310, 2015

      • bitmap
        I coudl test, sure
      • 2015-12-19 35337, 2015

      • opatel99
        Oh no. I want to finish this. I really do. I just need my Mineo to guide me :). No school tomorrow, so I can stay awake until 3am when he is awake.
      • 2015-12-19 35347, 2015

      • opatel99
      • 2015-12-19 35344, 2015

      • bitmap
        it stopped at [359, 490] for me
      • 2015-12-19 35358, 2015

      • bitmap
        with 4440 unmatched files left
      • 2015-12-19 35345, 2015

      • chirlu`
        bitmap: What is the Redis version that’s running on teto?
      • 2015-12-19 35318, 2015

      • bitmap
        Version: 2:2.2.12-1build1
      • 2015-12-19 35312, 2015

      • chirlu`
        Thanks.
      • 2015-12-19 35338, 2015

      • opatel99
        bitmap: Do you see anything blatantly wrong?
      • 2015-12-19 35322, 2015

      • bitmap
        I'm sort of confused becuase I thought add_files and _file_loaded always ran in the main GUI thread anyway
      • 2015-12-19 35312, 2015

      • opatel99
        I have tried ... 47 ways to approach this. None of them fully work.
      • 2015-12-19 35335, 2015

      • opatel99
        My closest one was when Mineo only had 1 file load without metadata
      • 2015-12-19 35300, 2015

      • opatel99
        and another was when Mineo said it worked, but I had too many variables.
      • 2015-12-19 35326, 2015

      • bitmap
        well, do you still have the version that worked?
      • 2015-12-19 35327, 2015

      • opatel99
        I can taste the success, just cant savour it yet
      • 2015-12-19 35330, 2015

      • opatel99
        Yeah
      • 2015-12-19 35329, 2015

      • opatel99
        bitmap: I believe this was the one with too much mess
      • 2015-12-19 35331, 2015

      • opatel99
      • 2015-12-19 35310, 2015

      • opatel99
        and this was the one with some minor success: https://gist.github.com/anonymous/40060d5c71ffb59…
      • 2015-12-19 35341, 2015

      • bitmap
        well the first one still left 3333 unmatched files for me
      • 2015-12-19 35355, 2015

      • bitmap
        which I had to cluster manually
      • 2015-12-19 35328, 2015

      • opatel99
        bitmap: I am a mess
      • 2015-12-19 35354, 2015

      • opatel99
        bitmap: How did the second fare?
      • 2015-12-19 35313, 2015

      • bitmap
        one sec
      • 2015-12-19 35350, 2015

      • bitmap
        not finished yet, but...it appears to be working much better, if you ignore the maximum recursion depth errors
      • 2015-12-19 35333, 2015

      • bitmap
        yeah, looks like it got all the files this time
      • 2015-12-19 35343, 2015

      • opatel99
        So...should I take off from there?
      • 2015-12-19 35350, 2015

      • bitmap
        I'd probably start from there and figure out why calling self.cluster within _file_loaded is bad
      • 2015-12-19 35334, 2015

      • bitmap
        I guess this might be something you already talked to Mineo about, though
      • 2015-12-19 35306, 2015

      • bitmap has a strong suspicion it has to do with QtCore.QCoreApplication.processEvents()
      • 2015-12-19 35333, 2015

      • Nyanko-sensei joined the channel
      • 2015-12-19 35341, 2015

      • opatel99
        bitmap: Are you referring to
      • 2015-12-19 35359, 2015

      • opatel99
      • 2015-12-19 35342, 2015

      • bitmap
        that's not the exact error I get, but it's a symptom of the same cause
      • 2015-12-19 35314, 2015

      • D4RK-PH0ENiX has quit
      • 2015-12-19 35301, 2015

      • D4RK-PH0ENiX joined the channel
      • 2015-12-19 35308, 2015

      • typhoe has quit
      • 2015-12-19 35326, 2015

      • D4RK-PH0ENiX has quit
      • 2015-12-19 35305, 2015

      • typhoe joined the channel
      • 2015-12-19 35303, 2015

      • opatel99
        What would be your approach bitmap ?
      • 2015-12-19 35314, 2015

      • bitmap
        hmm
      • 2015-12-19 35352, 2015

      • bitmap
        this isn't a good solution, but I'd try seeing if it works after removing QtCore.QCoreApplication.processEvents()
      • 2015-12-19 35301, 2015

      • bitmap
        in def cluster
      • 2015-12-19 35301, 2015

      • bitmap
        I have a feeling that that's modifying stuff in the same thread we're working in
      • 2015-12-19 35307, 2015

      • Bookzombie has quit
      • 2015-12-19 35325, 2015

      • Bookzombie joined the channel
      • 2015-12-19 35356, 2015

      • xtifr has left the channel
      • 2015-12-19 35307, 2015

      • opatel99
        bitmap: I just tried that. Lots of unmatched files
      • 2015-12-19 35347, 2015

      • opatel99
        and still got that loopdy loop
      • 2015-12-19 35357, 2015

      • bitmap
        ah :/
      • 2015-12-19 35337, 2015

      • opatel99
        Can you try
      • 2015-12-19 35340, 2015

      • opatel99
      • 2015-12-19 35347, 2015

      • opatel99
        I wont bother you much after this.
      • 2015-12-19 35359, 2015

      • bitmap
        sure
      • 2015-12-19 35300, 2015

      • bitmap
        well, on first try it clustered everything without any errors :o
      • 2015-12-19 35310, 2015

      • opatel99
        bitmap: Praise?
      • 2015-12-19 35349, 2015

      • bitmap
        did it work for you, too?
      • 2015-12-19 35320, 2015

      • opatel99
        bitmap: yep. 2 files unmatched, but that may just be the clustering technique