Leftmost: LordSputnik Trying to change the select2 component to match Flatly
2015-12-21 35546, 2015
typhoe has quit
2015-12-21 35521, 2015
typhoe joined the channel
2015-12-21 35517, 2015
Nyanko-sensei joined the channel
2015-12-21 35547, 2015
d4rkie has quit
2015-12-21 35506, 2015
rahulr
Shouldn't there be python2 instead of python in shebang of tagger?
2015-12-21 35502, 2015
opatel99
rahulr: Just use venv to make python2 the default for that directory
2015-12-21 35544, 2015
ariscop joined the channel
2015-12-21 35518, 2015
rahulr
Yeah. But why not mention it explicitly?
2015-12-21 35559, 2015
D4RK-PH0ENiX has quit
2015-12-21 35528, 2015
reosarevok
ruaok: someone wants to give us money on support, please help them do so ;)
2015-12-21 35538, 2015
reosarevok
(I don't know the answers)
2015-12-21 35548, 2015
Leo_Verto has quit
2015-12-21 35524, 2015
JonnyJD joined the channel
2015-12-21 35505, 2015
D4RK-PH0ENiX joined the channel
2015-12-21 35532, 2015
Nyanko-sensei has quit
2015-12-21 35510, 2015
triggerwarning joined the channel
2015-12-21 35532, 2015
dcentral joined the channel
2015-12-21 35510, 2015
ariscop_ joined the channel
2015-12-21 35518, 2015
triggerwarning has quit
2015-12-21 35522, 2015
ariscop has quit
2015-12-21 35550, 2015
chirlu`
Do we know that ETags are broken?
2015-12-21 35524, 2015
ariscop_ has quit
2015-12-21 35510, 2015
regagain joined the channel
2015-12-21 35516, 2015
JonnyJD has quit
2015-12-21 35533, 2015
ariscop joined the channel
2015-12-21 35530, 2015
Leftmost
rahulr, it's likely just outdated and could be changed.
2015-12-21 35549, 2015
Leftmost
opatel99, don't spend too much time on it. If you can't make it work, we'll suffer through.
2015-12-21 35506, 2015
regagain has quit
2015-12-21 35534, 2015
opatel99
Leftmost: I got it!
2015-12-21 35539, 2015
opatel99
Leftmost: Is it okay to just change the select2bootstrap.css
2015-12-21 35516, 2015
opatel99
Because this is a universal change for a theme
2015-12-21 35558, 2015
Leftmost
If it's a change that's appropriate for the upstream select2-bootstrap-theme project, I'd make a pull request there and note it in your submission materials for the task. If it's not appropriate for upstream, I'd suggest making a new file and including it in the stylesheets section of our templates after select2-bootstrap.css.
2015-12-21 35523, 2015
opatel99
Leftmost: What if it is a flatly compatible version of select2?
2015-12-21 35538, 2015
Leftmost
Well, if the change makes select2-bootstrap-theme more compatible in general, it should probably go upstream. If it would break compatibility for select2-bootstrap-theme in some places, it should probably go in our repo for now.
2015-12-21 35538, 2015
opatel99
Leftmost: The change is not more compatible in general, but only applicable for usage with the flatly theme. I think you are right in just keeping it as a local port
2015-12-21 35515, 2015
Leftmost
LordSputnik, heads up: I'd like to explore what we would need a custom react select component to do and whether it would be feasible to write and maintain our own. ("This isn't feasible" is a perfectly acceptable conclusion, but maintaining select2 is getting to be a chore in and of itself and there are a bunch of places where its current functionality seems unintuitive to me.)
2015-12-21 35547, 2015
Leftmost
It's obviously not my highest priority. Just want to think seriously about it while we work on making -data-js all nice.
2015-12-21 35503, 2015
opatel99
Leftmost: Can you check the styling?
2015-12-21 35520, 2015
rahulr has quit
2015-12-21 35536, 2015
Nyanko-sensei joined the channel
2015-12-21 35503, 2015
rahulr joined the channel
2015-12-21 35558, 2015
D4RK-PH0ENiX has quit
2015-12-21 35557, 2015
kepstin_ joined the channel
2015-12-21 35513, 2015
warp_ joined the channel
2015-12-21 35509, 2015
moufl joined the channel
2015-12-21 35555, 2015
dom96 has quit
2015-12-21 35555, 2015
inversechi has quit
2015-12-21 35555, 2015
_5moufl has quit
2015-12-21 35555, 2015
kuno has quit
2015-12-21 35556, 2015
kepstin has quit
2015-12-21 35503, 2015
warp_ is now known as kuno
2015-12-21 35506, 2015
moufl is now known as _5moufl
2015-12-21 35546, 2015
inversechi joined the channel
2015-12-21 35550, 2015
kepstin_ is now known as kepstin
2015-12-21 35514, 2015
dom96 joined the channel
2015-12-21 35556, 2015
djinni`_ joined the channel
2015-12-21 35534, 2015
_spuniun joined the channel
2015-12-21 35509, 2015
zag joined the channel
2015-12-21 35518, 2015
Leftmost
opatel99, I need to run for now. I'll have a look in the morning. Ping me with the link whenever you have a chance.
2015-12-21 35553, 2015
mRokita_ joined the channel
2015-12-21 35534, 2015
YatharthROCK__ joined the channel
2015-12-21 35535, 2015
drsaunder joined the channel
2015-12-21 35547, 2015
opatel99
Leftmost: Okay.. Just submitted the rest of my stuff. Submitting task
2015-12-21 35538, 2015
YatharthROCK__
Leftmost: Saw your comment on the "Ensure all strings are translatable"; had in fact only run my code, not tested — oops! I fixed all errors and warnings my code introduced; had you noticed any other issues with my PR?
