#metabrainz

/

      • reosarevok
        In any case, we did get useful feedback from it, even from people who didn't complete anything else

        • 2015-12-21 35523, 2015

      • reosarevok
        So, not complaining :)

        • 2015-12-21 35555, 2015

      • LordSputnik
        stanislas: just you - I'll add any others who've edited the files later on

        • 2015-12-21 35505, 2015

      • Gentlecat
        qu3ntin0: what if you replace it with "ubuntu/precise64" in Vagrantfile?

        • 2015-12-21 35510, 2015

      • Gentlecat
        https://atlas.hashicorp.com/ubuntu/boxes/precise64

        • 2015-12-21 35530, 2015

      • opatel99
        reosarevok: I would hope that a lot of those people stuck around. Make this more lively... (Not that it isnt already, but the more the merrier)

        • 2015-12-21 35550, 2015

      • reosarevok
        haha. Dunno, I'm fairly happy with how it is a lot of the time :)

        • 2015-12-21 35519, 2015

      • Gentlecat
        opatel99: because you have a typo? `@@release_bp....`

        • 2015-12-21 35519, 2015

      • qu3ntin0
        Gentlecat: i'll see how it goes

        • 2015-12-21 35521, 2015

      • reosarevok
        I mean, it's nice to have people around but if there are four conversations going on at the same time it's a bit chaotic

        • 2015-12-21 35535, 2015

      • reosarevok
        I'm reasonably happy with having a smaller core of pretty active students

        • 2015-12-21 35545, 2015

      • opatel99
        Gentlecat: The paste site added that automatically. Idk why hold on

        • 2015-12-21 35546, 2015

      • stanislas
        LordSputnik: My surname contains 'ś' character, can I include it or should I use just 's'

        • 2015-12-21 35547, 2015

      • stanislas
        ?

        • 2015-12-21 35557, 2015

      • reosarevok
        (I'd like more casual users in #musicbrainz but)

        • 2015-12-21 35504, 2015

      • opatel99
        http://paste.ee/p/OUAlx

        • 2015-12-21 35520, 2015

      • Gentlecat
        also, "why is not working" is pretty vague

        • 2015-12-21 35521, 2015

      • LordSputnik
        stanislas: that should be fine, as long as you're saving with the utf8 encoding

        • 2015-12-21 35531, 2015

      • stanislas
        I am

        • 2015-12-21 35536, 2015

      • LordSputnik
        go for it then :)

        • 2015-12-21 35542, 2015

      • Gentlecat
        I still don't understand what the problem is

        • 2015-12-21 35542, 2015

      • regagain has quit

        • 2015-12-21 35554, 2015

      • opatel99
        Sorry. Error:http://paste.ee/p/AHDqs

        • 2015-12-21 35507, 2015

      • reosarevok
        yay Estonian domain :p

        • 2015-12-21 35509, 2015

      • Gentlecat
        "ValueError: View function did not return a response"

        • 2015-12-21 35517, 2015

      • Gentlecat
        your view doesn't return a response

        • 2015-12-21 35529, 2015

      • opatel99
        Right, but what if I just want to test it. What dummy response could I return

        • 2015-12-21 35551, 2015

      • Gentlecat
        `return "dummy response because I'm testing"`

        • 2015-12-21 35520, 2015

      • Gentlecat
        don't be afraid to try stuff, I'm sure your VM is not going to explode :)

        • 2015-12-21 35534, 2015

      • Gentlecat
        even if it does, you can just create a new one

        • 2015-12-21 35521, 2015

      • opatel99
        yeah.

        • 2015-12-21 35549, 2015

      • Freso
        reosarevok: Cheers. :)

        • 2015-12-21 35513, 2015

      • Freso
        opatel99: Because you don't see all the participants in here. :)

        • 2015-12-21 35517, 2015

      • Freso
        Unfortunately.

        • 2015-12-21 35549, 2015

      • opatel99
        Freso: A beginner task should have been to get involved on IRC

        • 2015-12-21 35507, 2015

      • stanislas
        LordSputnik: It should be ok now.

        • 2015-12-21 35519, 2015

      • Freso
        opatel99: Feel free to write up a suggestion for a beginner task and I'll look at it. ;)

        • 2015-12-21 35545, 2015

      • reosarevok
        Yeah, I guess there's still time for that even this year - I was going to say it was a decent idea for next year but

        • 2015-12-21 35518, 2015

      • Freso
        reosarevok: Yep. I didn't say I wouldn't add it this year. ;)

        • 2015-12-21 35521, 2015

      • reosarevok
        I'd be a bit wary of annoying the usual users with a lot of "Hi I am X from Y and I'm a GCI student" btut still

        • 2015-12-21 35533, 2015

      • Freso
        Yeah, that's my concern too.

        • 2015-12-21 35531, 2015

      • opatel99
        Well my experience that once I tried the chat, I was addicted

        • 2015-12-21 35533, 2015

      • Freso
        I wanted to extend the create a MusicBrainz account with posting a link to that as well as a welcome message in a thread on the forum/Discourse, but didn't want to do that until Discourse was operational.

        • 2015-12-21 35540, 2015

      • Freso
        opatel99: :)

        • 2015-12-21 35553, 2015

      • stanislas
        LordSputnik: My pep8 doesn't warn me about anything in these files now, strange.

        • 2015-12-21 35503, 2015

      • stanislas
        I've enabled all warnings

        • 2015-12-21 35515, 2015

      • LordSputnik
        stanislas: hmm that is odd

        • 2015-12-21 35537, 2015

      • opatel99
        So we can have that beginner task just be: spend 2 days in the chat room and participate in some discussions. Once submitted, mentor can check the logs to see what participation was done

        • 2015-12-21 35537, 2015

      • LordSputnik
        Don't worry then, just make a pull request to the main repository and we can close the task

        • 2015-12-21 35559, 2015

      • stanislas
        I am using pep8 from PyCharm, maybe command-line one is better.

        • 2015-12-21 35527, 2015

      • opatel99
        I usually use command line once introduced to it. Soemtimes for a quick check, http://pep8online.com/

        • 2015-12-21 35549, 2015

      • stanislas
        LordSputnik: Ok, seeing it now.

        • 2015-12-21 35527, 2015

      • opatel99
        Is 4d1e6020-324d-4e8c-af1d-c7a2525a15ee a valid release?

        • 2015-12-21 35509, 2015

      • reosarevok
        heh

        • 2015-12-21 35521, 2015

      • opatel99
        oh nvm that is release-group

        • 2015-12-21 35530, 2015

      • reosarevok
        Is there a ticket already for the URLs making the page too large instead of wrapping? https://beta.musicbrainz.org/release/818cea9f-f6c…

        • 2015-12-21 35500, 2015

      • opatel99
        reosarevok: Is that just setting a max-width on that container?

        • 2015-12-21 35508, 2015

      • reosarevok
        I dunno :)

        • 2015-12-21 35543, 2015

      • reosarevok
        That's a question for bitmap probably, in any case not for me - I haven't touched our css :)

        • 2015-12-21 35556, 2015

      • reosarevok
        But it does feel a bit silly

        • 2015-12-21 35501, 2015

      • stanislas
        LordSputnik: And do you have any objections to my tests :) ?

        • 2015-12-21 35506, 2015

      • reosarevok
        Anyway, time for me to sleep

        • 2015-12-21 35509, 2015

      • reosarevok
        Have fun!

        • 2015-12-21 35536, 2015

      • gcilou_ has quit

        • 2015-12-21 35504, 2015

      • Freso
        opatel99: Spending two days sounds like more than 0-3 hours of work.

        • 2015-12-21 35521, 2015

      • chirlu`
        reosarevok: URL cleanup to trim the URL down to the necessary third of its length?

        • 2015-12-21 35530, 2015

      • opatel99
        Freso: One day

        • 2015-12-21 35547, 2015

      • reosarevok
        That'd also be good for this specific one, yes

        • 2015-12-21 35509, 2015

      • reosarevok
        I'm off to bed now, maybe you could add one or two tickets if they don't exist yet?

        • 2015-12-21 35550, 2015

      • qu3ntin0
        Gentlecat: finally got it fixed!

        • 2015-12-21 35556, 2015

      • Bookzombie
        New pull request "[#BB-57] Add /creator/:id unit tests" by stasszczesniak: https://github.com/bookbrainz/bookbrainz-ws/pull/…

        • 2015-12-21 35504, 2015

      • Gentlecat
        qu3ntin0: what was the issue?

        • 2015-12-21 35519, 2015

      • qu3ntin0
        Gentlecat: the cacert.pem provided with vagrant was broken

        • 2015-12-21 35539, 2015

      • stanislas
        LordSputnik: I've made a pull request

        • 2015-12-21 35540, 2015

      • qu3ntin0
        Gentlecat: had to copy /etc/ssl/certs/ca-certificates.crt to /opt/vagrant/embedded/cacert.pem

        • 2015-12-21 35544, 2015

      • LordSputnik
        stanislas: great, thanks :)

        • 2015-12-21 35557, 2015

      • opatel99
        stanislas: Is pull request best for tasks with more than one instance?

        • 2015-12-21 35501, 2015

      • opatel99
        LordSputnik: ^

        • 2015-12-21 35534, 2015

      • stanislas
        opatel99: are there any tasks with more than one instance, that require doing a pull request ?

        • 2015-12-21 35554, 2015

      • D4RK-PH0ENiX has quit

        • 2015-12-21 35532, 2015

      • opatel99
        stanislas: I just finished a multiple instance task and I just submitted the necessary files as attachment and diff for now. If it is chosen to be used over the other persons, I can submit pull request

        • 2015-12-21 35548, 2015

      • opatel99
        Just to minimize clutter in the pull requests regarding the same issue

        • 2015-12-21 35555, 2015

      • LordSputnik
        stanislas: hmm, opatel99 has a point, just cancel the PR for now - no need to upload the files, I've got a local copy of your repository :)

        • 2015-12-21 35520, 2015

      • LordSputnik
        stanislas: Approved the task :)

        • 2015-12-21 35536, 2015

      • LordSputnik
        Well done - it's been a tough one, but you're good at that kind of task :D

        • 2015-12-21 35534, 2015

      • stanislas
        LordSputnik: Thanks for help for this task, really.

        • 2015-12-21 35529, 2015

      • Bookzombie
        stasszczesniak closed pull request "[#BB-57] Add /creator/:id unit tests" without merge (https://github.com/bookbrainz/bookbrainz-ws/pull/…)

        • 2015-12-21 35546, 2015

      • opatel99
        LordSputnik: Can you put me in your testing bootcamp starting tomorrow?

        • 2015-12-21 35509, 2015

      • opatel99
        Now that stanislas graduated, you have an opening

        • 2015-12-21 35519, 2015

      • LordSputnik
        opatel99: hehe, well, make a start, and let me know if you have any questions

        • 2015-12-21 35528, 2015

      • opatel99
        Yeah. Gotta start somewhere

        • 2015-12-21 35535, 2015

      • LordSputnik
        Also search the chat logs, because it's likely that stanislas has had most of the problems you'll face too :P

        • 2015-12-21 35543, 2015

      • opatel99
        yeah

        • 2015-12-21 35503, 2015

      • stanislas
        LordSputnik: I've had a lot of problems :)

        • 2015-12-21 35524, 2015

      • stanislas
        LordSputnik: A lot to learn from

        • 2015-12-21 35541, 2015

      • ruaok
        zas: baron is up.

        • 2015-12-21 35551, 2015

      • ruaok
        localhost setup is complete, please log in and verify

        • 2015-12-21 35502, 2015

      • stanislas
        LordSputnik: I've seen some build failing on my tests, just after making a PR. What was that :) ?

        • 2015-12-21 35509, 2015

      • ruaok
        it was stuck ast fsck and DWNI walked it through the boot sequence.

        • 2015-12-21 35531, 2015

      • opatel99
        Gentlecat: I have to write tests for release?

        • 2015-12-21 35536, 2015

      • stanislas
        LordSputnik, opatel99: bye :) finally going to sleep

        • 2015-12-21 35516, 2015

      • opatel99
        stanislas: bye bye

        • 2015-12-21 35516, 2015

      • zas
        ruaok: baron ok

        • 2015-12-21 35524, 2015

      • zas
        what was the issue ?

        • 2015-12-21 35556, 2015

      • Freso
        stanislas: If you're looking for your next task and want to do something other than BB, I've got just the one... O:)

        • 2015-12-21 35504, 2015

      • yeeeargh joined the channel

        • 2015-12-21 35505, 2015

      • Freso
        Oh, good night.

        • 2015-12-21 35508, 2015

      • zas
        baron is on 14.10 ?

        • 2015-12-21 35513, 2015

      • zas
        hmmm

        • 2015-12-21 35503, 2015

      • Freso
        stanislas: I also see you already claimed another task. Ah well. :)

        • 2015-12-21 35530, 2015

      • Freso
        Or maybe not. :p

        • 2015-12-21 35552, 2015

      • opatel99
        Freso: What is just the one?

        • 2015-12-21 35531, 2015

      • Freso
        opatel99: https://codein.withgoogle.com/tasks/4647133944741…

        • 2015-12-21 35531, 2015

      • gcibot
        CB: Add indication of review language || 3 days || Code, User Interface || MetaBrainz Foundation

        • 2015-12-21 35532, 2015

      • opatel99
        Or not my level?

        • 2015-12-21 35538, 2015

      • D4RK-PH0ENiX joined the channel

        • 2015-12-21 35538, 2015

      • Freso
        I would really like to see that one fixed ASAP. :)

        • 2015-12-21 35544, 2015

      • D4RK-PH0ENiX has quit

        • 2015-12-21 35553, 2015

      • opatel99
        Ooh I could do that right after my current one.

        • 2015-12-21 35511, 2015

      • D4RK-PH0ENiX joined the channel

        • 2015-12-21 35515, 2015

      • opatel99
        I am on CritiqueBrainz 5157785138364416

        • 2015-12-21 35528, 2015

      • Freso
        (Since another review task that I want to make public depends on mentors being able to check that the review has its language set properly… ;))

        • 2015-12-21 35517, 2015

      • Freso
        Ah, neat. That's one of mine. :)

        • 2015-12-21 35523, 2015

      • opatel99
        I saw

        • 2015-12-21 35532, 2015

      • qu3ntin0
        Gentlecat: one more error :( https://gist.github.com/anonymous/4ebf832de9cec03…

        • 2015-12-21 35548, 2015

      • Freso likes hacking URLs, so get annoyed when URL hacking isn't "intuitive" :p

        • 2015-12-21 35559, 2015

      • opatel99
        Freso: I got https://qvvrfflawd.localtunnel.me/release/4a3541a… so far

        • 2015-12-21 35501, 2015

      • Freso
        opatel99: Was it also you who did the caa.org/api redirect?

        • 2015-12-21 35516, 2015

      • opatel99
        Nope. I was planning on it, but I was sniped

        • 2015-12-21 35519, 2015

      • Freso
        Cool.

        • 2015-12-21 35521, 2015

      • Freso
        Ah well. :)

        • 2015-12-21 35537, 2015

      • Freso
        Ooh. Right. That was marked a beginner task. Boy was I wrong. :p

        • 2015-12-21 35551, 2015

      • Freso
        But yeah, another case of my liking to URL hack. :p

        • 2015-12-21 35556, 2015

      • opatel99
        Freso: Currently just outputs the text for the release-group it should redirect to

        • 2015-12-21 35518, 2015

      • opatel99
        Now I gotta learn some Flask and Blueprint to learn redirect

        • 2015-12-21 35520, 2015

      • opatel99
        Freso: Do all releases have a release-group attached?

        • 2015-12-21 35552, 2015

      • Freso
        Yes.

        • 2015-12-21 35510, 2015

      • Freso
        (But not all Release Groups have a Release.)

        • 2015-12-21 35553, 2015

      • Gentlecat
        opatel99: it would be very nice if you could write tests for new stuff that you add

        • 2015-12-21 35542, 2015

      • Gentlecat
        what's SQLALCHEMY_DATABASE_URI set in your config file?

        • 2015-12-21 35550, 2015

      • Gentlecat
        set to

        • 2015-12-21 35511, 2015

      • opatel99
        I believe that is for qu3ntin0 ^?

        • 2015-12-21 35540, 2015

      • Gentlecat
        oh, sorry

        • 2015-12-21 35551, 2015

      • Freso
        legoktm: Still around by chance?

        • 2015-12-21 35501, 2015

      • legoktm
        Yup

        • 2015-12-21 35505, 2015

      • Freso
        🙌

        • 2015-12-21 35552, 2015

      • Freso
        legoktm: I would like to add .odp and... .pptx (I know D:) to the WikiFileUploadWhitelist. I think I may be able to do it myself. Strong objection?

        • 2015-12-21 35511, 2015

      • Freso
        (I want to upload GCI students' presentations to the wiki rather than having to figure out another way to host them.)

        • 2015-12-21 35502, 2015

      • Gentlecat
        opatel99: http://flask.pocoo.org/docs/0.10/api/#flask.redir…

        • 2015-12-21 35552, 2015

      • legoktm
        Freso: https://www.mediawiki.org/wiki/Manual:Configuring… I think that should work