... oh ffs. "Phishing attack ahead Attackers on ia601303.us.archive.org might try to trick you to steal your information (for example, passwords, messages, or credit cards)."
that's the bug: string ends with nul chars (from the byte buffer), which are never trimmed
2015-12-27 36100, 2015
zas is debugging java code .... something is seriously wrong in our organization ;)
2015-12-27 36147, 2015
zas
this has the following effect: nginx proxy detects invalid header in response from search server (of course ... nul bytes in it)
2015-12-27 36120, 2015
zas
and therefore incorrectly interpret this as a misbehavior of the search server, eventually marking it as failed
2015-12-27 36123, 2015
CatQuest joined the channel
2015-12-27 36153, 2015
zas
then 10 seconds later, it is marked again as healthy, etc ...
2015-12-27 36127, 2015
zas
ruaok: got it ?
2015-12-27 36135, 2015
ruaok was reading docs and nows returns to backscrolls
2015-12-27 36127, 2015
stanislas
LordSputnik, Leftmost: When posting a creator with language_id, which doesn't link to any language created, there is an exception, and not a 400
2015-12-27 36127, 2015
ruaok
I get the problem, for sure.
2015-12-27 36140, 2015
stanislas
LordSputnik, Leftmost: It shouldn't work that way, should it ?
2015-12-27 36159, 2015
opatel99
LordSputnik: Is the alias function supposed to work on the book titles or the author names? Both?
2015-12-27 36128, 2015
ruaok
zas: so line 124 where it constructs the response is incorrect since it takes data from a string, when it should be copying bytes from the byte buffer.
2015-12-27 36139, 2015
kinshukk has left the channel
2015-12-27 36126, 2015
chirlu`
Not line 122, where it turns the whole buffer into a string?
2015-12-27 36142, 2015
zas
ruaok: line 124 removes the id (an integer), then uses the rest as response
So changing the line to “String result = new String(dpReceive.getData(), dpReceive.getOffset(), dpReceive.getLength());” might do it.
2015-12-27 36157, 2015
ruaok
so. much. useless. code.
2015-12-27 36149, 2015
ruaok
not sure about the getOffset()
2015-12-27 36159, 2015
ruaok
shouldn't it always be 0?
2015-12-27 36138, 2015
Gentlecat
blueflute19: you mean GCI website? just put a link there
2015-12-27 36153, 2015
blueflute19
Gentlecat: yup I do, thanks!
2015-12-27 36105, 2015
chirlu`
ruaok: Maybe, but I don’t see there is any guarantee on that.
2015-12-27 36108, 2015
reosarevok
blueflute19: the review should be on the CritiqueBrainz site, and then you should link to the review on the GCI page, and to wherever in your social media you've shared it (if I'm remembering the task correctly)
2015-12-27 36105, 2015
ruaok
I guess I am just confused about what that really means.
2015-12-27 36112, 2015
blueflute19
reosarevok: is there anyway to unsubmit a task? I forgot to link to the social media
2015-12-27 36120, 2015
chirlu`
From receive() documentation: “The length field of the datagram packet object contains the length of the received message. If the message is longer than the packet's length, the message is truncated.”
2015-12-27 36120, 2015
opatel99
reosarevok: Does alias sorting apply to books too?
2015-12-27 36122, 2015
reosarevok
Just comment again
2015-12-27 36126, 2015
reosarevok
blueflute19 ^
2015-12-27 36131, 2015
chirlu`
Now I’m confused.
2015-12-27 36153, 2015
ruaok
since the transmission will be complete by the time the code executes, I'm not sure what offset would or should be.
2015-12-27 36154, 2015
ruaok
heh.
2015-12-27 36100, 2015
blueflute19
reosarevok: got it, thanks haha
2015-12-27 36103, 2015
chirlu`
Does that mean that the length field may be more than the actual buffer length?
2015-12-27 36153, 2015
reosarevok
opatel99: I have no idea what this is about :) In MusicBrainz we have some degree of sorting for song alias sort-names and the like ("The" moves to the end and stuff like that) so I would expect something like that in BB but I don't really know
2015-12-27 36141, 2015
reosarevok
(basically our artist sort names are specially convoluted but we do sort every kind of alias - in English it rarely changes much but for example in Japanese apparently it changes script for sorting)
2015-12-27 36130, 2015
opatel99
I think I got the names down, but titles of entities like Book Titles is a different story.
