#metabrainz

/

      • gcilou
        Well, I was kind of unsure how to set up the server. Where is spotify_mappings defined for the other pages?

        • 2016-01-03 00340, 2016

      • Gentlecat
        here, for example https://github.com/metabrainz/critiquebrainz/blob…

        • 2016-01-03 00347, 2016

      • gcilou
        Well, then why can't I just stick that in the review editor file?

        • 2016-01-03 00329, 2016

      • Gentlecat
        and server setup should be relatively straightforward https://critiquebrainz.readthedocs.org/contrib/in…

        • 2016-01-03 00351, 2016

      • Gentlecat
        what do you mean by stick that?

        • 2016-01-03 00306, 2016

      • kauai
        haha, https://www.youtube.com/watch?v=8l7WQK-I_aw

        • 2016-01-03 00313, 2016

      • Gentlecat
        you'll use the same module (mbspotify), yes

        • 2016-01-03 00328, 2016

      • Gentlecat
        but code will be slightly different

        • 2016-01-03 00344, 2016

      • gcilou
        Ok

        • 2016-01-03 00349, 2016

      • Gentlecat
        if you need help understanding python, feel free to ask questions

        • 2016-01-03 00311, 2016

      • ashutosh joined the channel

        • 2016-01-03 00355, 2016

      • gcilou
        Alright, thanks. So what needs to change in review.py for it to work?

        • 2016-01-03 00347, 2016

      • Gentlecat
        you need to pass list with spotify mappings to the template

        • 2016-01-03 00324, 2016

      • Gentlecat
        only when review is being written for release group

        • 2016-01-03 00335, 2016

      • opatel99 joined the channel

        • 2016-01-03 00312, 2016

      • Gentlecat
        so first you need to check what's in `review.entity_type`

        • 2016-01-03 00321, 2016

      • gcilou
        ok..

        • 2016-01-03 00358, 2016

      • Gentlecat
        types are defined here: https://github.com/metabrainz/critiquebrainz/blob…

        • 2016-01-03 00341, 2016

      • Gentlecat
        so if it's "release_group" you can get list of mappings from mbspotify module

        • 2016-01-03 00313, 2016

      • Gentlecat
        after that pass it to the same template that is currently used there

        • 2016-01-03 00302, 2016

      • gcilou
        OK, so all this is in review.py?

        • 2016-01-03 00326, 2016

      • Gentlecat
        correct

        • 2016-01-03 00330, 2016

      • Leo_Verto has quit

        • 2016-01-03 00352, 2016

      • gcilou
        SO are we just altering the code in release_group.py line 13 and down?

        • 2016-01-03 00312, 2016

      • Gentlecat
        no, it's doing completely different thing

        • 2016-01-03 00354, 2016

      • gcilou
        OK

        • 2016-01-03 00318, 2016

      • CatmanIX joined the channel

        • 2016-01-03 00336, 2016

      • gcilou
        So the "pass it to the same template" is that going to be the same as the 'return' line I did before?

        • 2016-01-03 00339, 2016

      • Gentlecat
        no

        • 2016-01-03 00345, 2016

      • djpretzel has quit

        • 2016-01-03 00322, 2016

      • Gentlecat
        you can't just copy `return` from release group entity code

        • 2016-01-03 00334, 2016

      • The_Catman has quit

        • 2016-01-03 00339, 2016

      • djpretzel joined the channel

        • 2016-01-03 00333, 2016

      • Gentlecat
        it would be the same as https://github.com/metabrainz/critiquebrainz/blob…, but with additional argument that passes spotify mappings

        • 2016-01-03 00321, 2016

      • gcilou
        OK, and would I change "review/write.html"?

        • 2016-01-03 00333, 2016

      • Gentlecat
        I don't think you need to modify it

        • 2016-01-03 00351, 2016

      • stanislas
        LordSputnik: I've just made a commit, you might want to take a look.

        • 2016-01-03 00326, 2016

      • gcilou
        Alright.

        • 2016-01-03 00334, 2016

      • gcilou
        Gentlecat, is this right at all? https://gist.github.com/caroline-gschwend/8fdf605…

        • 2016-01-03 00336, 2016

      • Gentlecat
        yes

        • 2016-01-03 00349, 2016

      • Gentlecat
        don't forget about `else:` part as well

        • 2016-01-03 00300, 2016

      • Gentlecat
        it should be the same as it is now

        • 2016-01-03 00337, 2016

      • gcilou
        'same as it is now'?

        • 2016-01-03 00339, 2016

      • Gentlecat
        also, there should be no spaces around `=` in that function call, keep everything you add consistent with existing code

        • 2016-01-03 00355, 2016

      • Gentlecat
        same `return` statement

        • 2016-01-03 00352, 2016

      • gcilou
        The else statement should be the 'return' statement?

        • 2016-01-03 00310, 2016

      • Gentlecat
        for other entity type

        • 2016-01-03 00336, 2016

      • gcilou
        OH so like ln 199 in review.py?

        • 2016-01-03 00346, 2016

      • Gentlecat
        yes

        • 2016-01-03 00357, 2016

      • ashutosh has quit

        • 2016-01-03 00358, 2016

      • dcentral has quit

        • 2016-01-03 00335, 2016

      • Bookzombie
        New pull request "BB-148: Add weight to revision diff" by opatel99: https://github.com/bookbrainz/bookbrainz-ws/pull/…

        • 2016-01-03 00331, 2016

      • Bookzombie
        New pull request "BB-152: Fix navigation menu staying depressed" by opatel99: https://github.com/bookbrainz/bookbrainz-site/pul…

        • 2016-01-03 00306, 2016

      • opatel99 has quit

        • 2016-01-03 00348, 2016

      • ruaok
        search is dead. on it.

        • 2016-01-03 00352, 2016

      • opatel99 joined the channel

        • 2016-01-03 00332, 2016

      • JesseW joined the channel

        • 2016-01-03 00341, 2016

      • opatel99
        LordSputnik: Should the .gitignore include lobes and config?

        • 2016-01-03 00307, 2016

      • zas
        ruaok: ty

        • 2016-01-03 00316, 2016

      • ruaok
        np

        • 2016-01-03 00323, 2016

      • LordSputnik
        stanislas: looks good to me

        • 2016-01-03 00328, 2016

      • ruaok
        so much easier sitting a computer and not doing it on a mobile. :)

        • 2016-01-03 00331, 2016

      • LordSputnik
        opatel99: which .gitignore?

        • 2016-01-03 00338, 2016

      • opatel99
        bookbrainz-site

        • 2016-01-03 00353, 2016

      • LordSputnik
        opatel99: Probably yes, because they should never be versioned

        • 2016-01-03 00319, 2016

      • opatel99
        LordSputnik: Also, I PR'ed two of the display bugs, working on disambiguation right now, and still gotta make final changes to my first Alignment PR

        • 2016-01-03 00336, 2016

      • zas
        Indexer ran once and they start to crash again...

        • 2016-01-03 00342, 2016

      • kauai has quit

        • 2016-01-03 00314, 2016

      • ruaok
        I can't decide if I should try and fix the stack dumper or just push to get the new search stuff out the door.

        • 2016-01-03 00318, 2016

      • chirlu`
        ruaok/zas: The rotation perhaps happened too late – the indexer was started during low load, but when it finished, the load was already high again.

        • 2016-01-03 00347, 2016

      • ruaok nods

        • 2016-01-03 00357, 2016

      • chirlu`
        Very high, actually. It seems everyone has returned from the New Year holidays.

        • 2016-01-03 00300, 2016

      • opatel99
        LordSputnik: Everytime I try to submit an edition, I get Unhandled rejection Error: There was an error accessing the web service

        • 2016-01-03 00348, 2016

      • zas
        chirlu`: yes, i ran it manually for this time, but next ones will be crontrolled by cron

        • 2016-01-03 00305, 2016

      • zas
        it was to have recording indexed

        • 2016-01-03 00315, 2016

      • zas
        ruaok: imho the new search is the way to go, fixing this old stuff looks a waste of time. That said, it depends when we can have the new search production ready...

        • 2016-01-03 00356, 2016

      • ruaok
        yeah, no clue. weeksio said he was going to do some work over the break, but didn't see anything.

        • 2016-01-03 00308, 2016

      • ruaok
        I think the first thing to do is to make beta use the new search.

        • 2016-01-03 00331, 2016

      • ruaok
        and when beta users are stop screaming we can consider releasing it.

        • 2016-01-03 00346, 2016

      • zas
        LordSputnik: any progress on OAuth/discourse side ?

        • 2016-01-03 00300, 2016

      • zas
        ruaok: agreed

        • 2016-01-03 00312, 2016

      • zas
        where is the new search supposed to run ?

        • 2016-01-03 00332, 2016

      • ruaok
        for testing, we'll use the VM that we setup on google cloud hosting.

        • 2016-01-03 00338, 2016

      • zas
        if pingu has fixed and more ram it could be it

        • 2016-01-03 00341, 2016

      • ruaok
        for production, we'll use dora/roobarb.

        • 2016-01-03 00327, 2016

      • LordSputnik
        zas: http://chatlogs.metabrainz.org/brainzbot/metabrai…

        • 2016-01-03 00344, 2016

      • LordSputnik
        I meant to re-ping that to you the other day, I don't think you saw it

        • 2016-01-03 00307, 2016

      • LordSputnik
        opatel99: on bookbrainz.org?

        • 2016-01-03 00315, 2016

      • opatel99
        LordSputnik: On local

        • 2016-01-03 00323, 2016

      • The_Catman joined the channel

        • 2016-01-03 00325, 2016

      • zas
        LordSputnik: ok thanks, i think we'll have to add this to next meeting topic

        • 2016-01-03 00311, 2016

      • TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | MeB meeting agenda: Reviews; minimum supported Ubuntu/Perl version from May (chirlu), OAuth/Discourse

        • 2016-01-03 00312, 2016

      • CatmanIX has quit

        • 2016-01-03 00317, 2016

      • LordSputnik
        opatel99: oh, what webservice is it configured to use?

        • 2016-01-03 00322, 2016

      • LordSputnik
        Did you log in successfully?

        • 2016-01-03 00330, 2016

      • opatel99
        LordSputnik: sandbox and yes

        • 2016-01-03 00307, 2016

      • opatel99
        LordSputnik: http://hastebin.com/raw/imibazager

        • 2016-01-03 00313, 2016

      • CallerNo6 has quit

        • 2016-01-03 00337, 2016

      • opatel99
        LordSputnik: And for the display disambiguation, would you like it Like "Default(Disambig)" or a different column or something else altogether

        • 2016-01-03 00352, 2016

      • CallerNo6 joined the channel

        • 2016-01-03 00314, 2016

      • LordSputnik
        opatel99: hmm, not sure I can help much, it might have to stay buggy until we have better WS tests and upgrade things to the direct-database branch

        • 2016-01-03 00323, 2016

      • LordSputnik
        opatel99: Title (disambiguation) should be fine :)

        • 2016-01-03 00345, 2016

      • LordSputnik
        opatel99: is the error happening for all edits, or just when you try to do some particular action? Does changing entity help?

        • 2016-01-03 00306, 2016

      • reosarevok
        ruaok / zas: does that search actually work at all now? What's the status of it? (I don't actually have any idea)

        • 2016-01-03 00343, 2016

      • reosarevok
        If it kinda works for most stuff it's probably fine to put it in beta, but it needs to be at least usable with quirks, not just too broken to edit with :)

        • 2016-01-03 00315, 2016

      • CallerNo6 has quit

        • 2016-01-03 00305, 2016

      • Leo_Verto joined the channel

        • 2016-01-03 00308, 2016

      • CallerNo6 joined the channel

        • 2016-01-03 00325, 2016

      • zas
        reosarevok: if you are talking about the "new" search server, i have absolutely no idea about its current status, perhaps ruaok is knowing a bit more, but until someone reviewed the existing code and run i guess we'll not know much more

        • 2016-01-03 00344, 2016

      • reosarevok
        Yeah, the new one. Ok :)

        • 2016-01-03 00304, 2016

      • reosarevok
        We should at least throw it in a sandbox for sure

        • 2016-01-03 00343, 2016

      • zas
        that's the plan

        • 2016-01-03 00310, 2016

      • CallerNo6 has quit

        • 2016-01-03 00312, 2016

      • reosarevok
        Happy to give it a go on a sandbox to see if it seems kinda ok, although I guess Mineo or weeksio probably know a bit more about its status already :)

        • 2016-01-03 00313, 2016

      • ruaok
        http://solr-test.musicbrainz.org

        • 2016-01-03 00325, 2016

      • ruaok
        Meh. Supposed to be running here.

        • 2016-01-03 00343, 2016

      • ruaok
        Maybe search is on port 8080

        • 2016-01-03 00314, 2016

      • chirlu`
        Nope, not on 8080.

        • 2016-01-03 00321, 2016

      • ruaok
        The MB interface isn't so important.

        • 2016-01-03 00354, 2016

      • ruaok
        Solr is running there and we need to expose it and fix up beta to use it.

        • 2016-01-03 00324, 2016

      • ruaok
        I'll ping weeksio on that.

        • 2016-01-03 00341, 2016

      • chirlu`
        I could refer my sandbox to solr-test for people to try.

        • 2016-01-03 00358, 2016

      • reosarevok
        chirlu`: that'd be neat

        • 2016-01-03 00316, 2016

      • chirlu`
        As soon as it is actually running there, of course.

        • 2016-01-03 00325, 2016

      • reosarevok
        Well, yeah :)

        • 2016-01-03 00338, 2016

      • stanislas
        LordSputnik: I am thinking of adding the relationships checking in get or automatizing put/post data generating, what do you think is more important now ?

        • 2016-01-03 00303, 2016

      • CallerNo6 joined the channel

        • 2016-01-03 00329, 2016

      • gcilou
        Gentlecat, committed the changes

        • 2016-01-03 00352, 2016

      • Gentlecat
        gcilou: you should really try running it :)

        • 2016-01-03 00335, 2016

      • Gentlecat
        `id` is undefined

        • 2016-01-03 00326, 2016

      • Gentlecat
        actually it would be defined because it's a built-in function

        • 2016-01-03 00334, 2016

      • Gentlecat
        you probably need `entity_id`

        • 2016-01-03 00327, 2016

      • Gentlecat
        if you need help with running the server, ask :)

        • 2016-01-03 00326, 2016

      • opatel99
        LordSputnik: Changing entity does not help, and I can add publication fine. The problem is when adding an edition to it.

        • 2016-01-03 00326, 2016

      • leonardo has quit

        • 2016-01-03 00334, 2016

      • opatel99
        LordSputnik: Issue is that I can't test disambiguation display until that works.

        • 2016-01-03 00300, 2016

      • gcilou
        OK, I just was using 'id' because that statement is used elsewhere

        • 2016-01-03 00345, 2016

      • gcilou
        https://github.com/metabrainz/critiquebrainz/blob… Like here

        • 2016-01-03 00351, 2016

      • gcilou
        Gentlecat ^

        • 2016-01-03 00355, 2016

      • Gentlecat
        right, but it's defined above in that block

        • 2016-01-03 00310, 2016

      • leonardo joined the channel

        • 2016-01-03 00319, 2016

      • gcilou
        'id = str(id)'

        • 2016-01-03 00334, 2016

      • leonardo is now known as Guest73164

        • 2016-01-03 00308, 2016

      • Gentlecat
        initially as an argument

        • 2016-01-03 00343, 2016

      • gcilou
        OK, so we need to use 'entity_id'?

        • 2016-01-03 00356, 2016

      • Gentlecat
        yes

        • 2016-01-03 00308, 2016

      • Gentlecat
        and please try running it

        • 2016-01-03 00342, 2016

      • Gentlecat
        it's very useful in general, you don't want to blindly make changes

        • 2016-01-03 00314, 2016

      • gcilou
        Ok, so what is this 'config' file that i need to change to test? I've already installed vagrant

        • 2016-01-03 00327, 2016

      • Gentlecat
        perfect