#metabrainz

/

      • reosarevok is not stalking you
      • 2016-01-05 00538, 2016

      • CJ_
        Lies!
      • 2016-01-05 00559, 2016

      • reosarevok
        shh
      • 2016-01-05 00515, 2016

      • stanislas
        reosarevok: I was trying to look on sites like empik.pl, which is selling books, but libraries catalogues are better I suppose
      • 2016-01-05 00541, 2016

      • reosarevok
        Heh :)
      • 2016-01-05 00547, 2016

      • reosarevok
        Library catalogues tend to be pretty awesome
      • 2016-01-05 00501, 2016

      • reosarevok gets a ton of info about obscure classical releases out of worlcat
      • 2016-01-05 00505, 2016

      • reosarevok
        *worldcat even
      • 2016-01-05 00501, 2016

      • stanislas
        reosarevok: The Warsaw Library has its own catalogue, if you ever want to find some info about polish books you can look here : http://primo.koszykowa.pl/primo_library/libweb/ac…
      • 2016-01-05 00546, 2016

      • gcilou <3 s Warsaw 8D
      • 2016-01-05 00548, 2016

      • ariscop has quit
      • 2016-01-05 00541, 2016

      • Gentlecat
        gcilou: did you notice that text doesn't show up in the editor
      • 2016-01-05 00503, 2016

      • gcilou
        When editing a review?
      • 2016-01-05 00507, 2016

      • Gentlecat
        yes
      • 2016-01-05 00524, 2016

      • gcilou
        No, I didn't notice that. Did I do that?
      • 2016-01-05 00535, 2016

      • Gentlecat
        guess :)
      • 2016-01-05 00554, 2016

      • Gentlecat
        or just try on the master branch
      • 2016-01-05 00554, 2016

      • gcilou
        lol, let me go see what I did
      • 2016-01-05 00508, 2016

      • gcilou
        try what?
      • 2016-01-05 00526, 2016

      • Gentlecat
        try checking it
      • 2016-01-05 00515, 2016

      • gcilou
        through testing?
      • 2016-01-05 00537, 2016

      • Gentlecat
        just by trying it, there's no test for it
      • 2016-01-05 00539, 2016

      • Gentlecat
        you can trust me that it will work :)
      • 2016-01-05 00523, 2016

      • gcilou
        Can you explain what you mean by trying on the master branch?
      • 2016-01-05 00546, 2016

      • Gentlecat
        "git checkout master" and try editing
      • 2016-01-05 00502, 2016

      • Gentlecat
        see if original text is there initially
      • 2016-01-05 00528, 2016

      • Gentlecat
        if it is, it means that your change affected that
      • 2016-01-05 00545, 2016

      • gcilou
        'try editing' ?
      • 2016-01-05 00548, 2016

      • Gentlecat
        editing existing review
      • 2016-01-05 00512, 2016

      • gcilou
        through git?
      • 2016-01-05 00539, 2016

      • reosarevok
        In your own running copy :)
      • 2016-01-05 00546, 2016

      • reosarevok
        I assume?
      • 2016-01-05 00549, 2016

      • Gentlecat
        critiquebrainz website
      • 2016-01-05 00511, 2016

      • gcilou
        hm. OK so through vagrant?
      • 2016-01-05 00501, 2016

      • Gentlecat
        yes, start a server in vagrant, just like you did before
      • 2016-01-05 00509, 2016

      • gcilou
        OK
      • 2016-01-05 00517, 2016

      • Gentlecat
        switch branch: "git checkout master"
      • 2016-01-05 00516, 2016

      • Gentlecat
        I can just tell you what the problem is
      • 2016-01-05 00519, 2016

      • gcilou
        it says that I'm already on master.
      • 2016-01-05 00552, 2016

      • gcilou
        Have I done all my work on master?
      • 2016-01-05 00546, 2016

      • gcilou
        OH, nevermind. So now that I did that, when editing a review, I can see the text
      • 2016-01-05 00550, 2016

      • Gentlecat
        you modified if..else that is doing thing that is not relevant to what you need to change https://github.com/metabrainz/critiquebrainz/pull…
      • 2016-01-05 00549, 2016

      • gcilou
        SO does mine need to go below that then?
      • 2016-01-05 00554, 2016

      • Gentlecat
        yes
      • 2016-01-05 00559, 2016

      • Gentlecat
        do you understand why?
      • 2016-01-05 00500, 2016

      • gcilou
        OK, thank you
      • 2016-01-05 00545, 2016

      • gcilou
        Yes I do
      • 2016-01-05 00521, 2016

      • gcilou
        Fixed!
      • 2016-01-05 00547, 2016

      • weeksio_ joined the channel
      • 2016-01-05 00553, 2016

      • regagain joined the channel
      • 2016-01-05 00551, 2016

      • regagain has quit
      • 2016-01-05 00521, 2016

      • regagain joined the channel
      • 2016-01-05 00506, 2016

      • gcilou
        Gentlecat, did that fix it?
      • 2016-01-05 00555, 2016

      • Gentlecat
        this `return` statement should not be there: https://github.com/metabrainz/critiquebrainz/pull…
      • 2016-01-05 00515, 2016

      • Gentlecat
        it means everything below it is unreachable, so player is not going to show up during creation
      • 2016-01-05 00506, 2016

      • gcilou
        Yeah ok, I thought I changed that, I guess not!
      • 2016-01-05 00517, 2016

      • ariscop joined the channel
      • 2016-01-05 00501, 2016

      • gcilou
        There, Gentlcat, that should do it!
      • 2016-01-05 00510, 2016

      • gcilou
        * Gentlecat ^
      • 2016-01-05 00532, 2016

      • Gentlecat
        yep, looking at it
      • 2016-01-05 00518, 2016

      • gcilou thanks Gentlecat for his patience and help during this task!! This has taught me a lot!
      • 2016-01-05 00535, 2016

      • Gentlecat
        no problem :)
      • 2016-01-05 00555, 2016

      • yeeeargh
        chirlu` and others who are working on the solr search. i spent some time and compared the web-service output of the new solr search to the one of the old search server. do you prefer one ticket with all the differences i found on all entities types or one ticket per entity type?
      • 2016-01-05 00528, 2016

      • chirlu`
        Mineo, weeksio_, CJ_: ^
      • 2016-01-05 00508, 2016

      • chirlu`
        Personally, I’d say it should be grouped in some meaningful way.
      • 2016-01-05 00509, 2016

      • yeeeargh
        just posting my results as a textfile can be done too :D
      • 2016-01-05 00506, 2016

      • opatel99 joined the channel
      • 2016-01-05 00515, 2016

      • opatel99
        Freso: Hey!
      • 2016-01-05 00538, 2016

      • chirlu`
        For instance the tag-count issue, I’d say it doesn’t make sense to mention that in separate tickets for each entity type having tags.
      • 2016-01-05 00507, 2016

      • chirlu`
        It’s probably one issue that can be solved in one go for all types.
      • 2016-01-05 00507, 2016

      • weeksio_
        what chirlu` said ;-)
      • 2016-01-05 00502, 2016

      • chirlu`
        yeeeargh: Perhaps show your text file somewhere, then I might have a better idea what should be grouped.
      • 2016-01-05 00510, 2016

      • chirlu`
        But tickets are still needed.
      • 2016-01-05 00534, 2016

      • yeeeargh
      • 2016-01-05 00549, 2016

      • chirlu`
        Hm, the Japanese sortname thing is interesting.
      • 2016-01-05 00524, 2016

      • chirlu`
        I first thought it might be outdated data, but the alias was never changed and had the Katakana (?) sortname from the beginning.
      • 2016-01-05 00540, 2016

      • yeeeargh
        jep, my first thought that it was just different date on the sandbox
      • 2016-01-05 00517, 2016

      • yeeeargh
        *data
      • 2016-01-05 00517, 2016

      • chirlu`
        OK, so I think it makes more sense to group by type of problem, rather than entity type.
      • 2016-01-05 00554, 2016

      • chirlu`
        You could extend SOLR-7 to be about all types for which life-span is missing.
      • 2016-01-05 00520, 2016

      • creature has quit
      • 2016-01-05 00505, 2016

      • weeksio_
        yeeeargh: per ruaok, we aren't going to support freedb with this
      • 2016-01-05 00508, 2016

      • chirlu`
        So, I see approx. these tickets: count, [artist credits], ASIN, video, [type+iswc], [life-span], [annotation], series, jp-sortname.
      • 2016-01-05 00529, 2016

      • chirlu`
        Where [brackets] mean there is already a ticket (but may need extending).
      • 2016-01-05 00546, 2016

      • chirlu`
        Not sure about the relationships.
      • 2016-01-05 00546, 2016

      • yeeeargh
        chirlu`: that’s what i figured. just wanted to make sure before i open a lot of tickets in a way that makes things harder for you to work with
      • 2016-01-05 00518, 2016

      • chirlu`
        Well, I don’t work with them. ;-)
      • 2016-01-05 00538, 2016

      • chirlu`
        But I hope the search server devs will like the same structure.
      • 2016-01-05 00524, 2016

      • chirlu`
        Perhaps one summary ticket for things that are *added* compared to the current one
      • 2016-01-05 00528, 2016

      • weeksio_
        sounds good to me...thanks yeeeargh and chirlu`
      • 2016-01-05 00547, 2016

      • chirlu`
        and one each per entity type for the relationship issues, they look a bit different.
      • 2016-01-05 00521, 2016

      • chirlu`
        (If they turn out to be the same, they can be closed as duplicates of the first one.)
      • 2016-01-05 00537, 2016

      • yeeeargh
        well, i guess i wont open any of these today anyway. i’ll have a go at it tomorrow (after i hat a quick look at the chatlog) :)
      • 2016-01-05 00508, 2016

      • chirlu`
        + the aliases, probably three tickets in total (instrument, area/primary flag, JP sortname).
      • 2016-01-05 00512, 2016

      • chirlu`
        Thanks for testing!
      • 2016-01-05 00520, 2016

      • chirlu`
        And for reporting. :)
      • 2016-01-05 00513, 2016

      • yeeeargh
        well, that’s at least one thing i can to to hopefully get the site/search up to speed again (hopefully)
      • 2016-01-05 00543, 2016

      • yeeeargh
        well, of to watch something different then json/xml. have a good one everybody
      • 2016-01-05 00526, 2016

      • reosarevok
        weeksio_: for now, I hope - freedb import is great as a base for further corrections so it'd be a shame to lose the option :(
      • 2016-01-05 00540, 2016

      • reosarevok
        (at the least, it's a nice source of track durations)
      • 2016-01-05 00529, 2016

      • reosarevok
        It's definitely not needed for release though, given we have a mess in our hands and all
      • 2016-01-05 00553, 2016

      • weeksio_
        I guess it could come back...it's particularly difficult though to include...I can't recall ruaok's exact statement, but it's probably in the chatlogs from late July-ish
      • 2016-01-05 00527, 2016

      • weeksio_
        definitly after ian left
      • 2016-01-05 00506, 2016

      • stanislas
        LordSputnik: I've recently found out, that in WorkData.create() you need to pass a list of dictionaries with one key, which is language_id as a data and in update you can just pass a language_id (on a second position, but that's not the point) https://github.com/bookbrainz/bookbrainz-schema/b…. I think that create should be simplified to just get a simple list
      • 2016-01-05 00525, 2016

      • stanislas
        What do you think ?
      • 2016-01-05 00537, 2016

      • reosarevok
        Hmm. Ok, dunno. Don't worry about it anyway, once the main thing is going we can think about it again
      • 2016-01-05 00528, 2016

      • weeksio_ has quit
      • 2016-01-05 00515, 2016

      • stanislas
        LordSputnik: new commit ;)
      • 2016-01-05 00521, 2016

      • chirlu`
      • 2016-01-05 00533, 2016

      • reosarevok
        Yeah, it isn't very used, that doesn't mean *I* don't use it personally, heh :)
      • 2016-01-05 00510, 2016

      • reosarevok
        But oh well, I guess I'd live without it - it's basically a way to get track times for me, and a few times saving some title typing
      • 2016-01-05 00504, 2016

      • kepstin
        it might be possible to keep the old search server sort of running, doing only the freedb? dunno if the effort that would take makes sense.
      • 2016-01-05 00533, 2016

      • opatel99
        LordSputnik: How does the scope work for MusicBrainz OAuth?
      • 2016-01-05 00557, 2016

      • opatel99
        Freso: LordSputnik: I am getting closer. Will try to finish up tonight. Here is what I have accomplished so far
      • 2016-01-05 00558, 2016

      • opatel99
      • 2016-01-05 00535, 2016

      • JonnyJD has quit
      • 2016-01-05 00556, 2016

      • Leo_Verto has quit
      • 2016-01-05 00548, 2016

      • opatel99
        Can someone test my OAuth?
      • 2016-01-05 00545, 2016

      • LordSputnik
        stanislas: hmm, but there's another bug in there actually - WorkData has no language_id attribute, I think
      • 2016-01-05 00554, 2016

      • LordSputnik
        stanislas: I do think the interfaces should be the same, definitely
      • 2016-01-05 00552, 2016

      • CallerNo6
        opatel99, "authenticating..." (little icon thingy going in circle)
      • 2016-01-05 00520, 2016

      • opatel99
        CallerNo6: Did it prompt you to login/confirm anything via Musicbrainz?
      • 2016-01-05 00523, 2016

      • LordSputnik
        bitmap: is there an MB test server anywhere at the moment? I don't think we should be asking people to log in to opatel99's HTTP discourse with real credentials
      • 2016-01-05 00556, 2016

      • CallerNo6
        opatel99, yeah, I got a popup asking for permission, clicked "allow".
      • 2016-01-05 00503, 2016

      • bitmap
        would a sandbox work?
      • 2016-01-05 00514, 2016

      • LordSputnik
        bitmap: yeah, if one's up
      • 2016-01-05 00533, 2016

      • opatel99
        sorry :(
      • 2016-01-05 00537, 2016

      • LordSputnik
        actually, it should be OK
      • 2016-01-05 00541, 2016

      • bitmap
      • 2016-01-05 00546, 2016

      • stanislas
        LordSputnik: WorkData has languages attribute :)
      • 2016-01-05 00549, 2016

      • LordSputnik
        Since the credentials aren't going through the HTTP connection
      • 2016-01-05 00502, 2016

      • LordSputnik
        stanislas: but not a WorkData.language_id, which is being set in create
      • 2016-01-05 00535, 2016

      • LordSputnik
        opatel99: great start, looks like you've almost cracked it
      • 2016-01-05 00540, 2016

      • LordSputnik
        still need to know about scopes?
      • 2016-01-05 00548, 2016

      • opatel99
        LordSputnik: Nope. Now gotta handle the callback
      • 2016-01-05 00556, 2016

      • LordSputnik
        :)
      • 2016-01-05 00559, 2016

      • opatel99
        scope="profile" should be enough right?
      • 2016-01-05 00512, 2016

      • LordSputnik
        opatel99: I think so, depends what the JSON endpoint requires
      • 2016-01-05 00515, 2016

      • stanislas
        LordSputnik: Oh, I've not noticed that.
      • 2016-01-05 00540, 2016

      • LordSputnik
        stanislas: it's not a major issue, it'll just be ignored by SQLAlchemy when saving
      • 2016-01-05 00505, 2016

      • LordSputnik
        stanislas: opatel99 about to head off for tonight, any quick things before I go?
      • 2016-01-05 00519, 2016

      • stanislas
        LordSputnik: my commit ?
      • 2016-01-05 00522, 2016

      • opatel99
        LordSputnik: Is there a way to disable state and code in the callback?
      • 2016-01-05 00536, 2016

      • stanislas
        It is not quick really :)
      • 2016-01-05 00552, 2016

      • stanislas
        LordSputnik: It is not a problem, if you review it later, like tomorrow :)
      • 2016-01-05 00551, 2016

      • LordSputnik
        opatel99: what do you mean?
      • 2016-01-05 00546, 2016

      • opatel99
        LordSputnik: when the redirect uri occurs, there is a state and code parameter in the URL. Should that be harmless?
      • 2016-01-05 00554, 2016

      • LordSputnik
        yeah, I wouldn't worry too much - if you don't know what it's for, it's probably safe to ignore
      • 2016-01-05 00529, 2016

      • Freso
        opatel99: The site's auth worked for me. :)
      • 2016-01-05 00537, 2016

      • Freso goes to unauth and then catch up on the channel