#metabrainz

Freso: well, anyway, I was asking about reviews because we've got at least one student who's done all four and wants more. I was trying to think of another "type" to suggest.

CallerNo6: it might be good to encourage them to try another type of task

LordSputnik, true.

LordSputnik pushed 1 commits to bookbrainz-schema: https://github.com/bookbrainz/bookbrainz-schema...

Leftmost: I think the migration script is done now :D apart from relationships

Any task suggestions?

I never really gave it any serious thought before, but I'm starting to think I'm kinda dyslexic. I keep reading "MeB" as "Mebd".

JesseW: The great evaluator. Can you check out my code?

Sure. :-) link?

although I might prefer "the REPL loop in the sky" :-)

JesseW: Feynman was the Great Explainer. Pres. Carter was the Great Negotiator. Henry Clay was the Great Compromiser. You have big shoes to fill.

yeah, my feet are not anywhere *close* to that big (and a good thing, too)

looking

this is ruby, right? I am ... much ... less familiar with ruby.

still glad to look at it though

It's said that Ruby is read like English. Just read it...? (*sorry*)

Eh, I'm better at Python than *English* in some ways. :-)

OK, I've read the three files. I have no questions or suggestions for improvement, though. :-/

Closing that chapter, can someone test a display component out for me?

opatel99 closed pull request "BB-154: Align navbar search input with button by forcing line-height and height" without merge (https://github.com/bookbrainz/bookbrainz-site/p...)

LordSputnik, I guess what I'm not clear on is whether we'd be typing revisions again or whether we could have relationship changes in the same revision as entity changes.

I'm also not happy with the idea of having one set per pair of entities, as I think it's unintuitive in terms of database layout, fetching, and creating.

Leftmost: Two of my PRs have been sitting for a while. Can you take a look when you get a chance?

Also, do https://i.imgur.com/g1d4IAY.png and https://i.imgur.com/pNKqpt1.png look aligned? (Regarding the search field and the search button)

I'll try to get to them soon. Haven't had a lot of time the last little bit, unfortunately.

Understandable. I'm still adjusting from the long break too

Note: What does http://tickets.musicbrainz.org/browse/BB-149 mean?

New pull request "BB-154: Aligned search input field and search button." by opatel99: https://github.com/bookbrainz/bookbrainz-site/p...

So, if you go to the linked publication and open one of the editions, there's a note up top that says "first edition", etc. That's a disambiguation comment. That should be displayed on the publication page with the name.

(If the disambiguation comment is set.)

Where?

Displayed where *

With the name of the edition.

Okay. Also, I think I messed up image uploading on http://tickets.musicbrainz.org/browse/BB-154

Sorry I'm throwing this all at once. I bottle up

(can I tell you guys how much it excites me to see all this GCI activity in here?)

I can see your images, so that seems right. Unless you're after something else.

I was trying to upload the 100percent and 170percent in the comments

Those were my proposals

Ahh. Can't say I've ever tried to attach images in Jira, so I may not be much help.

Ehh. It should be good enough?

Leftmost: I'm still confused on how to format the disambiguation into the editions... Where do I put it (with the name of the edition)

A diff column?

In parens after the name. See the first two results of http://musicbrainz.org/search?query=Solas&t...

And this is just for publication?

That's what the bug says, though I suspect it's needed for publisher edition lists as well.

Leftmost: I think I just gotta add edition.disambiguation.comment to https://github.com/bookbrainz/bookbrainz-site/b... ?

and the publisher counterpart?

Yeah. In parens, and with any appropriate styling, which I don't know offhand.

.disambiguation.comment is a property for entity. In this case, each edition is an entity correct? So that method will work?

I think so. Sorry, my mind is mostly somewhere else, so I may not be thinking clearly on this.

No worries. It's almost midnight here and I had a really long day today.. Had to get training on tax-form-filling and certification today.

If it's affecting your psyche, you shouldn't be present at all...

BTW, is there a comparison between bookbrainz and the Internet Archive's Open Library site already written that someone could link me to?

JesseW, there isn't, really. I don't know that it would come out very flattering right now anyhow. ;) I'd love to see one written up, though.

OK, makes sense. :-)

If you have specific questions, feel free to ask them. In a few days, I can give you a better rundown if you're still interested.

If the comparison focused on goals/principals, it might not be unfavorable to BookBrainz.

No specific questions (and absolutely no hurry on it)

Are there any line length limits for Jade?

Not that I'm aware.

Kuno mentioned Bookbrainz here, 3 years ago: https://joeyh.name/blog/entry/Goodreads_vs_Libr...

New pull request "BB-149: Display disambig. in Edts. table for publication and publisher" by opatel99: https://github.com/bookbrainz/bookbrainz-site/p...

LordSputnik: I have completed BB-(148, 149, 152, 154) which are four display bugs listed on the task page, have submitted PR's and updated the JIRA pages. Please do let me know if any adjustments need to be made.

P.S. Style Guidelines... Anything wrong with last week's edition?

CallerNo6: I agree with LordSputnik (gasp! shock! horror! (at least it's not Leftmost)): suggest that they try out other tasks, but also encourage them to keep adding reviews on their own if they like writing reviews. GCI is meant to help them get involved in FLOSS organisations, and we could definitely do with more people reviewing things on CB outside of GCI context.

darwin: :)

CallerNo6: Like I've said, there are three "add release to MB" type tasks they can poke at if it's because they want to do more tasks but not do coding.

But if they just like writing reviews, well, they're more than welcome to also just write more reviews. ;) You can tell them to come here or to #musicbrainz if they want people to give them feedback on their reviews.

LordSputnik: In bbschema/entity.py in line 395, shouldn't it be 'if alias.get('primary', False):' ?

LordSputnik: https://github.com/bookbrainz/bookbrainz-schema...

zas: ping regarding discourse plugin?

opatel99: it looks fine to me, but as freso said, i'm not a ruby guy

zas: Did you try the demo?

i did, but it was few days ago, where is the latest one ? (last was on an ip if i remember)