#metabrainz

/

      • CatCat has quit

        • 2016-01-10 01038, 2016

      • CallerNo6
        Freso: well, anyway, I was asking about reviews because we've got at least one student who's done all four and wants more. I was trying to think of another "type" to suggest.

        • 2016-01-10 01050, 2016

      • CatCat joined the channel

        • 2016-01-10 01050, 2016

      • CatCat has quit

        • 2016-01-10 01050, 2016

      • CatCat joined the channel

        • 2016-01-10 01018, 2016

      • Irator has quit

        • 2016-01-10 01046, 2016

      • yeeeargh has quit

        • 2016-01-10 01047, 2016

      • ariscop has quit

        • 2016-01-10 01004, 2016

      • D4RK-PH0ENiX has quit

        • 2016-01-10 01001, 2016

      • ariscop joined the channel

        • 2016-01-10 01010, 2016

      • LordSputnik
        CallerNo6: it might be good to encourage them to try another type of task

        • 2016-01-10 01001, 2016

      • Nyanko-sensei joined the channel

        • 2016-01-10 01030, 2016

      • blup has quit

        • 2016-01-10 01016, 2016

      • CallerNo6
        LordSputnik, true.

        • 2016-01-10 01038, 2016

      • blup joined the channel

        • 2016-01-10 01056, 2016

      • Bookzombie
        LordSputnik pushed 1 commits to bookbrainz-schema: https://github.com/bookbrainz/bookbrainz-schema/c…

        • 2016-01-10 01055, 2016

      • LordSputnik
        Leftmost: I think the migration script is done now :D apart from relationships

        • 2016-01-10 01045, 2016

      • opatel99
        Any task suggestions?

        • 2016-01-10 01033, 2016

      • CallerNo6
        I never really gave it any serious thought before, but I'm starting to think I'm kinda dyslexic. I keep reading "MeB" as "Mebd".

        • 2016-01-10 01015, 2016

      • ariscop has quit

        • 2016-01-10 01038, 2016

      • ariscop joined the channel

        • 2016-01-10 01005, 2016

      • JonnyJD joined the channel

        • 2016-01-10 01002, 2016

      • JesseW joined the channel

        • 2016-01-10 01011, 2016

      • JesseW has quit

        • 2016-01-10 01058, 2016

      • JesseW joined the channel

        • 2016-01-10 01041, 2016

      • opatel99
        JesseW: The great evaluator. Can you check out my code?

        • 2016-01-10 01022, 2016

      • JesseW
        Sure. :-) link?

        • 2016-01-10 01010, 2016

      • JesseW 's previous title was "the juggling janitor" -- not sure if that's better or worse than "the great evaluator"

        • 2016-01-10 01033, 2016

      • JesseW
        although I might prefer "the REPL loop in the sky" :-)

        • 2016-01-10 01051, 2016

      • opatel99
        JesseW: Feynman was the Great Explainer. Pres. Carter was the Great Negotiator. Henry Clay was the Great Compromiser. You have big shoes to fill.

        • 2016-01-10 01019, 2016

      • opatel99
        https://github.com/metabrainz/discourse-musicbrai…

        • 2016-01-10 01024, 2016

      • JesseW
        yeah, my feet are not anywhere *close* to that big (and a good thing, too)

        • 2016-01-10 01035, 2016

      • JesseW
        looking

        • 2016-01-10 01029, 2016

      • JesseW
        this is ruby, right? I am ... much ... less familiar with ruby.

        • 2016-01-10 01039, 2016

      • JesseW
        still glad to look at it though

        • 2016-01-10 01002, 2016

      • opatel99
        It's said that Ruby is read like English. Just read it...? (*sorry*)

        • 2016-01-10 01031, 2016

      • JesseW
        Eh, I'm better at Python than *English* in some ways. :-)

        • 2016-01-10 01055, 2016

      • JesseW
        OK, I've read the three files. I have no questions or suggestions for improvement, though. :-/

        • 2016-01-10 01021, 2016

      • JesseW is also less than highly knowledgable about OAuth, for that matter.

        • 2016-01-10 01020, 2016

      • JonnyJD has quit

        • 2016-01-10 01041, 2016

      • typhoe has quit

        • 2016-01-10 01013, 2016

      • typhoe joined the channel

        • 2016-01-10 01033, 2016

      • opatel99
        Closing that chapter, can someone test a display component out for me?

        • 2016-01-10 01024, 2016

      • Bookzombie
        opatel99 closed pull request "BB-154: Align navbar search input with button by forcing line-height and height" without merge (https://github.com/bookbrainz/bookbrainz-site/pul…)

        • 2016-01-10 01048, 2016

      • Leftmost
        LordSputnik, I guess what I'm not clear on is whether we'd be typing revisions again or whether we could have relationship changes in the same revision as entity changes.

        • 2016-01-10 01033, 2016

      • Leftmost
        I'm also not happy with the idea of having one set per pair of entities, as I think it's unintuitive in terms of database layout, fetching, and creating.

        • 2016-01-10 01047, 2016

      • opatel99
        Leftmost: Two of my PRs have been sitting for a while. Can you take a look when you get a chance?

        • 2016-01-10 01019, 2016

      • opatel99
        Also, do https://i.imgur.com/g1d4IAY.png and https://i.imgur.com/pNKqpt1.png look aligned? (Regarding the search field and the search button)

        • 2016-01-10 01043, 2016

      • Leftmost
        I'll try to get to them soon. Haven't had a lot of time the last little bit, unfortunately.

        • 2016-01-10 01006, 2016

      • opatel99
        Understandable. I'm still adjusting from the long break too

        • 2016-01-10 01032, 2016

      • opatel99
        Note: What does http://tickets.musicbrainz.org/browse/BB-149 mean?

        • 2016-01-10 01031, 2016

      • Bookzombie
        New pull request "BB-154: Aligned search input field and search button." by opatel99: https://github.com/bookbrainz/bookbrainz-site/pul…

        • 2016-01-10 01031, 2016

      • Leftmost
        So, if you go to the linked publication and open one of the editions, there's a note up top that says "first edition", etc. That's a disambiguation comment. That should be displayed on the publication page with the name.

        • 2016-01-10 01037, 2016

      • Leftmost
        (If the disambiguation comment is set.)

        • 2016-01-10 01001, 2016

      • opatel99
        Where?

        • 2016-01-10 01006, 2016

      • opatel99
        Displayed where *

        • 2016-01-10 01025, 2016

      • Leftmost
        With the name of the edition.

        • 2016-01-10 01027, 2016

      • opatel99
        Okay. Also, I think I messed up image uploading on http://tickets.musicbrainz.org/browse/BB-154

        • 2016-01-10 01035, 2016

      • opatel99
        Sorry I'm throwing this all at once. I bottle up

        • 2016-01-10 01013, 2016

      • darwin
        (can I tell you guys how much it excites me to see all this GCI activity in here?)

        • 2016-01-10 01007, 2016

      • Leftmost
        I can see your images, so that seems right. Unless you're after something else.

        • 2016-01-10 01035, 2016

      • opatel99
        I was trying to upload the 100percent and 170percent in the comments

        • 2016-01-10 01046, 2016

      • opatel99
        Those were my proposals

        • 2016-01-10 01022, 2016

      • Leftmost
        Ahh. Can't say I've ever tried to attach images in Jira, so I may not be much help.

        • 2016-01-10 01039, 2016

      • opatel99
        Ehh. It should be good enough?

        • 2016-01-10 01033, 2016

      • opatel99
        darwin: Double smiley for that (:)

        • 2016-01-10 01008, 2016

      • opatel99
        Leftmost: I'm still confused on how to format the disambiguation into the editions... Where do I put it (with the name of the edition)

        • 2016-01-10 01014, 2016

      • opatel99
        A diff column?

        • 2016-01-10 01023, 2016

      • MajorLurker joined the channel

        • 2016-01-10 01020, 2016

      • Leftmost
        In parens after the name. See the first two results of http://musicbrainz.org/search?query=Solas&typ…

        • 2016-01-10 01002, 2016

      • opatel99
        And this is just for publication?

        • 2016-01-10 01026, 2016

      • Leftmost
        That's what the bug says, though I suspect it's needed for publisher edition lists as well.

        • 2016-01-10 01028, 2016

      • opatel99
        Leftmost: I think I just gotta add edition.disambiguation.comment to https://github.com/bookbrainz/bookbrainz-site/blo… ?

        • 2016-01-10 01033, 2016

      • opatel99
        and the publisher counterpart?

        • 2016-01-10 01003, 2016

      • Leftmost
        Yeah. In parens, and with any appropriate styling, which I don't know offhand.

        • 2016-01-10 01038, 2016

      • opatel99
        .disambiguation.comment is a property for entity. In this case, each edition is an entity correct? So that method will work?

        • 2016-01-10 01015, 2016

      • div13 joined the channel

        • 2016-01-10 01023, 2016

      • Leftmost
        I think so. Sorry, my mind is mostly somewhere else, so I may not be thinking clearly on this.

        • 2016-01-10 01020, 2016

      • opatel99
        No worries. It's almost midnight here and I had a really long day today.. Had to get training on tax-form-filling and certification today.

        • 2016-01-10 01049, 2016

      • opatel99
        If it's affecting your psyche, you shouldn't be present at all...

        • 2016-01-10 01030, 2016

      • JesseW
        BTW, is there a comparison between bookbrainz and the Internet Archive's Open Library site already written that someone could link me to?

        • 2016-01-10 01059, 2016

      • Leftmost
        JesseW, there isn't, really. I don't know that it would come out very flattering right now anyhow. ;) I'd love to see one written up, though.

        • 2016-01-10 01019, 2016

      • JesseW
        OK, makes sense. :-)

        • 2016-01-10 01004, 2016

      • Leftmost
        If you have specific questions, feel free to ask them. In a few days, I can give you a better rundown if you're still interested.

        • 2016-01-10 01007, 2016

      • JesseW
        If the comparison focused on goals/principals, it might not be unfavorable to BookBrainz.

        • 2016-01-10 01022, 2016

      • JesseW
        No specific questions (and absolutely no hurry on it)

        • 2016-01-10 01009, 2016

      • opatel99
        Are there any line length limits for Jade?

        • 2016-01-10 01001, 2016

      • Leftmost
        Not that I'm aware.

        • 2016-01-10 01013, 2016

      • JesseW
        Kuno mentioned Bookbrainz here, 3 years ago: https://joeyh.name/blog/entry/Goodreads_vs_Librar…

        • 2016-01-10 01046, 2016

      • Bookzombie
        New pull request "BB-149: Display disambig. in Edts. table for publication and publisher" by opatel99: https://github.com/bookbrainz/bookbrainz-site/pul…

        • 2016-01-10 01037, 2016

      • opatel99
        LordSputnik: I have completed BB-(148, 149, 152, 154) which are four display bugs listed on the task page, have submitted PR's and updated the JIRA pages. Please do let me know if any adjustments need to be made.

        • 2016-01-10 01058, 2016

      • opatel99
        P.S. Style Guidelines... Anything wrong with last week's edition?

        • 2016-01-10 01013, 2016

      • JesseW has quit

        • 2016-01-10 01016, 2016

      • dpmittal joined the channel

        • 2016-01-10 01018, 2016

      • dpmittal has quit

        • 2016-01-10 01038, 2016

      • dpmittal joined the channel

        • 2016-01-10 01043, 2016

      • baykelper joined the channel

        • 2016-01-10 01054, 2016

      • JesseW joined the channel

        • 2016-01-10 01044, 2016

      • dpmittal has quit

        • 2016-01-10 01005, 2016

      • dpmittal joined the channel

        • 2016-01-10 01043, 2016

      • JesseW has quit

        • 2016-01-10 01036, 2016

      • The_Freso joined the channel

        • 2016-01-10 01023, 2016

      • Freso has quit

        • 2016-01-10 01023, 2016

      • The_Freso is now known as Freso

        • 2016-01-10 01044, 2016

      • opatel99 has quit

        • 2016-01-10 01040, 2016

      • ariscop has quit

        • 2016-01-10 01032, 2016

      • ariscop joined the channel

        • 2016-01-10 01016, 2016

      • aman joined the channel

        • 2016-01-10 01049, 2016

      • dpmittal has quit

        • 2016-01-10 01057, 2016

      • baykelper has quit

        • 2016-01-10 01045, 2016

      • blup has quit

        • 2016-01-10 01001, 2016

      • CatCat has quit

        • 2016-01-10 01054, 2016

      • dpmittal joined the channel

        • 2016-01-10 01042, 2016

      • CatCat joined the channel

        • 2016-01-10 01042, 2016

      • CatCat has quit

        • 2016-01-10 01042, 2016

      • CatCat joined the channel

        • 2016-01-10 01012, 2016

      • blup joined the channel

        • 2016-01-10 01042, 2016

      • aman has quit

        • 2016-01-10 01014, 2016

      • yeeeargh joined the channel

        • 2016-01-10 01050, 2016

      • mRokita has quit

        • 2016-01-10 01021, 2016

      • mRokita joined the channel

        • 2016-01-10 01022, 2016

      • mRokita has quit

        • 2016-01-10 01022, 2016

      • mRokita joined the channel

        • 2016-01-10 01023, 2016

      • JonnyJD joined the channel

        • 2016-01-10 01049, 2016

      • blup is now known as CatQuest

        • 2016-01-10 01040, 2016

      • dpmittal has quit

        • 2016-01-10 01018, 2016

      • dpmittal joined the channel

        • 2016-01-10 01034, 2016

      • dpmittal has quit

        • 2016-01-10 01051, 2016

      • dpmittal joined the channel

        • 2016-01-10 01011, 2016

      • dpmittal has quit

        • 2016-01-10 01018, 2016

      • dpmittal joined the channel

        • 2016-01-10 01021, 2016

      • dpmittal has quit

        • 2016-01-10 01025, 2016

      • Freso
        CallerNo6: I agree with LordSputnik (gasp! shock! horror! (at least it's not Leftmost)): suggest that they try out other tasks, but also encourage them to keep adding reviews on their own if they like writing reviews. GCI is meant to help them get involved in FLOSS organisations, and we could definitely do with more people reviewing things on CB outside of GCI context.

        • 2016-01-10 01050, 2016

      • Freso
        darwin: :)

        • 2016-01-10 01002, 2016

      • Freso
        CallerNo6: Like I've said, there are three "add release to MB" type tasks they can poke at if it's because they want to do more tasks but not do coding.

        • 2016-01-10 01043, 2016

      • Freso
        But if they just like writing reviews, well, they're more than welcome to also just write more reviews. ;) You can tell them to come here or to #musicbrainz if they want people to give them feedback on their reviews.

        • 2016-01-10 01035, 2016

      • stanislas
        LordSputnik: In bbschema/entity.py in line 395, shouldn't it be 'if alias.get('primary', False):' ?

        • 2016-01-10 01021, 2016

      • stanislas
        LordSputnik: https://github.com/bookbrainz/bookbrainz-schema/b…

        • 2016-01-10 01034, 2016

      • christina joined the channel

        • 2016-01-10 01035, 2016

      • ariscop has quit

        • 2016-01-10 01013, 2016

      • dpmittal joined the channel

        • 2016-01-10 01009, 2016

      • dpmittal has quit

        • 2016-01-10 01050, 2016

      • dpmittal joined the channel

        • 2016-01-10 01045, 2016

      • opatel99 joined the channel

        • 2016-01-10 01024, 2016

      • opatel99
        zas: ping regarding discourse plugin?

        • 2016-01-10 01052, 2016

      • Eleint joined the channel

        • 2016-01-10 01009, 2016

      • Eleint has left the channel

        • 2016-01-10 01049, 2016

      • zas
        opatel99: it looks fine to me, but as freso said, i'm not a ruby guy

        • 2016-01-10 01050, 2016

      • opatel99
        zas: Did you try the demo?

        • 2016-01-10 01022, 2016

      • zas
        i did, but it was few days ago, where is the latest one ? (last was on an ip if i remember)